Re: pgsql: Generate syscache info from catalog files

2024-02-05 Thread Peter Eisentraut
On 05.02.24 13:48, Aleksander Alekseev wrote: Hi, I have found that the files are not listed in the clean target in src/include/Makefile. That might explain it, but it's gotta be fixed anyway. I'll go ahead with that. Looks like that made guaibasaurus happy, but I'm still mystified as to wh

Re: pgsql: Generate syscache info from catalog files

2024-02-05 Thread Aleksander Alekseev
Hi, > > I have found that the files are not listed in the clean target in > > src/include/Makefile. That might explain it, but it's gotta be fixed > > anyway. I'll go ahead with that. > > Looks like that made guaibasaurus happy, but I'm still mystified > as to what was wrong and why it didn't re

Re: pgsql: Generate syscache info from catalog files

2024-01-23 Thread Tom Lane
Peter Eisentraut writes: > On 23.01.24 15:08, Tom Lane wrote: >> Per guaibasaurus[1], this commit broke "make dist": >> I'm not sure why --- the makefile changes treat these new files >> exactly like other generated files. It doesn't repro here, >> either, which is odd. It looks like a timing pr

Re: pgsql: Generate syscache info from catalog files

2024-01-23 Thread Peter Eisentraut
On 23.01.24 15:08, Tom Lane wrote: Peter Eisentraut writes: Generate syscache info from catalog files Per guaibasaurus[1], this commit broke "make dist": ... rm -rf tmp_install/ portlock/ rm -f config.cache config.log config.status GNUmakefile make[1]: Leaving directory '/home/pgsql/buildfa

Re: pgsql: Generate syscache info from catalog files

2024-01-23 Thread Tom Lane
I wrote: > Peter Eisentraut writes: >> Generate syscache info from catalog files > Per guaibasaurus[1], this commit broke "make dist": > ... > I'm not sure why --- the makefile changes treat these new files > exactly like other generated files. It doesn't repro here, > either, which is odd. It

Re: pgsql: Generate syscache info from catalog files

2024-01-23 Thread Tom Lane
Peter Eisentraut writes: > Generate syscache info from catalog files Per guaibasaurus[1], this commit broke "make dist": ... rm -rf tmp_install/ portlock/ rm -f config.cache config.log config.status GNUmakefile make[1]: Leaving directory '/home/pgsql/buildfarm/buildroot/HEAD/pgsql.build/postgre

pgsql: Generate syscache info from catalog files

2024-01-22 Thread Peter Eisentraut
Generate syscache info from catalog files Add a new genbki macros MAKE_SYSCACHE that specifies the syscache ID macro, the underlying index, and the number of buckets. From that, we can generate the existing tables in syscache.h and syscache.c via genbki.pl. Reviewed-by: John Naylor Discussion: