Make the order of the header file includes consistent
Similar to commit 7e735035f20.
Author: Richard Guo
Reviewed-by: Bharath Rupireddy
Discussion:
https://www.postgresql.org/message-id/flat/CAMbWs4-WhpCFMbXCjtJ%2BFzmjfPrp7Hw1pk4p%2BZpU95Kh3ofZ1A%40mail.gmail.com
Branch
--
master
Details
Make the order of the header file includes consistent.
Similar to commits 14aec03502, 7e735035f2 and dddf4cdc33, this commit
makes the order of header file inclusion consistent in more places.
Author: Vignesh C
Reviewed-by: Amit Kapila
Discussion:
https://postgr.es/m/CALDaNm2Sznv8RR6Ex-iJO6xAdsx
On Tue, Nov 12, 2019 at 5:19 PM Amit Kapila wrote:
>
> On Tue, Nov 12, 2019 at 8:33 AM Amit Kapila wrote:
> >
> > Make the order of the header file includes consistent in backend modules.
> >
>
> I see two buildfarm failures at this commit, but none seems to related
> to this change.
>
Both the
On Tue, Nov 12, 2019 at 8:33 AM Amit Kapila wrote:
>
> Make the order of the header file includes consistent in backend modules.
>
I see two buildfarm failures at this commit, but none seems to related
to this change.
1. The failure of anole seems to have happened earlier as well.
https://buildf
Make the order of the header file includes consistent in backend modules.
Similar to commits 7e735035f2 and dddf4cdc33, this commit makes the order
of header file inclusion consistent for backend modules.
In the passing, removed a couple of duplicate inclusions.
Author: Vignesh C
Reviewed-by: Ku
On Fri, Oct 25, 2019 at 03:21:13PM +0530, Amit Kapila wrote:
> Reverted and the buildfarm is green again. Thanks!
Thanks for fixing, and the follow-up thread. (Just saw the rest as
well.)
--
Michael
signature.asc
Description: PGP signature
On Fri, Oct 25, 2019 at 11:47 AM Michael Paquier wrote:
>
> On Fri, Oct 25, 2019 at 09:32:29AM +0530, Amit Kapila wrote:
> > One possible reason could be that pgtypeslib_extern.h has define like below:
> > #ifndef bool
> > #define bool char
> > #endif /* ndef bool */
>
> Possible. I have not look
On Fri, Oct 25, 2019 at 1:30 PM Andrew Gierth
wrote:
>
> > "Amit" == Amit Kapila writes:
>
> Amit> BTW, prairiedog is also show similar failure and both seems to
> Amit> have similar OS except for versions.
>
> Be aware that prairiedog and locust (unlike the rest of the buildfarm)
> have co
> "Amit" == Amit Kapila writes:
Amit> BTW, prairiedog is also show similar failure and both seems to
Amit> have similar OS except for versions.
Be aware that prairiedog and locust (unlike the rest of the buildfarm)
have compilers whose "bool" type is not 1 byte long; PG can't use that,
so
On Fri, Oct 25, 2019 at 09:32:29AM +0530, Amit Kapila wrote:
> One possible reason could be that pgtypeslib_extern.h has define like below:
> #ifndef bool
> #define bool char
> #endif /* ndef bool */
Possible. I have not looked closely.
> It is possible that all the functions that have bool has
On Fri, Oct 25, 2019 at 9:32 AM Amit Kapila wrote:
>
> On Fri, Oct 25, 2019 at 8:54 AM Amit Kapila wrote:
> >
> > > And the cause is visibly this portion of the commit:
> > > --- a/src/interfaces/ecpg/pgtypeslib/dt_common.c
> > > +++ b/src/interfaces/ecpg/pgtypeslib/dt_common.c
> > > @@ -7,9 +7,9
On Fri, Oct 25, 2019 at 8:54 AM Amit Kapila wrote:
>
> On Fri, Oct 25, 2019 at 8:47 AM Michael Paquier wrote:
> >
> > Hi Amit,
> >
> > On Fri, Oct 25, 2019 at 02:24:50AM +, Amit Kapila wrote:
> > > Make the order of the header file includes consistent in non-backend
> > > modules.
> > >
> >
On Fri, Oct 25, 2019 at 8:47 AM Michael Paquier wrote:
>
> Hi Amit,
>
> On Fri, Oct 25, 2019 at 02:24:50AM +, Amit Kapila wrote:
> > Make the order of the header file includes consistent in non-backend
> > modules.
> >
> > Similar to commit 7e735035f2, this commit makes the order of header fi
Hi Amit,
On Fri, Oct 25, 2019 at 02:24:50AM +, Amit Kapila wrote:
> Make the order of the header file includes consistent in non-backend modules.
>
> Similar to commit 7e735035f2, this commit makes the order of header file
> inclusion consistent for non-backend modules.
>
> In passing, fix t
Make the order of the header file includes consistent in non-backend modules.
Similar to commit 7e735035f2, this commit makes the order of header file
inclusion consistent for non-backend modules.
In passing, fix the case where we were using angle brackets (<>) for the
local module includes inste
Make the order of the header file includes consistent in contrib modules.
The basic rule we follow here is to always first include 'postgres.h' or
'postgres_fe.h' whichever is applicable, then system header includes and
then Postgres header includes. In this, we also follow that all the
Postgres
16 matches
Mail list logo
