On 2020/12/02 12:21, Michael Paquier wrote:
On Wed, Dec 02, 2020 at 12:14:33PM +0900, Michael Paquier wrote:
Neither gcc nor clang complain on my end, even with
-Werror=maybe-uninitialized, because they understand that the status
will be set anyway as we have no default in the switch? :)
Yo
On Wed, Dec 02, 2020 at 12:14:33PM +0900, Michael Paquier wrote:
> Neither gcc nor clang complain on my end, even with
> -Werror=maybe-uninitialized, because they understand that the status
> will be set anyway as we have no default in the switch? :)
>
> You are right, this is bad practice for th
On Wed, Dec 02, 2020 at 11:42:58AM +0900, Fujii Masao wrote:
> On 2020/12/02 10:41, Michael Paquier wrote:
>> Move SHA2 routines to a new generic API layer for crypto hashes
>
> Thanks for improving this!
> I got the following compiler failure. ISTM that the variable "status"
> in both pg_cryptoha
On 2020/12/02 10:41, Michael Paquier wrote:
Move SHA2 routines to a new generic API layer for crypto hashes
Thanks for improving this!
I got the following compiler failure. ISTM that the variable "status"
in both pg_cryptohash_update() and pg_cryptohash_final() needs
to be initialized with 0.
Move SHA2 routines to a new generic API layer for crypto hashes
Two new routines to allocate a hash context and to free it are created,
as these become necessary for the goal behind this refactoring: switch
the all cryptohash implementations for OpenSSL to use EVP (for FIPS and
also because upstre
