Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-30 Thread Michael Paquier
On Fri, Jul 30, 2021 at 02:03:32PM -0400, Andrew Dunstan wrote: > It's working. You can re-re-enable the tests. Thanks! I have just re-enabled the tests. I wasn't really useful here at the end :) -- Michael signature.asc Description: PGP signature

Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-30 Thread Andrew Dunstan
On 7/30/21 8:40 AM, Michael Paquier wrote: > >> I will see if a more modern zlib helps matters. It's working. You can re-re-enable the tests. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-30 Thread Michael Paquier
On Fri, Jul 30, 2021 at 07:42:45AM -0400, Andrew Dunstan wrote: > Well that unsticks the test, so now it fails in an ordinary way, so +1 > for doing that. I must say that --no-loop seems a little ill-designed. > Effectively we have to choose between zero loops and infinite loops.  > But that seems

Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-30 Thread Andrew Dunstan
On 7/29/21 8:29 PM, Michael Paquier wrote: > On Thu, Jul 29, 2021 at 01:26:22PM -0400, Andrew Dunstan wrote: >> It gets stuck in a loop like this: >> >> ok 19 - one partial WAL segment was created >> 0/2001968 >> # Running: pg_receivewal -D >> H:/prog/bf/root/HEAD/pgsql.build/src/bin/pg_baseback

Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-29 Thread Michael Paquier
On Thu, Jul 29, 2021 at 01:26:22PM -0400, Andrew Dunstan wrote: > It gets stuck in a loop like this: > > ok 19 - one partial WAL segment was created > 0/2001968 > # Running: pg_receivewal -D > H:/prog/bf/root/HEAD/pgsql.build/src/bin/pg_basebackup/tmp_check/t_020_pg_receivewal_primary_data/archiv

Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-29 Thread Andrew Dunstan
On 7/27/21 2:24 PM, Andrew Dunstan wrote: > On 7/21/21 9:08 PM, Andrew Dunstan wrote: >> On 7/21/21 8:00 PM, Michael Paquier wrote: >>> On Wed, Jul 21, 2021 at 10:05:19AM -0400, Andrew Dunstan wrote: drongo, an MSVC animal running on the same machine, doesn't seem to have an issue, nor

Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-27 Thread Michael Paquier
On Tue, Jul 27, 2021 at 02:24:12PM -0400, Andrew Dunstan wrote: > I have got to the bottom of the issue on fairywren - it was caused by > using a zlib I had build (and which is used on drongo) rather than the > mingw64 zlib package. So I've switched that. Thanks! > While doing that I uncovered so

Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-27 Thread Andrew Dunstan
On 7/21/21 9:08 PM, Andrew Dunstan wrote: > On 7/21/21 8:00 PM, Michael Paquier wrote: >> On Wed, Jul 21, 2021 at 10:05:19AM -0400, Andrew Dunstan wrote: >>> drongo, an MSVC animal running on the same machine, doesn't seem to have >>> an issue, nor jacana which runs msys1, so this seems possibly

Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-21 Thread Michael Paquier
On Wed, Jul 21, 2021 at 09:08:28PM -0400, Andrew Dunstan wrote: > Yeah, bowerbird got a SIGBREAK that caused the whole buildfarm run to > die, so it's even worse than fairywren. That's impressive. I went through the code of zlib and its documentation, and I don't see anything wrong in what we are

Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-21 Thread Andrew Dunstan
On 7/21/21 8:00 PM, Michael Paquier wrote: > On Wed, Jul 21, 2021 at 10:05:19AM -0400, Andrew Dunstan wrote: >> drongo, an MSVC animal running on the same machine, doesn't seem to have >> an issue, nor jacana which runs msys1, so this seems possibly >> msys2-specific. I'll investigate on a simila

Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-21 Thread Michael Paquier
On Wed, Jul 21, 2021 at 10:05:19AM -0400, Andrew Dunstan wrote: > drongo, an MSVC animal running on the same machine, doesn't seem to have > an issue, nor jacana which runs msys1, so this seems possibly > msys2-specific. I'll investigate on a similar instance I have. How is doing bowerbird? I was

Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-21 Thread Andrew Dunstan
On 7/20/21 7:43 PM, Michael Paquier wrote: > On Tue, Jul 20, 2021 at 05:33:52PM -0400, Andrew Dunstan wrote: >> fairywren doesn't seem to like this. > Indeed, it doesn't. The logs don't offer much, and I am not sure if > this is a problem that happens when opening the first segment, or if > that

Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-20 Thread Michael Paquier
On Tue, Jul 20, 2021 at 05:33:52PM -0400, Andrew Dunstan wrote: > fairywren doesn't seem to like this. Indeed, it doesn't. The logs don't offer much, and I am not sure if this is a problem that happens when opening the first segment, or if that's the first write. The starting position is good: p

Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-20 Thread Andrew Dunstan
On 7/19/21 11:23 PM, Michael Paquier wrote: > Re-enable TAP tests of pg_receivewal for ZLIB on Windows > > This is a revert of 6cea447, that disabled those tests temporarily on > Windows due to failures with bowerbird where gzflush() would fail when > executed on a freshly-opened compressed and p

pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-19 Thread Michael Paquier
Re-enable TAP tests of pg_receivewal for ZLIB on Windows This is a revert of 6cea447, that disabled those tests temporarily on Windows due to failures with bowerbird where gzflush() would fail when executed on a freshly-opened compressed and partial segment. This problem should be taken care of n