pgsql: Small tidyup for commit d41a178b, part II.

2023-03-16 Thread Thomas Munro
Small tidyup for commit d41a178b, part II. Further to commit 6a9229da, checking for NULL is now redundant. An "out of memory" error would have been thrown already by palloc() and treated as FATAL, so we can delete a few more lines. Back-patch to all releases, like those other commits. Reported-

pgsql: Small tidyup for commit d41a178b, part II.

2023-03-16 Thread Thomas Munro
Small tidyup for commit d41a178b, part II. Further to commit 6a9229da, checking for NULL is now redundant. An "out of memory" error would have been thrown already by palloc() and treated as FATAL, so we can delete a few more lines. Back-patch to all releases, like those other commits. Reported-

pgsql: Small tidyup for commit d41a178b, part II.

2023-03-16 Thread Thomas Munro
Small tidyup for commit d41a178b, part II. Further to commit 6a9229da, checking for NULL is now redundant. An "out of memory" error would have been thrown already by palloc() and treated as FATAL, so we can delete a few more lines. Back-patch to all releases, like those other commits. Reported-

pgsql: Small tidyup for commit d41a178b, part II.

2023-03-16 Thread Thomas Munro
Small tidyup for commit d41a178b, part II. Further to commit 6a9229da, checking for NULL is now redundant. An "out of memory" error would have been thrown already by palloc() and treated as FATAL, so we can delete a few more lines. Back-patch to all releases, like those other commits. Reported-

pgsql: Small tidyup for commit d41a178b, part II.

2023-03-16 Thread Thomas Munro
Small tidyup for commit d41a178b, part II. Further to commit 6a9229da, checking for NULL is now redundant. An "out of memory" error would have been thrown already by palloc() and treated as FATAL, so we can delete a few more lines. Back-patch to all releases, like those other commits. Reported-

pgsql: Small tidyup for commit d41a178b, part II.

2023-03-16 Thread Thomas Munro
Small tidyup for commit d41a178b, part II. Further to commit 6a9229da, checking for NULL is now redundant. An "out of memory" error would have been thrown already by palloc() and treated as FATAL, so we can delete a few more lines. Back-patch to all releases, like those other commits. Reported-

Re: pgsql: Small tidyup for commit d41a178b.

2023-03-16 Thread Thomas Munro
On Fri, Mar 17, 2023 at 1:36 PM Tom Lane wrote: > Thomas Munro writes: > > Small tidyup for commit d41a178b. > > A comment was left behind claiming that we needed to use malloc() rather > > than palloc() because the corresponding free would run in another > > thread, but that's not true anymore.

Re: pgsql: Small tidyup for commit d41a178b.

2023-03-16 Thread Tom Lane
Thomas Munro writes: > Small tidyup for commit d41a178b. > A comment was left behind claiming that we needed to use malloc() rather > than palloc() because the corresponding free would run in another > thread, but that's not true anymore. Remove that comment. And, with > the reason being gone, w

pgsql: Small tidyup for commit d41a178b.

2023-03-16 Thread Thomas Munro
Small tidyup for commit d41a178b. A comment was left behind claiming that we needed to use malloc() rather than palloc() because the corresponding free would run in another thread, but that's not true anymore. Remove that comment. And, with the reason being gone, we might as well actually use pa

pgsql: Small tidyup for commit d41a178b.

2023-03-16 Thread Thomas Munro
Small tidyup for commit d41a178b. A comment was left behind claiming that we needed to use malloc() rather than palloc() because the corresponding free would run in another thread, but that's not true anymore. Remove that comment. And, with the reason being gone, we might as well actually use pa

pgsql: Small tidyup for commit d41a178b.

2023-03-16 Thread Thomas Munro
Small tidyup for commit d41a178b. A comment was left behind claiming that we needed to use malloc() rather than palloc() because the corresponding free would run in another thread, but that's not true anymore. Remove that comment. And, with the reason being gone, we might as well actually use pa

pgsql: Small tidyup for commit d41a178b.

2023-03-16 Thread Thomas Munro
Small tidyup for commit d41a178b. A comment was left behind claiming that we needed to use malloc() rather than palloc() because the corresponding free would run in another thread, but that's not true anymore. Remove that comment. And, with the reason being gone, we might as well actually use pa

pgsql: Small tidyup for commit d41a178b.

2023-03-16 Thread Thomas Munro
Small tidyup for commit d41a178b. A comment was left behind claiming that we needed to use malloc() rather than palloc() because the corresponding free would run in another thread, but that's not true anymore. Remove that comment. And, with the reason being gone, we might as well actually use pa

pgsql: Small tidyup for commit d41a178b.

2023-03-16 Thread Thomas Munro
Small tidyup for commit d41a178b. A comment was left behind claiming that we needed to use malloc() rather than palloc() because the corresponding free would run in another thread, but that's not true anymore. Remove that comment. And, with the reason being gone, we might as well actually use pa