pgsql: When performing a base backup, check for read errors.

2019-09-06 Thread Robert Haas
When performing a base backup, check for read errors. The old code didn't differentiate between a read error and a concurrent truncation. fread reports both of these by returning 0; you have to use feof() or ferror() to distinguish between them, which this code did not do. It might be a better id

pgsql: When performing a base backup, check for read errors.

2019-09-06 Thread Robert Haas
When performing a base backup, check for read errors. The old code didn't differentiate between a read error and a concurrent truncation. fread reports both of these by returning 0; you have to use feof() or ferror() to distinguish between them, which this code did not do. It might be a better id

pgsql: When performing a base backup, check for read errors.

2019-09-06 Thread Robert Haas
When performing a base backup, check for read errors. The old code didn't differentiate between a read error and a concurrent truncation. fread reports both of these by returning 0; you have to use feof() or ferror() to distinguish between them, which this code did not do. It might be a better id

pgsql: When performing a base backup, check for read errors.

2019-09-06 Thread Robert Haas
When performing a base backup, check for read errors. The old code didn't differentiate between a read error and a concurrent truncation. fread reports both of these by returning 0; you have to use feof() or ferror() to distinguish between them, which this code did not do. It might be a better id

pgsql: When performing a base backup, check for read errors.

2019-09-06 Thread Robert Haas
When performing a base backup, check for read errors. The old code didn't differentiate between a read error and a concurrent truncation. fread reports both of these by returning 0; you have to use feof() or ferror() to distinguish between them, which this code did not do. It might be a better id

pgsql: When performing a base backup, check for read errors.

2019-09-06 Thread Robert Haas
When performing a base backup, check for read errors. The old code didn't differentiate between a read error and a concurrent truncation. fread reports both of these by returning 0; you have to use feof() or ferror() to distinguish between them, which this code did not do. It might be a better id

pgsql: When performing a base backup, check for read errors.

2019-09-06 Thread Robert Haas
When performing a base backup, check for read errors. The old code didn't differentiate between a read error and a concurrent truncation. fread reports both of these by returning 0; you have to use feof() or ferror() to distinguish between them, which this code did not do. It might be a better id