pgsql: Attempt to stabilize postgres_fdw tests

2023-11-02 Thread David Rowley
Attempt to stabilize postgres_fdw tests cac169d68 adjusted DEFAULT_FDW_TUPLE_COST and that seems to have caused a test to become unstable on 32-bit machines. Try to make it stable again. Reported-by: Michael Paquier Discussion: https://postgr.es/m/zum2iha8x2lrg...@paquier.xyz Branch -- mast

pgsql: Be more wary about NULL values for GUC string variables.

2023-11-02 Thread Tom Lane
Be more wary about NULL values for GUC string variables. get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN has a NULL boot_val. Nosing around found a couple of other places that seemed insufficiently cautious about NULL string values, although those are likely unreachable in pr

pgsql: Be more wary about NULL values for GUC string variables.

2023-11-02 Thread Tom Lane
Be more wary about NULL values for GUC string variables. get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN has a NULL boot_val. Nosing around found a couple of other places that seemed insufficiently cautious about NULL string values, although those are likely unreachable in pr

pgsql: Make GetConfigOption/GetConfigOptionResetString return "" for NU

2023-11-02 Thread Tom Lane
Make GetConfigOption/GetConfigOptionResetString return "" for NULL. As per the preceding commit, GUC APIs generally expose NULL-valued string variables as empty strings. Extend that policy to GetConfigOption() and GetConfigOptionResetString(), eliminating a crash hazard for unwary callers, as wel

pgsql: Be more wary about NULL values for GUC string variables.

2023-11-02 Thread Tom Lane
Be more wary about NULL values for GUC string variables. get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN has a NULL boot_val. Nosing around found a couple of other places that seemed insufficiently cautious about NULL string values, although those are likely unreachable in pr

pgsql: Be more wary about NULL values for GUC string variables.

2023-11-02 Thread Tom Lane
Be more wary about NULL values for GUC string variables. get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN has a NULL boot_val. Nosing around found a couple of other places that seemed insufficiently cautious about NULL string values, although those are likely unreachable in pr

pgsql: Be more wary about NULL values for GUC string variables.

2023-11-02 Thread Tom Lane
Be more wary about NULL values for GUC string variables. get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN has a NULL boot_val. Nosing around found a couple of other places that seemed insufficiently cautious about NULL string values, although those are likely unreachable in pr

pgsql: Be more wary about NULL values for GUC string variables.

2023-11-02 Thread Tom Lane
Be more wary about NULL values for GUC string variables. get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN has a NULL boot_val. Nosing around found a couple of other places that seemed insufficiently cautious about NULL string values, although those are likely unreachable in pr

pgsql: Be more wary about NULL values for GUC string variables.

2023-11-02 Thread Tom Lane
Be more wary about NULL values for GUC string variables. get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN has a NULL boot_val. Nosing around found a couple of other places that seemed insufficiently cautious about NULL string values, although those are likely unreachable in pr

pgsql: Stabilize postgres_fdw tests on 32-bit machines

2023-11-02 Thread David Rowley
Stabilize postgres_fdw tests on 32-bit machines cac169d68 adjusted DEFAULT_FDW_TUPLE_COST and that seems to have caused a test to become unstable on 32-bit machines. 4b14e1871 tried to fix this as originally the plan was flipping between a Nested Loop and Hash Join. That commit forced the Nested