pgsql: Add injection-point test for new multixact CV usage

2024-08-20 Thread Alvaro Herrera
Add injection-point test for new multixact CV usage Before commit a0e0fb1ba56f, multixact.c contained a case in the multixact-read path where it would loop sleeping 1ms each time until another multixact-create path completed, which was uncovered by any tests. That commit changed the code to rely

pgsql: Fix a couple of wait event descriptions.

2024-08-20 Thread Nathan Bossart
Fix a couple of wait event descriptions. The descriptions for ProcArrayGroupUpdate and XactGroupUpdate claim that these events mean we are waiting for the group leader "at end of a parallel operation," but neither pertains to parallel operations. This commit reverts these descriptions to their wo

pgsql: Fix a couple of wait event descriptions.

2024-08-20 Thread Nathan Bossart
Fix a couple of wait event descriptions. The descriptions for ProcArrayGroupUpdate and XactGroupUpdate claim that these events mean we are waiting for the group leader "at end of a parallel operation," but neither pertains to parallel operations. This commit reverts these descriptions to their wo

pgsql: Fix a couple of wait event descriptions.

2024-08-20 Thread Nathan Bossart
Fix a couple of wait event descriptions. The descriptions for ProcArrayGroupUpdate and XactGroupUpdate claim that these events mean we are waiting for the group leader "at end of a parallel operation," but neither pertains to parallel operations. This commit reverts these descriptions to their wo

pgsql: Fix a couple of wait event descriptions.

2024-08-20 Thread Nathan Bossart
Fix a couple of wait event descriptions. The descriptions for ProcArrayGroupUpdate and XactGroupUpdate claim that these events mean we are waiting for the group leader "at end of a parallel operation," but neither pertains to parallel operations. This commit reverts these descriptions to their wo

pgsql: Fix a couple of wait event descriptions.

2024-08-20 Thread Nathan Bossart
Fix a couple of wait event descriptions. The descriptions for ProcArrayGroupUpdate and XactGroupUpdate claim that these events mean we are waiting for the group leader "at end of a parallel operation," but neither pertains to parallel operations. This commit reverts these descriptions to their wo

pgsql: Fix a couple of wait event descriptions.

2024-08-20 Thread Nathan Bossart
Fix a couple of wait event descriptions. The descriptions for ProcArrayGroupUpdate and XactGroupUpdate claim that these events mean we are waiting for the group leader "at end of a parallel operation," but neither pertains to parallel operations. This commit reverts these descriptions to their wo

pgsql: Improve configure error for ICU libraries if pkg-config is absen

2024-08-20 Thread Jeff Davis
Improve configure error for ICU libraries if pkg-config is absent. If pkg-config is not installed, the ICU libraries cannot be found, but the custom configure error message did not mention this. This might lead to confusion about the actual problem. To improve this, remove the explicit error messa

pgsql: Minor wording change in table "JSON Creation Functions"

2024-08-20 Thread Alvaro Herrera
Minor wording change in table "JSON Creation Functions" For readability. Backpatch to 16. Author: Erik Wienhold Discussion: https://postgr.es/m/8ddac732-d650-4958-b9c9-ea8e61162...@ewie.name Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/678a8358d18d4079ced9f365

pgsql: Minor wording change in table "JSON Creation Functions"

2024-08-20 Thread Alvaro Herrera
Minor wording change in table "JSON Creation Functions" For readability. Backpatch to 16. Author: Erik Wienhold Discussion: https://postgr.es/m/8ddac732-d650-4958-b9c9-ea8e61162...@ewie.name Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/25642b2a8b4215722

pgsql: Minor wording change in table "JSON Creation Functions"

2024-08-20 Thread Alvaro Herrera
Minor wording change in table "JSON Creation Functions" For readability. Backpatch to 16. Author: Erik Wienhold Discussion: https://postgr.es/m/8ddac732-d650-4958-b9c9-ea8e61162...@ewie.name Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5effd5970429cdac5

pgsql: Remove _PG_fini()

2024-08-20 Thread Michael Paquier
Remove _PG_fini() ab02d702ef08 has removed from the backend the code able to support the unloading of modules, because this has never worked. This removes the last references to _PG_fini(), that could be used as a callback for modules to manipulate the stack when unloading a library. The test mo

pgsql: Slightly refactor varstr_sortsupport() to improve readability.

2024-08-20 Thread Jeff Davis
Slightly refactor varstr_sortsupport() to improve readability. Author: Andreas Karlsson Discussion: https://postgr.es/m/69c2a864-846f-4309-bd5a-aaa1c34f9...@proxel.se Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a95ff1fe2eb4926b13e0940ad1f37d048704bdb0 Modified

Re: pgsql: Slightly refactor varstr_sortsupport() to improve readability.

2024-08-20 Thread Richard Guo
On Wed, Aug 21, 2024 at 6:33 AM Jeff Davis wrote: > Slightly refactor varstr_sortsupport() to improve readability. > > Author: Andreas Karlsson > Discussion: https://postgr.es/m/69c2a864-846f-4309-bd5a-aaa1c34f9...@proxel.se > > Branch > -- > master > > Details > --- > https://git.postgres

pgsql: Don't advance origin during apply failure.

2024-08-20 Thread Amit Kapila
Don't advance origin during apply failure. We advance origin progress during abort on successful streaming and application of ROLLBACK in parallel streaming mode. But the origin shouldn't be advanced during an error or unsuccessful apply due to shutdown. Otherwise, it will result in a transaction

pgsql: Don't advance origin during apply failure.

2024-08-20 Thread Amit Kapila
Don't advance origin during apply failure. We advance origin progress during abort on successful streaming and application of ROLLBACK in parallel streaming mode. But the origin shouldn't be advanced during an error or unsuccessful apply due to shutdown. Otherwise, it will result in a transaction

pgsql: Don't advance origin during apply failure.

2024-08-20 Thread Amit Kapila
Don't advance origin during apply failure. We advance origin progress during abort on successful streaming and application of ROLLBACK in parallel streaming mode. But the origin shouldn't be advanced during an error or unsuccessful apply due to shutdown. Otherwise, it will result in a transaction