[COMMITTERS] pgsql: Remove an antiquated comment.

2005-10-12 Thread Neil Conway
Log Message: --- Remove an antiquated comment. Modified Files: -- pgsql/src/backend/storage/lmgr: proc.c (r1.165 -> r1.166) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/lmgr/proc.c.diff?r1=1.165&r2=1.166) --

Re: [COMMITTERS] pgsql: Do all accesses to shared buffer headers

2005-10-12 Thread Neil Conway
On Thu, 2005-13-10 at 00:11 -0400, Tom Lane wrote: > BTW, forgot to reply to this part, but: have at it. I've committed the attached patch; feel free to improve it if you're not happy. -Neil Index: src/include/storage/spin.h === RCS

[COMMITTERS] pgsql: Add a comment describing the requirement that pointers into

2005-10-12 Thread Neil Conway
Log Message: --- Add a comment describing the requirement that pointers into shared memory that is protected by a spinlock must be volatile, per recent discussion. Modified Files: -- pgsql/src/include/storage: spin.h (r1.25 -> r1.26) (http://developer.postg

Re: [COMMITTERS] pgsql: Do all accesses to shared buffer headers

2005-10-12 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Wed, 2005-12-10 at 18:54 -0400, Tom Lane wrote: >> We do however have here a New Coding Rule that's good for all parts >> of the backend: if you are accessing a spinlock-protected data structure >> then you should be using a volatile-qualified pointer fo

[COMMITTERS] pgsql: Update trigger demo to reflect new trigger ordering.

2005-10-12 Thread Bruce Momjian
Log Message: --- Update trigger demo to reflect new trigger ordering. Modified Files: -- pgsql/doc/src/sgml: trigger.sgml (r1.42 -> r1.43) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/trigger.sgml.diff?r1=1.42&r2=1.43) ---

[COMMITTERS] pgsql: Remove extra

2005-10-12 Thread Bruce Momjian
Log Message: --- Remove extra Modified Files: -- pgsql/doc/src/sgml/ref: copy.sgml (r1.67 -> r1.68) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ref/copy.sgml.diff?r1=1.67&r2=1.68) ---(end of broadcast)---

[COMMITTERS] pgsql: Update: > * Prevent PQfnumber() from lowercasing unquoted the

2005-10-12 Thread Bruce Momjian
Log Message: --- Update: > * Prevent PQfnumber() from lowercasing unquoted the column name > > PQfnumber() should never have been doing lowercasing, but historically > it has so we need a way to prevent it > Modified Files: -- pgsql/doc: TODO (r1.1690 -> r1.16

[COMMITTERS] press - pr: Final edits in preparation for translation.

2005-10-12 Thread User Aglio
Log Message: --- Final edits in preparation for translation. Includes splitting off "translation" version from EN version. Modified Files: -- pr/releases/8.1/en: release.txt (r1.13 -> r1.14) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/press/pr/releases/8.

Re: [COMMITTERS] pgsql: Do all accesses to shared buffer headers through

2005-10-12 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > IMHO it is notationally clearer to define a "BufferDescPtr" that > contains the "volatile" qualifier than to make sure that "volatile" is > used everywhere that it is needed -- obviously, neither approach is > fool-proof. But perhaps that's just me... Pers

[COMMITTERS] pgsql: Don't try to remove duplicate OR-subclauses in

2005-10-12 Thread Tom Lane
Log Message: --- Don't try to remove duplicate OR-subclauses in create_bitmap_subplan and make_restrictinfo_from_bitmapqual. The likelihood of finding duplicates seems much less than in the AND-subclause case, and the cost much higher, because OR lists with hundreds or even thousands of su

Re: [COMMITTERS] pgsql: Do all accesses to shared buffer headers

2005-10-12 Thread Neil Conway
On Wed, 2005-12-10 at 18:54 -0400, Tom Lane wrote: > How would a typedef make it safer? I see no particular difference > between omitting the "volatile" and choosing the wrong typedef. IMHO it is notationally clearer to define a "BufferDescPtr" that contains the "volatile" qualifier than to make

[COMMITTERS] pgsql: Fix spelling error, per Michael Fuhr.

2005-10-12 Thread Tom Lane
Log Message: --- Fix spelling error, per Michael Fuhr. Modified Files: -- pgsql/doc/src/sgml/ref: update.sgml (r1.32 -> r1.33) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ref/update.sgml.diff?r1=1.32&r2=1.33) ---(

Re: [COMMITTERS] pgsql: Do all accesses to shared buffer headers through

2005-10-12 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Wed, 2005-12-10 at 13:45 -0300, Tom Lane wrote: >> Do all accesses to shared buffer headers through volatile-qualified >> pointers, to ensure that compilers won't rearrange accesses to occur >> while we're not holding the buffer header spinlock. > That

[COMMITTERS] pgsql: Remove item: < * Prevent libpq's PQfnumber() from lowercasing

2005-10-12 Thread Bruce Momjian
Log Message: --- Remove item: < * Prevent libpq's PQfnumber() from lowercasing the column name < < One idea is to lowercase all identifiers except those that are < surrounded by quotes. < Modified Files: -- pgsql/doc: TODO (r1.1689 -> r1.1690) (http:/

Re: [COMMITTERS] pgsql: Do all accesses to shared buffer headers

2005-10-12 Thread Neil Conway
On Wed, 2005-12-10 at 13:45 -0300, Tom Lane wrote: > Do all accesses to shared buffer headers through volatile-qualified > pointers, to ensure that compilers won't rearrange accesses to occur > while we're not holding the buffer header spinlock. That is fairly error prone :-( Would it be possible

[COMMITTERS] veil - veil: Documentation fixes for installation instructions.

2005-10-12 Thread User Bloodnok
Log Message: --- Documentation fixes for installation instructions. Fixes for use of LWLocks in different Postgres versions. Modified Files: -- veil/docs: Doxyfile (r1.2 -> r1.3) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/veil/veil/docs/Doxyfile.diff?r1=1

[COMMITTERS] pgsql: Fix longstanding bug found by Atsushi Ogawa: _bt_check_unique

2005-10-12 Thread Tom Lane
Log Message: --- Fix longstanding bug found by Atsushi Ogawa: _bt_check_unique would mark the wrong buffer dirty when trying to kill a dead index entry that's on a page after the one it started on. No risk of data corruption, just inefficiency, but still a bug. Tags: REL8_0_STABLE M

[COMMITTERS] pgsql: Fix longstanding bug found by Atsushi Ogawa: _bt_check_unique

2005-10-12 Thread Tom Lane
Log Message: --- Fix longstanding bug found by Atsushi Ogawa: _bt_check_unique would mark the wrong buffer dirty when trying to kill a dead index entry that's on a page after the one it started on. No risk of data corruption, just inefficiency, but still a bug. Tags: REL7_4_STABLE M

[COMMITTERS] pgsql: Fix longstanding bug found by Atsushi Ogawa: _bt_check_unique

2005-10-12 Thread Tom Lane
Log Message: --- Fix longstanding bug found by Atsushi Ogawa: _bt_check_unique would mark the wrong buffer dirty when trying to kill a dead index entry that's on a page after the one it started on. No risk of data corruption, just inefficiency, but still a bug. Tags: REL7_3_STABLE M

[COMMITTERS] pgsql: Fix longstanding bug found by Atsushi Ogawa: _bt_check_unique

2005-10-12 Thread Tom Lane
Log Message: --- Fix longstanding bug found by Atsushi Ogawa: _bt_check_unique would mark the wrong buffer dirty when trying to kill a dead index entry that's on a page after the one it started on. No risk of data corruption, just inefficiency, but still a bug. Modified Files: ---

[COMMITTERS] pgsql: Fix another recently-changed place that was messing with

2005-10-12 Thread Tom Lane
Log Message: --- Fix another recently-changed place that was messing with spinlock- protected data structures and not using a volatile pointer for same. Modified Files: -- pgsql/src/backend/storage/lmgr: lwlock.c (r1.32 -> r1.33) (http://developer.postgresq

[COMMITTERS] pgsql: Do all accesses to shared buffer headers through

2005-10-12 Thread Tom Lane
Log Message: --- Do all accesses to shared buffer headers through volatile-qualified pointers, to ensure that compilers won't rearrange accesses to occur while we're not holding the buffer header spinlock. It's probably not necessary to mark volatile in every single place in bufmgr.c, but

[COMMITTERS] wikipedia - wikipgedia: LocalSettings is generated by the install

2005-10-12 Thread User Xzilla
Log Message: --- LocalSettings is generated by the install program. the patch file was an after effect of developement, remove them and add a cvsignore to prevent localsettings from coming back Added Files: --- wikipgedia/config: .cvsignore (r1.1) (http://cvs

[COMMITTERS] pgsql: Add warning about plperl nested named subroutines Andrew Dunstan

2005-10-12 Thread Bruce Momjian
Log Message: --- Add warning about plperl nested named subroutines Andrew Dunstan Modified Files: -- pgsql/doc/src/sgml: plperl.sgml (r2.45 -> r2.46) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/plperl.sgml.diff?r1=2.45&r2=2.46)

[COMMITTERS] pginstaller - pginst: Russian Translation update from Andrey Repko

2005-10-12 Thread User Dpage
Log Message: --- Russian Translation update from Andrey Repko Modified Files: -- pginst/lang: ru.xml (r1.12 -> r1.13) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pginstaller/pginst/lang/ru.xml.diff?r1=1.12&r2=1.13) ---(end of broad

[COMMITTERS] pgsql: No longer needed: < < * Add code to detect an SMP machine and

2005-10-12 Thread Bruce Momjian
Log Message: --- No longer needed: < < * Add code to detect an SMP machine and handle spinlocks accordingly < from distributted.net, http://www1.distributed.net/source, < in client/common/cpucheck.cpp < < On SMP machines, it is possible that locks might be released shortly, < whi

[COMMITTERS] pginstaller - pginst: Re-merge strings

2005-10-12 Thread User Dpage
Log Message: --- Re-merge strings Modified Files: -- pginst/lang: de.xml (r1.26 -> r1.27) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pginstaller/pginst/lang/de.xml.diff?r1=1.26&r2=1.27) fr.xml (r1.14 -> r1.15) (http://cvs.pgfoundry.org/cg

[COMMITTERS] pgsql: Rearrange: < o %Add dumping of comments on composite type

2005-10-12 Thread Bruce Momjian
Log Message: --- Rearrange: < o %Add dumping of comments on composite type columns < o %Add dumping of comments on index columns < o Stop dumping CASCADE on DROP TYPE commands in clean mode > o %Add dumping of comments on index columns and composite type columns 604

[COMMITTERS] pgsql: Done: < o %Replace crude DELETE FROM method of pg_dumpall

2005-10-12 Thread Bruce Momjian
Log Message: --- Done: < o %Replace crude DELETE FROM method of pg_dumpall --clean for < cleaning of roles with separate DROP commands 608a607 > Modified Files: -- pgsql/doc: TODO (r1.1686 -> r1.1687) (http://developer.postgresql.org/cvswe

[COMMITTERS] pgsql: Add: < > o Allow pg_dump --clean to drop roles that own

2005-10-12 Thread Bruce Momjian
Log Message: --- Add: < > o Allow pg_dump --clean to drop roles that own objects or have > privileges Modified Files: -- pgsql/doc: TODO (r1.1685 -> r1.1686) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/TODO.diff?r1=1.1685&r2=1.1686

[COMMITTERS] pginstaller - pginst: Install the admin81 module in the postgres

2005-10-12 Thread User Dpage
Log Message: --- Install the admin81 module in the postgres database so pgAdmin can find it. Modified Files: -- pginst/ca: pginstca.c (r1.87 -> r1.88) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pginstaller/pginst/ca/pginstca.c.diff?r1=1.87&r2=1.88) -

[COMMITTERS] psqlodbc - psqlodbc: Use program files environment var in installer per

2005-10-12 Thread User Dpage
Log Message: --- Use program files environment var in installer per Johann Zuschlag Modified Files: -- psqlodbc/installer: Make.bat (r1.11 -> r1.12) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/psqlodbc/psqlodbc/installer/Make.bat.diff?r1=1.11&r2=1.12)

[COMMITTERS] pginstaller - pginst: Updates for beta3

2005-10-12 Thread User Dpage
Log Message: --- Updates for beta3 Modified Files: -- pginst/wxi: guid.lst (r1.25 -> r1.26) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pginstaller/pginst/wxi/guid.lst.diff?r1=1.25&r2=1.26) ---(end of broadcast)

[COMMITTERS] pginstaller - pginst: Update README to include details on getting the

2005-10-12 Thread User Dpage
Log Message: --- Update README to include details on getting the kerberos dlls right. Modified Files: -- pginst: README (r1.17 -> r1.18) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pginstaller/pginst/README.diff?r1=1.17&r2=1.18) --

[COMMITTERS] pginstaller - pginst: Update JDBC driver to build 402.

2005-10-12 Thread User Dpage
Log Message: --- Update JDBC driver to build 402. Modified Files: -- pginst/wxs: pginst.wxs (r1.144 -> r1.145) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pginstaller/pginst/wxs/pginst.wxs.diff?r1=1.144&r2=1.145) ---(end of broadca

[COMMITTERS] pginstaller - pginst: Update version for beta 3

2005-10-12 Thread User Dpage
Log Message: --- Update version for beta 3 Modified Files: -- pginst: Makefile.config (r1.39 -> r1.40) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pginstaller/pginst/Makefile.config.diff?r1=1.39&r2=1.40) ---(end of broadcast)--

[COMMITTERS] pgsql: Update keywords table for 8.1.

2005-10-12 Thread Peter Eisentraut
Log Message: --- Update keywords table for 8.1. Modified Files: -- pgsql/doc/src/sgml: keywords.sgml (r2.15 -> r2.16) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/keywords.sgml.diff?r1=2.15&r2=2.16) ---(end of broa

[COMMITTERS] psqlodbc - psqlodbc: Bump version number

2005-10-12 Thread User Dpage
Log Message: --- Bump version number Modified Files: -- psqlodbc: configure.ac (r1.33 -> r1.34) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/psqlodbc/psqlodbc/configure.ac.diff?r1=1.33&r2=1.34) psqlodbc.rc (r1.62 -> r1.63) (http://cvs.pgfou

[COMMITTERS] psqlodbc - psqlodbc: Use program files environment var in Windows

2005-10-12 Thread User Dpage
Log Message: --- Use program files environment var in Windows makefile per Johann Zuschlag Modified Files: -- psqlodbc: win32.mak (r1.28 -> r1.29) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/psqlodbc/psqlodbc/win32.mak.diff?r1=1.28&r2=1.29) --

[COMMITTERS] psqlodbc - psqlodbc: Use pg_config to find libpq.

2005-10-12 Thread User Petere
Log Message: --- Use pg_config to find libpq. Modified Files: -- psqlodbc: Makefile.am (r1.25 -> r1.26) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/psqlodbc/psqlodbc/Makefile.am.diff?r1=1.25&r2=1.26) configure.ac (r1.32 -> r1.33) (http://c