[COMMITTERS] pgsql: Fix some minor issues in view pretty-printing.

2012-12-24 Thread Tom Lane
Fix some minor issues in view pretty-printing. Code review for commit 2f582f76b1945929ff07116cd4639747ce9bb8a1: don't use a static variable for what ought to be a deparse_context field, fix non-multibyte-safe test for spaces, avoid useless and potentially O(N^2) (though admittedly with a very smal

[COMMITTERS] pgsql: Fix some minor issues in view pretty-printing.

2012-12-24 Thread Tom Lane
Fix some minor issues in view pretty-printing. Code review for commit 2f582f76b1945929ff07116cd4639747ce9bb8a1: don't use a static variable for what ought to be a deparse_context field, fix non-multibyte-safe test for spaces, avoid useless and potentially O(N^2) (though admittedly with a very smal

[COMMITTERS] pgsql: Update comments on rd_newRelfilenodeSubid.

2012-12-24 Thread Simon Riggs
Update comments on rd_newRelfilenodeSubid. Ensure comments accurately reflect state of code given new understanding, and recent changes. Include example code from Noah Misch to illustrate how rd_newRelfilenodeSubid can be reset deterministically. No code changes. Branch -- master Details

[COMMITTERS] pgsql: Keep rd_newRelfilenodeSubid across overflow.

2012-12-24 Thread Simon Riggs
Keep rd_newRelfilenodeSubid across overflow. Teach RelationCacheInvalidate() to keep rd_newRelfilenodeSubid across rel cache message overflows, so that behaviour is now fully deterministic. Noah Misch Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ae9aba69a8608c6e5d

[COMMITTERS] pgsql: Fix more weird compiler messages caused

2012-12-24 Thread Simon Riggs
Fix more weird compiler messages caused by unmatched function prototypes. Andres Freund Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/42fa810c144cb76c911cc664244bc369911eb840 Modified Files -- src/include/commands/event_trigger.h |4 ++-- src/includ

Re: [COMMITTERS] pgsql: Adjust many backend functions to return OID rather than void.

2012-12-24 Thread Andres Freund
Hi, On 2012-12-24 12:52:26 +, Simon Riggs wrote: > On 23 December 2012 21:49, Robert Haas wrote: > > Adjust many backend functions to return OID rather than void. > > > > Extracted from a larger patch by Dimitri Fontaine. It is hoped that > > this will provide infrastructure for enriching th

Re: [COMMITTERS] pgsql: Adjust many backend functions to return OID rather than void.

2012-12-24 Thread Simon Riggs
On 23 December 2012 21:49, Robert Haas wrote: > Adjust many backend functions to return OID rather than void. > > Extracted from a larger patch by Dimitri Fontaine. It is hoped that > this will provide infrastructure for enriching the new event trigger > functionality, but it seems possibly usefu

[COMMITTERS] pgsql: Add function prototype from previous commit.

2012-12-24 Thread Simon Riggs
Add function prototype from previous commit. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2dcb2ebee2ec830fbe547459b2176238efc2a3e0 Modified Files -- src/include/catalog/pg_aggregate.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sen