[COMMITTERS] pgsql: Rename EXPLAIN ANALYZE's "total runtime" output to "execution ti

Rename EXPLAIN ANALYZE's "total runtime" output to "execution time". Now that EXPLAIN also outputs a "planning time" measurement, the use of "total" here seems rather confusing: it sounds like it might include the planning time which of course it doesn't. Majority opinion was that "execution time

[COMMITTERS] pgsql: docs: properly document psql auto encoding mode

docs: properly document psql auto encoding mode In psql, both stdin and stdout must be terminals to get a client encoding of 'auto'. Patch by Albe Laurenz Backpatch to 9.3. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e183d11262f4e04ce7f191a9655aeeaa4682a7f5 Mo

[COMMITTERS] pgsql: docs: properly document psql auto encoding mode

docs: properly document psql auto encoding mode In psql, both stdin and stdout must be terminals to get a client encoding of 'auto'. Patch by Albe Laurenz Backpatch to 9.3. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/aa0a5198baba5bbf04081393e77d07ac3febc

[COMMITTERS] pgsql: libpq: use pgsocket for socket values, for portability

libpq: use pgsocket for socket values, for portability Previously, 'int' was used for socket values in libpq, but socket values are unsigned on Windows. This is a style correction. Initial patch and previous PGINVALID_SOCKET initial patch by Joel Jacobson, modified by me Report from PVS-Studio

[COMMITTERS] pgsql: doc: move min_recovery_apply_delay into the right section

doc: move min_recovery_apply_delay into the right section Patch by Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/be5f7fff470066dc3ee655b25840733eb9006426 Modified Files -- doc/src/sgml/recovery-config.sgml | 100 ++

[COMMITTERS] pgsql: psql: update --help output for unaligned mode params

psql: update --help output for unaligned mode params Previously it wasn't clear from --help that -F, -R, -z, -0 only controlled psql unaligned output. Initial patch from Jov , adjustments by me Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8c349ba5c04c3b5fdceb13c

[COMMITTERS] pgsql: Fix object identities for text search objects

Fix object identities for text search objects We were neglecting to schema-qualify them. Backpatch to 9.3, where object identities were introduced as a concept by commit f8348ea32ec8. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/83ab8e32f24542e3ab1f73b24c57cdbed6

[COMMITTERS] pgsql: Fix object identities for text search objects

Fix object identities for text search objects We were neglecting to schema-qualify them. Backpatch to 9.3, where object identities were introduced as a concept by commit f8348ea32ec8. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/0bf52bd990f324440c1cb9cc88e

[COMMITTERS] pgsql: Fix contrib/postgres_fdw's remote-estimate representation of arr

Fix contrib/postgres_fdw's remote-estimate representation of array Params. We were emitting "(SELECT null::typename)", which is usually interpreted as a scalar subselect, but not so much in the context "x = ANY(...)". This led to remote-side parsing failures when remote_estimate is enabled. A quic

[COMMITTERS] pgsql: Fix contrib/postgres_fdw's remote-estimate representation of arr

Fix contrib/postgres_fdw's remote-estimate representation of array Params. We were emitting "(SELECT null::typename)", which is usually interpreted as a scalar subselect, but not so much in the context "x = ANY(...)". This led to remote-side parsing failures when remote_estimate is enabled. A quic

Re: [COMMITTERS] pgsql: Attempt to get plpython regression tests working again for MSVC

Andrew Dunstan writes: > On 04/16/2014 02:00 PM, Tom Lane wrote: >> While not objecting to the patch itself, I don't understand this commit >> message. I see no recent buildfarm results suggesting that currawong >> (or indeed any other MSVC critter) is unhappy with plpython. > The reason it's no

[COMMITTERS] pgsql: docs: make max_wal_senders higher to handle disconnects

docs: make max_wal_senders higher to handle disconnects Document abrupt streaming client disconnection might leave slots in use, so max_wal_senders should be slightly higher than needed to allow for immediate reconnection. Per mention by Magnus Branch -- master Details --- http://git.p

Re: [COMMITTERS] pgsql: Attempt to get plpython regression tests working again for MSVC

On 04/16/2014 02:00 PM, Tom Lane wrote: Andrew Dunstan writes: Attempt to get plpython regression tests working again for MSVC builds. This has probably been broken for quite a long time. Buildfarm member currawong's current results suggest that it's been broken since 9.1, so backpatch this to

[COMMITTERS] pgsql: Update oidjoins regression test for 9.4.

Update oidjoins regression test for 9.4. Now that we're pretty much feature-frozen, it's time to update the checks on system catalog foreign-key references. (It looks like we missed doing this altogether for 9.3. Sigh.) Branch -- master Details --- http://git.postgresql.org/pg/commitdi

Re: [COMMITTERS] pgsql: Attempt to get plpython regression tests working again for MSVC

Andrew Dunstan writes: > Attempt to get plpython regression tests working again for MSVC builds. > This has probably been broken for quite a long time. Buildfarm member > currawong's current results suggest that it's been broken since 9.1, so > backpatch this to that branch. While not objecting t

[COMMITTERS] pgsql: Attempt to get plpython regression tests working again for MSVC

Attempt to get plpython regression tests working again for MSVC builds. This has probably been broken for quite a long time. Buildfarm member currawong's current results suggest that it's been broken since 9.1, so backpatch this to that branch. This only supports Python 2 - I will handle Python 3

[COMMITTERS] pgsql: Attempt to get plpython regression tests working again for MSVC

Attempt to get plpython regression tests working again for MSVC builds. This has probably been broken for quite a long time. Buildfarm member currawong's current results suggest that it's been broken since 9.1, so backpatch this to that branch. This only supports Python 2 - I will handle Python 3

[COMMITTERS] pgsql: Attempt to get plpython regression tests working again for MSVC

Attempt to get plpython regression tests working again for MSVC builds. This has probably been broken for quite a long time. Buildfarm member currawong's current results suggest that it's been broken since 9.1, so backpatch this to that branch. This only supports Python 2 - I will handle Python 3

[COMMITTERS] pgsql: Attempt to get plpython regression tests working again for MSVC

Attempt to get plpython regression tests working again for MSVC builds. This has probably been broken for quite a long time. Buildfarm member currawong's current results suggest that it's been broken since 9.1, so backpatch this to that branch. This only supports Python 2 - I will handle Python 3

[COMMITTERS] pgsql: Use AF_UNSPEC not PF_UNSPEC in getaddrinfo calls.

Use AF_UNSPEC not PF_UNSPEC in getaddrinfo calls. According to the Single Unix Spec and assorted man pages, you're supposed to use the constants named AF_xxx when setting ai_family for a getaddrinfo call. In a few places we were using PF_xxx instead. Use of PF_xxx appears to be an ancient BSD co

[COMMITTERS] pgsql: Use AF_UNSPEC not PF_UNSPEC in getaddrinfo calls.

Use AF_UNSPEC not PF_UNSPEC in getaddrinfo calls. According to the Single Unix Spec and assorted man pages, you're supposed to use the constants named AF_xxx when setting ai_family for a getaddrinfo call. In a few places we were using PF_xxx instead. Use of PF_xxx appears to be an ancient BSD co

[COMMITTERS] pgsql: Use AF_UNSPEC not PF_UNSPEC in getaddrinfo calls.

Use AF_UNSPEC not PF_UNSPEC in getaddrinfo calls. According to the Single Unix Spec and assorted man pages, you're supposed to use the constants named AF_xxx when setting ai_family for a getaddrinfo call. In a few places we were using PF_xxx instead. Use of PF_xxx appears to be an ancient BSD co

[COMMITTERS] pgsql: pg_upgrade: remove redundant include files

pg_upgrade: remove redundant include files The files were already included by pg_upgrade.h. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/95cb917297ebe77add3cef4f01cca1004031fa9a Modified Files -- contrib/pg_upgrade/exec.c |1 - contrib/pg_upgrad

[COMMITTERS] pgsql: Use AF_UNSPEC not PF_UNSPEC in getaddrinfo calls.

Use AF_UNSPEC not PF_UNSPEC in getaddrinfo calls. According to the Single Unix Spec and assorted man pages, you're supposed to use the constants named AF_xxx when setting ai_family for a getaddrinfo call. In a few places we were using PF_xxx instead. Use of PF_xxx appears to be an ancient BSD co

[COMMITTERS] pgsql: Use AF_UNSPEC not PF_UNSPEC in getaddrinfo calls.

Use AF_UNSPEC not PF_UNSPEC in getaddrinfo calls. According to the Single Unix Spec and assorted man pages, you're supposed to use the constants named AF_xxx when setting ai_family for a getaddrinfo call. In a few places we were using PF_xxx instead. Use of PF_xxx appears to be an ancient BSD co

[COMMITTERS] pgsql: Use AF_UNSPEC not PF_UNSPEC in getaddrinfo calls.

Use AF_UNSPEC not PF_UNSPEC in getaddrinfo calls. According to the Single Unix Spec and assorted man pages, you're supposed to use the constants named AF_xxx when setting ai_family for a getaddrinfo call. In a few places we were using PF_xxx instead. Use of PF_xxx appears to be an ancient BSD co

[COMMITTERS] pgsql: Fix timeout in LDAP lookup of libpq connection parameters

Fix timeout in LDAP lookup of libpq connection parameters Bind attempts to an LDAP server should time out after two seconds, allowing additional lines in the service control file to be parsed (which provide a fall back to a secondary LDAP server or default options). The existing code failed to enf

[COMMITTERS] pgsql: Fix timeout in LDAP lookup of libpq connection parameters

Fix timeout in LDAP lookup of libpq connection parameters Bind attempts to an LDAP server should time out after two seconds, allowing additional lines in the service control file to be parsed (which provide a fall back to a secondary LDAP server or default options). The existing code failed to enf

[COMMITTERS] pgsql: Fix timeout in LDAP lookup of libpq connection parameters

Fix timeout in LDAP lookup of libpq connection parameters Bind attempts to an LDAP server should time out after two seconds, allowing additional lines in the service control file to be parsed (which provide a fall back to a secondary LDAP server or default options). The existing code failed to enf

[COMMITTERS] pgsql: Fix timeout in LDAP lookup of libpq connection parameters

Fix timeout in LDAP lookup of libpq connection parameters Bind attempts to an LDAP server should time out after two seconds, allowing additional lines in the service control file to be parsed (which provide a fall back to a secondary LDAP server or default options). The existing code failed to enf

[COMMITTERS] pgsql: Fix timeout in LDAP lookup of libpq connection parameters

Fix timeout in LDAP lookup of libpq connection parameters Bind attempts to an LDAP server should time out after two seconds, allowing additional lines in the service control file to be parsed (which provide a fall back to a secondary LDAP server or default options). The existing code failed to enf

[COMMITTERS] pgsql: Fix timeout in LDAP lookup of libpq connection parameters

Fix timeout in LDAP lookup of libpq connection parameters Bind attempts to an LDAP server should time out after two seconds, allowing additional lines in the service control file to be parsed (which provide a fall back to a secondary LDAP server or default options). The existing code failed to enf

[COMMITTERS] pgsql: Add to_regprocedure() and to_regoperator().

Add to_regprocedure() and to_regoperator(). These are natural complements to the functions added by commit 0886fc6a5c75b294544263ea979b9cf6195407d9, but they weren't included in the original patch for some reason. Add them. Patch by me, per a complaint by Tom Lane. Review by Tatsuo Ishii. Bran

[COMMITTERS] pgsql: Try to fix spurious DSM failures on Windows.

Try to fix spurious DSM failures on Windows. Apparently, Windows can sometimes return an error code even when the operation actually worked just fine. Rearrange the order of checks according to what appear to be the best practices in this area. Amit Kapila Branch -- master Details ---

[COMMITTERS] pgsql: doc: fix json_extract_path_text() typo by adding jsonb

doc: fix json_extract_path_text() typo by adding jsonb Report from rudolf Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ed4a26260c6ebd7948eacc42eddae1e898239f6e Modified Files -- doc/src/sgml/func.sgml |2 +- 1 file changed, 1 insertion(+), 1 delet

[COMMITTERS] pgsql: check socket creation errors against PGINVALID_SOCKET

check socket creation errors against PGINVALID_SOCKET Previously, in some places, socket creation errors were checked for negative values, which is not true for Windows because sockets are unsigned. This masked socket creation errors on Windows. Backpatch through 9.0. 8.4 doesn't have the infra

[COMMITTERS] pgsql: check socket creation errors against PGINVALID_SOCKET

check socket creation errors against PGINVALID_SOCKET Previously, in some places, socket creation errors were checked for negative values, which is not true for Windows because sockets are unsigned. This masked socket creation errors on Windows. Backpatch through 9.0. 8.4 doesn't have the infra

[COMMITTERS] pgsql: check socket creation errors against PGINVALID_SOCKET

check socket creation errors against PGINVALID_SOCKET Previously, in some places, socket creation errors were checked for negative values, which is not true for Windows because sockets are unsigned. This masked socket creation errors on Windows. Backpatch through 9.0. 8.4 doesn't have the infra

[COMMITTERS] pgsql: check socket creation errors against PGINVALID_SOCKET

check socket creation errors against PGINVALID_SOCKET Previously, in some places, socket creation errors were checked for negative values, which is not true for Windows because sockets are unsigned. This masked socket creation errors on Windows. Backpatch through 9.0. 8.4 doesn't have the infra

[COMMITTERS] pgsql: check socket creation errors against PGINVALID_SOCKET

check socket creation errors against PGINVALID_SOCKET Previously, in some places, socket creation errors were checked for negative values, which is not true for Windows because sockets are unsigned. This masked socket creation errors on Windows. Backpatch through 9.0. 8.4 doesn't have the infra

[COMMITTERS] pgsql: Use correctly-sized buffer when zero-filling a WAL file.

Use correctly-sized buffer when zero-filling a WAL file. I mixed up BLCKSZ and XLOG_BLCKSZ when I changed the way the buffer is allocated a couple of weeks ago. With the default settings, they are both 8k, but they can be changed at compile-time. Branch -- master Details --- http://git.p

[COMMITTERS] pgsql: Use correctly-sized buffer when zero-filling a WAL file.

Use correctly-sized buffer when zero-filling a WAL file. I mixed up BLCKSZ and XLOG_BLCKSZ when I changed the way the buffer is allocated a couple of weeks ago. With the default settings, they are both 8k, but they can be changed at compile-time. Branch -- REL9_0_STABLE Details --- http:

[COMMITTERS] pgsql: Use correctly-sized buffer when zero-filling a WAL file.

Use correctly-sized buffer when zero-filling a WAL file. I mixed up BLCKSZ and XLOG_BLCKSZ when I changed the way the buffer is allocated a couple of weeks ago. With the default settings, they are both 8k, but they can be changed at compile-time. Branch -- REL9_3_STABLE Details --- http:

[COMMITTERS] pgsql: Use correctly-sized buffer when zero-filling a WAL file.

Use correctly-sized buffer when zero-filling a WAL file. I mixed up BLCKSZ and XLOG_BLCKSZ when I changed the way the buffer is allocated a couple of weeks ago. With the default settings, they are both 8k, but they can be changed at compile-time. Branch -- REL8_4_STABLE Details --- http:

[COMMITTERS] pgsql: Use correctly-sized buffer when zero-filling a WAL file.

Use correctly-sized buffer when zero-filling a WAL file. I mixed up BLCKSZ and XLOG_BLCKSZ when I changed the way the buffer is allocated a couple of weeks ago. With the default settings, they are both 8k, but they can be changed at compile-time. Branch -- REL9_2_STABLE Details --- http:

[COMMITTERS] pgsql: Use correctly-sized buffer when zero-filling a WAL file.

Use correctly-sized buffer when zero-filling a WAL file. I mixed up BLCKSZ and XLOG_BLCKSZ when I changed the way the buffer is allocated a couple of weeks ago. With the default settings, they are both 8k, but they can be changed at compile-time. Branch -- REL9_1_STABLE Details --- http: