[COMMITTERS] pgsql: Fix spelling in comment

2015-05-19 Thread Simon Riggs
Fix spelling in comment Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/7d0d2b8da1fee13e473495ffdfc7d642b37ebd63 Modified Files -- src/backend/access/transam/xlog.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-commit

[COMMITTERS] pgsql: Fix spelling in comment

2015-05-19 Thread Simon Riggs
Fix spelling in comment Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f6a54fefc299b933052885bb0532c476d382cc71 Modified Files -- src/backend/access/transam/xlog.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers ma

Re: [COMMITTERS] pgsql: Refactor ON CONFLICT index inference parse tree representation.

2015-05-19 Thread Andres Freund
On 2015-05-19 17:24:49 -0400, Tom Lane wrote: > Andres Freund writes: > > Refactor ON CONFLICT index inference parse tree representation. > > This evidently changed stored rules, so it should've had a catversion > bump. It's not too important because I did one earlier today, but > just as a remi

Re: [COMMITTERS] pgsql: Refactor ON CONFLICT index inference parse tree representation.

2015-05-19 Thread Tom Lane
Andres Freund writes: > Refactor ON CONFLICT index inference parse tree representation. This evidently changed stored rules, so it should've had a catversion bump. It's not too important because I did one earlier today, but just as a reminder ... regards, tom lane --

[COMMITTERS] pgsql: Refactor ON CONFLICT index inference parse tree representation.

2015-05-19 Thread Andres Freund
Refactor ON CONFLICT index inference parse tree representation. Defer lookup of opfamily and input type of a of a user specified opclass until the optimizer selects among available unique indexes; and store the opclass in the parse analyzed tree instead. The primary reason for doing this is that

[COMMITTERS] pgsql: Various fixes around ON CONFLICT for rule deparsing.

2015-05-19 Thread Andres Freund
Various fixes around ON CONFLICT for rule deparsing. Neither the deparsing of the new alias for INSERT's target table, nor of the inference clause was supported. Also fixup a typo in an error message. Add regression tests to test those code paths. Author: Peter Geoghegan Branch -- master D

Re: [COMMITTERS] pgsql: Change pg_seclabel.provider and pg_shseclabel.provider to type "

2015-05-19 Thread Tom Lane
Stephen Frost writes: > * Andrew Dunstan ([email protected]) wrote: >> The buildfarm has no support for contrib/sepgsql > Right, that's on my list of things to address, though I'm not > particularly worried about the changes being made. The replacement patch seems even less likely to have any

Re: [COMMITTERS] pgsql: Change pg_seclabel.provider and pg_shseclabel.provider to type "

2015-05-19 Thread Stephen Frost
* Andrew Dunstan ([email protected]) wrote: > On 05/18/2015 08:20 PM, Tom Lane wrote: > >[email protected] (Andres Freund) writes: > >>On 2015-05-19 00:08:05 +, Tom Lane wrote: > >>>Note: for lack of a suitable testing environment, I've not really exercised > >>>this change. I trust the bui

Re: [COMMITTERS] pgsql: Change pg_seclabel.provider and pg_shseclabel.provider to type "

2015-05-19 Thread Andrew Dunstan
On 05/18/2015 08:20 PM, Tom Lane wrote: [email protected] (Andres Freund) writes: On 2015-05-19 00:08:05 +, Tom Lane wrote: Note: for lack of a suitable testing environment, I've not really exercised this change. I trust the buildfarm will show up any mistakes. Shouldn't src/test/module

[COMMITTERS] pgsql: Fix off-by-one error in Assertion.

2015-05-19 Thread Heikki Linnakangas
Fix off-by-one error in Assertion. The point of the assertion is to ensure that the arrays allocated in stack are large enough, but the check was one item short. This won't matter in practice because MaxIndexTuplesPerPage is an overestimate, so you can't have that many items on a page in reality.

[COMMITTERS] pgsql: Fix off-by-one error in Assertion.

2015-05-19 Thread Heikki Linnakangas
Fix off-by-one error in Assertion. The point of the assertion is to ensure that the arrays allocated in stack are large enough, but the check was one item short. This won't matter in practice because MaxIndexTuplesPerPage is an overestimate, so you can't have that many items on a page in reality.

[COMMITTERS] pgsql: Fix off-by-one error in Assertion.

2015-05-19 Thread Heikki Linnakangas
Fix off-by-one error in Assertion. The point of the assertion is to ensure that the arrays allocated in stack are large enough, but the check was one item short. This won't matter in practice because MaxIndexTuplesPerPage is an overestimate, so you can't have that many items on a page in reality.

[COMMITTERS] pgsql: Fix off-by-one error in Assertion.

2015-05-19 Thread Heikki Linnakangas
Fix off-by-one error in Assertion. The point of the assertion is to ensure that the arrays allocated in stack are large enough, but the check was one item short. This won't matter in practice because MaxIndexTuplesPerPage is an overestimate, so you can't have that many items on a page in reality.

[COMMITTERS] pgsql: Fix off-by-one error in Assertion.

2015-05-19 Thread Heikki Linnakangas
Fix off-by-one error in Assertion. The point of the assertion is to ensure that the arrays allocated in stack are large enough, but the check was one item short. This won't matter in practice because MaxIndexTuplesPerPage is an overestimate, so you can't have that many items on a page in reality.

[COMMITTERS] pgsql: Fix off-by-one error in Assertion.

2015-05-19 Thread Heikki Linnakangas
Fix off-by-one error in Assertion. The point of the assertion is to ensure that the arrays allocated in stack are large enough, but the check was one item short. This won't matter in practice because MaxIndexTuplesPerPage is an overestimate, so you can't have that many items on a page in reality.

[COMMITTERS] pgsql: Revert "Change pg_seclabel.provider and pg_shseclabel.provider t

2015-05-19 Thread Tom Lane
Revert "Change pg_seclabel.provider and pg_shseclabel.provider to type "name"." This reverts commit b82a7be603f1811a0a707b53c62de6d5d9431740. There is a better (less invasive) way to fix it, which I will commit next. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a

[COMMITTERS] pgsql: Avoid collation dependence in indexes of system catalogs.

2015-05-19 Thread Tom Lane
Avoid collation dependence in indexes of system catalogs. No index in template0 should have collation-dependent ordering, especially not indexes on shared catalogs. For most textual columns we avoid this issue by using type "name" (which sorts per strcmp()). However there are a few indexed colum

Re: [COMMITTERS] pgsql: hstore_plpython: Fix regression tests under Python 3

2015-05-19 Thread Andrew Dunstan
On 05/16/2015 11:36 PM, Peter Eisentraut wrote: hstore_plpython: Fix regression tests under Python 3 These are still not fixed. See for example cheers andrew -- Sent via pgsql-committers maili