[COMMITTERS] pgsql: Revert test case added by commit 1e165d05fe06a9072867607886f818b

2017-08-01 Thread Tom Lane
Revert test case added by commit 1e165d05fe06a9072867607886f818bc255507db. The buildfarm is still showing at least three distinct behaviors for a bad locale name in CREATE COLLATION. Although this test was helpful for getting the error reporting code into some usable shape, it doesn't seem worth

[COMMITTERS] pgsql: Second try at getting useful errors out of newlocale/_create_loc

2017-08-01 Thread Tom Lane
Second try at getting useful errors out of newlocale/_create_locale. The early buildfarm returns for commit 1e165d05f are pretty awful: not only does Windows not return a useful error, but it looks like a lot of Unix-ish platforms don't either. Given the number of different errnos seen so far, gu

[COMMITTERS] pgsql: Suppress less info in regression tests using DROP CASCADE.

2017-08-01 Thread Tom Lane
Suppress less info in regression tests using DROP CASCADE. DROP CASCADE doesn't currently promise to visit dependent objects in a fixed order, so when the regression tests use it, we typically need to suppress the details of which objects get dropped in order to have predictable test output. Trad

[COMMITTERS] pgsql: Try to deliver a sane message for _create_locale() failure on Wi

2017-08-01 Thread Tom Lane
Try to deliver a sane message for _create_locale() failure on Windows. We were just printing errno, which is certainly not gonna work on Windows. Now, it's not entirely clear from Microsoft's documentation whether _create_locale() adheres to standard Windows error reporting conventions, but let's

[COMMITTERS] pgsql: doc: Fix typo

2017-08-01 Thread Peter Eisentraut
doc: Fix typo Author: Fabien COELHO Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c1bb7870463bd8ab2b28b363616ec60a9041e13a Modified Files -- doc/src/sgml/ref/pgbench.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-commi

[COMMITTERS] pgsql: doc: Fix typo

2017-08-01 Thread Peter Eisentraut
doc: Fix typo Author: Fabien COELHO Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ac219b92d3aa94641cc9628b59b478d0e1b7f542 Modified Files -- doc/src/sgml/ref/pgbench.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsq

[COMMITTERS] pgsql: Allow creation of C/POSIX collations without depending on libc b

2017-08-01 Thread Tom Lane
Allow creation of C/POSIX collations without depending on libc behavior. Most of our collations code has special handling for the locale names "C" and "POSIX", allowing those collations to be used whether or not the system libraries think those locale names are valid, or indeed whether said librar

[COMMITTERS] pgsql: Further improve consistency of configure's program searching.

2017-08-01 Thread Tom Lane
Further improve consistency of configure's program searching. Peter Eisentraut noted that commit 40b9f1921 had broken a configure behavior that some people might rely on: AC_CHECK_PROGS(FOO,...) will allow the search to be overridden by specifying a value for FOO on configure's command line or in

[COMMITTERS] pgsql: Comment fix for partition_rbound_cmp().

2017-08-01 Thread Dean Rasheed
Comment fix for partition_rbound_cmp(). This was an oversight in d363d42. Beena Emerson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4de6216877a32e869fe1cf168c1fe1ffb8c3d576 Modified Files -- src/backend/catalog/partition.c | 2 +- 1 file changed, 1