Re: [COMMITTERS] pgsql: Fix compiler warnings on 64-bit boxes:

2006-09-06 Thread Gavin Sherry
On Wed, 6 Sep 2006, Teodor Sigaev wrote: > > It might seem a minor quibble, but it seems like a more reliable approach > > might be to cast to a 64 bit type and user a 64 bit int formatter. > %ld ? %lld? depending on architecture? > > > > > It seems unlikely that state->ptr - state->begin would y

Re: [COMMITTERS] pgsql: Fix compiler warnings on 64-bit boxes:

2006-09-06 Thread Gavin Sherry
On Wed, 6 Sep 2006, Teodor Sigaev wrote: > Log Message: > --- > Fix compiler warnings on 64-bit boxes: difference between > pointers are int64, but warnings are emitted for position info in > error messages in parser, so, just cast it to int32 > > Modified Files: > -- > pgs

Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for

2004-08-24 Thread Gavin Sherry
Yes On Tue, 24 Aug 2004, Robert Treat wrote: > I think I missed this in the earlier patches, but does the alter table syntax > still work for indexes in addition to the new syntax? > > On Saturday 21 August 2004 22:47, Gavin Sherry wrote: > > Here is a change to the alter_tab

Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for

2004-08-21 Thread Gavin Sherry
wrote: > Gavin Sherry <[EMAIL PROTECTED]> writes: > > Thanks for spotting this sloppy work. Basically, I cropped my diff because > > there was lots of unrelated code in the work space. But I was a little too > > hard and culled allfiles.sgml, alter.c, equal/copyfuncs.c and a

Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for

2004-08-21 Thread Gavin Sherry
Umm... oops. On Sat, 21 Aug 2004, Tom Lane wrote: > [EMAIL PROTECTED] (Bruce Momjian) writes: > > Add ALTER INDEX, particularly for moving tablespaces. > > This patch is a perfect example of why unreviewed patches should not > go in during beta. > > So far I have noticed the following problems wi