Back in 2001 a hack to add __attribute__((packed)) to ItemPtr was
added with a comment "Appropriate whack upside the head for ARM"
(dcbbdb1b3ee). I don't know if this is still a factor in 2016 or not
but it has already resulted in some collateral damage in 2015 when
some compiler took that as licen
Fix various common mispellings.
Mostly these are just comments but there are a few in documentation
and a handful in code and tests. Hopefully this doesn't cause too much
unnecessary pain for backpatching. I relented from some of the most
common like "thru" for that reason. The rest don't seem num
Be conservative about alignment requirements of struct epoll_event.
Use MAXALIGN size/alignment to guarantee that later uses of memory are
aligned correctly. E.g. epoll_event might need 8 byte alignment on some
platforms, but earlier allocations like WaitEventSet and WaitEvent might
not sized to g
Change type of DOW/DOY to UNITS
Branch
--
REL9_3_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/fde40e53f3b188f974f87aa3608210ccb1232fb8
Modified Files
--
src/interfaces/ecpg/pgtypeslib/dt_common.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
Change type of DOW/DOY to UNITS
Branch
--
REL9_5_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/a1242402854178eded9bd4f2b8cd8ef46d1e9864
Modified Files
--
src/interfaces/ecpg/pgtypeslib/dt_common.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
Change type of DOW/DOY to UNITS
Branch
--
REL9_1_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/0252d299a1325f29a70f761c8250fe8c4b6b
Modified Files
--
src/interfaces/ecpg/pgtypeslib/dt_common.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
Change type of DOW/DOY to UNITS
Branch
--
REL9_0_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/92d956f51d5ef093652598aee0da63624d6eceec
Modified Files
--
src/interfaces/ecpg/pgtypeslib/dt_common.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
Change type of DOW/DOY to UNITS
Branch
--
REL9_2_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/af9d9e59c2d644159b906a278cbead0d0049ecd1
Modified Files
--
src/interfaces/ecpg/pgtypeslib/dt_common.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
Change type of DOW/DOY to UNITS
Branch
--
REL9_4_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/0198a8d82a16ccffefbc692278eccba85f41c381
Modified Files
--
src/interfaces/ecpg/pgtypeslib/dt_common.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
Change type of DOW/DOY to UNITS
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/37239ef8c9fa72e0f73a307cc413a03a743878d3
Modified Files
--
src/interfaces/ecpg/pgtypeslib/dt_common.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
Sent
On Sun, Sep 6, 2015 at 4:02 AM, Tom Lane wrote:
> Shouldn't that get back-patched?
Indeed. I was trying to work out the git workflow and making a token
effort to test it. I think I've done it now.
> Also, what about ecpg's copy of the code?
That I hadn't thought of. Will look at it but it's aft
Move DTK_ISODOW DTK_DOW and DTK_DOY to be type UNITS rather than
RESERV. RESERV is meant for tokens like "now" and having them in that
category throws errors like these when used as an input date:
stark=# SELECT 'doy'::timestamptz;
ERROR: unexpected dtype 33 while parsing timestamptz "doy"
LINE 1
Move DTK_ISODOW DTK_DOW and DTK_DOY to be type UNITS rather than
RESERV. RESERV is meant for tokens like "now" and having them in that
category throws errors like these when used as an input date:
stark=# SELECT 'doy'::timestamptz;
ERROR: unexpected dtype 33 while parsing timestamptz "doy"
LINE 1
Move DTK_ISODOW DTK_DOW and DTK_DOY to be type UNITS rather than
RESERV. RESERV is meant for tokens like "now" and having them in that
category throws errors like these when used as an input date:
stark=# SELECT 'doy'::timestamptz;
ERROR: unexpected dtype 33 while parsing time
Move DTK_ISODOW DTK_DOW and DTK_DOY to be type UNITS rather than
RESERV. RESERV is meant for tokens like "now" and having them in that
category throws errors like these when used as an input date:
stark=# SELECT 'doy'::timestamptz;
ERROR: unexpected dtype 33 while parsing timestamptz "doy"
LINE 1
Move DTK_ISODOW DTK_DOW and DTK_DOY to be type UNITS rather than
RESERV. RESERV is meant for tokens like "now" and having them in that
category throws errors like these when used as an input date:
stark=# SELECT 'doy'::timestamptz;
ERROR: unexpected dtype 33 while parsing timestamptz "doy"
LINE 1
Move DTK_ISODOW DTK_DOW and DTK_DOY to be type UNITS rather than
RESERV. RESERV is meant for tokens like "now" and having them in that
category throws errors like these when used as an input date:
stark=# SELECT 'doy'::timestamptz;
ERROR: unexpected dtype 33 while parsing time
Move DTK_ISODOW DTK_DOW and DTK_DOY to be type UNITS rather than
RESERV. RESERV is meant for tokens like "now" and having them in that
category throws errors like these when used as an input date:
stark=# SELECT 'doy'::timestamptz;
ERROR: unexpected dtype 33 while parsing timestamptz "doy"
LINE 1
Adjust Release Notes to reflect holding off wrapped expanded mode until 9.5
(thanks Michael Paquier)
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/663675885ec2c97c8b59ce3e30f6ad05d162a584
Modified Files
--
doc/src/sgml/release-9.4.sgml |8
On Mon, Aug 18, 2014 at 4:55 PM, Tom Lane wrote:
> Actually, that needs to be done in master, which is always the
> authoritative copy of release-note SGML files.
hm, interesting. ok.
--
greg
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your
Adjust Release Notes to reflect holding off wrapped expanded mode until 9.5
(thanks Michael Paquier)
Branch
--
REL9_4_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/61947069ffb27a7eb8037cbd7756dbcbb06ebd4a
Modified Files
--
doc/src/sgml/release-9.4.sgml |8 --
Fix further concerns about psql wrapping in expanded mode having
collateral damage on other formats, by Sergey Muraviov.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/458ef6bad15702a3ac9b7b302a0378f8817620c0
Modified Files
--
src/bin/psql/print.c
Revert psql changes to support wrapped expanded mode. That feature is
nice and we'll keep it in 9.5 but it'll take more time to iron out the
collateral damage on other queries and also on tools like
check_postgres.
revert dbe31616c9be7380b8a88cdfbeaa68dbdcdebc36
revert 6513633b94173fc1d9e2b213c43f
Remove unnecessary cast causing a warning
Incidentally, I reversed the two names in the earlier commit. The
original author was Sergey Muraviov and the reviewer was Emre
Hasegeli.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/dbe31616c9be7380b8a88cdfbeaa68dbdcdebc3
Add support for wrapping to psql's "extended" mode. This makes it very
feasible to display tables that have both many columns and some large
data in some columns (such as pg_stats).
Emre Hasegeli with review and rewriting from Sergey Muraviov and
reviewed by Greg Stark
Branc
Yeah I think this is OK.
But the original goal seems like it would be easier and better done with an
immutable function which lies and calls elog to leak information. That's
the actual attack this is supposed to protect against anyways.
That would make the tests more robust against other changes
On Sun, Mar 23, 2014 at 1:22 PM, Heikki Linnakangas wrote:
> The reason for the typedef is precisely that an enum is not guaranteed to
> be one byte. Tom suggested getting rid of the typedef, but it's needed to
> make sure it's stored as one byte.
>
> I'll go add a comment to it, explaining why i
Fix thinko in worker_spi, count(*) returns a bigint. Thanks RhodiumToad
Branch
--
REL9_3_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/9720164d3426b0a223208b9dc5698264cdb9e2a0
Modified Files
--
contrib/worker_spi/worker_spi.c |2 +-
1 file changed, 1 insertion
Fix thinko in worker_spi, count(*) returns a bigint. Thanks RhodiumToad
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/cfa1cd711c2648e0beab50448c5a71ef91a3e1cb
Modified Files
--
contrib/worker_spi/worker_spi.c |2 +-
1 file changed, 1 insertion(+), 1
Sync ECPG with WITH ORDINALITY changes
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/69b7d59a744134e33bbe51dab44dd4113c83b7fb
Modified Files
--
src/interfaces/ecpg/preproc/parse.pl |1 +
src/interfaces/ecpg/preproc/parser.c
Add SQL Standard WITH ORDINALITY support for UNNEST (and any other SRF)
Author: Andrew Gierth, David Fetter
Reviewers: Dean Rasheed, Jeevan Chalke, Stephen Frost
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/c62736cc37f6812d1ebb41ea5a86ffe60564a1f0
Modified Files
On Thu, May 2, 2013 at 4:44 PM, Dimitri Fontaine wrote:
> Use unicode super power and ouput µsec, as it's meant to be? Then google
> is useful again, for the smaller number of people who would need it.
The SI abbreviation would be µs actually.
I don't think it's worth spending an U+03B9 of time
fix up a couple non-prototypes of the form foo() to be foo(void) -- found using
-Wstrict-prototypes
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/7b66e2c086b1a24d8adad52842725db8c0499e02
Modified Files
--
src/bin/pg_basebackup/pg_basebackup.c |4 ++
Uhm. We don't plan to release 7.4 do we?
On Fri, May 14, 2010 at 4:44 AM, Marc G. Fournier
wrote:
> Log Message:
> ---
>
> tag 7.4.29
>
> Tags:
>
> REL7_4_STABLE
>
> Modified Files:
> --
> pgsql:
> configure (r1.310.2.41 -> r1.310.2.42)
>
> (http://anonc
Log Message:
---
add EPERM to the list of return codes to expect from opening directories based
on Vista results
Modified Files:
--
pgsql/src/port:
copydir.c (r1.34 -> r1.35)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/port/copydir.c?r1=1.34&r2=1.3
Log Message:
---
Second try at fsyncing directories in CREATE DATABASE. Let's see what the build
farm says of opening directories read-only and ignoring EBADF from fsync of
directories
Modified Files:
--
pgsql/src/port:
copydir.c (r1.33 -> r1.34)
(http://
On Mon, Feb 22, 2010 at 2:54 AM, Tom Lane wrote:
> Actually, that code had *multiple* problems including stat'ing the wrong
> file entirely, not to mention that this last commit failed to even
> compile. I also think it should scan the todir not the fromdir, just on
> general principles to avoid
On Sun, Feb 21, 2010 at 11:43 PM, Andres Freund wrote:
> Could you add it back?
>
Oops, sorry. Sigh. Done.
--
greg
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Log Message:
---
Oops, don't forget to rewind the directory before scanning it to fsync files in
CREATE DATABASE
Modified Files:
--
pgsql/src/port:
copydir.c (r1.28 -> r1.29)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/port/copydir.c?r1=1.28&r2=1.2
Log Message:
---
revert prior patch to fsync directories until portability problems exposed by
build farm can be sorted out
Tags:
REL8_1_STABLE
Modified Files:
--
pgsql/src/port:
copydir.c (r1.16.2.2 -> r1.16.2.3)
(http://anoncvs.postgresql.org/cvswe
Log Message:
---
revert to showing buffer counts in explain (buffers)
Modified Files:
--
pgsql/src/backend/commands:
explain.c (r1.201 -> r1.202)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/explain.c?r1=1.201&r2=1.202)
--
Sent via
Log Message:
---
revert prior patch to fsync directories until portability problems exposed by
build farm can be sorted out
Tags:
REL8_3_STABLE
Modified Files:
--
pgsql/src/port:
copydir.c (r1.21.2.2 -> r1.21.2.3)
(http://anoncvs.postgresql.org/cvswe
Log Message:
---
revert prior patch to fsync directories until portability problems exposed by
build farm can be sorted out
Tags:
REL8_2_STABLE
Modified Files:
--
pgsql/src/port:
copydir.c (r1.18.2.2 -> r1.18.2.3)
(http://anoncvs.postgresql.org/cvswe
Log Message:
---
revert prior patch to fsync directories until portability problems exposed by
build farm can be sorted out
Tags:
REL8_4_STABLE
Modified Files:
--
pgsql/src/port:
copydir.c (r1.23.2.1 -> r1.23.2.2)
(http://anoncvs.postgresql.org/cvswe
Log Message:
---
Temporarily disable fsyncing the database directory in CREATE DATABASE
until we can work out portability issues the build farm uncovered.
In passing avoid fsyncing subdirectories twice.
Modified Files:
--
pgsql/src/port:
copydir.c (r1.27 -> r1.28)
Log Message:
---
Display explain buffers measurements in memory units rather than blocks. Also
show "Total Buffer Usage" to hint that these are totals not averages per loop
Modified Files:
--
pgsql/src/backend/commands:
explain.c (r1.200 -> r1.201)
(http:/
Log Message:
---
Speed up CREATE DATABASE by deferring the fsyncs until after copying
all the data and using posix_fadvise to nudge the OS into flushing it
earlier. This also hopefully makes CREATE DATABASE avoid spamming the
cache.
Tests show a big speedup on Linux at least on some filesy
Log Message:
---
Make CREATE DATABASE safe against losing whole files by fsyncing the
directory and not just the individual files.
Back-patch to 8.1 -- before that we just called "cp -r" and never
fsynced anything anyways.
Modified Files:
--
pgsql/src/port:
copydir
Log Message:
---
Make CREATE DATABASE safe against losing whole files by fsyncing the
directory and not just the individual files.
Back-patch to 8.1 -- before that we just called "cp -r" and never
fsynced anything anyways.
Tags:
REL8_4_STABLE
Modified Files:
--
pgsql
Log Message:
---
Make CREATE DATABASE safe against losing whole files by fsyncing the
directory and not just the individual files.
Back-patch to 8.1 -- before that we just called "cp -r" and never
fsynced anything anyways.
Tags:
REL8_3_STABLE
Modified Files:
--
pgsql
Log Message:
---
Make CREATE DATABASE safe against losing whole files by fsyncing the
directory and not just the individual files.
Back-patch to 8.1 -- before that we just called "cp -r" and never
fsynced anything anyways.
Tags:
REL8_2_STABLE
Modified Files:
--
pgsql
Log Message:
---
Make CREATE DATABASE safe against losing whole files by fsyncing the
directory and not just the individual files.
Back-patch to 8.1 -- before that we just called "cp -r" and never
fsynced anything anyways.
Tags:
REL8_1_STABLE
Modified Files:
--
pgsql
On Sat, Jan 23, 2010 at 4:37 PM, Simon Riggs wrote:
> max_standby_delay = -1 option removed to prevent deadlock.
This seems unacceptable to me. It means it's impossible to configure a
reporting slave so it doesn't spuriously signal errors if your reports
run too long.
Recall that I am still of t
On Tue, Aug 4, 2009 at 5:04 AM, Tom Lane wrote:
> Cause pg_proc.probin to be declared as text, not bytea.
Doesn't this relate to the earlier discussion of whether to re-encode
filenames and paths?
What's going to happen if I have filenames which aren't valid encoded
strings in the server encoding
54 matches
Mail list logo