Re: [COMMITTERS] pgsql: Replace pgindent shell script with Perl script. Update perltidy

2012-08-07 Thread Tom Lane
Bruce Momjian writes: > On Sat, Aug 4, 2012 at 05:55:51PM -0400, Tom Lane wrote: >>> I'm not sure if we have any project policy for minimum required Perl >>> version, but I've not found that any of our other Perl scripts don't >>> work with 5.8. > Tom, please make whatever changes you wish so it

Re: [COMMITTERS] pgsql: Replace pgindent shell script with Perl script. Update perltidy

2012-08-04 Thread Bruce Momjian
On Sat, Aug 4, 2012 at 05:55:51PM -0400, Tom Lane wrote: > Andrew Dunstan writes: > > On 08/04/2012 03:40 PM, Tom Lane wrote: > >> I'm not sure if we have any project policy for minimum required Perl > >> version, but I've not found that any of our other Perl scripts don't > >> work with 5.8. >

Re: [COMMITTERS] pgsql: Replace pgindent shell script with Perl script. Update perltidy

2012-08-04 Thread Andrew Dunstan
On 08/04/2012 05:55 PM, Tom Lane wrote: Andrew Dunstan writes: On 08/04/2012 03:40 PM, Tom Lane wrote: I'm not sure if we have any project policy for minimum required Perl version, but I've not found that any of our other Perl scripts don't work with 5.8. Well, It's at least in 5.10.1 which

Re: [COMMITTERS] pgsql: Replace pgindent shell script with Perl script. Update perltidy

2012-08-04 Thread Tom Lane
Andrew Dunstan writes: > On 08/04/2012 03:40 PM, Tom Lane wrote: >> I'm not sure if we have any project policy for minimum required Perl >> version, but I've not found that any of our other Perl scripts don't >> work with 5.8. > Well, It's at least in 5.10.1 which dates from 3 years ago. I suspec

Re: [COMMITTERS] pgsql: Replace pgindent shell script with Perl script. Update perltidy

2012-08-04 Thread Andrew Dunstan
On 08/04/2012 03:40 PM, Tom Lane wrote: I wrote: This version of pgindent is just about completely broken, so far as my possibly-a-bit-hoary Perl (5.8.7) is concerned. I think it could be made more portable without too much effort, but I am wondering what the heck "\h" is supposed to mean in a

Re: [COMMITTERS] pgsql: Replace pgindent shell script with Perl script. Update perltidy

2012-08-04 Thread Tom Lane
I wrote: > This version of pgindent is just about completely broken, so far as my > possibly-a-bit-hoary Perl (5.8.7) is concerned. I think it could be > made more portable without too much effort, but I am wondering what the > heck "\h" is supposed to mean in a regex? After a bit of research I f

Re: [COMMITTERS] pgsql: Replace pgindent shell script with Perl script. Update perltidy

2012-08-04 Thread Tom Lane
Bruce Momjian writes: > Replace pgindent shell script with Perl script. Update perltidy > instructions to perltidy Perl files that lack Perl file extensions. This version of pgindent is just about completely broken, so far as my possibly-a-bit-hoary Perl (5.8.7) is concerned. I think it could b

[COMMITTERS] pgsql: Replace pgindent shell script with Perl script. Update perltidy

2012-08-04 Thread Bruce Momjian
Replace pgindent shell script with Perl script. Update perltidy instructions to perltidy Perl files that lack Perl file extensions. pgindent Perl coding by Andrew Dunstan, restructured by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/149ac7d45595f64f7b60833de7