Re: [COMMITTERS] pgsql: Several fixes to array handling in ecpg.

2014-04-10 Thread Michael Meskes
On Thu, Apr 10, 2014 at 09:44:39AM -0400, Tom Lane wrote: > This patch is causing almost all of the Windows buildfarm members to > fail with compilation errors, along the lines of Argh, I stopped monitoring the buildfarm for this patch when the first 5 to 10 members came up green. Windows being so

Re: [COMMITTERS] pgsql: Several fixes to array handling in ecpg.

2014-04-10 Thread Tom Lane
Michael Meskes writes: > Several fixes to array handling in ecpg. This patch is causing almost all of the Windows buildfarm members to fail with compilation errors, along the lines of pointer_to_struct.pgc(27): error C2065: 'customer' : undeclared identifier pointer_to_struct.pgc(27): error C206

Re: [COMMITTERS] pgsql: Several fixes to array handling in ecpg.

2014-04-09 Thread Andres Freund
On 2014-04-09 12:46:35 +0200, Michael Meskes wrote: > > > Several fixes to array handling in ecpg. > > > > What's actually fixed by this? > > There were a couple of reports that data got filled into array incorrectly > and at least some of those were fixed by the patches. It'd be useful to desc

Re: [COMMITTERS] pgsql: Several fixes to array handling in ecpg.

2014-04-09 Thread Michael Meskes
> > Several fixes to array handling in ecpg. > > What's actually fixed by this? There were a couple of reports that data got filled into array incorrectly and at least some of those were fixed by the patches. > The patch, or at least the comments, don't look entirely finished: > + /* > +

Re: [COMMITTERS] pgsql: Several fixes to array handling in ecpg.

2014-04-09 Thread Andres Freund
Hi, On 2014-04-09 09:24:08 +, Michael Meskes wrote: > Several fixes to array handling in ecpg. What's actually fixed by this? The patch, or at least the comments, don't look entirely finished: + /* +* If siz i.e. the size of structure of which this variable is part of, +

[COMMITTERS] pgsql: Several fixes to array handling in ecpg.

2014-04-09 Thread Michael Meskes
Several fixes to array handling in ecpg. Patches by Ashutosh Bapat Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/3b8fda6763ceccac0fc5ae0e921568235608252c Modified Files -- src/interfaces/ecpg/preproc/type.c | 17 +++-- .../

[COMMITTERS] pgsql: Several fixes to array handling in ecpg.

2014-04-09 Thread Michael Meskes
Several fixes to array handling in ecpg. Patches by Ashutosh Bapat Conflicts: src/interfaces/ecpg/test/expected/preproc-outofscope.c Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/0de1068365909970eb75c51d82467d28631b63ef Modified Files

[COMMITTERS] pgsql: Several fixes to array handling in ecpg.

2014-04-09 Thread Michael Meskes
Several fixes to array handling in ecpg. Patches by Ashutosh Bapat Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/2b3136de9ed80cf89287651048d1597ebc1b4b6d Modified Files -- src/interfaces/ecpg/preproc/type.c | 17 +++-- .../

[COMMITTERS] pgsql: Several fixes to array handling in ecpg.

2014-04-09 Thread Michael Meskes
Several fixes to array handling in ecpg. Patches by Ashutosh Bapat Conflicts: src/interfaces/ecpg/test/expected/preproc-outofscope.c Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/0c2eb989ea93f3e0ccbbbf39853bcd3e23879603 Modified Files

[COMMITTERS] pgsql: Several fixes to array handling in ecpg.

2014-04-09 Thread Michael Meskes
Several fixes to array handling in ecpg. Patches by Ashutosh Bapat Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f9179685371b74bf4752bf3f87846e5625cf91fa Modified Files -- src/interfaces/ecpg/preproc/type.c | 17 +- src/interfaces/ecp