Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-12 Thread Michael Paquier
On Wed, May 13, 2015 at 12:31 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: Mind share more details about that? How would you detect that a given test in serial_schedule needs to be considered by test_ddl_deparse automatically? WIth a new type of keyword in a

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-12 Thread Andrew Dunstan
On 05/12/2015 12:05 AM, Alvaro Herrera wrote: Michael Paquier wrote: On Tue, May 12, 2015 at 11:43 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, May 12, 2015 at 11:37 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: On Tue, May 12, 2015 at 7:16 AM,

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-12 Thread Andrew Dunstan
On 05/12/2015 10:03 AM, Alvaro Herrera wrote: In any case, it is not good to keep the buildfarm machines broken for too long, and personally I would rather avoid adding one more hack in the MSVC build scripts. The MSVC build scripts *are* hacks themselves. Anyway, I'll look into it. Nobody

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-12 Thread Alvaro Herrera
Michael Paquier wrote: On Tue, May 12, 2015 at 1:05 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Sure. I want to avoid doing that, though: we may want to generate a schedule based on src/test/regress/serial_schedule, so that newly added tests to the regular suite are automatically

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-12 Thread Alvaro Herrera
Michael Paquier wrote: Mind share more details about that? How would you detect that a given test in serial_schedule needs to be considered by test_ddl_deparse automatically? WIth a new type of keyword in a schedule file? This looks like a different feature to me that's going to need more

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-11 Thread Michael Paquier
On Tue, May 12, 2015 at 11:43 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, May 12, 2015 at 11:37 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: On Tue, May 12, 2015 at 7:16 AM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Not sure what's the real

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-11 Thread Alvaro Herrera
Michael Paquier wrote: On Tue, May 12, 2015 at 11:43 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, May 12, 2015 at 11:37 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: On Tue, May 12, 2015 at 7:16 AM, Alvaro Herrera alvhe...@alvh.no-ip.org

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-11 Thread Michael Paquier
On Tue, May 12, 2015 at 1:05 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: On Tue, May 12, 2015 at 11:43 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, May 12, 2015 at 11:37 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote:

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-11 Thread Michael Paquier
On Tue, May 12, 2015 at 1:18 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, May 12, 2015 at 1:05 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: On Tue, May 12, 2015 at 11:43 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, May 12, 2015 at

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-11 Thread Michael Paquier
On Tue, May 12, 2015 at 7:16 AM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Allow on-the-fly capture of DDL event details This feature lets user code inspect and take action on DDL events. Whenever a ddl_command_end event trigger is installed, DDL actions executed are saved to a list which

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-11 Thread Alvaro Herrera
Michael Paquier wrote: On Tue, May 12, 2015 at 7:16 AM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Allow on-the-fly capture of DDL event details This feature lets user code inspect and take action on DDL events. Whenever a ddl_command_end event trigger is installed, DDL actions

Re: [COMMITTERS] pgsql: Allow on-the-fly capture of DDL event details

2015-05-11 Thread Michael Paquier
On Tue, May 12, 2015 at 11:37 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: On Tue, May 12, 2015 at 7:16 AM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Allow on-the-fly capture of DDL event details This feature lets user code inspect and take action on DDL