Re: [COMMITTERS] pgsql: Separate block sampling functions

2015-05-18 Thread Andrew Dunstan
On 05/15/2015 07:44 AM, Andrew Dunstan wrote: On 05/15/2015 06:04 AM, Simon Riggs wrote: On 15 May 2015 at 04:59, Tom Lane t...@sss.pgh.pa.us mailto:t...@sss.pgh.pa.us wrote: The difference there was that that was specifically adding a new feature of value to FDWs. This is just

Re: [COMMITTERS] pgsql: Separate block sampling functions

2015-05-18 Thread Simon Riggs
On 18 May 2015 at 10:53, Tom Lane t...@sss.pgh.pa.us wrote: Andrew Dunstan and...@dunslane.net writes: What is the current state of this? Are we sticking with what Tom classified as drive-by breakage? Since I was the one complaining, I'm willing to do the legwork to insert a compatibility

Re: [COMMITTERS] pgsql: Separate block sampling functions

2015-05-15 Thread Michael Paquier
On Fri, May 15, 2015 at 8:44 PM, Andrew Dunstan and...@dunslane.net wrote: On 05/15/2015 06:04 AM, Simon Riggs wrote: On 15 May 2015 at 04:59, Tom Lane t...@sss.pgh.pa.us mailto:t...@sss.pgh.pa.us wrote: The difference there was that that was specifically adding a new feature

Re: [COMMITTERS] pgsql: Separate block sampling functions

2015-05-15 Thread Simon Riggs
On 15 May 2015 at 04:59, Tom Lane t...@sss.pgh.pa.us wrote: The difference there was that that was specifically adding a new feature of value to FDWs. This is just drive-by breakage. I think that comment is reasonable. I will continue with my commits of tablesample, then return to see if we

Re: [COMMITTERS] pgsql: Separate block sampling functions

2015-05-15 Thread Andrew Dunstan
On 05/15/2015 06:04 AM, Simon Riggs wrote: On 15 May 2015 at 04:59, Tom Lane t...@sss.pgh.pa.us mailto:t...@sss.pgh.pa.us wrote: The difference there was that that was specifically adding a new feature of value to FDWs. This is just drive-by breakage. I think that comment is

Re: [COMMITTERS] pgsql: Separate block sampling functions

2015-05-14 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: Separate block sampling functions This patch broke buildfarm member crake. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription:

Re: [COMMITTERS] pgsql: Separate block sampling functions

2015-05-14 Thread Tom Lane
Michael Paquier michael.paqu...@gmail.com writes: On Fri, May 15, 2015 at 12:03 PM, Simon Riggs si...@2ndquadrant.com wrote: On 15 May 2015 at 03:50, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: Separate block sampling functions This patch broke buildfarm

Re: [COMMITTERS] pgsql: Separate block sampling functions

2015-05-14 Thread Simon Riggs
On 15 May 2015 at 03:50, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: Separate block sampling functions This patch broke buildfarm member crake. OK, thanks. I missed that amongst the other unrelated failures. Looking now. -- Simon Riggs

Re: [COMMITTERS] pgsql: Separate block sampling functions

2015-05-14 Thread Simon Riggs
On 15 May 2015 at 04:06, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, May 15, 2015 at 12:03 PM, Simon Riggs si...@2ndquadrant.com wrote: On 15 May 2015 at 03:50, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: Separate block sampling functions

Re: [COMMITTERS] pgsql: Separate block sampling functions

2015-05-14 Thread Tom Lane
Michael Paquier michael.paqu...@gmail.com writes: On Fri, May 15, 2015 at 12:22 PM, Tom Lane t...@sss.pgh.pa.us wrote: TBH, I think that this patch itself was a bad idea and should be reverted. I don't object to changing APIs used by external modules when there's a good reason to break them,

Re: [COMMITTERS] pgsql: Separate block sampling functions

2015-05-14 Thread Michael Paquier
On Fri, May 15, 2015 at 12:03 PM, Simon Riggs si...@2ndquadrant.com wrote: On 15 May 2015 at 03:50, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: Separate block sampling functions This patch broke buildfarm member crake. OK, thanks. I missed that amongst

Re: [COMMITTERS] pgsql: Separate block sampling functions

2015-05-14 Thread Michael Paquier
On Fri, May 15, 2015 at 12:12 PM, Simon Riggs si...@2ndquadrant.com wrote: On 15 May 2015 at 04:06, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, May 15, 2015 at 12:03 PM, Simon Riggs si...@2ndquadrant.com wrote: On 15 May 2015 at 03:50, Tom Lane t...@sss.pgh.pa.us wrote:

Re: [COMMITTERS] pgsql: Separate block sampling functions

2015-05-14 Thread Michael Paquier
On Fri, May 15, 2015 at 12:22 PM, Tom Lane t...@sss.pgh.pa.us wrote: Michael Paquier michael.paqu...@gmail.com writes: On Fri, May 15, 2015 at 12:03 PM, Simon Riggs si...@2ndquadrant.com wrote: On 15 May 2015 at 03:50, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com