Robert Haas writes:
> On Thu, Feb 2, 2017 at 11:16 PM, Tom Lane wrote:
>> I just made the C code agree with what the SQL declarations for the
>> functions say.
> Doesn't look like it to me. You changed a bunch of places that say
> UInt32GetDatum to UInt64GetDatum, but the SQL type certainly is
On Fri, Feb 3, 2017 at 8:13 PM, Tom Lane wrote:
> Amit Kapila writes:
>> I have gone through all the of the SQL declarations and it seems
>> hash_metapage_info(...,OUT procid int4,..) is not consistent. procid
>> is unsigned int, so isn't it better to use the corresponding datatype
>> as int8 in
On Thu, Feb 2, 2017 at 11:16 PM, Tom Lane wrote:
> Robert Haas writes:
>> On Thu, Feb 2, 2017 at 11:00 PM, Tom Lane wrote:
>>> I'm about to push a fix that removes the crashes (or at least the ones
>>> I see on dromedary),
>
>> For comparison, a patch I wrote by inspection is attached.
>
> Hm,
Amit Kapila writes:
> I have gone through all the of the SQL declarations and it seems
> hash_metapage_info(...,OUT procid int4,..) is not consistent. procid
> is unsigned int, so isn't it better to use the corresponding datatype
> as int8 in SQL function hash_metapage_info then use Int64GetDatum
On Fri, Feb 3, 2017 at 4:36 PM, Amit Kapila wrote:
> On Fri, Feb 3, 2017 at 9:46 AM, Tom Lane wrote:
>> Robert Haas writes:
>>> On Thu, Feb 2, 2017 at 11:00 PM, Tom Lane wrote:
I'm about to push a fix that removes the crashes (or at least the ones
I see on dromedary),
>>
>>> For compa
On Fri, Feb 3, 2017 at 9:46 AM, Tom Lane wrote:
> Robert Haas writes:
>> On Thu, Feb 2, 2017 at 11:00 PM, Tom Lane wrote:
>>> I'm about to push a fix that removes the crashes (or at least the ones
>>> I see on dromedary),
>
>> For comparison, a patch I wrote by inspection is attached.
>
> Hm, so
Robert Haas writes:
> On Thu, Feb 2, 2017 at 11:00 PM, Tom Lane wrote:
>> I'm about to push a fix that removes the crashes (or at least the ones
>> I see on dromedary),
> For comparison, a patch I wrote by inspection is attached.
Hm, some of what you have here matches what I just pushed, but no
On Thu, Feb 2, 2017 at 11:00 PM, Tom Lane wrote:
> Robert Haas writes:
>> Ugh, yes. Sorry, I should have checked this more carefully before
>> commit. I mentioned the problem in a previous review and failed to
>> notice that it hadn't been fixed. Are you taking care of it at this
>> point or s
Robert Haas writes:
> Ugh, yes. Sorry, I should have checked this more carefully before
> commit. I mentioned the problem in a previous review and failed to
> notice that it hadn't been fixed. Are you taking care of it at this
> point or should I keep at it?
I'm about to push a fix that remove
On Thu, Feb 2, 2017 at 10:40 PM, Tom Lane wrote:
> Robert Haas writes:
>> pageinspect: Try to fix some bugs in previous commit.
>
> This is a first step, but there's more :-(. Poking at it now on
> dromedary.
Ugh, yes. Sorry, I should have checked this more carefully before
commit. I mentione
Robert Haas writes:
> pageinspect: Try to fix some bugs in previous commit.
This is a first step, but there's more :-(. Poking at it now on
dromedary.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your
11 matches
Mail list logo
