Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-04-24 Thread Christian Ullrich
* Magnus Hagander wrote: Add putenv support for msvcrt from Visual Studio 2013 This was missed when VS 2013 support was added. Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9f633b404cb3be6139f8dfdea00538489ffef9ab Just noticed something. This

Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-04-25 Thread Christian Ullrich
* Magnus Hagander wrote: On Sun, Apr 24, 2016 at 9:56 PM, Christian Ullrich wrote: * Magnus Hagander wrote: Add putenv support for msvcrt from Visual Studio 2013 http://git.postgresql.org/pg/commitdiff/9f633b404cb3be6139f8dfdea00538489ffef9ab Just noticed something. This DLL detection by

Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-04-25 Thread Christian Ullrich
* Andrew Dunstan wrote: On 04/25/2016 09:27 AM, Christian Ullrich wrote: * Magnus Hagander wrote: On Sun, Apr 24, 2016 at 9:56 PM, Christian Ullrich wrote: Just noticed something. This DLL detection by name has never worked in debug builds where the DLL names end in "d"

Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-04-25 Thread Christian Ullrich
* Christian Ullrich wrote: * Andrew Dunstan wrote: What if both are present? Is a release build prevented from loading a debug dll and vice versa? Debug and release are simply two separate CRTs. If your process contains a module that needs the one, and another that needs the other, you

Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-04-26 Thread Christian Ullrich
* Christian Ullrich wrote: wrong even without considering the debug/release split. If we load a compiled extension built with a CRT we have not seen yet, _after_ the first call to pgwin32_putenv(), that module's CRT's view of its environment will be frozen because we will never

Re: [COMMITTERS] pgsql: Support building with Visual Studio 2015

2016-04-29 Thread Christian Ullrich
* Andrew Dunstan wrote: Support building with Visual Studio 2015 http://git.postgresql.org/pg/commitdiff/da52474f3d3cbdf38d8a6677a4ebedaf402ade3a diff --git a/src/port/win32env.c b/src/port/win32env.c index 7e4ff62..d6b0ebe 100644 (file) --- a/src/port/win32env.c +++ b/src/port/win32env.c @@ -

Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-09-01 Thread Christian Ullrich
* Michael Paquier wrote: > On Wed, Apr 27, 2016 at 2:39 AM, Christian Ullrich wrote: >> * Christian Ullrich wrote: > And actually, by looking at those patches, isn't it a dangerous > practice to be able to load multiple versions of the same DLL routines > in the

Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-09-06 Thread Christian Ullrich
* Michael Paquier wrote: On Thu, Sep 1, 2016 at 4:03 PM, Christian Ullrich wrote: My conclusion from April stands: The fact that master looks like it does means that there have not been many (or any) complaints about missing cross-module environment variables. If nobody ever needs to see

Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-09-06 Thread Christian Ullrich
* Michael Paquier wrote: On Tue, Sep 6, 2016 at 5:36 PM, Christian Ullrich wrote: * Michael Paquier wrote: In order to avoid any problems with the load and unload windows, my bet goes for 0001, 0002 and 0003, with the last two patches merged together, 0001 being only a set of independent