[COMMITTERS] pgsql: Add support for logging the current role.

2011-01-12 Thread Robert Haas
Add support for logging the current role. Stephen Frost, with some editorialization by me. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=a8a8867912c46a68c9ac14903b3dba2fab8f7097 Modified Files -- doc/src/sgml/config.sgml

[COMMITTERS] pgsql: Revert patch adding support for logging the current role.

2011-01-12 Thread Robert Haas
Revert patch adding support for logging the current role. This reverts commit a8a8867912c46a68c9ac14903b3dba2fab8f7097, committed by me earlier today (2011-01-12). This isn't safe inside an aborted transaction. Noted by Tom Lane. Branch -- master Details --- http://git.postgresql.org/g

[COMMITTERS] pgsql: Document that WITH queries are also called Common Table Expressi

2011-01-19 Thread Robert Haas
Document that WITH queries are also called Common Table Expressions. Peter Geoghegan, reviewed by Stephen Frost Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=92f7eebbbd6554f0414ab869abd8733cef751249 Modified Files -- doc/src/sg

[COMMITTERS] pgsql: Document that WITH queries are also called Common Table Expressi

2011-01-19 Thread Robert Haas
Document that WITH queries are also called Common Table Expressions. Peter Geoghegan, reviewed by Stephen Frost Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=ba3afc88d2b81fc609cda8504ee7b54c54b379d7 Modified Files -- doc

[COMMITTERS] pgsql: Document that WITH queries are also called Common Table Expressi

2011-01-19 Thread Robert Haas
Document that WITH queries are also called Common Table Expressions. Peter Geoghegan, reviewed by Stephen Frost Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=9de3f2843c4cf695a37d04d268df350b6118a232 Modified Files -- doc

[COMMITTERS] pgsql: Add new psql command \dL to list languages.

2011-01-19 Thread Robert Haas
Add new psql command \dL to list languages. Original patch by Fernando Ike, revived by Josh Kuperschmidt, reviewed by Andreas Karlsson, and in earlier versions by Tom Lane and Peter Eisentraut. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h

[COMMITTERS] pgsql: Make ALTER TABLE revalidate uniqueness and exclusion constraints

2011-01-20 Thread Robert Haas
Make ALTER TABLE revalidate uniqueness and exclusion constraints. Failure to do so can lead to constraint violations. This was broken by commit 1ddc2703a936d03953657f43345460b9242bbed1 on 2010-02-07, so back-patch to 9.0. Noah Misch. Regression test by me. Branch -- master Details ---

[COMMITTERS] pgsql: Make ALTER TABLE revalidate uniqueness and exclusion constraints

2011-01-20 Thread Robert Haas
Make ALTER TABLE revalidate uniqueness and exclusion constraints. Failure to do so can lead to constraint violations. This was broken by commit 1ddc2703a936d03953657f43345460b9242bbed1 on 2010-02-07, so back-patch to 9.0. Noah Misch. Regression test by me. Branch -- REL9_0_STABLE Details

[COMMITTERS] pgsql: Emphasize where OVER needs to be when using a window function.

2011-01-21 Thread Robert Haas
Emphasize where OVER needs to be when using a window function. Jeff Turner Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=d3b372e92d4efdd6f63da35996f04ff009c932b5 Modified Files -- doc/src/sgml/advanced.sgml |2 +- 1 files ch

[COMMITTERS] pgsql: Code cleanup for assign_XactIsoLevel.

2011-01-21 Thread Robert Haas
Code cleanup for assign_XactIsoLevel. The new coding avoids a spurious debug message when a transaction that has changed the isolation level has been rolled back. It also allows the property to be freely changed to the current value within a subtransaction. Kevin Grittner, with one small change

[COMMITTERS] pgsql: Avoid treating WAL senders as normal backends.

2011-01-21 Thread Robert Haas
Avoid treating WAL senders as normal backends. The previous coding treated anything that wasn't an autovacuum launcher as a normal backend, which is wrong now that we also have WAL senders. Fujii Masao, reviewed by Robert Haas, Alvaro Herrera, Tom Lane, and Bernd Helmle. Branch -- m

[COMMITTERS] pgsql: Code cleanup for assign_transaction_read_only.

2011-01-22 Thread Robert Haas
Code cleanup for assign_transaction_read_only. As in commit fb4c5d2798730f60b102d775f22fb53c26a6445d on 2011-01-21, this avoids spurious debug messages and allows idempotent changes at any time. Along the way, make assign_XactIsoLevel allow idempotent changes even when not within a subtransaction

[COMMITTERS] pgsql: sepgsql, an SE-Linux integration for PostgreSQL

2011-01-23 Thread Robert Haas
sepgsql, an SE-Linux integration for PostgreSQL This is still pretty rough - among other things, the documentation needs work, and the messages need a visit from the style police - but this gets the basic framework in place. KaiGai Kohei Branch -- master Details --- http://git.postgresq

[COMMITTERS] pgsql: First round of cleanup of sepgsql code and documentation.

2011-01-23 Thread Robert Haas
First round of cleanup of sepgsql code and documentation. Robert Haas, with a few suggestions from Thom Brown Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=194c8f713aa62a528afa4ce4274b80aaff9eb264 Modified Files -- contrib

Re: [COMMITTERS] pgsql: sepgsql, an SE-Linux integration for PostgreSQL

2011-01-23 Thread Robert Haas
> haven't yet gone through though. Thanks. I just committed a bunch of cleanup, including whatever of your patch I didn't rewrite along the way. If you want to take another crack at it now I'd be most grateful... -- Robert Haas EnterpriseDB: http://www.enterprisedb.com T

[COMMITTERS] pgsql: Blind attempt to exclude sepgsql from MSVC build system.

2011-01-23 Thread Robert Haas
Blind attempt to exclude sepgsql from MSVC build system. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=c26ac226e45fbf84cd63588498c00da9417aebc1 Modified Files -- src/tools/msvc/Install.pm |1 + src/tools/msvc/Mkvcbuild.pm |

[COMMITTERS] pgsql: PGXS support for contrib/hstore

2011-01-23 Thread Robert Haas
PGXS support for contrib/hstore Joey Adams Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=41611f16e933dafa9c3ae0477f89537ea1459eb6 Modified Files -- contrib/hstore/Makefile | 13 + 1 files changed, 9 insertions(+),

[COMMITTERS] pgsql: More documentation cleanup for sepgsql.

2011-01-24 Thread Robert Haas
More documentation cleanup for sepgsql. Thom Brown and Robert Haas Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=ea2c2641f908cde198a100d847078a05385b Modified Files -- doc/src/sgml/sepgsql.sgml | 96

Re: [COMMITTERS] pgsql: sepgsql, an SE-Linux integration for PostgreSQL

2011-01-24 Thread Robert Haas
On Mon, Jan 24, 2011 at 8:18 AM, Thom Brown wrote: > On 24 January 2011 03:52, Robert Haas wrote: >> On Sun, Jan 23, 2011 at 9:39 PM, Thom Brown wrote: >>> There are quite a few sentences which I'm not sure how to correct as I >>> don't know how they'r

[COMMITTERS] pgsql: Fix thinko in ALTER FOREIGN TABLE documentation.

2011-01-25 Thread Robert Haas
Fix thinko in ALTER FOREIGN TABLE documentation. Noah Misch Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=558d1c95ae6afb8728f70a150c593f7e7aa5fac1 Modified Files -- doc/src/sgml/ref/alter_foreign_table.sgml |2 +- 1 files ch

[COMMITTERS] pgsql: Correct ALTER TYPE -> SET DATA TYPE in ALTER TABLE documentation

2011-01-25 Thread Robert Haas
Correct ALTER TYPE -> SET DATA TYPE in ALTER TABLE documentation. The latter is the correct name of the operation to change the data type of a column. Noah Misch Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=2c3e29299842f6de74ff96d3

[COMMITTERS] pgsql: Correct ALTER TYPE -> SET DATA TYPE in ALTER TABLE documentation

2011-01-25 Thread Robert Haas
Correct ALTER TYPE -> SET DATA TYPE in ALTER TABLE documentation. The latter is the correct name of the operation to change the data type of a column. Noah Misch Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=2b2b2ae2aa4a7089aee729e67bb3231

Re: [COMMITTERS] pgsql: Update warning about synchronous-commit durability, per suggesti

2011-01-26 Thread Robert Haas
. You don't need to give any special warning for synchronous_commit above and beyond what applies to the whole section. Just delete that part. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers mailing list (pgsql

[COMMITTERS] pgsql: Remove arbitrary ALTER TABLE .. ADD COLUMN restriction.

2011-01-26 Thread Robert Haas
Remove arbitrary ALTER TABLE .. ADD COLUMN restriction. The previous coding prevented ALTER TABLE .. ADD COLUMN from being used with a non-NULL default in situations where the table's rowtype was being used elsewhere. But this is a completely arbitrary restriction since you could do the same oper

[COMMITTERS] pgsql: Add a comment explaining why we force physical removal of OIDs.

2011-01-26 Thread Robert Haas
Add a comment explaining why we force physical removal of OIDs. Noah Misch, slightly revised. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=5c2a7c6e97741564ab4ff336eac8d8227485dd4c Modified Files -- src/backend/commands/tablecm

[COMMITTERS] pgsql: Restore ALTER TABLE .. ADD COLUMN w/DEFAULT restriction.

2011-01-27 Thread Robert Haas
Restore ALTER TABLE .. ADD COLUMN w/DEFAULT restriction. This reverts commit a06e41deebdf74b8b5109329dc75b2e9d9057962 of 2011-01-26. Per discussion, this behavior is not wanted, as it would need to change if we ever made composite types support DEFAULT. Branch -- master Details --- http:

[COMMITTERS] pgsql: Try to avoid running with a full fsync request queue.

2011-01-29 Thread Robert Haas
Try to avoid running with a full fsync request queue. When we need to insert a new entry and the queue is full, compact the entire queue in the hopes of making room for the new entry. Doing this on every insertion might worsen contention on BgWriterCommLock, but when the queue it's full, it's far

[COMMITTERS] pgsql: Log restartpoints in the same fashion as checkpoints.

2011-02-02 Thread Robert Haas
Log restartpoints in the same fashion as checkpoints. Prior to 9.0, restartpoints never created, deleted, or recycled WAL files, but now they can. This code makes log_checkpoints treat checkpoints and restartpoints symmetrically. It also adjusts up the documentation of the parameter to mention r

[COMMITTERS] pgsql: Various sepgsql corrections.

2011-02-02 Thread Robert Haas
Various sepgsql corrections. KaiGai Kohei Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=c7689ee73346d198177dee538501bb1148c8cebb Modified Files -- contrib/sepgsql/dml.c | 37 ++ contrib/sepgsql/expecte

[COMMITTERS] pgsql: Minor sepgsql regression test fixes.

2011-02-02 Thread Robert Haas
Minor sepgsql regression test fixes. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=87d967f70f4866c17404f6a9b8062f892ed31e08 Modified Files -- contrib/sepgsql/.gitignore |2 ++ contrib/sepgsql/expected/dml.out |3 ++-

[COMMITTERS] pgsql: sepgsql doc fix

2011-02-02 Thread Robert Haas
sepgsql doc fix KaiGai Kohei Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=4ff9dec1386b714f6c26a52ca6880b14e94dd1db Modified Files -- doc/src/sgml/sepgsql.sgml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Se

[COMMITTERS] pgsql: Further sepgsql documentation cleanup.

2011-02-02 Thread Robert Haas
Further sepgsql documentation cleanup. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=4c4daf671074cc64290e9255c14365b55bf7a47b Modified Files -- doc/src/sgml/sepgsql.sgml | 180 + 1 fil

[COMMITTERS] pgsql: ALTER TABLE sometimes takes only ShareUpdateExclusiveLock.

2011-02-03 Thread Robert Haas
ALTER TABLE sometimes takes only ShareUpdateExclusiveLock. Along the way, be more consistent about the wording we use here. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=7212c77d0cabcc468fec0b9cd7f2413b64b77050 Modified Files -

[COMMITTERS] pgsql: Avoid maintaining three separate copies of the error codes list.

2011-02-03 Thread Robert Haas
Avoid maintaining three separate copies of the error codes list. src/pl/plpgsql/src/plerrcodes.h, src/include/utils/errcodes.h, and a big chunk of errcodes.sgml are now automatically generated from a single file, src/backend/utils/errcodes.txt. Jan Urbański, reviewed by Tom Lane. Branch -- m

[COMMITTERS] pgsql: Preserve copyright notice from old errcodes.h file.

2011-02-03 Thread Robert Haas
Preserve copyright notice from old errcodes.h file. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=b8a0467e10a41d32ecf889d40de81223e0439c5b Modified Files -- src/backend/utils/errcodes.txt |1 + 1 files changed, 1 insertions(+

[COMMITTERS] pgsql: Unbreak the VPATH build.

2011-02-03 Thread Robert Haas
Unbreak the VPATH build. My commit ddfe26f6441c24660595c5efe5fd0bd3974cdc5c of 2010-02-03 broke it. Per buildfarm. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=dde9684d65ed66656f765d3fd97f2e522a189132 Modified Files -- src/ba

[COMMITTERS] pgsql: Unbreak 'configure' followed immediately by 'make install'.

2011-02-04 Thread Robert Haas
Unbreak 'configure' followed immediately by 'make install'. More fallout from ddfe26f6441c24660595c5efe5fd0bd3974cdc5c. Report by Fujii Masao. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=b87811ee273360c45d92b0e7bb7e67670312c221 Modified

[COMMITTERS] pgsql: Make handling of errcodes.h more consistent with other generated

2011-02-04 Thread Robert Haas
Make handling of errcodes.h more consistent with other generated headers. This fixes make distprep, and seems more robust in other ways as well. Some special handling is required because errcodes.txt is needed by some stuff in src/port, but just by src/backend as is the case for the other generate

[COMMITTERS] pgsql: Use $(MAKE) rather than make.

2011-02-04 Thread Robert Haas
Use $(MAKE) rather than make. Per buildfarm. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=6f59a5e5dd73ec2c448dd7038accf5aaba6dc04b Modified Files -- src/port/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[COMMITTERS] pgsql: Update ALTER TABLE docs to mention using VACUUM FULL for rewrite

2011-02-04 Thread Robert Haas
Update ALTER TABLE docs to mention using VACUUM FULL for rewrites. Remove the claim that ALTER TABLE .. SET DATA TYPE is the fastest way of rewriting a table, since it no longer is. Noah Misch and Robert Haas, based on a suggestion from Tom Lane. Branch -- master Details --- http

[COMMITTERS] pgsql: Avoid including postgres.h in frontend compiles of src/port.

2011-02-04 Thread Robert Haas
Avoid including postgres.h in frontend compiles of src/port. This isn't kosher, and doesn't play nicely with my recent changes to the Makefile in this directory. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=8201aea90c2b171808c65836fcce4f29

[COMMITTERS] pgsql: Move pipe.c into the backend.

2011-02-04 Thread Robert Haas
Move pipe.c into the backend. It's full of backend-specific error reporting, so it's neither possible nor necessary for this to be used from frontend code. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=b1e65c32168a2b64276a57be8c4dc5a63d33e1

[COMMITTERS] pgsql: Clarify comment in ATRewriteTable().

2011-02-04 Thread Robert Haas
Clarify comment in ATRewriteTable(). Make sure it's clear that the prohibition on adding a column with a default when the rowtype is used elsewhere is intentional, and be a bit more explicit about the other cases where we perform this check. Branch -- master Details --- http://git.postgr

[COMMITTERS] pgsql: Tighten ALTER FOREIGN TABLE .. SET DATA TYPE checks.

2011-02-05 Thread Robert Haas
Tighten ALTER FOREIGN TABLE .. SET DATA TYPE checks. If the foreign table's rowtype is being used as the type of a column in another table, we can't just up and change its data type. This was already checked for composite types and ordinary tables, but we previously failed to enforce it for forei

Re: [COMMITTERS] pgsql: remove tags.

2011-02-06 Thread Robert Haas
revert, instead?  It's not apparent to me that these > changes were improvements. I'll buy that one. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make cha

[COMMITTERS] pgsql: Avoid having autovacuum workers wait for relation locks.

2011-02-07 Thread Robert Haas
Avoid having autovacuum workers wait for relation locks. Waiting for relation locks can lead to starvation - it pins down an autovacuum worker for as long as the lock is held. But if we're doing an anti-wraparound vacuum, then we still wait; maintenance can no longer be put off. To assist with t

[COMMITTERS] pgsql: Tweak find_composite_type_dependencies API a bit more.

2011-02-11 Thread Robert Haas
Tweak find_composite_type_dependencies API a bit more. Per discussion with Noah Misch, the previous coding, introduced by my commit 65377e0b9c0e0397b1598b38b6a7fb8b6f740d39 on 2011-02-06, was really an abuse of RELKIND_COMPOSITE_TYPE, since the caller in typecmds.c is actually passing the name of

[COMMITTERS] pgsql: Typo fixes. receivedUpto should be capitalized consistently.

2011-02-11 Thread Robert Haas
Typo fixes. receivedUpto should be capitalized consistently. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d309acf201ab2c5bbd1f6a5d51e4a8060eb6a63c Modified Files -- src/backend/replication/README|4 ++-- src/backend/replication/walreceiver.

[COMMITTERS] pgsql: Allow tab-completion of :variable even as first word on a line.

2011-02-11 Thread Robert Haas
Allow tab-completion of :variable even as first word on a line. Christoph Berg Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5917574539732a6e521a6dc260fcd7c9a258d89e Modified Files -- src/bin/psql/tab-complete.c | 22 +++--- 1 files ch

[COMMITTERS] pgsql: Teach ALTER TABLE .. SET DATA TYPE to avoid some table rewrites.

2011-02-12 Thread Robert Haas
ng the way, add some debugging messages that make it possible to understand what operations ALTER TABLE is actually performing in these cases. Noah Misch and Robert Haas Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d31e2a495b6f2127afc31b4da2e5f4e89aa2cdfe

[COMMITTERS] pgsql: Delete stray word from comment.

2011-02-14 Thread Robert Haas
Delete stray word from comment. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8e1124eeeb128ef87045debfeb8f24cd6dbab874 Modified Files -- src/backend/commands/tablecmds.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-com

[COMMITTERS] pgsql: Avoid a few more SET DATA TYPE table rewrites.

2011-02-14 Thread Robert Haas
Avoid a few more SET DATA TYPE table rewrites. When the new type is an unconstrained domain over the old type, we don't need to rewrite the table. Noah Misch and Robert Haas Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0d90dc16f87bd991d7eb9f536ca46acef75

[COMMITTERS] pgsql: Rename max_predicate_locks_per_transaction.

2011-02-15 Thread Robert Haas
Rename max_predicate_locks_per_transaction. The new name, max_pred_locks_per_transaction, is shorter. Kevin Grittner, per discussion. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6a77e9385eb46829ce80971bc655df9f3ef00d9a Modified Files -- doc/src/sgml

[COMMITTERS] pgsql: Assorted corrections to the patch to add WAL receiver replies.

2011-02-15 Thread Robert Haas
Assorted corrections to the patch to add WAL receiver replies. Per reports from Fujii Masao. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/883a9659faf6e49e314b264ca32ed7645068a409 Modified Files -- doc/src/sgml/config.sgml| 46 +++

[COMMITTERS] pgsql: pg_ctl promote

2011-02-15 Thread Robert Haas
pg_ctl promote Fujii Masao, reviewed by Robert Haas, Stephen Frost, and Magnus Hagander. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4695da5ae97bbb58d274887fd68edbe88d03ebcb Modified Files -- doc/src/sgml/high-availability.sgml | 24

[COMMITTERS] pgsql: WAL receiver shouldn't try to send a reply when dying.

2011-02-16 Thread Robert Haas
WAL receiver shouldn't try to send a reply when dying. Per report from, and discussion with, Fujii Masao. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3a087369c0ea858e56c8af5072de91778a644383 Modified Files -- src/backend/replication/walreceiver.c |

[COMMITTERS] pgsql: Remove rule to build sepgsql-regtest.pp.

2011-02-17 Thread Robert Haas
Remove rule to build sepgsql-regtest.pp. Instead, document how to build it manually. Per discussion. KaiGai Kohei, with some wordsmithing by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/24bc6b3db3579f4c480c6d0f81f7e50f1e6c0180 Modified Files --

[COMMITTERS] pgsql: Typo fixes.

2011-02-17 Thread Robert Haas
Typo fixes. Thom Brown Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9408783aefee9d58dd9daf53c8d6b24ab226f05b Modified Files -- doc/src/sgml/sepgsql.sgml |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers maili

Re: [COMMITTERS] pgsql: Remove rule to build sepgsql-regtest.pp.

2011-02-17 Thread Robert Haas
On Thu, Feb 17, 2011 at 6:44 AM, Thom Brown wrote: > Couple typos: > > s/source fire/source file/ > s/If this packages/If this package/ I don't know, I kind of like "source fire". Sounds exciting. Thanks as usual Thom. -- Robert Haas EnterpriseDB: http://www.ente

[COMMITTERS] pgsql: Add some words of caution to elog.c.

2011-02-17 Thread Robert Haas
Add some words of caution to elog.c. Stephen Frost, somewhat rewritten by me Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f196738534baa95badd9d8f1debb5822240ebc6b Modified Files -- src/backend/utils/error/elog.c |6 ++ 1 files changed, 6 insert

[COMMITTERS] pgsql: Add client_hostname field to pg_stat_activity.

2011-02-17 Thread Robert Haas
Add client_hostname field to pg_stat_activity. Peter Eisentraut, reviewed by Steve Singer, Alvaro Herrera, and me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4a25bc145ad5d05da6f01c00bae0f576e9e17115 Modified Files -- doc/src/sgml/monitoring.sgml

[COMMITTERS] pgsql: Prevent possible compiler warnings.

2011-02-17 Thread Robert Haas
Prevent possible compiler warnings. Simon Riggs reports that rnode.dbNode and rnode.spcNode were generating unused variable warnings on gcc 4.4.3 with CFLAGS=-O1 Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a3e8486dffc413506b14eae9dc5d423f6ae8324a Modified Files

Re: [COMMITTERS] pgsql: Separate messages for standby replies and hot standby feedback.

2011-02-18 Thread Robert Haas
lication.html > > Hadn't forgotten, just working thru things in priority order. Updating the documentation is surely not a low-priority item. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers mailing list (p

[COMMITTERS] pgsql: Fix a couple of unlogged tables goofs.

2011-02-22 Thread Robert Haas
Fix a couple of unlogged tables goofs. "SELECT ... INTO UNLOGGED tabname" works, but wasn't documented; CREATE UNLOGGED SEQUENCE and CREATE UNLOGGED VIEW failed an assertion, instead of throwing a sensible error. Latter issue reported by Itagaki Takahiro; patch review by Tom Lane. Branch --

[COMMITTERS] pgsql: Named restore point improvements.

2011-02-24 Thread Robert Haas
Named restore point improvements. Emit a log message when creating a named restore point, and improve documentation for pg_create_restore_point(). Euler Taveira de Oliveira, per suggestions from Thom Brown, with some additional wordsmithing by me. Branch -- master Details --- http:

[COMMITTERS] pgsql: Rename pg_stat_replication.apply_location to replay_location.

2011-02-28 Thread Robert Haas
Rename pg_stat_replication.apply_location to replay_location. For consistency with pg_last_xlog_replay_location. Per discussion. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/92c30fd2edee6da6e018f41a1d67b4ac2f8fcbdd Modified Files -- src/backend/catal

[COMMITTERS] pgsql: Avoid excessive Hot Standby feedback messages.

2011-03-01 Thread Robert Haas
Avoid excessive Hot Standby feedback messages. Without this patch, when wal_receiver_status_interval=0, indicating that no status messages should be sent, Hot Standby feedback messages are instead sent extremely frequently. Fujii Masao, with documentation changes by me. Branch -- master Det

[COMMITTERS] pgsql: Refactor seclabel.c to use the new check_object_ownership functi

2011-03-04 Thread Robert Haas
Refactor seclabel.c to use the new check_object_ownership function. This avoids duplicate (and not-quite-matching) code, and makes the logic for SECURITY LABEL match COMMENT and ALTER EXTENSION ADD/DROP. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/efa415da8c0fb8c

[COMMITTERS] pgsql: Remove emphasis from 9.1alpha3 items.

2011-03-05 Thread Robert Haas
Remove emphasis from 9.1alpha3 items. In preparation for 9.1alpha4 release notes, where only the 9.1alpha4 features will be emphasized. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a4406da967093a9793db0fbceb6e226e318932b6 Modified Files -- doc/src/sgm

[COMMITTERS] pgsql: First cut at 9.1alpha4 release notes.

2011-03-05 Thread Robert Haas
First cut at 9.1alpha4 release notes. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5c44f38d3b63c5a11f58fe558adfe4d3cf4dcc39 Modified Files -- doc/src/sgml/release-9.1.sgml | 545 - 1 files changed, 539 insertions

[COMMITTERS] pgsql: Add missing word.

2011-03-05 Thread Robert Haas
Add missing word. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f31e532492aa950c62c3ded32d07d1e42017e557 Modified Files -- doc/src/sgml/release-9.1.sgml |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) -- Sent via pgsql-committers maili

[COMMITTERS] pgsql: Remove one copy of duplicated alpha4 release note.

2011-03-05 Thread Robert Haas
Remove one copy of duplicated alpha4 release note. Noted by Andy Colson Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c0f2b2e256a3e98c2a066cee8623b7ab156b7f9c Modified Files -- doc/src/sgml/release-9.1.sgml | 12 1 files changed, 0 insert

[COMMITTERS] pgsql: Synchronous replication doc corrections.

2011-03-07 Thread Robert Haas
Synchronous replication doc corrections. Thom Brown Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c74d3aceb99ea6c6d102109349b514e76e497592 Modified Files -- doc/src/sgml/config.sgml|2 +- doc/src/sgml/high-availability.sgml |9 +++---

[COMMITTERS] pgsql: Reword alpha release note item on SSI.

2011-03-07 Thread Robert Haas
Reword alpha release note item on SSI. Per Josh Berkus; some additional explanatory text by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bcf85e3f44a518eb7bb759541189efb6726fe9bc Modified Files -- doc/src/sgml/release-9.1.sgml |9 - 1 fi

[COMMITTERS] pgsql: Create "replication and recovery" section in alpha release notes

2011-03-08 Thread Robert Haas
Create "replication and recovery" section in alpha release notes. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/51c0124481213eab45db193929614070da7b60d1 Modified Files -- doc/src/sgml/release-9.1.sgml | 109 ++--- 1 f

[COMMITTERS] pgsql: Update alpha release notes for latest commits.

2011-03-08 Thread Robert Haas
Update alpha release notes for latest commits. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f14ae5f905282109c9a2571c2048c564004f24c5 Modified Files -- doc/src/sgml/release-9.1.sgml | 49 ++-- 1 files changed, 32 ins

[COMMITTERS] pgsql: Make alpha release notes more consistent as regards periods.

2011-03-08 Thread Robert Haas
Make alpha release notes more consistent as regards periods. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/26ed3fdb4553a0e52c8534292de0f39bfc2c5022 Modified Files -- doc/src/sgml/release-9.1.sgml | 23 +++ 1 files changed, 11 insert

[COMMITTERS] pgsql: Replication README updates.

2011-03-10 Thread Robert Haas
Replication README updates. Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/fcb99609b60012bc2e828b8941d5db46f2625f4a Modified Files -- src/backend/replication/README | 31 ++- 1 files changed, 18 insertions(+), 13

[COMMITTERS] pgsql: Add missing index terms for recovery control functions.

2011-03-10 Thread Robert Haas
Add missing index terms for recovery control functions. Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1c3b434a0897a727127b7c4083f2bfa2c9b690c3 Modified Files -- doc/src/sgml/func.sgml | 10 ++ 1 files changed, 10 insertions(+), 0 d

[COMMITTERS] pgsql: Emit a LOG message when pausing at the recovery target.

2011-03-10 Thread Robert Haas
Emit a LOG message when pausing at the recovery target. Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d16e290a8a52d76d01ef1d70f8c6942a0870 Modified Files -- src/backend/access/transam/xlog.c |3 +++ 1 files changed, 3 insertions(+),

[COMMITTERS] pgsql: Minor sync rep corrections.

2011-03-10 Thread Robert Haas
Minor sync rep corrections. Fujii Masao, with a bit of additional wordsmithing by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/64360987953e450e53098e6b79d89c5b80dc7842 Modified Files -- src/backend/replication/syncrep.c |6 +++--- src/backend/

[COMMITTERS] pgsql: Remove obsolete comment.

2011-03-10 Thread Robert Haas
Remove obsolete comment. In earlier versions of the sync rep patch, waiters removed themselves from the queue, but now walsender removes them before doing the wakeup. Report by Fujii Masao. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e397d2ee6474865becb8f99ac285

[COMMITTERS] pgsql: More synchronous replication tweaks.

2011-03-10 Thread Robert Haas
More synchronous replication tweaks. SyncRepRequested() must check not only the value of the synchronous_replication GUC but also whether max_wal_senders > 0. Otherwise, we might end up waiting for sync rep even when there's no possibility of a standby ever managing to connect. There are some exi

Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.

2011-03-10 Thread Robert Haas
uation in my machine. The attached patch fixes this > problem. I committed a slightly different fix for this problem. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: More synchronous replication typo fixes.

2011-03-10 Thread Robert Haas
More synchronous replication typo fixes. Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2e019c8611654175780db488d81cc2dc8311f22e Modified Files -- src/backend/replication/syncrep.c |2 +- src/include/storage/proc.h|2 +- 2 file

[COMMITTERS] pgsql: Make error handling of synchronous_standby_names consistent.

2011-03-10 Thread Robert Haas
Make error handling of synchronous_standby_names consistent. It's not a good idea to kill the postmaster just because someone muffs this, and it's not consistent with what we do for other, similar GUCs. Fujii Masao, with a bit more hacking by me Branch -- master Details --- http://git.p

[COMMITTERS] pgsql: Remove 13 keywords that are used only for ROLE options.

2011-03-15 Thread Robert Haas
Remove 13 keywords that are used only for ROLE options. Review by Tom Lane. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5ca4dfc79f21828174de3a8bc7d29718d0c52c34 Modified Files -- src/backend/parser/gram.y | 132 +++-

[COMMITTERS] pgsql: Minor sync rep documentation improvements.

2011-03-15 Thread Robert Haas
Minor sync rep documentation improvements. - Make the name of the ID tag for the GUC entry match the GUC name. - Clarify that synchronous_replication waits for xlog flush, not receipt. - Mention that synchronous_replication won't wait if max_wal_senders=0. Branch -- master Details --- ht

[COMMITTERS] pgsql: Corrections to CREATE FOREIGN TABLE documentation.

2011-03-16 Thread Robert Haas
Corrections to CREATE FOREIGN TABLE documentation. Omit incorrect = sign, and properly document server_name parameter. Shigeru Hanada Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5f588e20051eb18333f6ea5b46bd779ba1eb8773 Modified Files -- doc/src/sgml

[COMMITTERS] pgsql: Tab completion for \pset format and \pset linestyle.

2011-03-16 Thread Robert Haas
Tab completion for \pset format and \pset linestyle. Pavel Stehule Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ad3aff45f0d302b35d009e525de8a9d0ee9745a9 Modified Files -- src/bin/psql/tab-complete.c | 18 ++ 1 files changed, 18 insert

[COMMITTERS] pgsql: Fix various possible problems with synchronous replication.

2011-03-17 Thread Robert Haas
Fix various possible problems with synchronous replication. 1. Don't ignore query cancel interrupts. Instead, if the user asks to cancel the query after we've already committed it, but before it's on the standby, just emit a warning and let the COMMIT finish. 2. Don't ignore die interrupts (pg_t

[COMMITTERS] pgsql: Add pause_at_recovery_target to recovery.conf.sample; improve do

2011-03-17 Thread Robert Haas
Add pause_at_recovery_target to recovery.conf.sample; improve docs. Fujii Masao, but with the proposed behavior change reverted, and the rest adjusted accordingly. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/84abea76f60c5fd1c008b8ddf250b4bc89e288fc Modified File

[COMMITTERS] pgsql: Remove bogus comment.

2011-03-17 Thread Robert Haas
Remove bogus comment. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/02b1f84e7d2c8921d3ef291469cfd4b7235358f0 Modified Files -- src/backend/replication/walsender.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) -- Sent via pgsql-committer

[COMMITTERS] pgsql: Protocol documentation for Hot Standby feedback messages.

2011-03-17 Thread Robert Haas
Protocol documentation for Hot Standby feedback messages. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/76dbb4615389e1f44e48074b87be77262143021e Modified Files -- doc/src/sgml/protocol.sgml | 63 +-- 1 files chan

[COMMITTERS] pgsql: Minor fixes for high availability documentation.

2011-03-17 Thread Robert Haas
Minor fixes for high availability documentation. Erik Rijkers and me Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f94c6f9c0f05ff70b232e620eb9c420294e90cd3 Modified Files -- doc/src/sgml/high-availability.sgml | 28 ++-- 1 file

[COMMITTERS] pgsql: Remove bogus semicolons in recoveryPausesHere.

2011-03-18 Thread Robert Haas
Remove bogus semicolons in recoveryPausesHere. Without this, the startup process goes into a tight loop, consuming 100% of one CPU and failing to respond to interrupts. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/777e8c0015743224cc46f3ce39243b05c6d882ef Modified

[COMMITTERS] pgsql: Remove ancient -X options to pg_dump, pg_dumpall, pg_restore.

2011-03-18 Thread Robert Haas
Remove ancient -X options to pg_dump, pg_dumpall, pg_restore. The last version in which these options were documented is now EOL, so it's time to get rid of them for real. We now use GNU-style long options instead. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c5e

[COMMITTERS] pgsql: Make synchronous replication query cancel/die messages more cons

2011-03-18 Thread Robert Haas
Make synchronous replication query cancel/die messages more consistent. Per a gripe from Thom Brown about my previous commit in this area, commit 9a56dc3389b9470031e9ef8e45c95a680982e01a. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7a37900443b016e0e7c72f6b42327bc

Re: [COMMITTERS] pgsql: Document the all-balls IPv6 address.

2011-03-18 Thread Robert Haas
usually write it ::0/0). "all balls" seems like a colloquialism best avoided in our documentation. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make c

Re: [COMMITTERS] pgsql: Remove ancient -X options to pg_dump, pg_dumpall, pg_restore.

2011-03-18 Thread Robert Haas
On Fri, Mar 18, 2011 at 9:05 PM, Tom Lane wrote: > Robert Haas writes: >> Remove ancient -X options to pg_dump, pg_dumpall, pg_restore. >> The last version in which these options were documented is now EOL, so >> it's time to get rid of them for real.  We now use

  1   2   3   4   5   6   7   8   9   10   >