[COMMITTERS] pgsql: Fix pg_dumpall regression test to be locale-independent.

2016-10-13 Thread Tom Lane
Fix pg_dumpall regression test to be locale-independent. The expected results in commit b4fc64578 seem to have been generated in a non-C locale, which just points up the fact that the ORDER BY clause was locale-sensitive. Per buildfarm. Branch -- master Details ---

Re: [COMMITTERS] pgsql: Make pg_dumpall's database ACL query independent of hash table o

2016-10-13 Thread Tom Lane
Andres Freund writes: > On 2016-10-13 01:33:53 +, Andres Freund wrote: >> Make pg_dumpall's database ACL query independent of hash table order. > Hrmpf, longfin doesn't like this much (as in unstable order). It was failing for me and Peter as well. Did you generate the

[COMMITTERS] pgsql: Clean up handling of anonymous mmap'd shared-memory segment.

2016-10-13 Thread Tom Lane
Clean up handling of anonymous mmap'd shared-memory segment. Fix detaching of the mmap'd segment to have its own on_shmem_exit callback, rather than piggybacking on the one for detaching from the SysV segment. That was confusing, and given the distance between the two attach calls, it was trouble

[COMMITTERS] pgsql: Clean up handling of anonymous mmap'd shared-memory segment.

2016-10-13 Thread Tom Lane
Clean up handling of anonymous mmap'd shared-memory segment. Fix detaching of the mmap'd segment to have its own on_shmem_exit callback, rather than piggybacking on the one for detaching from the SysV segment. That was confusing, and given the distance between the two attach calls, it was trouble

[COMMITTERS] pgsql: Clean up handling of anonymous mmap'd shared-memory segment.

2016-10-13 Thread Tom Lane
Clean up handling of anonymous mmap'd shared-memory segment. Fix detaching of the mmap'd segment to have its own on_shmem_exit callback, rather than piggybacking on the one for detaching from the SysV segment. That was confusing, and given the distance between the two attach calls, it was trouble

[COMMITTERS] pgsql: Clean up handling of anonymous mmap'd shared-memory segment.

2016-10-13 Thread Tom Lane
Clean up handling of anonymous mmap'd shared-memory segment. Fix detaching of the mmap'd segment to have its own on_shmem_exit callback, rather than piggybacking on the one for detaching from the SysV segment. That was confusing, and given the distance between the two attach calls, it was trouble

[COMMITTERS] pgsql: Try to find out the actual hugepage size when making a MAP_HUGET

2016-10-13 Thread Tom Lane
Try to find out the actual hugepage size when making a MAP_HUGETLB request. Even if Linux's mmap() is okay with a partial-hugepage request, munmap() is not, as reported by Chris Richards. Therefore it behooves us to try a bit harder to find out the actual hugepage size, instead of assuming that

[COMMITTERS] pgsql: Try to find out the actual hugepage size when making a MAP_HUGET

2016-10-13 Thread Tom Lane
Try to find out the actual hugepage size when making a MAP_HUGETLB request. Even if Linux's mmap() is okay with a partial-hugepage request, munmap() is not, as reported by Chris Richards. Therefore it behooves us to try a bit harder to find out the actual hugepage size, instead of assuming that

[COMMITTERS] pgsql: Remove dead code in pg_dump.

2016-10-13 Thread Tom Lane
Remove dead code in pg_dump. I'm not sure if this provision for "pg_backup" behaving a bit differently from "pg_dump" ever did anything useful in a released version. But it's definitely dead code now. Michael Paquier Branch -- master Details ---

[COMMITTERS] pgsql: Fix typo.

2016-10-13 Thread Tatsuo Ishii
Fix typo. Confirmed by Tom Lane. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b1ee762a6138df073d4b2b80c235dd9025a8532c Modified Files -- doc/src/sgml/parallel.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers

[COMMITTERS] pgsql: Fix typo.

2016-10-13 Thread Tatsuo Ishii
Fix typo. Confirmed by Tom Lane. Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b8850031ccc51401c256203b7dc9029a1160479e Modified Files -- doc/src/sgml/parallel.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

Re: [COMMITTERS] pgsql: Make pg_dumpall's database ACL query independent of hash table o

2016-10-13 Thread Andres Freund
On 2016-10-13 09:41:38 -0700, Andres Freund wrote: > On 2016-10-13 10:49:14 -0400, Tom Lane wrote: > > Andres Freund writes: > > > On 2016-10-13 01:33:53 +, Andres Freund wrote: > > >> Make pg_dumpall's database ACL query independent of hash table order. > > > > > Hrmpf,

[COMMITTERS] pgsql: Fix another bug in merging of inherited CHECK constraints.

2016-10-13 Thread Tom Lane
Fix another bug in merging of inherited CHECK constraints. It's not good for an inherited child constraint to be marked connoinherit; that would result in the constraint not propagating to grandchild tables, if any are created later. The code mostly prevented this from happening but there was

[COMMITTERS] pgsql: Fix another bug in merging of inherited CHECK constraints.

2016-10-13 Thread Tom Lane
Fix another bug in merging of inherited CHECK constraints. It's not good for an inherited child constraint to be marked connoinherit; that would result in the constraint not propagating to grandchild tables, if any are created later. The code mostly prevented this from happening but there was

[COMMITTERS] pgsql: Fix another bug in merging of inherited CHECK constraints.

2016-10-13 Thread Tom Lane
Fix another bug in merging of inherited CHECK constraints. It's not good for an inherited child constraint to be marked connoinherit; that would result in the constraint not propagating to grandchild tables, if any are created later. The code mostly prevented this from happening but there was

[COMMITTERS] pgsql: Fix another bug in merging of inherited CHECK constraints.

2016-10-13 Thread Tom Lane
Fix another bug in merging of inherited CHECK constraints. It's not good for an inherited child constraint to be marked connoinherit; that would result in the constraint not propagating to grandchild tables, if any are created later. The code mostly prevented this from happening but there was

[COMMITTERS] pgsql: Fix another bug in merging of inherited CHECK constraints.

2016-10-13 Thread Tom Lane
Fix another bug in merging of inherited CHECK constraints. It's not good for an inherited child constraint to be marked connoinherit; that would result in the constraint not propagating to grandchild tables, if any are created later. The code mostly prevented this from happening but there was

[COMMITTERS] pgsql: Fix another bug in merging of inherited CHECK constraints.

2016-10-13 Thread Tom Lane
Fix another bug in merging of inherited CHECK constraints. It's not good for an inherited child constraint to be marked connoinherit; that would result in the constraint not propagating to grandchild tables, if any are created later. The code mostly prevented this from happening but there was

[COMMITTERS] pgsql: Fix handling of pgstat counters for TRUNCATE in a prepared trans

2016-10-13 Thread Tom Lane
Fix handling of pgstat counters for TRUNCATE in a prepared transaction. pgstat_twophase_postcommit is supposed to duplicate the math in AtEOXact_PgStat, but it had missed out the bit about clearing t_delta_live_tuples/t_delta_dead_tuples for a TRUNCATE. It's harder than you might think to

[COMMITTERS] pgsql: Fix handling of pgstat counters for TRUNCATE in a prepared trans

2016-10-13 Thread Tom Lane
Fix handling of pgstat counters for TRUNCATE in a prepared transaction. pgstat_twophase_postcommit is supposed to duplicate the math in AtEOXact_PgStat, but it had missed out the bit about clearing t_delta_live_tuples/t_delta_dead_tuples for a TRUNCATE. It's harder than you might think to

[COMMITTERS] pgsql: Fix handling of pgstat counters for TRUNCATE in a prepared trans

2016-10-13 Thread Tom Lane
Fix handling of pgstat counters for TRUNCATE in a prepared transaction. pgstat_twophase_postcommit is supposed to duplicate the math in AtEOXact_PgStat, but it had missed out the bit about clearing t_delta_live_tuples/t_delta_dead_tuples for a TRUNCATE. It's harder than you might think to

[COMMITTERS] pgsql: Fix typo.

2016-10-13 Thread Tatsuo Ishii
Fix typo. Confirmed by Michael Paquier. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/13d3180fd14c624bbb274e200e98ddb50e260216 Modified Files -- doc/src/sgml/parallel.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

[COMMITTERS] pgsql: Fix typo.

2016-10-13 Thread Tatsuo Ishii
Fix typo. Confirmed by Michael Paquier. Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/a209d6dc8cce69bf4d305486816845be3febacba Modified Files -- doc/src/sgml/parallel.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

Re: [COMMITTERS] pgsql: Make pg_dumpall's database ACL query independent of hash table o

2016-10-13 Thread Peter Eisentraut
On 10/12/16 10:05 PM, Andres Freund wrote: > On 2016-10-13 01:33:53 +, Andres Freund wrote: >> Make pg_dumpall's database ACL query independent of hash table order. >> >> Previously GRANT order on databases was not well defined, due to the use >> of EXCEPT without an ORDER BY. Add an ORDER