Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events

2017-08-08 Thread Thomas Munro
On Wed, Aug 9, 2017 at 7:39 AM, Alvaro Herrera wrote: > Fix inadequacies in recently added wait events > > In commit 9915de6c1cb2, we introduced a new wait point for replication > slots and incorrectly labelled it as wait event PG_WAIT_LOCK. That's > wrong, so invent an

[COMMITTERS] pgsql: Tag refs/tags/REL9_6_4 was created

2017-08-08 Thread pgsql
Tag refs/tags/REL9_6_4 was created. -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Tag refs/tags/REL9_3_18 was created

2017-08-08 Thread pgsql
Tag refs/tags/REL9_3_18 was created. -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Tag refs/tags/REL9_4_13 was created

2017-08-08 Thread pgsql
Tag refs/tags/REL9_4_13 was created. -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Tag refs/tags/REL9_2_22 was created

2017-08-08 Thread pgsql
Tag refs/tags/REL9_2_22 was created. -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Tag refs/tags/REL_10_BETA3 was created

2017-08-08 Thread pgsql
Tag refs/tags/REL_10_BETA3 was created. -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Tag refs/tags/REL9_5_8 was created

2017-08-08 Thread pgsql
Tag refs/tags/REL9_5_8 was created. -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix typo in comment

2017-08-08 Thread Alvaro Herrera
Fix typo in comment Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f5d54ef97abdd1df3d6bfe0320a565ecce742abe Modified Files -- src/backend/utils/sort/tuplesort.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers

[COMMITTERS] pgsql: Fix datumSerialize infrastructure to not crash on non-varlena da

2017-08-08 Thread Tom Lane
Fix datumSerialize infrastructure to not crash on non-varlena data. Commit 1efc7e538 did a poor job of emulating existing logic for touching Datums that might be expanded-object pointers. It didn't check for typlen being -1 first, which meant it could crash on fixed-length pass-by-ref values,

[COMMITTERS] pgsql: Reword some unclear comments

2017-08-08 Thread Alvaro Herrera
Reword some unclear comments Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/77d2c00af78ee12ae0d1cea34605f1e7af3f6d93 Modified Files -- src/backend/access/heap/heapam.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- Sent via

[COMMITTERS] pgsql: doc: Add missing pieces to logical replication protocol doc

2017-08-08 Thread Peter Eisentraut
doc: Add missing pieces to logical replication protocol doc Reported-by: Kyle Conroy Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/13f03a001e4d841b6a27c0c9c3fe14e1fb2aad80 Modified Files -- doc/src/sgml/protocol.sgml | 22

[COMMITTERS] pgsql: Fix yet another race condition in recovery/t/001_stream_rep.pl.

2017-08-08 Thread Tom Lane
Fix yet another race condition in recovery/t/001_stream_rep.pl. In commit 5c77690f6, we added polling in front of most of the get_slot_xmins calls in 001_stream_rep.pl, but today's results from buildfarm member nightjar show that at least one more poll loop is needed. Proactively add a poll loop

[COMMITTERS] pgsql: Reword some unclear comments

2017-08-08 Thread Alvaro Herrera
Reword some unclear comments Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/962b26b674d29fa2834afbd760a9229bc42a5876 Modified Files -- src/backend/access/heap/heapam.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- Sent via

[COMMITTERS] pgsql: Reword some unclear comments

2017-08-08 Thread Alvaro Herrera
Reword some unclear comments Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9cc510fe89a3f013091bf7234ca893ba74a15094 Modified Files -- src/backend/access/heap/heapam.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- Sent via

[COMMITTERS] pgsql: Reword some unclear comments

2017-08-08 Thread Alvaro Herrera
Reword some unclear comments Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1924ef41668773ad62d845eebc11ff35f17446ad Modified Files -- src/backend/access/heap/heapam.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- Sent via

[COMMITTERS] pgsql: Reword some unclear comments

2017-08-08 Thread Alvaro Herrera
Reword some unclear comments Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e829db0b19bda06996a1c7104ca1251c8eacaa2c Modified Files -- src/backend/access/heap/heapam.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- Sent via

[COMMITTERS] pgsql: Fix datumSerialize infrastructure to not crash on non-varlena da

2017-08-08 Thread Tom Lane
Fix datumSerialize infrastructure to not crash on non-varlena data. Commit 1efc7e538 did a poor job of emulating existing logic for touching Datums that might be expanded-object pointers. It didn't check for typlen being -1 first, which meant it could crash on fixed-length pass-by-ref values,

[COMMITTERS] pgsql: Fix replication origin-related race conditions

2017-08-08 Thread Alvaro Herrera
Fix replication origin-related race conditions Similar to what was fixed in commit 9915de6c1cb2 for replication slots, but this time it's related to replication origins: DROP SUBSCRIPTION attempts to drop the replication origin, but that fails if the replication worker process hasn't yet marked

[COMMITTERS] pgsql: Fix inadequacies in recently added wait events

2017-08-08 Thread Alvaro Herrera
Fix inadequacies in recently added wait events In commit 9915de6c1cb2, we introduced a new wait point for replication slots and incorrectly labelled it as wait event PG_WAIT_LOCK. That's wrong, so invent an appropriate new wait event instead, and document it properly. While at it, fix numerous