Re: Create Procedure

2020-06-29 Thread Bruce Momjian
improved: > > - Provide more examples; > - Describe the use of IN and INOUT variables; > - Describe the use of cursors. You might find those in CREATE FUNCTION, which is similar. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterpr

Re: reindex database

2020-06-29 Thread Bruce Momjian
synching with the > standby cluster and impact on the standby cluster). > Thank you, > Andrei Bancila For full-cluster, non-logical replication, the data files on the primary and replicas have to be identical, so any reindex on the primary generates replayed WAL records to the

Re: INDEX with optional storage parameter value

2020-06-29 Thread Bruce Momjian
On Mon, Jun 29, 2020 at 04:18:58PM +0900, Michael Paquier wrote: > On Sat, Jun 27, 2020 at 05:14:23PM -0400, Bruce Momjian wrote: > > I found a few more places that also didn't properly document this; > > patch attached. > > Good catch! I am not seeing any missing spot

Re: INDEX with optional storage parameter value

2020-06-27 Thread Bruce Momjian
fastupdate='true') "testtable_c1_idx1" gin (c1) WITH (fastupdate='false') "testtable_c1_idx2" gin (c1) WITH (fastupdate='true') I found a few more places that also didn't properly document this; patch attached. -- Bruce Momjian https://momjian.us Enterpris

Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-25 Thread Bruce Momjian
On Tue, Jun 16, 2020 at 02:02:20PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > OK, I didn't think there was enough desire to put it its own paragraph, > > but I like the idea of mentioning all of the trigger functions; patch > > attached. > > This one WFM. Pat

Re: Please add a link to [BRIN] physical block ranges of a table

2020-06-25 Thread Bruce Momjian
and where the links can appear. For example now that > we have the term "transactions per second" we could add it to acronyms. Yes, this is a great direction to go in! -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com The use

Re: listing roles

2020-06-25 Thread Bruce Momjian
nd features, but that would make the text awkward. psql \du does show you want you wanted. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its emptiness, Bruce Lee

Re: Please add a link to [BRIN] physical block ranges of a table

2020-06-25 Thread Bruce Momjian
On Thu, Jun 25, 2020 at 10:17:56AM -0400, Dave Cramer wrote: > > > On Thu, 25 Jun 2020 at 10:10, Bruce Momjian wrote: > > On Wed, Jun 24, 2020 at 05:13:05PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website:

Re: Please add a link to [BRIN] physical block ranges of a table

2020-06-25 Thread Bruce Momjian
ted in Table 67.1. For more information see Chapter 67. Did you want a link earlier in the section? -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com The us

Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-16 Thread Bruce Momjian
On Tue, Jun 16, 2020 at 01:39:45PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I have developed the attached patch which is in a better direction. > > I still wish you wouldn't jam this topic into an only-marginally-related > sentence. In the case at hand, the point

Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-16 Thread Bruce Momjian
On Tue, Jun 16, 2020 at 10:08:14AM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I have created the attached patch to mention > > suppress_redundant_updates_trigger() in this case. I don't think having > > an actual example is warranted. > > I don't like

Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-16 Thread Bruce Momjian
s_redundant_updates_trigger(); > > > Just to introduce and like the feature. > > Thank you for your great work best regards I have created the attached patch to mention suppress_redundant_updates_trigger() in this case. I don't think having an actual example is warranted. -- B

Re: Documentation 9.8. Data Type Formatting Functions: missing behaviour on invalid input at to_date()

2020-06-13 Thread Bruce Momjian
On Fri, Jun 12, 2020 at 02:47:29PM -0700, David G. Johnston wrote: > On Fri, Jun 12, 2020 at 2:28 PM Bruce Momjian wrote: > > On Fri, Jun  5, 2020 at 11:16:59AM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: >

Re: create database with template doesn't copy ACL

2020-06-12 Thread Bruce Momjian
is the (currently) expected > behavior when issuing CREATE DATABASE newdb WITH TEMPLATE my_tmpl; > It would be useful for the documentation to note this caveat. Uh, what ACLs are not copied? -- Bruce Momjian https://momjian.us EnterpriseDB

Re: Documentation 9.8. Data Type Formatting Functions: missing behaviour on invalid input at to_date()

2020-06-12 Thread Bruce Momjian
", it is invalid, so an error seems appropriate. I don't remember anyone complaining the expected a NULL return. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its emptiness, Bruce Lee

Re: Adding xreflable

2020-06-11 Thread Bruce Momjian
On Thu, Jun 4, 2020 at 07:11:41PM +0200, Peter Eisentraut wrote: > On 2020-06-04 00:38, Alvaro Herrera wrote: > > On 2020-Jun-02, Bruce Momjian wrote: > > > > > I can adjust things, but what logic are we following? Before my patch, > > > sepgsql had an xreflabe

Re: Adding xreflable

2020-06-11 Thread Bruce Momjian
On Thu, Jun 4, 2020 at 07:14:17PM +0200, Peter Eisentraut wrote: > On 2020-06-02 18:07, Bruce Momjian wrote: > > I can adjust things, but what logic are we following? Before my patch, > > sepgsql had an xreflabel, and vacuumlo did not. I would like to have a > > document

Re: max_wal_size

2020-06-02 Thread Bruce Momjian
> As I understand now, this is true when we talk about the checkpoint as a > process. > "Maximum size to let the WAL grow to between a(b) and b(e), between b(b) and c > (e), etc". What if we say: "Maximum size to let the WAL grow during automatic WAL checkpoint

Re: Adding xreflable

2020-06-02 Thread Bruce Momjian
On Tue, May 26, 2020 at 01:41:41PM +0200, Peter Eisentraut wrote: > On 2020-05-22 18:45, Bruce Momjian wrote: > > Ugh, I see what you mean. I have read doc/src/sgml/README.links many > > times and still get confused. What you are saying is that if there is > > no xreflabel

Re: Adding xreflable

2020-05-22 Thread Bruce Momjian
On Fri, May 22, 2020 at 12:09:18PM +0200, Peter Eisentraut wrote: > On 2020-05-15 18:47, Bruce Momjian wrote: > > Done. Thanks for the tips. > > This doesn't seem right. By adding xreflabels you are changing the > appearance for all links pointing to the target, not onl

Re: Wrong link for FETCH FIRST in pg13 release notes

2020-05-21 Thread Bruce Momjian
gt; The link, by mistake, goes to: > https://www.postgresql.org/docs/13/sql-fetch.html > > Should link to: > https://www.postgresql.org/docs/13/sql-select.html#SQL-LIMIT Oops, good point, fixed. -- Bruce Momjian https://momjian.us EnterpriseDB

Re: explanation for random_page_cost is outdated

2020-05-21 Thread Bruce Momjian
On Mon, Apr 27, 2020 at 12:16:30PM -0400, Bruce Momjian wrote: > On Mon, Apr 27, 2020 at 06:02:41AM +0200, Pavel Stehule wrote: > >  >  Storage that has a low random read cost relative to sequential, e.g. > > solid-state drives, might also be better modeled with a value

Re: 11.7 Indexes on Expressions: editorial correction

2020-05-21 Thread Bruce Momjian
ff to just revert > a9760d0f3 altogether. Bruce's last proposal mostly did that, > but it still insisted on muddying an existing example with an > unrelated comment. Muddy patch applied. ;-) I am open to clarifying it but I think we need something in our docs about this idea.

Re: pgsql: doc: add examples of creative use of unique expression indexes

2020-05-21 Thread Bruce Momjian
On Mon, Apr 20, 2020 at 08:31:29PM -0400, Bruce Momjian wrote: > On Mon, Apr 20, 2020 at 04:21:32PM -0400, Tom Lane wrote: > > [ sorry, I'd lost track of this thread ] > > > > Bruce Momjian writes: > > > I now remember that I wrote the first IS NULL i

Re: Adding xreflable

2020-05-15 Thread Bruce Momjian
On Fri, May 15, 2020 at 11:30:34AM -0400, Bruce Momjian wrote: > On Fri, May 15, 2020 at 11:06:58AM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > Well, I would like both the SQL command references and the application > > > man pages to have xreflabel text

Re: Adding xreflable

2020-05-15 Thread Bruce Momjian
On Fri, May 15, 2020 at 11:06:58AM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Well, I would like both the SQL command references and the application > > man pages to have xreflabel text. > > I guess my point is that in the other several thousand pages of th

Re: Relnotes for 13: There is word missing in UUID generation sentence

2020-05-15 Thread Bruce Momjian
were only available if external modules > uuid-ossp or pgcrypto were installed. Oh, yes, fixed. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Adding xreflable

2020-05-15 Thread Bruce Momjian
he comment headings at the top of our ref/*.sgml files are inconsistent and will fix those too. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient R

Re: The suggestion of reducing autovacuum_vacuum_cost_delay should be documented

2020-05-12 Thread Bruce Momjian
On Tue, May 12, 2020 at 07:26:07PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Tue, May 12, 2020 at 03:38:16PM -0700, David G. Johnston wrote: > >> The proposal is to document in versions 9.4 to 11 that the recommended > >> value > >> for

Re: The suggestion of reducing autovacuum_vacuum_cost_delay should be documented

2020-05-12 Thread Bruce Momjian
On Tue, May 12, 2020 at 03:38:16PM -0700, David G. Johnston wrote: > On Tue, May 12, 2020 at 2:41 PM Bruce Momjian wrote: > > On Tue, May 12, 2020 at 05:40:14PM -0400, Bruce Momjian wrote: > > On Tue, May 12, 2020 at 10:26:27AM +, PG Doc comments form wrote: >

Re: The suggestion of reducing autovacuum_vacuum_cost_delay should be documented

2020-05-12 Thread Bruce Momjian
to 2ms in > PostgreSQL 12. Reducing the autovacuum_vacuum_cost_delay will make the > autovacuum more aggressive and might reduce the vacuum cost for > write-intensive workload on big table. Uh, we usually don't suggest new defaults in back branches. -- Bruce Momji

Re: Direct links to edit documentation

2020-05-05 Thread Bruce Momjian
hem in". All I can say is that most emails we get about the docs using the form are just complaints, and we have to write some suggested text and get approaval from the reporter that the text is clear. We don't get many acutal _suggestions_. -- Bruce Momjian https://momjian.

Re: adding a TOC to the psql reference page

2020-04-30 Thread Bruce Momjian
id attribute Yes, I can see the value in that, but I don't think we do that for any other SQL comments. Would doing it just for psql make sense? -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As y

Re: Direct links to edit documentation

2020-04-29 Thread Bruce Momjian
directly. Wow, that sounds like a nice idea, but I have no idea how to do that. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: explanation for random_page_cost is outdated

2020-04-27 Thread Bruce Momjian
1 > is good too, especially for an ideal server with huge memory cache. Uh, well, 1.0 is fine for non-SSDs too if all the data is in cache, and there are no database writes. --- > > > > 27 апр. 2020 г., в 19:16, Bru

Re: explanation for random_page_cost is outdated

2020-04-27 Thread Bruce Momjian
for SSDs for years, and I think it would be helpful to suggest that value, so doc patch attached. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancien

Re: terminology in example

2020-04-22 Thread Bruce Momjian
Patch applied back to 9.5, thanks. --- On Wed, Apr 1, 2020 at 08:27:59PM -0400, Bruce Momjian wrote: > On Wed, Apr 1, 2020 at 08:37:30AM +0200, Laurenz Albe wrote: > > On Tue, 2020-03-31 at 19:10 -0400, Bruc

Re: An XSLT example script

2020-04-21 Thread Bruce Momjian
; in the wrong list. We should change the tagging. > > Why is it wrong to make this a figure? I thought figure was just images. Was figure really right, or something else? This is the only script we use? programlisting maybe? -- Bruce Momjian https://momjian.us Enterprise

Re: Backend Flowchart / Developer doc

2020-04-21 Thread Bruce Momjian
ns a > > Query.qual field which does not exist in the Query structure. > > I think that diagram (and the accompanying wiki page) requires a *lot* > of more significant updating than just that field. It is wildly > outdated. I developed the attached patch to fix the items I sa

Re: An XSLT example script

2020-04-20 Thread Bruce Momjian
0ab..2f1cf46c2a 100644 > --- a/doc/src/sgml/func.sgml > +++ b/doc/src/sgml/func.sgml > @@ -11499,7 +11499,7 @@ table2-mapping > converted into other XML-based formats. > > > - > + > XSLT Stylesheet for Converting SQL/XML Output to HTML > >

Re: pgsql: doc: add examples of creative use of unique expression indexes

2020-04-20 Thread Bruce Momjian
On Mon, Apr 20, 2020 at 04:21:32PM -0400, Tom Lane wrote: > [ sorry, I'd lost track of this thread ] > > Bruce Momjian writes: > > I now remember that I wrote the first IS NULL in: > > CREATE UNIQUE INDEX tests_target_one_null ON tests ((target IS NULL)) > > WHERE

Re: pgsql: doc: add examples of creative use of unique expression indexes

2020-04-11 Thread Bruce Momjian
On Fri, Apr 10, 2020 at 08:17:09PM -0400, Bruce Momjian wrote: > On Fri, Apr 10, 2020 at 07:21:29PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > I agree with your analysis. I still want to have some mention that > > > partial indexes can be used to create

Re: Documentation: 21.5. Default Roles

2020-04-09 Thread Bruce Momjian
On Thu, Apr 9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote: > On 4/9/20 4:57 PM, Bruce Momjian wrote: > > Jonathan, Stephen, with the minor release done, can we focus on adding > > the URL redirect and completing the patch to rename this feature in the > > docs? Tha

Re: Documentation: 21.5. Default Roles

2020-04-09 Thread Bruce Momjian
On Thu, Feb 6, 2020 at 10:59:09AM -0500, Jonathan Katz wrote: > On 2/6/20 12:11 AM, Bruce Momjian wrote: > > On Tue, Feb 4, 2020 at 11:31:19AM -0500, Jonathan Katz wrote: > >>> Using this feature to handle the rename of a file *between* major > >>> versions, t

Re: terminology in example

2020-04-01 Thread Bruce Momjian
On Wed, Apr 1, 2020 at 08:37:30AM +0200, Laurenz Albe wrote: > On Tue, 2020-03-31 at 19:10 -0400, Bruce Momjian wrote: > > > The attached patch fixes the problem. The regression tests also have > > many mentions of "altitude." Should those be changed too? > &g

Re: terminology in example

2020-03-31 Thread Bruce Momjian
On Tue, Mar 24, 2020 at 01:41:41PM -0400, Bruce Momjian wrote: > On Tue, Mar 24, 2020 at 03:57:25PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/12/ddl-inherit

Re: Incomplete or misleading explanation of the data types for mathematical operators

2020-03-31 Thread Bruce Momjian
Patch applied through 9.5, thanks. --- On Sat, Mar 21, 2020 at 10:31:32AM -0400, Bruce Momjian wrote: > On Thu, Mar 5, 2020 at 08:03:19PM -0700, Sergei Agalakov wrote: > > On 3/5/2020 7:29 PM, Bruce Momj

Re: Users/Roles do not align.

2020-03-31 Thread Bruce Momjian
Patch applied through 9.5, thanks. --- On Mon, Mar 9, 2020 at 10:50:26PM -0400, Bruce Momjian wrote: > On Thu, Feb 6, 2020 at 11:06:44AM +0100, Jürgen Purtz wrote: > > > > > There's a few things wro

Re: Move description of general lock behaviour out of the "13.3.1. Table-level Locks section"

2020-03-31 Thread Bruce Momjian
Patch applied through 9.5. --- On Thu, Mar 12, 2020 at 04:34:20PM -0400, Bruce Momjian wrote: > On Mon, Feb 3, 2020 at 05:04:00PM +, PG Doc comments form wrote: > > The following documentation comment has be

Re: pg_buffercache query example results misleading, grouping by just relname, needs schema_name

2020-03-31 Thread Bruce Momjian
Patch applied through PG 9.5. Thanks. --- On Tue, Mar 17, 2020 at 05:21:36PM -0400, Bruce Momjian wrote: > On Wed, Feb 12, 2020 at 11:55:51PM +, PG Doc comments form wrote: > > The following documentation co

Re: Wrong insert before trigger examples

2020-03-31 Thread Bruce Momjian
Patch applied back through PG 10. --- On Fri, Mar 13, 2020 at 06:56:37PM -0400, Bruce Momjian wrote: > On Wed, Feb 5, 2020 at 09:36:49AM +, PG Doc comments form wrote: > > The following documentation comment

Re: optionally schema-qualified for table_name

2020-03-25 Thread Bruce Momjian
On Wed, Mar 25, 2020 at 01:46:54PM +0100, Peter Eisentraut wrote: > On 2020-03-24 21:58, Bruce Momjian wrote: > > That is a good point. I used CREATE VIEW as an example because that is > > what the user reported, but it seems only create_view and reindexed use > > a sche

Re: optionally schema-qualified for table_name

2020-03-24 Thread Bruce Momjian
On Tue, Mar 24, 2020 at 09:35:25PM +0100, Peter Eisentraut wrote: > On 2020-03-23 02:27, Bruce Momjian wrote: > > On Sun, Mar 22, 2020 at 06:20:04PM -0400, Tom Lane wrote: > > > Bruce Momjian writes: > > > > On Sun, Mar 22, 2020 at 03:05:01PM -0400, Tom Lane wrote:

Re: terminology in example

2020-03-24 Thread Bruce Momjian
.org/docs/current/ddl-inherit.html > the word 'altitude' should be replaced with 'elevation'. Yes, I see your point: https://mapscaping.com/blogs/geo-candy/what-is-the-difference-between-elevation-relief-and-altitude -- Bruce Momjian https://m

Re: Examples required in || 5.10. Table Partitioning

2020-03-24 Thread Bruce Momjian
Tanay  > > > On Sun, Mar 15, 2020, 1:12 AM Bruce Momjian wrote: > > On Thu, Feb  6, 2020 at 12:23:46PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.p

Re: optionally schema-qualified for table_name

2020-03-22 Thread Bruce Momjian
On Sun, Mar 22, 2020 at 06:20:04PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Sun, Mar 22, 2020 at 03:05:01PM -0400, Tom Lane wrote: > >> I don't really think this is an improvement, mainly because that > >> error message is inventing a notation that we d

Re: optionally schema-qualified for table_name

2020-03-22 Thread Bruce Momjian
On Sun, Mar 22, 2020 at 03:05:01PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I see what you mean. The attached patch fixes this, as well as > > adjusting the error message. I didn't see any other cases. > > I don't really think this is an improvement, mainly

Re: optionally schema-qualified for table_name

2020-03-21 Thread Bruce Momjian
.ss OWNED BY test.x; SET search_path = public, zz; ALTER SEQUENCE zz.ss OWNED BY test.x; SET search_path = public; ALTER SEQUENCE zz.ss OWNED BY test.x; --> ERROR: relation "test" does not exist ALTER SEQUENCE zz.ss OW

Re: Incomplete or misleading explanation of the data types for mathematical operators

2020-03-21 Thread Bruce Momjian
On Thu, Mar 5, 2020 at 08:03:19PM -0700, Sergei Agalakov wrote: > On 3/5/2020 7:29 PM, Bruce Momjian wrote: > > On Wed, Jan 29, 2020 at 07:35:18PM +, PG Doc comments form wrote: > > > Multiplication preserves data type, exponentiation silently converts > >

Re: Possible typos in the #12.1.1 examples

2020-03-20 Thread Bruce Momjian
= d.id AND m.id = 12; > > This one is actually valid as well, as long as both relations don't > use the same column names, but I can see your point to add the aliases > to the quals of the WHERE clause to bring more clarity. Agreed, alias added in all supported branches. --

Re: explanation for random_page_cost is outdated

2020-03-19 Thread Bruce Momjian
unclear or not have enough visibility: https://www.postgresql.org/docs/12/runtime-config-query.html#RUNTIME-CONFIG-QUERY-CONSTANTS Storage that has a low random read cost relative to sequential, e.g. solid-state drives, might also be better modeled with a lower va

Re: "Cannot" vs "could not"

2020-03-19 Thread Bruce Momjian
On Thu, Mar 19, 2020 at 12:07:35PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > We use "cannot" and "could not" quite often in source code and error > > messages: > > Yup. > > > Is there any sense that we should have more consistency

"Cannot" vs "could not"

2020-03-19 Thread Bruce Momjian
ins the difference well, i.e., "cannot" is present tens, "could not" is past tense: https://www.englishforums.com/English/CannotVsCouldNot/bhprvk/post.htm Is there any sense that we should have more consistency in our message wording? -- Bruce Momjian https://momji

Re: Better documentation for row_number() combined with set returning functions

2020-03-18 Thread Bruce Momjian
3 | 4 | 1 1 | 5 | 2 2 | 5 | 2 3 | 5 | 2 1 | 6 | 3 2 | 6 | 3 3 | 6 | 3 -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As

Re: REGEXP_REPLACE : How to use a column value in the regex

2020-03-17 Thread Bruce Momjian
test pg_sYYtistic I didn't think it was worth documenting this. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: Clarification on interactions between query parameters and partial indexes

2020-03-17 Thread Bruce Momjian
ulated. Then a generic plan is created and its estimated cost is compared to the average custom-plan cost. Subsequent executions use the generic plan if its cost is not so much higher than the average custom-plan cost as to make repeated replanning seem preferable. --

Re: pg_buffercache query example results misleading, grouping by just relname, needs schema_name

2020-03-17 Thread Bruce Momjian
IT 10; > > Example Results: > Current Query returns 1 row with buffer count summed for 3 tables: > relname buffers > tab1 72401 > > Modified Query: > schema_name relname buffers > schema1 tab11883 > schema2 tab169961 > schema

Re: COPY performance vs insert

2020-03-17 Thread Bruce Momjian
O ... SELECT FROM or INSERT INTO ... VALUES. You can run tests to prove it. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: 9.4. String Functions and Operators page does not document that encode adds line breaks

2020-03-16 Thread Bruce Momjian
ve the newlines from the output. I think you should just use the existing Postgres SQL string functions to remove the newlines. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: create extension requires superuser?

2020-03-14 Thread Bruce Momjian
y to check which functions require super-user rights. It is buried in the C code. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: Examples required in || 5.10. Table Partitioning

2020-03-14 Thread Bruce Momjian
int ) PARTITION BY LIST (left(lower(name), 1)); CREATE TABLE cities_ab PARTITION OF cities ( CONSTRAINT city_id_nonzero CHECK (city_id != 0) ) FOR VALUES IN ('a', 'b'); Is that sufficient? -- Bruce Momjian https://momjian.us EnterpriseDB

Re: Wrong insert before trigger examples

2020-03-13 Thread Bruce Momjian
the attached patch to clarify which definition to use. I am not sure if more extensive changes are needed. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + +

Re: btree index maximum row size

2020-03-12 Thread Bruce Momjian
ee because the hashes are much shorter. Expression indexes can also help. What is your use-case for indexing very long values? -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once wa

Re: Move description of general lock behaviour out of the "13.3.1. Table-level Locks section"

2020-03-12 Thread Bruce Momjian
o was to mention that row-level locks are released in a similar way to table-level locks. Patch attached. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + +

Re: Users/Roles do not align.

2020-03-09 Thread Bruce Momjian
- pg_authid pg_subscription pg_database pg_db_role_setting pg_tablespace pg_auth_members pg_shdepend pg_shdescription pg_replication_origin pg_shseclabel -- Bruce Momjian https://momjian.us Enterpris

Re: Incomplete or misleading explanation of the data types for mathematical operators

2020-03-05 Thread Bruce Momjian
s > both int and numeric types to double. > The best would be to explain this behaivior of operators like it was done > for mathematical functions. Uh, how does this relate to bitwise operators? Why would we mention type changes for things like exponentiation in the bitwise operator docu

Re: Documentation: 21.5. Default Roles

2020-02-06 Thread Bruce Momjian
redirect stuff working so that we can make this change in a > future release. OK, thanks everyone. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: Documentation: 21.5. Default Roles

2020-02-05 Thread Bruce Momjian
ed about breaking something right before release. Folks, is it Thursday. Can we revert this and return to it when we are not rushed? Alternatively, can someone who controls all the moving parts, like redirects and Stephen's patch additions take ownership of this issue, with authority to revert

Re: Documentation: 21.5. Default Roles

2020-02-03 Thread Bruce Momjian
on what this is missing even in master, I will revert this patch in all branches soon. I think everyone agrees the new documentation title is better, but we don't want to break things or add inconsistency to do it. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: Documentation: 21.5. Default Roles

2020-01-21 Thread Bruce Momjian
On Tue, Jan 21, 2020 at 10:06:43AM +0100, Laurenz Albe wrote: > On Mon, 2020-01-20 at 17:13 -0500, Bruce Momjian wrote: > > Well, I am renaming the documentation label for the feature. Is that > > different than wording? I guess I can see that. If everyone agrees I > > can

Re: not clear what it means

2020-01-20 Thread Bruce Momjian
products/6-postgresql-extensions/ > In section about: pg_track_settings > look for: that me must called > I'm not one native speaker thus I'm sorry if I took your attention for > nothing, but is this really a phrase? > Thanks This requires a change to our website, so I am sending it

Re: Documentation: 21.5. Default Roles

2020-01-20 Thread Bruce Momjian
On Mon, Jan 20, 2020 at 06:45:16PM +, Simon Riggs wrote: > On Mon, 20 Jan 2020 at 16:03, Bruce Momjian wrote: > Usually when I apply "wording" doc patches to head only, someone > complains that it should be backpatched, so I did that in this case.  If > we wa

Re: Documentation: 21.5. Default Roles

2020-01-20 Thread Bruce Momjian
uot;prefined roles", and note they will be called this from Pg13. Usually when I apply "wording" doc patches to head only, someone complains that it should be backpatched, so I did that in this case. If we want to change that idea, we need to agree on the criteria. -- Bruce Mom

Re: Making the first few chapters of Part III more novice-friendly

2020-01-17 Thread Bruce Momjian
eties, there is no > specific content for Windows. > > I am happy to help develop solutions for any of the comments I send out. There is no question that our tutorials and novice stuff is lacking. We are very good with reference material. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: References between initdb and pg_controldata

2020-01-17 Thread Bruce Momjian
data. Uh, most people who use initdb don't care about pg_controldata, but if you are studying pg_controldata, you should know that initdb created it. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As

Re: Argument 'week' not supported in date_trunc function with intervals

2020-01-17 Thread Bruce Momjian
TE_TRUNC('week', INTERVAL '') to work if there is no month component, since interval is made up of months, days, and time. However, this would mean the function would work with some interval values, and not others. Is that an improvement? -- Bruce Momjian http://momjian.us Enterpri

Re: doc: Add anchors in create_table.sgml

2020-01-17 Thread Bruce Momjian
t I'm not sure about adding them to every single keyword of every > single reference page. Is that really useful? It would be helpful if the release notes could point to specific tables in the docs, rather than just sections. -- Bruce Momjian http://momjian.us EnterpriseDB

Re: pg_ctl in Windows

2020-01-17 Thread Bruce Momjian
nd what does the failure look like? -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: Spanish translation of postgresql manuals

2020-01-17 Thread Bruce Momjian
nish. Yes, someone is > interested in this, to contact me. Thank you. Great. I didn't realize we had no Spanish version, but a check on our website doesn't show any Spanish version: https://www.postgresql.org/docs/ I am sure there is a huge need for this. -- Bruce Momjian

Re: Documentation: 21.5. Default Roles

2020-01-14 Thread Bruce Momjian
html > which will now be broken, like from here?: I talked to Stephen on the phone and he is going to fix the doc areas I missed, and add some C comments. :-) Thanks. -- Bruce Momjian http://momjian.us EnterpriseDB http://e

Re: Documentation: 21.5. Default Roles

2020-01-14 Thread Bruce Momjian
On Tue, Jan 7, 2020 at 11:46:31AM +0100, Laurenz Albe wrote: > On Fri, 2019-12-27 at 12:16 -0500, Bruce Momjian wrote: > > On Fri, Dec 27, 2019 at 05:44:10AM +, PG Doc comments form wrote: > > > The following documentation comment has been logged on the website: > &

Re: Transaction Management requires Autocommit

2020-01-10 Thread Bruce Momjian
on Management" requires "Autocommit" to > be ON. Otherwise you get an error. Uh, you can only turn off autocommit on the client side, like psql, not in the server. What commands are you issuing and what error are you sseing? -- Bruce Momjian http://momjian.us Ente

Re: is_nullable column of information_schema.columns table

2019-12-30 Thread Bruce Momjian
the output? Thanks. Also, which Postgres version? -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: uniqueness and null could benefit from a hint for dba

2019-12-27 Thread Bruce Momjian
On Tue, Nov 5, 2019 at 12:13:06PM -0500, Bruce Momjian wrote: > On Tue, Oct 29, 2019 at 02:00:38PM +0200, Tuomas Leikola wrote: > > On Thu, Oct 24, 2019 at 5:31 PM Bruce Momjian wrote: > > > > Uh, I am wondering if it is just too details for our docs.  Can you >

Re: Why 'infinity' is not in range '[2019-01-02, infinity]'?

2019-12-27 Thread Bruce Momjian
On Wed, Nov 6, 2019 at 08:33:28AM -0500, Bruce Momjian wrote: > On Wed, Nov 6, 2019 at 12:15:17PM +0200, Eugen Konkov wrote: > > !Specifying a missing bound as exclusive is automatically converted > > !to inclusive, e.g., [,] is automatically converted > > !to

Re: Documentation: 21.5. Default Roles

2019-12-27 Thread Bruce Momjian
Good points. I have developed the attached documentation patch which includes your ideas. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Rom

Re: document effect of USAGE on foreign server to dblink

2019-12-23 Thread Bruce Momjian
On Thu, Dec 19, 2019 at 03:54:44PM -0500, Jeff Janes wrote: > > > On Thu, Dec 19, 2019 at 11:43 AM Bruce Momjian wrote: > > On Wed, Nov 27, 2019 at 11:33:03AM -0500, Jeff Janes wrote: > > I think that the permissions around the usage of foreign server names as >

Re: wait event docs

2019-12-21 Thread Bruce Momjian
ted to wait event profiles here: > https://www.postgresql.org/docs/devel/monitoring.html Agreed, it probably should be in the official docs. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: pg_basebackup page need further clarification

2019-12-21 Thread Bruce Momjian
ion: > > Hi! > At first I want to thank your for this wonderful software! > I'm reading pg_basebackup page now and don't see two important section: > 1) Restoring backup > 2) Difference with another backup utilities from postgre team > > Regards, Semyon. -- Bruce Momjian

Re: It is recommended to add detailed description about initdb ...

2019-12-21 Thread Bruce Momjian
e/myname/pgsql/bin, it > return bash: initdb: command not found The others are like this. It must > be /home/myname/pgsql/bin/initdb -D /home/myname/pgsql/data. This is related to your PATH environment variable setting and not something we document. -- Bruce Momjian http://m

<    1   2   3   4   5   6   7   >