On Thu, Jun 21, 2018 at 05:08:39AM -0500, Brad DeJong wrote:
> On Tue, Jun 19, 2018 at 9:20 PM, Euler Taveira wrote:
> > I left this change in the v2 patch.
> > I didn't remove it because it was an Oxford comma; I removed it because
> > there are only two items, tables and files, so th
2018-06-21 8:01 GMT-03:00 Brad DeJong :
> When you said "I think the sentence should be ...", I took that to mean that
> you know that the condition should be an OR.
>
There are separate conditions in the code (each one was done in
separate commits).
--
Euler Taveira
On Thu, Jun 21, 2018 at 5:08 AM, Brad DeJong wrote:
>
>
> On Tue, Jun 19, 2018 at 9:20 PM, Euler Taveira
> wrote:
>>
>> I see. I think the sentence should be "Exclude unlogged tables,
>> temporary tables, and pg_internal.init files from
>> streaming base backups".
>>
>> I like it. Done.
>
>>
>>
On Tue, Jun 19, 2018 at 9:20 PM, Euler Taveira wrote:
> Brad, your forgot to reply to pgsql-docs.
>
> 2018-06-19 20:21 GMT-03:00 Brad DeJong :
> > How about dropping the which clause entirely? I split this off as
> > release-11-newunit-v1.patch for further discussion.
> >
> Works for me. Could yo
Brad, your forgot to reply to pgsql-docs.
2018-06-19 20:21 GMT-03:00 Brad DeJong :
> How about dropping the which clause entirely? I split this off as
> release-11-newunit-v1.patch for further discussion.
>
Works for me. Could you append it to v2?
>>
>> -Exclude unlogged, tempora
2018-06-15 7:58 GMT-03:00 Brad DeJong :
> same patch but renamed to match the patch file naming convention
>
Comments above:
-Previously super users were exclusively granted to access these
+Previously, super-users were exclusively granted access to these
function
same patch but renamed to match the patch file naming convention
On Thu, Jun 14, 2018 at 6:13 PM, Brad DeJong wrote:
> The diff is for release-11.sgml.
>
> I fixed typos and grammar + rephrased some things that didn't seem to flow
>
> The only major change is the section on PSQL_PAGER.
>
> In th
The diff is for release-11.sgml.
I fixed typos and grammar + rephrased some things that didn't seem to flow
The only major change is the section on PSQL_PAGER.
In the section on the new --create-slot option for pg_basebackup, it seems
like --slot should include the =slotname part but I don't
kno
