Re: Correction for 9.6 documentation for OpenBSD

> On 3 Apr 2018, at 07:29, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.6/static/server-start.html > Description: > > OpenBSD 6.1 i386 > PostgreSQL 9.6 > > In Section 18.3. Starting the Database

Trailing semicolons on partitioning example commands

Is there a reason for not ending all partitioning commands with semicolons in the declarative partitioning example? https://www.postgresql.org/docs/devel/static/ddl-partitioning.html The two last commands with TABLESPACE clauses are ended with semicolons, the first three arent. Attached

Re: A simple question

> On 01 Feb 2018, at 13:09, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.3/static/sql-keywords-appendix.html > Description: > > Hello, my client has a plethora of reserved

Re: Documented toolchain for building docs on Windows

> On 13 Jul 2018, at 10:09, Peter Eisentraut > wrote: > > On 29.06.18 18:51, Daniel Gustafsson wrote: >>> On 29 Jun 2018, at 15:08, Peter Eisentraut >>> wrote: >>> >>> On 6/28/18 13:19, Daniel Gustafsson wrote: >>>> Unless so

Re: Document WaitForBackgroundWorkerShutdown and fix bgworker typo

> On 01 Mar 2018, at 17:46, Andres Freund <and...@anarazel.de> wrote: > > On 2018-02-09 23:43:26 +0100, Daniel Gustafsson wrote: >> WaitForBackgroundWorkerShutdown() was added in 924bcf4f16d, but never >> documented which seems like an oversight for such a useful funct

Re: json_populate_* functions have extra undocumented parameter

> On 23 Mar 2018, at 03:50, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/10/static/functions-json.html > Description: > > The json_populate_record and

Re: Add Pgfe library to client interfaces

> On 28 Jun 2018, at 15:32, Bruce Momjian wrote: > > On Fri, Jun 1, 2018 at 05:56:34PM +0300, Dmitry Igrishin wrote: >> Hello, >> >> Could we please add Pgfe client library to the external interfaces section? >> >> Patch is attached. > > Is everyone good with adding this? Is it too new?

Re: Documented toolchain for building docs on Windows

> On 28 Jun 2018, at 12:39, Peter Eisentraut > wrote: > > On 6/28/18 12:17, Daniel Gustafsson wrote: >> Section "17.1. Building with Visual C++ or the Microsoft Windows SDK” in the >> documentation has a subsection "Building the Documentation” which seems t

Re: Change pg_attribute textual link to an actual link

> On 22 Oct 2018, at 01:27, Tom Lane wrote: > > Daniel Gustafsson writes: >> In the System catalog/pg_attrdef documentation, there is a reference to >> pg_attribute with the text "see below". That makes sense in the PDF version >> (and similar renderings),

Improve wording for FDW header file reference

The "Foreign Data Wrapper Callback Routines” section contains an odd wording in the reference to the relevant headerfile: "The FdwRoutine struct type is declared in src/include/foreign/fdwapi.h, which see for additional details.” The attached patch is an attempt at improving

Missing whitespace in pg_dump docs

The attached diff adds what seems to be a missing whitespace in the discussion on dump formats. cheers ./daniel pg_dump_whitespace.diff Description: Binary data

Re: Change pg_attribute textual link to an actual link

> On 29 Oct 2018, at 08:39, Michael Paquier wrote: > > On Mon, Oct 22, 2018 at 12:09:41PM +0200, Daniel Gustafsson wrote: >> I think your latter suggestion pretty much covers all we need, so updated the >> patch with that too. > > Both the patch and the suggestio

Re: Proposed HTML Documentation Styles

> On 4 Oct 2018, at 18:33, Jonathan S. Katz wrote: > > On 10/4/18 12:28 PM, Alvaro Herrera wrote: >> This page http://174.138.60.30/docs/9.4/static/libpq-connect.html >> has some keywords inside "Warning" and "Note" boxes. Those keywords >> acquire a gray background instead of inheriting the

Re: .pgpass

> On 10 Jan 2019, at 04:45, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/10/libpq-pgpass.html > Description: > > I kindly suggest to let me edit this part to create examples such as > pg_restore

Re: Clarification to pg_upgrade docs on reverting to old cluster

On Friday, April 5, 2019 2:26 PM, Magnus Hagander wrote: > On Thu, Apr 4, 2019 at 11:14 PM Daniel Gustafsson wrote: > >> Reading the pg_upgrade reference page, I get the feeling that one of the >> bullets under "Reverting to old cluster" is a bit thin on detail to be

Clarification to pg_upgrade docs on reverting to old cluster

Reading the pg_upgrade reference page, I get the feeling that one of the bullets under "Reverting to old cluster" is a bit thin on detail to be helpful to newcomers: "If you ran pg_upgrade with --link, the data files are shared between the old and new cluster. If you started the new

Re: error

On Thursday, March 28, 2019 3:44 PM, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.6/xfunc-sql.html > Description: > > > hello > > i've descovered a small error - instead of integer should be numeric

Re: Missing pg_seetings catalog name in table 49.1

On Monday, April 1, 2019 8:33 AM, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.5/catalogs-overview.html > Description: > > Table 49.1 on https://www.postgresql.org/docs/9.5/catalogs-overview.html >

Re: Clarification to pg_upgrade docs on reverting to old cluster

On Friday, April 12, 2019 3:48 AM, Bruce Momjian wrote: > On Fri, Apr 5, 2019 at 02:23:22PM +0000, Daniel Gustafsson wrote: > > > On Friday, April 5, 2019 2:26 PM, Magnus Hagander mag...@hagander.net wrote: > > but wouldn't it sound better with "in this ca

Re: SPITupleTable members missing in docs

> On 14 Jun 2019, at 16:15, Tom Lane wrote: > > Daniel Gustafsson writes: >> Commit 3d13623d75d3206c8f009353415043a191ebab39 added the next and subid >> fields >> to the SPITupleTable struct, but they never made it into the documentation. >> While these

Formatting of warning about using ident

The warning about using ident for authorization or access control is using a with an rather than a , making it look quite different from the rest of the manual, and less like a warning IMO. https://www.postgresql.org/docs/devel/auth-ident.html The attached turns it into a and removes

Typo in GSSAPI docs

Commit b0b39f72b99 introduced a small typo in the GSSAPI documentation, see attached diff. cheers ./daniel gssapi_typo.diff Description: Binary data

Re: Typo in GSSAPI docs

> On 16 May 2019, at 10:40, Daniel Gustafsson wrote: > > Commit b0b39f72b99 introduced a small typo in the GSSAPI documentation, see > attached diff. Reading a bit closer there was one more, updated diff attached. cheers ./daniel gssapi_typo-v2.diff Description: Binary data

Re: Formatting of warning about using ident

> On 26 Jun 2019, at 15:09, Peter Eisentraut > wrote: > > On 2019-06-14 10:47, Daniel Gustafsson wrote: >> The warning about using ident for authorization or access control is using a >> with an rather than a , making it look >> quite different from the res

Re: Non working example

> On 1 Jul 2019, at 12:19, Maarten van Gijssel wrote: > > After I posted the question, I realised my mistake . I was using the pg gem > in Ruby to run the SQL "SELECT encode('123\000\001', 'base64')", the double > quotes ensure the `\0` will be interpreted as a null byte hence throwing the >

Re: TOC: List of Figures

> On 8 Jul 2019, at 21:43, Peter Eisentraut > wrote: > > On 2019-07-08 07:20, Jürgen Purtz wrote: >> To support the didactic method of media changes we >> should promote graphics with a summarizing list at a prominent place in >> front of the manual. > > This would make sense if we had fifty

Re: TOC: List of Figures

> On 8 Jul 2019, at 22:10, Tom Lane wrote: > let's wait till there's a > meaningful number of figures and then reconsider whether there's use in > a list of them. It's not like it will be any harder to make that change > in a year or two than it is today. In that case, let’s record this in the

Re: SPITupleTable members missing in docs

> On 12 Jul 2019, at 17:04, Tom Lane wrote: > > Fabien COELHO writes: >> To take into account Tom's comment, I'd suggest a middle ground by >> commenting a public and private part explicitely in the struct, something >> like: Thanks for the review! >> typedef struct { >> /* PUBLIC

Re: Outdated tip in the "Adding a column section"

> On 14 Jul 2019, at 08:12, Daniel Westermann (DWE) > wrote: > This is not true anymore since PostgreSQL 11, isn't it? If agreed, I would > try to write my first patch to remove that. Correct, as long as the default isn’t volatile. This was changed in 16828d5c0, please go ahead and propose a

Re: TOC: List of Figures

> On 2 Jul 2019, at 10:13, Jürgen Purtz wrote: > After the integration of figures into the documentation it may be helpful to > extent the TOC with a 'List of Figures'. Any opinion? +1, I think we should. > The alternative is a downshift of the postings by one level, see attachment > 2. How

Re: kilobyte unit spelled "K bytes"

> On 30 Aug 2019, at 02:34, Nikolay Samokhvalov wrote: > > Related: > https://www.postgresql.org/message-id/flat/20160730001838.GA22405%40momjian.us#ef946043c336d66e717e0e6e96639f92 > >

kilobyte unit spelled "K bytes"

In the documentation there is a single instance of “K bytes” being used to denote kilobytes (kB or kilobyte used everywhere else), which isn’t really correct as the k should be lowercased. The attached diff fixes this to make it consistent with the rest of the documentation. I opted for

Re: Formatting of warning about using ident

> On 22 Jul 2019, at 14:23, Peter Eisentraut > wrote: > Being a quote and being a warning are two orthogonal properties. So in > that sense, wrapping the quote in a warning element is more correct. > But the problem is now that a warning box is meant to be formatted out > of line, so writing

Re: SPITupleTable members missing in docs

> On 15 Jul 2019, at 23:18, Fabien COELHO wrote: >> I quite like this suggestion, so I’ve changed the patch to do this. Removed >> the doc: in the commit message to indicate that this is no longer just >> touching >> documentation. > > About v2: applies cleanly, compiles, make check and doc

SPITupleTable members missing in docs

Commit 3d13623d75d3206c8f009353415043a191ebab39 added the next and subid fields to the SPITupleTable struct, but they never made it into the documentation. While these are internal members, we already document several other internal ones (with a sentence on not using them) so add these too to make

Re: The word "virgin" used incorrectly and probably better off replaced

> On 7 Nov 2019, at 16:03, Alvaro Herrera wrote: > because we have not explained what a "virgin database" is. I think this is the key observation. > We could say "empty", which seems better suited than both "virgin" and > "pristine" anyway. empty is a lot better, but still isn't conveying

Re: The word "virgin" used incorrectly and probably better off replaced

> On 8 Nov 2019, at 16:19, Tom Lane wrote: > So the patch becomes s/virgin/pristine/g plus add a parenthetical > definition for the first use? Works for me. Agreed. cheers ./daniel

Re: The word "virgin" used incorrectly and probably better off replaced

> On 8 Nov 2019, at 14:10, Alvaro Herrera wrote: > > On 2019-Nov-08, Daniel Gustafsson wrote: > >> Agreed. I like your suggestion, or the inverse of it: "a database without >> any >> user defined objects". > > Here's a proposed patch. +1, LGTM cheers ./daniel

Re: Example 42.4. A PL/pgSQL Trigger Function for Auditing

> On 16 Dec 2019, at 20:27, Tom Lane wrote: > > .. maybe that is just more > evidence that a well-written example would be helpful? I think thats the key takeaway here. +1 on the gist of the suggestion that started this thread. cheers ./daniel

Re: A4 pdf points to 11.5 instead of 11.6

> On 19 Nov 2019, at 09:09, William Sescu (Suva) wrote: > If I download the A4 pdf of the version 11, it says 11.5 documentation. > > https://www.postgresql.org/docs/manuals/ > > However, it should contain the 11.6 documentation. Shouldn’t it? It indeed should. Looking at the other

Odd markup in SSL mode table

In the SSL mode table (33.1), one of the "MITM Protection" values is set using while seemingly being normal text. It has been like this since added in af2cf3be03f284aa12a07bce2b95d4a2768b290f, but I can't figure out why, and it makes it look odd IMO. Any reason not to apply the attached and

Re: Small typo in func.sgml

> On 19 Nov 2019, at 14:20, Tatsuo Ishii wrote: > > -Copies an existing logical replication slot name > src_slot_name > +Copies an existing logical replication slot named > src_slot_name +1 cheers ./daniel

Re: Example not producing shown output

> On 26 Nov 2019, at 19:28, Alvaro Herrera wrote: > Or perhaps we can add a second line in the example cell for the > @@ operator, to make it clear that both forms can be used. Users can be > expected to apply some intuition from that point onwards. Wouldn't it be more intuitive to add such a

Re: Example not producing shown output

> On 25 Nov 2019, at 13:05, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/functions-textsearch.html > Description: > > Page: https://www.postgresql.org/docs/12/functions-textsearch.html > >

Re: I suggest improving install steps for CentOS 8

Adding -www as this isn't a documentation issue but a website issue. > On 14 Nov 2019, at 03:36, Yasuhiro Horimoto wrote: > > Hello, > > I have found a problem with the following page. > > page: https://www.postgresql.org/download/linux/redhat/ > > I tried install PostgreSQL12 into CentOS 8

Re: Minor error

> On 28 Feb 2020, at 15:50, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/indexes-partial.html > Description: > > A sentence on this page reads: > "The system can recognize simple inequality

Re: Missing File weather.txt

> On 28 Jan 2020, at 03:22, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/tutorial-populate.html > Description: > > On this page https://www.postgresql.org/docs/12/tutorial-populate.html you >

Re: Typo in Documentation for Version 12 Section 40.3

> On 9 Jan 2020, at 10:34, Octopus ZHANG wrote: Please don't top-post on the mailinglists. > I partially agree. But with the context, it doesn't assume we want > `view<->visualize` the data. It also says: > > >> Another use for a materialized view is to allow faster access to data > >>

Re: Suggestion on Document for Version 12 Section 40.3

> On 9 Jan 2020, at 09:28, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/rules-materializedviews.html > Description: > > Hello all, > > > I'm reading Section 40.3, and there is an example (the

Re: Typo in Documentation for Version 12 Section 40.3

> On 9 Jan 2020, at 09:05, PG Doc comments form wrote: If people want to be able to quickly graph historical sales data, ... > > This sentence doesn't make sense. I think it should be: > > --- If people want to be able to quickly grab/obtain/get historical sales > data, ... I'm not a

Roles for pg_basebackup

Based on a recent conversation about backups I had I propose a small tweak to the pg_basebackup documentation. Listing the user types in the reverse order from today, putting superuser last, makes it IMO a little clearer that a REPLICATION role is preferrable to using a superuser for running

Re: Direct links to edit documentation

> On 4 May 2020, at 19:06, Magnus Hagander wrote: > Question is if the benefit would outweigh the cost, compared to just receiving > comments and "manually patching them in". Another question is the cost of managing access to such a system, we haven't exactly had the best of luck with input

Re: Roles for pg_basebackup

> On 28 Apr 2020, at 07:22, Fujii Masao wrote: > > On 2020/04/28 13:37, Michael Paquier wrote: >> On Mon, Apr 27, 2020 at 12:16:41PM +0200, Daniel Gustafsson wrote: >>> Based on a recent conversation about backups I had I propose a small tweak >>> to &g

TLS docs fixes for

While working with TLS I noticed that the password callback definition had an extra newline in the programlisting in the docs. Since the has been indented with the textblock, the newline comes from whitespace being significant. The attached 0001 fixes by instead anchoring on column zero like

Re: TLS docs fixes for

> On 14 May 2020, at 04:17, Michael Paquier wrote: > > On Wed, May 13, 2020 at 11:07:44PM +0200, Daniel Gustafsson wrote: >> While working with TLS I noticed that the password callback definition had an >> extra newline in the programlisting in the docs. Since the

Re: Missing comma?

> On 13 May 2020, at 12:20, Marina Polyakova wrote: > https://www.postgresql.org/docs/current/catalog-pg-class.html says "Columns > used to form “replica identity” for rows: d = default (primary key, if any), > n = nothing, f = all columns i = index with indisreplident set, or default". > Am

Re: Incorrect dropuser command in postgress 11

> On 18 Mar 2020, at 19:07, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/app-dropuser.html > Description: > > The command given in documentation for dropping a postgres user is 'dropuser > ' .

Re: initdb - creating clusters

> On 30 Aug 2020, at 17:21, Tom Lane wrote: > > Thomas Munro writes: >> + The discussions in this chapter assume that you are working with >> + an unmodified version of PostgreSQL, >> + for example one that you built from source according to the directions >> + in the preceding chapters.

Re: typo in literature reference

> On 10 Sep 2020, at 11:26, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/biblio.html > Description: > > Ullmann's classic should be > > [ull88] > Principles of Database and Knowledge-Base

Re: Installation on Cygwin

> On 8 Sep 2020, at 15:44, Magnus Hagander wrote > On Mon, Aug 31, 2020 at 5:52 PM Bruce Momjian > wrote: > I am thinking the list of operating systems should just be removed. > > Are you referring to the whole section 16.7 in the 12 version >

Re: Errors in explanation of the --with-libxml configure option.

> On 7 Oct 2020, at 02:43, PG Doc comments form wrote: > But neither XML2_CFLAGS nor XML2_LIBS appears in the actual configure > scripts or makefiles, and so of course setting those env vars does no good. > The INSTALL text file bundled in postgresql-12.1.tar.bz2 states instead The

Re: Installation instructions vs binaries

> On 15 Sep 2020, at 02:43, David G. Johnston > wrote: > On Tue, Sep 8, 2020 at 8:05 AM Magnus Hagander > wrote: > That leaves just the part of adding the actual new chapter of my patch. PFA. > Thoughts on that? +1 on this version of the patch. It seems a bit

Re: Fix PL/Lua link in External Projects appendix

> On 16 Oct 2020, at 11:26, Magnus Hagander wrote: > > On Fri, Oct 16, 2020 at 10:32 AM Daniel Gustafsson <mailto:dan...@yesql.se>> wrote: > The PL/Lua repository we link to in the documentation has been updated to say > DEPRECATED, with a reference to a new rep

Fix PL/Lua link in External Projects appendix

The PL/Lua repository we link to in the documentation has been updated to say DEPRECATED, with a reference to a new repo within the same Github organization. The attached patch updates the url in the postgres docs to point to the current repo. cheers ./daniel pllua_url.patch Description:

Re: initdb - creating clusters

> On 22 Jul 2020, at 18:34, Bruce Momjian wrote: > > On Tue, Jul 21, 2020 at 10:40:59AM +0200, Daniel Gustafsson wrote: >>> On 21 Jul 2020, at 02:25, Bruce Momjian wrote: >>> >>> On Thu, Jul 9, 2020 at 03:25:14PM +, PG Doc comments form wrote: >>&

Re: ALTER SYSTEM between upgrades

> On 25 Aug 2020, at 21:30, Bruce Momjian wrote: > > On Tue, Jul 14, 2020 at 12:52:23PM +0200, Daniel Gustafsson wrote: >>>> On 14 Jul 2020, at 01:58, Bruce Momjian wrote: >>> >>> I am creating a new thread to discuss the question raised by Alvar

Installation on Cygwin

I happened to stumble over the Cygwin section of the installation docs, and was surprised to see references to not entirely bleeding-edge Windows versions: "The adduser command is not supported; use the appropriate user management application on Windows NT, 2000, or XP. Otherwise, skip

Re: Version 13 documentation layout is harder to read than version 12

> On 29 Sep 2020, at 21:09, Jonathan S. Katz wrote: > If there is something that in a defined way is hampering usability, then > we should address it, There is the issue with screen readers which was reported in [0], but that thread stalled. I have it on my TODO still to try out the

Re: initdb - creating clusters

> On 12 Jul 2020, at 00:24, Tom Lane wrote: > > Daniel Gustafsson writes: >>> On 11 Jul 2020, at 23:36, Tom Lane wrote: >>> + For example, there may be special scripts for creating a database >>> + cluster. There almost certainly will be a mech

Re: Additional Chapter for Tutorial

> On 13 Jul 2020, at 14:20, Naresh gandi wrote: (please avoid top-posting) > Which version is this application for? > > I tried for v12 and v13 Beta, both failed. Unless being a bugfix, all patches are only considered against the main development branch in Git. As this is new material, it

Re: ALTER SYSTEM between upgrades

> On 14 Jul 2020, at 01:58, Bruce Momjian wrote: > I am creating a new thread to discuss the question raised by Alvaro of > how many ALTER SYSTEM settings are lost during major upgrades. Do we > properly document that users should migrate their postgresql.conf _and_ > postgresql.auto.conf files

Re: Additional Chapter for Tutorial

> On 2 Jun 2020, at 17:01, Jürgen Purtz wrote: > In comparison with to previous patch this one contains: > > - Position and title changed to reflect its intention and importance. > > - A delimits VACUUM basics from details. This is done because I cannot > find another suitable place for such

Re: initdb - creating clusters

> On 11 Jul 2020, at 23:36, Tom Lane wrote: > + For example, there may be special scripts for creating a database > + cluster. There almost certainly will be a mechanism for starting > + the server, Aren't we really talking about "running the server as a service" and not just starting it?

Re: wrong output column title in example

> On 21 Jun 2020, at 21:07, Erik Rijkers wrote: > > On 2020-06-21 18:21, PG Doc comments form wrote: >> The following documentation comment has been logged on the website: >> Page: https://www.postgresql.org/docs/12/arrays.html >> Description: >> In the last code block in "8.15.5. Searching in

Re: Schemaverse pointing to a dead link

> On 4 Dec 2020, at 09:15, William Sescu (Suva) wrote: > It looks like that the Schemaverse, which is listed on > > https://www.postgresql.org/docs/online-resources/ > > is pointing to a dead link. > > The Link https://schemaverse.com/ does not exist anymore. Maybe it was a transient

Re: Consistent reference to RFCs in the documentation

> On 1 Dec 2020, at 13:39, Heikki Linnakangas wrote: > On 05/11/2020 17:09, Daniel Gustafsson wrote: >> The attached patch adds ulinks for all >> RFC's and marks subsequent mentions as acronym to make the docs consistent. >> It >> also spells a

Consistent reference to RFCs in the documentation

When referencing RFC's, we have a mix of ulinking to the ietf.org entry and not. Also, for subsequent mentions of the same RFC on the same page we have some as while others are not. The attached patch adds ulinks for all RFC's and marks subsequent mentions as acronym to make the docs

Re: Postgres upgrade does not mention requirement to have only 1 user

> On 26 Jan 2021, at 09:39, Laurenz Albe wrote: > But perhaps it would not harm to be more explicit and add something like > that: > > "Do not create and users, tablespaces or other objects on the new cluster." +1, that makes sense (with a s/and/any/). -- Daniel Gusta

Replace mention of FTP server with more up to date downloads location

up to date. -- Daniel Gustafsson https://vmware.com/ ftp_server.diff Description: Binary data

Re: Replace mention of FTP server with more up to date downloads location

> On 22 Jan 2021, at 12:51, Magnus Hagander wrote: > > On Fri, Jan 22, 2021 at 11:36 AM Daniel Gustafsson wrote: >> >> While looking at something else, I noticed that we still refer to the >> "PostgreSQL FTP server" in the MSVC portion of the docs even t

Git is not an acronym

the acronyms page. -- Daniel Gustafsson https://vmware.com/ git_acronym.diff Description: Binary data

Re: Git is not an acronym

> On 10 Jun 2021, at 15:03, Jonathan S. Katz wrote: > > On 6/10/21 7:40 AM, Daniel Gustafsson wrote: >> Commit 651377933e031 cleaned up references to CVS replacing them with Git. >> Replacing CVS with Git in acronyms.sgml seems a bit incorrect though as Git >> isn't an

Re: markdown error

> On 7 Jul 2021, at 09:17, PG Doc comments form wrote: > Tables for operators and functions in version 13 and devel 14 are broken These tables were deliberately changed to this format to allow for wide content. -- Daniel Gustafsson https://vmware.com/

Update to reflect that TLS1 and TLSv1.1 are now deprecated

The recently published RFC 8996 deprecates the use of TLSv1 and TLSv1.1, the attached rewords where we say our default of 1.2 is industry best practice with a link to the authoritative source. -- Daniel Gustafsson https://vmware.com/ rfc_8996.diff Description: Binary data

Re: Update to reflect that TLS1 and TLSv1.1 are now deprecated

> On 24 Mar 2021, at 21:07, Peter Eisentraut > wrote: > > On 24.03.21 10:49, Daniel Gustafsson wrote: >> The recently published RFC 8996 deprecates the use of TLSv1 and TLSv1.1, the >> attached rewords where we say our default of 1.2 is industry best pra

TLS acronym

As discussed in the NSS thread, we've had TLS defined as an since commit c6763156589 in 2014 without actually having it defined in acronyms.sgml. The attached adds the definition linking to the Wikipedia entry for TLS. -- Daniel Gustafsson https://vmware.com/ tls_acronym.patch

CREATE TABLE typo

Commit f2a69b352de introduced a small typo in the CREATE TABLE documentation, fixed in the attached. -- Daniel Gustafsson https://vmware.com/ create_table_typo.diff Description: Binary data

Re: Background worker docs,

the process, in > + postgres should wait before restarting the process in While not being an native english speaker, I agree that this reads better. -- Daniel Gustafsson https://vmware.com/

Re: Background worker docs,

uot;in the event that it crashes" made it clear That, or “if it crashes” gets my vote. -- Daniel Gustafsson https://vmware.com/

Re: Background worker docs,

> On 27 Aug 2021, at 16:15, Tom Lane wrote: > > Daniel Gustafsson writes: >> On 27 Aug 2021, at 15:52, Dave Cramer wrote: >>> In my mind "in the event that it crashes" made it clear > >> That, or “if it crashes” gets my vote. > > Dave's word

Re: Background worker docs,

> On 27 Aug 2021, at 16:31, Tom Lane wrote: > > Daniel Gustafsson writes: >> On 27 Aug 2021, at 16:15, Tom Lane wrote: >>> Dave's wording sounds good to me. > >> I can go make that happen, backpatched down to 9.6 AFAICT on a quick skim, >> unless you’re

Re: Minor doc fixes

> On 13 Jul 2021, at 15:13, Ekaterina Kiryanova > wrote: > I've noticed some minor doc inconsistencies. > Please review the attached patch. Thanks for your patch, reviewing it I agree with your proposed changes. Unless there are objections I'll apply this within a few days

Re: Another pg_dump using split and gzip for large databases

attached. Maybe because the --filter option is only available in GNU split and not in POSIX, and thus not on FreeBSD and macOS etc. I'm not sure about what level of compatibility we strive for in the examples though. -- Daniel Gustafsson https://vmware.com/

Re: Another pg_dump using split and gzip for large databases

> On 29 Jul 2021, at 21:10, Bruce Momjian wrote: > > On Thu, Jul 29, 2021 at 07:15:21PM +0200, Daniel Gustafsson wrote: >>> On 29 Jul 2021, at 17:29, Bruce Momjian wrote: >>> >>> On Thu, Jul 29, 2021 at 05:23:20PM +0200, Daniel Gustafsson wrote: >>&

Re: Another pg_dump using split and gzip for large databases

> On 29 Jul 2021, at 17:29, Bruce Momjian wrote: > > On Thu, Jul 29, 2021 at 05:23:20PM +0200, Daniel Gustafsson wrote: >>> On 29 Jul 2021, at 16:58, Bruce Momjian wrote: >> >>> OK, I can adjust it to say "GNU split" or just skip this addition. >

Re: Another pg_dump using split and gzip for large databases

> On 29 Jul 2021, at 16:58, Bruce Momjian wrote: > OK, I can adjust it to say "GNU split" or just skip this addition. I don't have strong feelings either way, with a slight preference for writing it as "GNU split" since it's still a good tip for a large amount of read

Re: Typo in release notes for pg14

utor method to memorize results from the inner side of a nested-loop > join (David Rowley) Memoize is actually the correct term here, see for example the below commit: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=83f4fcc65503c5d4e5d5eefc8e7a70d3c9a6496f -- Daniel Gustafsson https://vmware.com/

Re: Update documentation page for translators

tool though, so I just added a small sentence to indicate that options exist, and that we don't necessarily require anyone to use a text editor. CC:ing developers who have spent time with translations for input. -- Daniel Gustafsson https://vmware.com/ translations.diff Description: Binary data

Re: Example of json_array_elements

ue [2,false] (3 rows) Your proposal is also syntactically correct, but it's not what the author intended when writing the example: postgres=# select * from json_array_elements('[[1,true], [2,false]]'); value --- [1,true] [2,false] (2 rows) -- Daniel Gustafsson

Re: broken link to "SELinux guide" from sepgsql

> On 28 Oct 2021, at 14:37, Michael Paquier wrote: > > On Thu, Oct 28, 2021 at 01:34:40PM +0200, Daniel Gustafsson wrote: >> AFAICT it's the same document, but updated. If we want to leave 9.6 in as >> much >> of a working state as possible I think it makes sense to

  1   2   3   >