Re: Role membership and DROP

2019-11-15 Thread Laurenz Albe
On Wed, 2019-11-13 at 17:17 -0500, Tom Lane wrote: > Laurenz Albe writes: > > I realized only today that if role A is a member of role B, > > A can ALTER and DROP objects owned by B. > > I don't have a problem with that, but the documentation seems to > > suggest otherw

Re: GSoD - a patch for Getting Started tutorial

2019-11-18 Thread Laurenz Albe
- I couldn't see anything about Windows. I think that particularly on Windows people would need a tutorial most, not because Windows people are more clueless, but because things work differently there. Many Windows users don't know how to start a shell. Yours, Laurenz Albe

Re: standalone-install.xml

2019-11-20 Thread Laurenz Albe
you how to start up > the database server" referes to the message from initdb: > > Success. You can now start the database server using: > > pg_ctl -D data -l logfile start > > Am I correct? Right. Maybe it were better to write: The output from the previous initdb step should have told you Yours, Laurenz Albe

Re: GSoD - a patch for Getting Started tutorial

2019-11-19 Thread Laurenz Albe
ink we can extend it with Windows specifics if there are no other major > concerns. > (But it'll probably take some time for me to try it and figure out the > differences. > Although I know how to start a shell, I'm sure I'll face other problems. :)) I understand your reluctance. But if we want to cater for clueless beginners, we cannot omit Windows. Yours, Laurenz Albe -- Cybertec | https://www.cybertec-postgresql.com

Re: GSoD - a patch for Getting Started tutorial

2019-11-20 Thread Laurenz Albe
cript included in these packages. I have always used "initdb" directly, and if I don't specify the -A option explicitly, I get "trust". Yours, Laurenz Albe

Re: GSoD - a patch for Getting Started tutorial

2019-11-20 Thread Laurenz Albe
ink that the material in this patch is an improvement over the "Installation" section in the current tutorial, but that the other sections ("Architectural Fundamentals", "Creating a Database" and "Accessing a Database") are better in the original. And I like the idea of a "troubleshooting" section. Yours, Laurenz Albe

Re: COPY manual is ambiguous about column list

2019-11-28 Thread Laurenz Albe
g about columns in the file, only columns in the table. But if you got it wrong, maybe a clarification would be a good idea. Yours, Laurenz Albe

Re: Difference between Bulk Load (Multiple inserts or single inserts) and COPY

2019-11-19 Thread Laurenz Albe
ter? so when indices are being created that query > slows down?? > > Please reply soon with more details or send a link where I can read it in > depth. That cannot be answered without knowing the exact statements and the table definitions. Yours, Laurenz Albe -- Cybertec | https://www.cybertec-postgresql.com

Re: Role membership and DROP

2019-11-19 Thread Laurenz Albe
On Tue, 2019-11-19 at 13:21 -0500, Tom Lane wrote: > Laurenz Albe writes: > > On Fri, 2019-11-15 at 13:41 -0500, Tom Lane wrote: > > > Laurenz Albe writes: > > > > On Wed, 2019-11-13 at 17:17 -0500, Tom Lane wrote: > > > > > It might be worth clarifyi

Re: pg_dump documentation page

2020-01-30 Thread Laurenz Albe
ere it specifies the target directory instead of a file. Yours, Laurenz Albe -- Cybertec | https://www.cybertec-postgresql.com

Re: documentation extension request - order with function over aggregated functions

2020-02-04 Thread Laurenz Albe
you get an extra unnecessary output column. You can either not use an alias in ORDER BY: SELECT a + b AS sum, c FROM table1 ORDER BY a + b + c; or you can use a subquery: SELECT sum, c FROM (SELECT a + b AS sum, c FROM table1) AS subq ORDER BY sum + c; Yours, Laurenz Albe

Re: pg_dump, --exclude-table-data

2020-02-02 Thread Laurenz Albe
foreign key that relies on the data will fail. Note that only the foreign key will fail and not get created, but the tables themselves will be restored. Yours, Laurenz Albe

Re: Shrinking SVG (Again)

2020-01-15 Thread Laurenz Albe
e / schema" image less. Some problems: - No user data should be stored in the "postgres" database. - "template0" has *no* other schemas or tables. It must be absolutely empty. - I am missing the global objects like roles and tablespaces "outside" the databases. I am fine with the directory layout image, but I wonder what "fluctuating states" may be. Yours, Laurenz Albe

Re: Documentation: 21.5. Default Roles

2020-01-21 Thread Laurenz Albe
going to say this should be backpatched. I for one think that it should be backpatched, as long as the old link keeps working. Yours, Laurenz Albe

Re: Put cluster in the hierarchy in 22.1

2020-01-07 Thread Laurenz Albe
gs as well: columns, constraints, triggers, etc. "Server" and "cluster" are synonymous here. Perhaps we should include "cluster" in parentheses behind "server". Yours, Laurenz Albe -- Cybertec | https://www.cybertec-postgresql.com

Re: Documentation: 21.5. Default Roles

2020-01-07 Thread Laurenz Albe
gt; clarity over all and removing any need to explain why postgres is not in > > this list of roles. > > > > Good points. I have developed the attached documentation patch which > includes your ideas. +1 I think that "predefined role" is better than "default role". Yours, Laurenz Albe -- Cybertec | https://www.cybertec-postgresql.com

Re: 37.10.3

2020-03-12 Thread Laurenz Albe
On Thu, 2020-03-12 at 06:34 +, PG Doc comments form wrote: > There is mention to macro PG_ARGNULL_xxx() which I cannot locate. Aren't you > talking of PG_ARGISNULL(n) ? Indeed. Here is a patch for that. Yours, Laurenz Albe diff --git a/doc/src/sgml/xfunc.sgml b/doc/src/sgml/xfunc.sgml

Re: 68.2.1

2020-03-12 Thread Laurenz Albe
ABLE, and it is referenced there. Yours, Laurenz Albe -- Cybertec | https://www.cybertec-postgresql.com

Re: recovery.conf in documentation for postgresql version 12

2020-04-08 Thread Laurenz Albe
n version 12? You were reading the v10 documentation by mistake. In the v12 page, "recovery.conf" is not mentioned. Yours, Laurenz Albe

Re: Ambiguos statement in wal-async-commit page

2020-04-14 Thread Laurenz Albe
he transaction commits without flushing WAL. The file that belongs to the table is removed during the commit. Now if there is a crash, it could happen that the transaction didn't happen (because the WAL wasn't persisted yet), but the file is already gone. This would be data corruption. Yours, Laurenz Albe

Re: pg_stat_statements showing passwords while create or alter users.

2020-04-17 Thread Laurenz Albe
hash it on the client side first. Most interactive clients have a way to do that, like psql`s "\password". Yours, Laurenz Albe -- Cybertec | https://www.cybertec-postgresql.com

Re: terminology in example

2020-04-01 Thread Laurenz Albe
gt;name text, >population real, > - altitude int -- (in ft) > + elevation int -- (in ft) > ); The "int" should be aligned with the rest (delete one space). Yours, Laurenz Albe

Re: Add A Glossary

2020-05-19 Thread Laurenz Albe
rgon. The term "client-server architecture" that you quote emphasized that. Perhaps "machine" would be the preferable term, because "host" is more prone to misunderstandings (except in a networking context). Yours, Laurenz Albe

Re: Possible mistake in backup documentation

2020-09-28 Thread Laurenz Albe
On Fri, 2020-09-25 at 14:50 +0200, Magnus Hagander wrote: > On Fri, Sep 25, 2020 at 2:32 PM Laurenz Albe wrote: > > On Tue, 2020-09-22 at 14:17 +, PG Doc comments form wrote: > > > In "25.3.3.2. Making An Exclusive Low-Level Backup", you said that "

Re: Possible mistake in backup documentation

2020-09-25 Thread Laurenz Albe
ch? Perhaps that is too complicated, but I have no idea how to make it simpler. Ceterum censeo, we should not deprecate the exclusive backup API. Yours, Laurenz Albe From 283fa644c15b08894fdff957e57e526b85913951 Mon Sep 17 00:00:00 2001 From: Laurenz Albe Date: Fri, 25 Sep 2020 14:26:58 +0200 Subj

Re: Add A Glossary

2020-05-20 Thread Laurenz Albe
uous usage, the definition of "server" must > clarify the allowed meanings. What's about: > > server: Depending on the context, the term *server* denotes: > > An IP-port which is offered by any OS. ? A port is a server? No way. > A - possibly virtualized - machine It might be good to disambiguate that, but I don't think that the PostgreSQL documentation should use the word "server" to mean "machine". > An abbreviation for the slightly longer term > "database(s)/cluster server" ??? this will support the > readability, but not the clarity ??? "Server" is short for "database server" and is a set of processes that listen for and handle incoming database client requests. I think that covers all the meanings you quoted from the documentation, except c), where it is used as shorthand for "server executable". Yours, Laurenz Albe

Re: initdb - creating clusters

2020-07-10 Thread Laurenz Albe
ternal sites in your documentation. (While writing this I have > searched to make sure I'm not writing rubbish and already understand that > pg_createcluster is a Debian solution/variant.) Something like the attached? Yours, Laurenz Albe From 001e5a31cc90bf307eb748a47f5a7b2389ea2f22 Mon Sep 17

Re: INDEX with optional storage parameter value

2020-06-29 Thread Laurenz Albe
> > > > It might be more correct to use the construct from CREATE TABLE: > > > > storage_parameter [= value] [, ... ] > > I found a few more places that also didn't properly document this; > patch attached. Looks good. Perhaps it is worth explaining this explici

Re: some charts or graphs of possible permissions would be nice

2020-06-10 Thread Laurenz Albe
rial for a tutorial rather than a documentation. Yours, Laurenz Albe

Re: strange syntax

2020-07-16 Thread Laurenz Albe
pecially this part: "who can access what is managed by" It is correct English, but maybe it could be worded better: "Schemas are a purely logical structure and impose no access restrictions, apart from those defined by the privilege system." Yours, Laurenz Albe

Re: Mention invalid null byte sequence

2020-12-07 Thread Laurenz Albe
sier to migrate to PostgreSQL :) +1; how about the attached patch? Yours, Laurenz Albe diff --git a/doc/src/sgml/charset.sgml b/doc/src/sgml/charset.sgml index cebc09ef91..7525b5c56e 100644 --- a/doc/src/sgml/charset.sgml +++ b/doc/src/sgml/charset.sgml @@ -1023,6 +1023,11 @@ CREATE COLLATION ig

Re: Mention invalid null byte sequence

2020-12-08 Thread Laurenz Albe
On Mon, 2020-12-07 at 15:27 -0500, Tom Lane wrote: > Laurenz Albe writes: > > On Sat, 2020-12-05 at 21:58 +, PG Doc comments form wrote: > > > The following documentation comment has been logged on the website: > > > Page: https://www.postgresql.org/docs

Re: Documentation of return values of range functions lower and upper

2020-11-11 Thread Laurenz Albe
the special values infinity and > -infinity, this is not correct, as those values are returned if explicitly > used as either bound. +1 Perhaps it would be better to say NULL if the range is empty or has no lower/upper bound Yours, Laurenz Albe

Re: Documentation of return values of range functions lower and upper

2020-11-18 Thread Laurenz Albe
On Wed, 2020-11-18 at 22:49 +0900, Fujii Masao wrote: > On 2020/11/12 17:14, Laurenz Albe wrote: > > > On Wed, 2020-11-11 at 18:19 +0100, Laurenz Albe wrote: > > > > Table 9.54 in page > > > > https://www.postgresql.org/docs/current/functions-range.html states

Re: Documentation of return values of range functions lower and upper

2020-11-12 Thread Laurenz Albe
On Wed, 2020-11-11 at 18:19 +0100, Laurenz Albe wrote: > > Table 9.54 in page > > https://www.postgresql.org/docs/current/functions-range.html states that the > > functions lower and upper return NULL if the requested bound is infinite. If > > the element type of the ra

Re: TRUNCATE VIEW

2021-01-25 Thread Laurenz Albe
On Mon, 2021-01-25 at 18:45 +0530, harisai hari wrote: > > On Mon, 25 Jan 2021, 6:08 pm Laurenz Albe, wrote: > > On Mon, 2021-01-25 at 12:06 +, PG Doc comments form wrote: > > > In this link https://www.postgresql.org/docs/12/ddl-priv.html you > > > mention

Re: Postgres upgrade does not mention requirement to have only 1 user

2021-01-26 Thread Laurenz Albe
documentation says, "Initialize the new PostgreSQL cluster" and that there is no need to start the cluster. That is a pretty strong indication that it is not necessary to create any objects there. But perhaps it would not harm to be more explicit and add something like that: "Do not create and users, tablespaces or other objects on the new cluster." Yours, Laurenz Albe

Re: TRUNCATE VIEW

2021-01-25 Thread Laurenz Albe
RUNCATE trigger on the view. Yours, Laurenz Albe

Re: Unnecessary use of .* in examples

2021-02-01 Thread Laurenz Albe
an > > String does not match regular expression, case insensitively > > 'thomas' !~* '.*vadim.*' → t I agree that that is comewhat confusing for people who understand regular expressions. On the other hand, the example should show some special characters, so that people who don't know regular expressions understand that this is more than substring matching. Perhaps 'thomas' ~ '^thom' and so on? Yours, Laurenz Albe

Re: Unnecessary use of .* in examples

2021-02-02 Thread Laurenz Albe
ld be better is to have an example with embedded .* > such as 'thomas' ~ 't.*m'. I agree, and thanks for improving it in https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=9522085ac917af66dba29939af328ae67300f10a Yours, Laurenz Albe

Re: 24.1.5.1. Multixacts And Wraparound

2021-06-22 Thread Laurenz Albe
On Mon, 2021-06-21 at 22:50 -0400, Bruce Momjian wrote: > On Fri, Jun 18, 2021 at 08:51:00AM +0200, Laurenz Albe wrote: > > On Thu, 2021-06-17 at 18:31 +, PG Doc comments form wrote: > > > In section "24.1.5.1. Multixacts And Wraparound" of > > > https://ww

Re: 24.1.5.1. Multixacts And Wraparound

2021-06-18 Thread Laurenz Albe
of the > addressable storage space" or maybe even "...space exceeds the amount of the > addressable storage space". Which is which? +1 I think that the second "the amount" in the sentence should be removed. Yours, Laurenz Albe

Re: SQL Commands COPY

2021-06-09 Thread Laurenz Albe
n the compatibility section works whereas the methods shown in the > synopsis and parameters sections do not work and will throw a syntax > error. You must be misreading something, the new syntax works: COPY (SELECT 42 AS x) TO STDOUT (FORMAT 'csv', FORCE_QUOTE (x)); Yours, Laurenz Albe

Improve documentation for pg_upgrade, standbys and rsync

2021-05-18 Thread Laurenz Albe
will have in real life. Yours, Laurenz Albe From 0ce2de70811ced07eb75215197cbb83cd7a7d2b9 Mon Sep 17 00:00:00 2001 From: Laurenz Albe Date: Tue, 18 May 2021 19:42:55 +0200 Subject: [PATCH] Improve doc for pg_upgrade and standby servers Recommend using the --relative option of rsync for clarity and adapt

Re: Additional Chapter for Tutorial

2021-05-21 Thread Laurenz Albe
t thing to do. You are welcome to re-submit the patch if you address the feedback. Yours, Laurenz Albe

Re: Online Documentation Search Issue

2021-05-18 Thread Laurenz Albe
ot sure if removing that stopword would be beneficial. But there is an index for the documentation: https://www.postgresql.org/docs/current/bookindex.html#indexdiv-B "BETWEEN" is in the index. So is "HAVING". Removing "HAVING" as a stopword would mean indexing "have", and that is obviously not going to help anybody. Yours, Laurenz Albe

Re: pg_monitor role description

2021-05-20 Thread Laurenz Albe
in | {} > > and I think most would agree that titling the column "Members" would > be backwards. Right. you have to read that like: Role name (bob) with attributes () is a member of (sysadmins). Yours, Laurenz Albe

Re: Update maintenance_work_mem/autovacuum_work_mem to reflect the 1GB limitation with VACUUM

2021-06-04 Thread Laurenz Albe
re right; theoretically, the correct place to document that would be the VACUUM documentation. But I guess that most people who are curious about VACUUM's memory usage will read the documentation for "maintenance_work_mem" or "autovacuum_work_mem". I have fixed a typo and adde

Re: [PATCH] add link to domain data types section from locale documentation

2021-05-27 Thread Laurenz Albe
ata_type_privileges", "domain_constraints", "domain_catalog", "domain_udt_usage", "domains" and the description below "columns") This selection is a bit arbitrary, I admit. Yours, Laurenz Albe

Re: [PATCH] fix ICU explorer link in locale documentation

2021-05-27 Thread Laurenz Albe
k should be changed. There are two options: 1. Trust that they will fix it soon and change the link to https://icu4c-demos.unicode.org/icu-bin/locexp 2. Despair and remove the link from the documentation. I suggest that we wait until the end of the June 2021 commitfest and decide then. If it is still not fixed then, the second option is better - or we move it to the next commitfest. Yours, Laurenz Albe

Re: Note that ALTER TABLE cannot alter generated stored columns

2021-05-30 Thread Laurenz Albe
eful to note this in the documentation with something like the > attached. +1 Yours, Laurenz Albe

Re: Improve documentation for pg_upgrade, standbys and rsync

2021-05-19 Thread Laurenz Albe
On Wed, 2021-05-19 at 10:31 -0400, Stephen Frost wrote: > * Laurenz Albe (laurenz.a...@cybertec.at) wrote: > > I revently tried to upgrade a standby following the documentation, > > but I found it hard to understand, [...] > > Haven't had a chance to look at this in depth but

Re: "68.4. Visibility Map" change suggestion.

2021-04-27 Thread Laurenz Albe
e any visible > tuples in them. I think that the wording of the documentation is more correct. The VM also tracks the pages that are not all-visible. They have the corresponding bit set to 0. Yours, Laurenz Albe

Re: Clarify how triggers relate to transactions

2021-04-28 Thread Laurenz Albe
principle, but I'd put that information on https://www.postgresql.org/docs/current/trigger-definition.html Yours, Laurenz Albe

Re: Rounding strategy

2021-04-22 Thread Laurenz Albe
s on your > platform. For numeric the function seems to round to nearest with ties going > away from zero (sometimes referred to as "round half up). 6.5 -> 7.0 and > -6.5 -> -7.0. Here is a proposed patch. Yours, Laurenz Albe From a0c40fd431820f6d1ce96f5bc3f41bd7665028be Mon Sep 17 00:

Re: BUG #16991: regclass is not case sensitive causing "relation does not exist" error

2021-05-05 Thread Laurenz Albe
ave regclass-accepting functions > all over, not to mention other OID alias types. I propose the attached > patch to move this info into the "Object Identifier Types" section. That patch looks good to me. I think it is an improvement to have that discussed under "data types". Yours, Laurenz Albe

Re: Clarify how triggers relate to transactions

2021-05-05 Thread Laurenz Albe
On Wed, 2021-04-28 at 13:24 +0200, Laurenz Albe wrote: > On Tue, 2021-04-27 at 14:26 +, PG Doc comments form wrote: > > https://www.postgresql.org/docs/current/sql-createtrigger.html mentions the > > word "transaction" only once, in reference specifically to constrain

Re: Update maintenance_work_mem/autovacuum_work_mem to reflect the 1GB limitation with VACUUM

2021-05-05 Thread Laurenz Albe
e is a patch for that, Yours, Laurenz Albe From 69ba1f6bef0209fa1093c39ba2e731641d7f5188 Mon Sep 17 00:00:00 2001 From: Laurenz Albe Date: Wed, 5 May 2021 12:02:11 +0200 Subject: [PATCH] Document the 1GB memory limit for VACUUM --- doc/src/sgml/config.sgml | 5 + 1 file changed, 5 insertions(+)

Re: Clarify how triggers relate to transactions

2021-04-28 Thread Laurenz Albe
eer review. Yours, Laurenz Albe

Re: [PATCH] add link to domain data types section from locale documentation

2021-03-31 Thread Laurenz Albe
r this > fix is desirable and correct (I'm new to Postgres) and if there is a > better way of suggesting an improvement for the documentation. > > [1] https://www.postgresql.org/docs/current/collation.html +1 Yours, Laurenz Albe

Re: [PATCH] add link to domain data types section from locale documentation

2021-04-01 Thread Laurenz Albe
ntly busy with the commitfest. You could add it to the next commitfest so that it does not get forgotten. Yours, Laurenz Albe

Re: Step 8 does not perform as documented

2021-03-04 Thread Laurenz Albe
nd restarted the server, but then the > server recover _past_ my recovery_target_time. I am not sure why. The log messages should tell you what is going on. Perhaps you used a wrong time zone. Yours, Laurenz Albe

Re: Rounding strategy

2021-04-19 Thread Laurenz Albe
as "round half up). 6.5 -> 7.0 and > -6.5 -> -7.0. +1 Yours, Laurenz Albe

Re: Document target_role param of ALTER DEFAULT PRIVILEGES

2021-02-17 Thread Laurenz Albe
e number of times I have seen people confused by that. Suggested patch attached. Yours, Laurenz Albe From 6ca7ad89b06c65d574a5e9da8192a14458863cb6 Mon Sep 17 00:00:00 2001 From: Laurenz Albe Date: Thu, 18 Feb 2021 08:14:55 +0100 Subject: [PATCH] Clarify docs for ALTER DEFAULT PRIVILEGES MIME-Version

Re: Documentation on Hash and btree Indexes on jsonb

2021-02-15 Thread Laurenz Albe
s > option could be discarded. I would love to hear your feedback on this > matter. The PostgreSQL documentation is talking about a B-tree index on the complete JSON, while the article is talking about a B-tree index on an expression that extracts one attribute of the JSON. These are quite d

Re: Rounding strategy

2021-04-23 Thread Laurenz Albe
On Thu, 2021-04-22 at 13:50 -0400, Tom Lane wrote: > Laurenz Albe writes: > > On Mon, 2021-04-19 at 08:00 +, PG Doc comments form wrote: > > > The 'round' mathematical function documentation doesn't specify its > > > rounding > > > strategy. If this wou

Re: Rounding strategy

2021-04-23 Thread Laurenz Albe
On Fri, 2021-04-23 at 09:40 +0200, Laurenz Albe wrote: > Makes sense. Here is an updated patch. I see that you have already committed your proposed version. Thanks! Yours, Laurenz Albe

Re: Clarify how triggers relate to transactions

2021-08-18 Thread Laurenz Albe
On Fri, 2021-07-30 at 16:20 -0400, Tom Lane wrote: > Laurenz Albe writes: > > On Wed, 2021-04-28 at 13:24 +0200, Laurenz Albe wrote: > > > On Tue, 2021-04-27 at 14:26 +, PG Doc comments form wrote: > > > > If I understand correctly, it would b

Re: Improve documentation for pg_upgrade, standbys and rsync

2021-08-18 Thread Laurenz Albe
luster? "Relative to my current directory" makes more sense to me here. > > + (There will be a mismatch if old standby servers were shut down > > + before the old primary or if the old standby servers are still > > running.) > > Would probably be good to note that if the standby's were shut down > before the primary then this method can *not* be used safely... The > above leaves it unclear about if the mismatch is an issue or not. I get > that this was in the original docs, but still would be good to improve > it. Agreed. Yours, Laurenz Albe

Re: create rule

2021-09-03 Thread Laurenz Albe
on columns with dropped columns and rules on non-empty tables can be created and used without problems. Perhaps you are using a mutilated fork of PostgreSQL. Yours, Laurenz Albe

Re: [PATCH] fix ICU explorer link in locale documentation

2021-09-03 Thread Laurenz Albe
On Thu, 2021-05-27 at 08:59 +0200, Laurenz Albe wrote: > On Thu, 2021-05-27 at 11:10 +0700, Anton Voloshin wrote: > > So I guess the https://icu4c-demos.unicode.org/icu-bin/locexp link is > > still the proper one, and eventually it will be fixed. Anyway, the old > >

Re: vacuum_freeze_min_age description validity

2021-09-17 Thread Laurenz Albe
f you increase the parameter, rows will be frozen later, so if the rows get deleted before they would get frozen, you save the work of freezing them. If you decrease the parameter, rows get frozen earlier, so the time until anti-wraparound vacuum is necessary will increase. Yours, Laurenz Albe

Re: Warn against transaction level advisory locks for emulating "flat file" DBMS locking strategies

2021-09-08 Thread Laurenz Albe
. transaction level locks. erhaps you can explain your case in some more detail. Yours, Laurenz Albe -- Cybertec | https://www.cybertec-postgresql.com

Re: ddl-basics.html plural stuff

2021-07-15 Thread Laurenz Albe
well as in the plural in English. Yours, Laurenz Albe

Re: Minor doc fixes

2021-07-13 Thread Laurenz Albe
r proposed changes. > Unless > there are objections I'll apply this within a few days. The changes look good to me as well. Yours, Laurenz Albe

Re: [PATCH] add link to domain data types section from locale documentation

2021-07-29 Thread Laurenz Albe
On Fri, 2021-07-23 at 23:07 +0200, Jürgen Purtz wrote: > On 27.05.21 09:45, Laurenz Albe wrote: > > I like the new link from "src/sgml/charset.sgml", but I think that > > there are a few other places in the documentation that are likely to be > > read by people w

Re: Missing mention of autovacuum_work_mem

2021-09-23 Thread Laurenz Albe
On Wed, 2021-09-22 at 17:45 -0300, Euler Taveira wrote: > On Mon, Sep 20, 2021, at 10:40 AM, nikolai.berkoff wrote: > > Yes that reads better still. > I'm attaching a patch with Laurenz's words. Thanks, and +1 from me. Yours, Laurenz Albe

Re: Missing mention of autovacuum_work_mem

2021-09-20 Thread Laurenz Albe
autovacuum, autovacuum_work_mem) is insufficient to store the number of dead tuples found." Yours, Laurenz Albe -- Cybertec | https://www.cybertec-postgresql.com

Re: Correction for vacuum_multixact_failsafe_age

2021-10-12 Thread Laurenz Albe
the link is not essential, is it? Changing it might break existing outside links. Yours, Laurenz Albe

Re: small patch

2021-10-12 Thread Laurenz Albe
On Mon, 2021-10-11 at 23:14 -0400, rir wrote: > On Sun, Oct 10, 2021 at 04:15:01PM -0400, rir wrote: > > On Fri, Oct 08, 2021 at 02:47:43PM +0200, Laurenz Albe wrote: > > > On Thu, 2021-10-07 at 16:06 -0400, rir wrote: > > > > FETCH [ direction ] [ FROM | IN ] curso

Re: small patch

2021-10-08 Thread Laurenz Albe
an be removed. I think that would be a good idea, and it would add clarity. I remain of the opinion that the comments should be retained, but we can leave that for somebody else to decide. Do you want to prepare a new patch and register it in the commitfest? Yours, Laurenz Albe

Re: small patch

2021-10-11 Thread Laurenz Albe
On Sun, 2021-10-10 at 16:15 -0400, rir wrote: > On Fri, Oct 08, 2021 at 02:47:43PM +0200, Laurenz Albe wrote: > > On Thu, 2021-10-07 at 16:06 -0400, rir wrote: > > > > So I suggest that you change the syntax diagram to > > > > FETCH [ direction ] [ FROM | IN

Re: Remove unary operator documentation https://www.postgresql.org/docs/current/datatype-oid.html

2021-10-11 Thread Laurenz Albe
entioned. Do I understand > correctly that this relates to unary operators, which are removed in > postgres 14? Unary *postfix* operators have been removed, not *prefix* operators like "-". Yours, Laurenz Albe

Re: Missing mention of autovacuum_work_mem

2021-09-27 Thread Laurenz Albe
On Mon, 2021-09-27 at 09:25 +0900, Michael Paquier wrote: > On Sat, Sep 25, 2021 at 07:51:15AM +0900, Michael Paquier wrote: > > WFM. > > This has been applied and backpatched as of 1ba8410. Thank you! Yours, Laurenz Albe

Re: [PATCH] fix ICU explorer link in locale documentation

2021-09-29 Thread Laurenz Albe
On Mon, 2021-09-27 at 14:31 -0400, Bruce Momjian wrote: > On Fri, Sep  3, 2021 at 09:39:45PM +0200, Laurenz Albe wrote: > > On Thu, 2021-05-27 at 08:59 +0200, Laurenz Albe wrote: > > > On Thu, 2021-05-27 at 11:10 +0700, Anton Voloshin wrote: > > > > So I guess the h

Re: small patch

2021-10-06 Thread Laurenz Albe
On Wed, 2021-10-06 at 23:39 -0400, rir wrote: > On Mon, Oct 04, 2021 at 08:18:22AM +0200, Laurenz Albe wrote: > > On Fri, 2021-10-01 at 21:06 -0400, rir wrote: > > > Minor changes to move.sgml and fetch.sgml. > > > > > > The text 'or empty' is inconsistent

Re: small patch

2021-10-04 Thread Laurenz Albe
uld retain "empty or one of", otherwise the following syntax would be undocumented: FETCH FROM c; Yours, Laurenz Albe

Re: The pg_stop_backup will return one row with three values.

2021-12-20 Thread Laurenz Albe
>  ","") > > > Seems to be returning 7 values ? No, that is one value with 7 newlines in it. Yours, Laurenz Albe -- Cybertec | https://www.cybertec-postgresql.com

Re: Error in sample on doc page

2021-11-15 Thread Laurenz Albe
14 22:48:09] [42601] ERROR: syntax error at end of input > [2021-11-14 22:48:09] Position: 79 I don't get that error. Perhaps you inadvertently were on a continuation line in psql. Yours, Laurenz Albe

Re: Triggers on underlying tables of updatable views

2021-11-23 Thread Laurenz Albe
On Mon, 2021-11-22 at 21:02 +0100, Laurenz Albe wrote: > On Mon, 2021-11-22 at 19:54 +0100, Max Ziermann wrote: > > Am 22.11.21 um 16:41 schrieb Laurenz Albe: > > > On Mon, 2021-11-22 at 12:06 +, PG Doc comments form wrote: > > > > "Note that the user perf

Re: text fields and performance for ETL

2021-11-11 Thread Laurenz Albe
ike varchar(30) is cheaper than a check constraint Yours, Laurenz Albe

Re: Explicit or implicit?

2021-11-21 Thread Laurenz Albe
@@ 'query here' Right. You can skip the explicit conversion of adding a type cast. Yours, Laurenz Albe

Re: Triggers on underlying tables of updatable views

2021-11-22 Thread Laurenz Albe
rmissions of the user > performing an insert/update/delete on the view? But that is not the case: that trigger will be executed with the permissions of the owner of the underlying table. Yours, Laurenz Albe

Re: Triggers on underlying tables of updatable views

2021-11-22 Thread Laurenz Albe
On Mon, 2021-11-22 at 19:54 +0100, Max Ziermann wrote: > Am 22.11.21 um 16:41 schrieb Laurenz Albe: > > On Mon, 2021-11-22 at 12:06 +, PG Doc comments form wrote: > > > "Note that the user performing the insert, update or delete on the view > > > must >

Re: [PATCH] fix ICU explorer link in locale documentation

2021-11-02 Thread Laurenz Albe
On Mon, 2021-10-04 at 17:11 -0400, Bruce Momjian wrote: > Patch applied back to PG 10, where ICU was added.  Thanks everyone for > the work on this. Thanks! I think you can close the commitfest entry: https://commitfest.postgresql.org/35/3059/ Yours, Laurenz Albe

Re: text fields and performance for ETL

2021-11-05 Thread Laurenz Albe
;. Otherwise, you are usually better off with "text". Yours, Laurenz Albe

Re: text fields and performance for ETL

2021-11-05 Thread Laurenz Albe
gt; > that > > may exist for the data.  I believe comments with respect to the SQL standard > > are already present and adequate. > > Agreed. +1, so let's leave it as it is. Yours, Laurenz Albe

Re: Be more clear what names can be used for tables with "CREATE TABLE"?

2021-10-31 Thread Laurenz Albe
e row of the table. > Therefore, tables cannot have the same name as any existing data type in the > same schema." Technically speaking, it is "objects stored in pg_class". Perhaps we can refer to the documentation of "pg_class", which will in turn refer you to "relkind". Yours, Laurenz Albe

Re: Triggers on underlying tables of updatable views

2021-12-01 Thread Laurenz Albe
s SECURITY DEFINERs). You could send a documentation patch with your suggested wording. I agree that some more detail could be helpful. Yours, Laurenz Albe

Re: Indexes on Expressions - a note to remind users to run ANALYZE after creation

2021-07-19 Thread Laurenz Albe
ther than "is created", and I would say something less drastic like "usually a good idea" rather than "important". Yours, Laurenz Albe

  1   2   3   >