Re: psql option

2024-04-09 Thread Bruce Momjian
/current/app-psql.html > > > > > > Nice catch, will fix. > > Committed, turns out the stray comma has been there since 7.3, so backpatched > it all the way. Thanks for the report! Yikes! :-) -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: CREATE ROLE

2024-03-27 Thread Bruce Momjian
in the attached patch, applied back to PG 16 where this typo was created. Thanks for the report. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/ref/create_

Re: substring start position behavior

2024-03-26 Thread Bruce Momjian
On Tue, Mar 26, 2024 at 11:07:07AM -0400, Bruce Momjian wrote: > On Wed, Mar 6, 2024 at 12:42:09AM -0500, Tom Lane wrote: > > I'm kind of inclined to not document this weirdness. I especially > > don't think it's worth giving an example that neither explains the > >

Re: substring start position behavior

2024-03-26 Thread Bruce Momjian
etract my doc patch for this. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Minor typo in Section, 27.2.8.4.

2024-03-11 Thread Bruce Momjian
s missing the word "the" > as shown below .. > "Such transaction commits may never be completed if any one of THE > synchronous standbys should crash." Agreed, word "the" added to all supported versions. -- Bruce Momjian https://momjian.us EDB

Re: substring start position behavior

2024-03-05 Thread Bruce Momjian
ndexed. Sure, updated patch attached. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index e5fa82c161..f981793f00 1006

Re: substring start position behavior

2024-03-05 Thread Bruce Momjian
str-function Oracle doesn't have substring(), just substr(), and matches Informix behavior, I think. I have developed the attached doc patch to document this. The only question is whether this substring behavior is so odd that we should not document it. -- Bruce Momjian https://m

Re: CREATE ROLE inheritance details

2024-02-01 Thread Bruce Momjian
in the PG 16 minor release which will be packaged on Monday. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: CREATE ROLE inheritance details

2024-01-29 Thread Bruce Momjian
On Sun, Jan 28, 2024 at 10:11:18AM -0700, David G. Johnston wrote: > On Fri, Jan 26, 2024 at 5:18 PM Bruce Momjian wrote: >   > +        Role membership with the inherit attribute can automatically use > +        whatever database privileges have been granted

Re: CREATE ROLE inheritance details

2024-01-26 Thread Bruce Momjian
nt way. Patch attached. I also found we didn't document that GRANT can be used to modify a membership's attributes even after it is created; I added that. Just a reminder, this is for PG 16 and master. -- Bruce Momjian https://momjian.us EDB h

Re: CREATE ROLE inheritance details

2024-01-17 Thread Bruce Momjian
On Wed, Jan 17, 2024 at 09:28:38AM +0100, Laurenz Albe wrote: > On Tue, 2024-01-16 at 17:03 -0500, Bruce Momjian wrote: > > I am unhappy with the documentation adjustments made to CREATE ROLE in > > Postgres 16 by this commit: > > > > commit e3ce2de09d > >

CREATE ROLE inheritance details

2024-01-16 Thread Bruce Momjian
this information, and clarify it. I would like to apply this to PG 16 and master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. test_inh.sh Description: Bourne shell script test_inh.sql

Re: initdb username doc bug

2024-01-10 Thread Bruce Momjian
On Wed, Jan 10, 2024 at 06:05:17PM +0100, Álvaro Herrera wrote: > On 2024-Jan-10, Bruce Momjian wrote: > > > On Mon, Jan 8, 2024 at 04:50:19PM -0500, Tom Lane wrote: > > > Bruce Momjian writes: > > > > Agreed, updated patch attached. > > > > > &g

Re: initdb username doc bug

2024-01-10 Thread Bruce Momjian
On Mon, Jan 8, 2024 at 04:50:19PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > Agreed, updated patch attached. > > WFM. Patch applied back to PG 16, which is where the erroneous text was added. -- Bruce Momjian https://m

Re: initdb username doc bug

2024-01-08 Thread Bruce Momjian
tdb anyway. > > Or if you want a few more words, "name of the operating-system user > running initdb". I don't like "installation user", that's just about > as vague as could be. Agreed, updated patch attached. -- Bruce Momjian https://momjian.us ED

Re: initdb username doc bug

2024-01-06 Thread Bruce Momjian
On Sat, Jan 6, 2024 at 08:11:14PM -0700, David G. Johnston wrote: > On Saturday, January 6, 2024, Bruce Momjian wrote: > > This commit: > >         commit 910cab820d >         Author: Alvaro Herrera >         Date:   Fri Nov 18 11:59:26 2022 +0100 >

initdb username doc bug

2024-01-06 Thread Bruce Momjian
of the cluster owner. This seems wrong since the cluster owner doesn't exist until the cluster is created. The text exists in PG 16 and master. The attached patch fixes this. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you

Re: [DOCS] Add example about date ISO format

2023-12-26 Thread Bruce Momjian
On Thu, Dec 7, 2023 at 02:18:28PM -0500, Bruce Momjian wrote: > Yes, there were a few problems with my initial patch. First, I should > have used "Z" instead of a Z which could be interpreted as a format > specification; I had already done that for "T" in the exampl

Re: unclear wording re: spoofing prevention on network connections

2023-12-09 Thread Bruce Momjian
time. ... I have CC'ed the patch author. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: [DOCS] Confusing Trigger Docs.

2023-12-07 Thread Bruce Momjian
On Sun, Nov 26, 2023 at 08:59:02PM +0100, Laurenz Albe wrote: > On Fri, 2023-11-24 at 13:14 -0500, Bruce Momjian wrote: > > On Thu, Nov 23, 2023 at 08:36:34AM +0100, Laurenz Albe wrote: > > > On Wed, 2023-11-22 at 14:49 -0800, Peter Geoghegan wrote: > > > > I don't th

Re: SELECT ... FOR UPDATE OF clause documentation implies use of table_names rather than aliases

2023-12-07 Thread Bruce Momjian
On Mon, Nov 20, 2023 at 08:20:57PM -0700, David G. Johnston wrote: > On Mon, Nov 20, 2023 at 8:16 PM Bruce Momjian wrote: > > On Mon, Nov 20, 2023 at 07:19:39PM -0700, David G. Johnston wrote: > > The placement in the numbered listing section feels wrong, I am OK with >

Re: [DOCS] intagg.sgml: example wrongly named and does not compile

2023-12-07 Thread Bruce Momjian
On Wed, Nov 22, 2023 at 10:19:57AM +0100, Laurenz Albe wrote: > On Tue, 2023-11-21 at 22:27 -0500, Bruce Momjian wrote: > > I like this six year old patch so would like to apply it to master, > > attached. > > +1, since it is arguably a bug fix. Patch applied to master.

Re: [DOCS] Add example about date ISO format

2023-12-07 Thread Bruce Momjian
he time zone _name_ or even the offset from the AT TIME ZONE value, so we must just pass the literal "Z" from the input to the output. This proves Alvaro's point on this issue: SELECT pg_typeof(current_timestamp AT TIME ZONE 'America/Santiago'); pg_typeof

Re: [DOCS] Rewording for ALTER TABLE ... ADD table_constraint_using_index

2023-11-24 Thread Bruce Momjian
f. > I > like "convert" slightly better instead. Nine year old patch, but still valid, so applied to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: [DOCS] Confusing Trigger Docs.

2023-11-24 Thread Bruce Momjian
QL knowledge, like me. I moved the parition pagagraph to a more logical location and tried to clarify the new paragraph to be more targeted on the goal, patch attached. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only y

Re: [DOCS] Add example about date ISO format

2023-11-24 Thread Bruce Momjian
On Thu, Nov 23, 2023 at 09:29:39AM +0100, Laurenz Albe wrote: > On Wed, 2023-11-22 at 11:58 -0500, Bruce Momjian wrote: > > Okay, I moved it into the "Note" section that talked about ISO 8601 > > output with "T", in the attached patch. > > Fine by me,

Re: [DOCS] Double negation in parameter description

2023-11-22 Thread Bruce Momjian
ion may only be used on a populated materialized view.? > > Your clarification is much appreciated. I know this is six years old, but fixed in master with the attached patch. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com

Re: [DOCS] Confusing Trigger Docs.

2023-11-22 Thread Bruce Momjian
es, since those effects may have contributed to the row being excluded from insertion. I modified the attached patch to explain this since it is not really the same as modifying the actual row. Does that add any value? If not, let's remove it. -- Bruce Momjian https://momjian

Re: [DOCS] Add example about date ISO format

2023-11-22 Thread Bruce Momjian
". I originally thought it belonged in section 9.8 too, but I think the value of this example is ISO 8601 and I don't see how we can cleanly mention that in table 9.31. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: [DOCS] Add example about date ISO format

2023-11-22 Thread Bruce Momjian
. > > +1 for moving it to section 8.5.2. Okay, I moved it into the "Note" section that talked about ISO 8601 output with "T", in the attached patch. I will apply this only to master since it is not a correction. -- Bruce Momjian https://momjian.us

Re: [DOCS] Add example about date ISO format

2023-11-21 Thread Bruce Momjian
ed patch I would like to apply to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index 93f068edcf..297cafb341 10064

Re: [DOCS] intagg.sgml: example wrongly named and does not compile

2023-11-21 Thread Bruce Momjian
s. > > Ouch. Shows you how old this module is :-( > > Indeed. > > >> I propose the attached patch to fix that. > > Um, the attached file seems empty from here. > > Ooops, sorry. It is attached. I like this six year old patch so would like to apply it to m

Re: [DOCS] The reference to 'atacontrol' on FreeBSD is outdated.

2023-11-21 Thread Bruce Momjian
On Wed, Nov 22, 2023 at 03:25:07PM +1300, Thomas Munro wrote: > On Wed, Nov 22, 2023 at 2:12 PM Bruce Momjian wrote: > > On Sat, Aug 12, 2017 at 10:47:00PM +0100, John Ekins wrote: > > > Sure. Camcontrol does indeed cover IDE, SCSI and SAS drives. > > > > > >

Re: [DOCS] Confusing Trigger Docs.

2023-11-21 Thread Bruce Momjian
On Thu, Aug 31, 2017 at 09:22:22AM -0700, Peter Geoghegan wrote: > On Thu, Aug 31, 2017 at 6:25 AM, Bruce Momjian wrote: > > On Mon, Jul 3, 2017 at 08:07:10PM +, n...@fairwindsoft.com wrote: > >> The following documentation comment has been logged on the website: >

Re: [DOCS] The reference to 'atacontrol' on FreeBSD is outdated.

2023-11-21 Thread Bruce Momjian
Support Enabled Value Vendor > write cacheyes yes > > I appreciate the Postgresql docs are not meant to be FreeBSD tutorials. I know this email is six years old, but I have applied this fix to all supported Postgres versions. A huge apology

Re: Documentation of FOR ROLE clause of ALTER DEFAULT PRIVILEGES missing

2023-11-21 Thread Bruce Momjian
/sql-alterdefaultprivileges.html We felt the doc rewrite was too extensive to backpatch. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: SELECT ... FOR UPDATE OF clause documentation implies use of table_names rather than aliases

2023-11-20 Thread Bruce Momjian
;FOR UPDATE" so I missed that section; updated patch attached. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/ref/select.sgml b/doc/src/sgml/ref/selec

Re: SELECT ... FOR UPDATE OF clause documentation implies use of table_names rather than aliases

2023-11-20 Thread Bruce Momjian
i.e., an unaliased table name or an alias in the sibling FROM > clause attached to this level of the query).  I like this better anyway on the > grounds that the thing being referenced can be a subquery or a view as well as > a table. Okay, how is the attached patch? --

Re: SELECT ... FOR UPDATE OF clause documentation implies use of table_names rather than aliases

2023-11-17 Thread Bruce Momjian
x | x ---+--- SELECT * FROM test AS t1 JOIN test AS t2 ON (TRUE) FOR UPDATE OF t2; x | x ---+--- The attached patch documents this. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com

Re: Missing documentation for FETCH FIRST in chapter 7.6

2023-11-17 Thread Bruce Momjian
link to the LIMIT > section in the SELECT reference page. I also renamed the "number" > variables to the same names used in the SELECT reference page and put > OFFSET in a new line (it looks visually better). I applied the attached patch based on your p

Re: Documentation of return values of range functions lower and upper

2023-11-13 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 06:22:59PM -0400, Bruce Momjian wrote: > On Thu, Nov 2, 2023 at 03:42:53PM +0100, Laurenz Albe wrote: > > On Thu, 2023-11-02 at 10:14 -0400, Bruce Momjian wrote: > > > Better, though "Is the range's upper bound unbounded?" makes me cringe. &g

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-13 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 11:08:53AM -0400, Bruce Momjian wrote: > On Thu, Nov 2, 2023 at 09:58:54AM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > I found a cleaner improvement, attached. > > > > OK by me. Maybe that doesn't make the point strongly en

Re: Typo in documentation - runtime-config-wal

2023-11-09 Thread Bruce Momjian
is this correction accurate? It seems so to me. After flushing WAL the writer sleeps for the length of time given by wal_writer_delay, unless woken up sooner --> by an asynchronously committing transaction. -- Bruce Momjian https://momjian.us EDB

Re: WAL Configuration Grammar Fix

2023-11-09 Thread Bruce Momjian
This patch is 4.5 years old, but still valid. Fixed with the attached patch applied to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/wal.sgml

Re: User mapping security

2023-11-09 Thread Bruce Momjian
On Thu, Nov 9, 2023 at 05:03:33PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > On Tue, Jul 16, 2019 at 02:01:00AM +, PG Doc comments form wrote: > >> I suppose it should be warned on the pages that foreign credentials with be > >> stored as simple text and wi

Re: User mapping security

2023-11-09 Thread Bruce Momjian
s. I know this is four years old, but the attached patch documents it. I don't think postgresql-fdw needs it since it relies on user mapping and discourages passwords in the connection string. -- Bruce Momjian https://momjian.us EDB https://enterp

Re: readability changes to postgres.sgml

2023-11-08 Thread Bruce Momjian
his patch. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Required locks for ANALYZE

2023-11-08 Thread Bruce Momjian
t; > parallel with non-DDL activity on the table. I know this report is four years old, but attached patch applied to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Usage instructions for pg_hba.conf file

2023-11-03 Thread Bruce Momjian
On Sat, Oct 28, 2023 at 04:04:47PM -0400, Bruce Momjian wrote: > On Tue, Aug 2, 2022 at 08:08:07PM +, PG Doc comments form wrote: > > 21.1.1 Loading or Reloading the Configuration > > The pg_hba.conf file is read on start-up... > > Note: The preceding statement...

Re: "22.3. Template Databases" documentation is incomplete

2023-11-03 Thread Bruce Momjian
On Sat, Oct 28, 2023 at 03:14:32PM -0400, Bruce Momjian wrote: > On Sat, Oct 28, 2023 at 02:42:06PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > Sorry, I attached a _colorized_ diff; here is a normal one. > > > > The new sentence is fine in isolati

Re: Incorrect mention of number of columns?

2023-11-03 Thread Bruce Momjian
ugh to be useful. > > I am not speaking about a warning at creation time, but rather a warning in > the > docs. Something like: Although a table with e.g. 1600 bigint columns can be > created, creating a tuple of more than 8160 bytes will fail. It is in the "limits" docs:

Re: Document target_role param of ALTER DEFAULT PRIVILEGES

2023-11-03 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 09:51:58PM -0400, Bruce Momjian wrote: > On Wed, Nov 1, 2023 at 09:31:52PM +0100, Laurenz Albe wrote: > > There is another patch in the current commitfest that addresses a similar > > problem, triggered by another complaint: > > https://commitfest.p

Re: Document target_role param of ALTER DEFAULT PRIVILEGES

2023-11-02 Thread Bruce Momjian
On Wed, Nov 1, 2023 at 09:31:52PM +0100, Laurenz Albe wrote: > On Wed, 2023-11-01 at 13:09 -0400, Bruce Momjian wrote: > > On Thu, Feb 18, 2021 at 08:16:13AM +0100, Laurenz Albe wrote: > > > On Wed, 2021-02-17 at 15:08 -0500, Jordi Gutiérrez Hermoso wrote: > > > >

Re: Documentation of return values of range functions lower and upper

2023-11-02 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 03:42:53PM +0100, Laurenz Albe wrote: > On Thu, 2023-11-02 at 10:14 -0400, Bruce Momjian wrote: > > Better, though "Is the range's upper bound unbounded?" makes me cringe. > > > > Oh, yeah, totally cringe, me too.  :-) > > >

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-02 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 09:58:54AM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I found a cleaner improvement, attached. > > OK by me. Maybe that doesn't make the point strongly enough, > but we can hope it's enough. Agreed. I thought last night about the sentence an

Re: Documentation of return values of range functions lower and upper

2023-11-02 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 08:56:13AM +0100, Laurenz Albe wrote: > On Wed, 2023-11-01 at 18:03 -0400, Bruce Momjian wrote: > > On Wed, Nov 1, 2023 at 09:40:43PM +0100, Laurenz Albe wrote: > > > > Yes, I agree this documentation needs help. > > > > >

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-02 Thread Bruce Momjian
On Wed, Nov 1, 2023 at 07:34:59PM -0400, Bruce Momjian wrote: > On Wed, Nov 1, 2023 at 07:12:48PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > On Wed, Nov 1, 2023 at 06:32:37PM -0400, Tom Lane wrote: > > >> But it *is* permissible, unless we add code

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-01 Thread Bruce Momjian
On Wed, Nov 1, 2023 at 07:12:48PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Wed, Nov 1, 2023 at 06:32:37PM -0400, Tom Lane wrote: > >> But it *is* permissible, unless we add code to reject it during > >> SET as Bruce mentioned. Which seems fa

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-01 Thread Bruce Momjian
On Wed, Nov 1, 2023 at 06:32:37PM -0400, Tom Lane wrote: > "David G. Johnston" writes: > > On Wednesday, November 1, 2023, Bruce Momjian wrote: > >> Did you want an error from the SET command? > > > That would probably be a decent addit

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-01 Thread Bruce Momjian
ng at this email can can't see the problem: SET default_tablespace = 'pg_global'; CREATE TABLE test (x int); ERROR: only shared relations can be placed in pg_global tablespace Did you want an error from the SET command? -- Bruce Momjian https://momjian.us EDB

Re: Documentation of return values of range functions lower and upper

2023-11-01 Thread Bruce Momjian
ed for unknown or undefined values. > > I think it would be better to say "returns NULL if the range is empty or > unbounded" > and "is the range unbounded on the upper end?". I had to go with "Is the multirange's lower bound unbounded?" because the surroundi

Re: Documentation of return values of range functions lower and upper

2023-11-01 Thread Bruce Momjian
infinity]'::tstzrange); upper_inf --- f For upper/lower(), it is clear that the documentation is better saying "unspecified" rather than infinite. The fact that upper/lower_inf() returns false for +/-Infinity is quite odd, but should at least be documented.

Re: Document target_role param of ALTER DEFAULT PRIVILEGES

2023-11-01 Thread Bruce Momjian
for a parent role will not change the default privileges of > > objects created by inherited roles. > > +1. I cannot count the number of times I have seen people confused by that. > > Suggested patch attached. I see how people can be confused. I wrote this patch, which

Re: doc-fix-for-POSIX-Time-Zone-Specifications

2023-10-31 Thread Bruce Momjian
please be kind to share your thought with me. I think "the" was missing, so I added it: As an example, CET-1CEST,M3.5.0,M10.5.0/3 describes the current (as of 2020) timekeeping practice in Paris. This specification --- -- Bruce Mom

Re: Typo in "43.9.1. Reporting Errors and Messages"?

2023-10-31 Thread Bruce Momjian
0900 Fix inconsistencies and typos in the tree, take 10 This addresses some issues with unnecessary code comments, fixes various typos in docs and comments, and removes some orphaned structures and definitions.

Re: 'value' has special behaviour in alter system

2023-10-31 Thread Bruce Momjian
On Tue, Oct 24, 2023 at 02:36:14PM -0400, Bruce Momjian wrote: > On Tue, Oct 24, 2023 at 02:05:53PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > I have developed the attached patch to document this. > > > > This seems a little imprecise: > > >

Re: Usage instructions for pg_hba.conf file

2023-10-28 Thread Bruce Momjian
> Note: The preceding statement... > The system view pg_hba_file_rules can be helpful... This is a good point. I moved the reload sections for pg_hba.conf and pg_ident.conf up near the top of their sections in the attached patch. -- Bruce Momjian https://momjian.us EDB

Re: "22.3. Template Databases" documentation is incomplete

2023-10-28 Thread Bruce Momjian
On Sat, Oct 28, 2023 at 02:42:06PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Sorry, I attached a _colorized_ diff; here is a normal one. > > The new sentence is fine in isolation, but this doesn't feel like > a great spot to put it. The preceding several lines are a

Re: Intro enhancement proposal

2023-10-28 Thread Bruce Momjian
greed. I adjusted some of the links and applied the attached patch to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/intro.sgml b/doc/src/sgml/intro.sgml i

Re: "22.3. Template Databases" documentation is incomplete

2023-10-28 Thread Bruce Momjian
On Sat, Oct 28, 2023 at 12:18:50PM -0400, Bruce Momjian wrote: > On Tue, Aug 9, 2022 at 08:33:11PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/14/manag

Re: "22.3. Template Databases" documentation is incomplete

2023-10-28 Thread Bruce Momjian
; exist in the template. > > cf: https://www.postgresql.org/docs/13/manage-ag-templatedbs.html I have created the attached patch to document this. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Typo in docs for "recovery_init_sync_method" parameter.

2023-10-27 Thread Bruce Momjian
ing system to synchronize whole file systems that > contain the data directory... I ended up with this rewording, attached, and applied to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is

Re: Minor inconsistencies

2023-10-27 Thread Bruce Momjian
view. I liked all these improvements and applied a modified version of your patch to master, thanks. Sorry for the delay. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: [very minor] Documentation suggestion

2023-10-27 Thread Bruce Momjian
ser] catalog table. but it still needs help ;-) Here is the text I just applied: Note that these commands can cause deadlocks not only for the system catalog tables listed above but for other catalog tables. Attached is the applied patch to master. -- Bruce Momjian

Re: First Person (I) Should be avoided

2023-10-27 Thread Bruce Momjian
> $ # I wonder what file 155173 is ... > > suggested change: > $ # what Postgres object does file 155173 represent ... Fixed with the attached, applied patch to master. -- Bruce Momjian https://momjian.us EDB https://enterpri

Re: Getting started

2023-10-24 Thread Bruce Momjian
superuser. I looked at this and initdb is mentioned in the installation section, and an incorrect user name is mentions as part of craetedb failure. I don't see what we can add to improve things here. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: 'value' has special behaviour in alter system

2023-10-24 Thread Bruce Momjian
On Tue, Oct 24, 2023 at 02:05:53PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I have developed the attached patch to document this. > > This seems a little imprecise: > > + Values with non-alphanumeric characters must be quoted. > > I think ac

Re: 'value' has special behaviour in alter system

2023-10-24 Thread Bruce Momjian
"b x", c'; .conf listen_addresses = 'a, "b x", c' Do we want to retain this difference in list processing? I have developed the attached patch to document this. -- Bruce Momjian https://momjian.us EDB https://enterp

Re: pg_upgrade doc uses inconsistent versions within the doc.

2023-10-10 Thread Bruce Momjian
On Wed, Sep 27, 2023 at 09:42:49AM +0200, Daniel Gustafsson wrote: > > On 26 Sep 2023, at 22:26, Bruce Momjian wrote: > > On Tue, Sep 26, 2023 at 10:56:27AM -0700, David G. Johnston wrote: > > >> I would get rid of any mentions of our old pre-v10 versioning sc

Re: Make SSPI documentation clearer

2023-10-10 Thread Bruce Momjian
On Thu, Sep 28, 2023 at 09:55:43AM -0400, Bruce Momjian wrote: > On Wed, Sep 27, 2023 at 07:09:02PM -0400, Bruce Momjian wrote: > > On Sun, Mar 12, 2023 at 08:36:53PM -0400, Stephen Frost wrote: > > > > When the server is on a non-Windows platform then the server mus

Re: Suggestion for deprecated spellings

2023-10-10 Thread Bruce Momjian
On Wed, Sep 27, 2023 at 08:17:54PM -0400, Bruce Momjian wrote: > On Mon, Jan 30, 2023 at 04:17:14PM -0500, Bruce Momjian wrote: > > On Mon, Jan 30, 2023 at 04:07:46PM -0500, Tom Lane wrote: > > > Bruce Momjian writes: > > > > On Thu, Jan 26, 2023 at 12:19:29PM +00

Re: Certificate authentication docs in multiple places

2023-10-10 Thread Bruce Momjian
On Wed, Sep 27, 2023 at 05:28:04PM -0400, Bruce Momjian wrote: > On Tue, Mar 28, 2023 at 04:28:24PM +0200, Peter Eisentraut wrote: > > On 23.03.23 14:33, Steve Atkins wrote: > > > A couple of times recently I’ve been chatting with someone about using > > > certificate a

Re: Seeming contradiction in 22.1

2023-10-10 Thread Bruce Momjian
On Wed, Sep 27, 2023 at 06:11:44PM -0400, Bruce Momjian wrote: > On Thu, Mar 23, 2023 at 05:45:03PM +0100, maja zaloznik wrote: > > Thanks David, this is very helpful! > > > > I would have to agree with Tom, that while technically true, the text could > &

Re: ODBC options

2023-10-06 Thread Bruce Momjian
at where I can post that? > > Spreadsheet is here if anyone wants to look at it. > https://www.dropbox.com/scl/fi/v1uj1umtj20k1ljenodvy/ > psqlODBC-Configuration-Options.xlsx?rlkey=fit9kbgy0fv0fr9vt0u0a9oim=0 Please see: https://odbc.postgresql.org/faq.html#1.6

Re: Do we really want to mention 8.3 in current versions of the docs?

2023-09-29 Thread Bruce Momjian
quot; > > The examples seem to be more or less fine,. Agreed. Removed in the attached applied patch. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/

Re: The documentation for storage type 'plain' actually allows single byte header

2023-09-29 Thread Bruce Momjian
-456,9 +456,7 @@ for storing TOAST-able columns on disk: > > >PLAIN prevents either compression or > - out-of-line storage; furthermore it disables use of single-byte headers > - for varlena types. > - This is the o

Re: Make SSPI documentation clearer

2023-09-28 Thread Bruce Momjian
On Wed, Sep 27, 2023 at 07:09:02PM -0400, Bruce Momjian wrote: > On Sun, Mar 12, 2023 at 08:36:53PM -0400, Stephen Frost wrote: > > > When the server is on a non-Windows platform then the server must use > > > GSSAPI > > > if it wants to authenticate the client eit

Re: Suggestion for deprecated spellings

2023-09-27 Thread Bruce Momjian
On Mon, Jan 30, 2023 at 04:17:14PM -0500, Bruce Momjian wrote: > On Mon, Jan 30, 2023 at 04:07:46PM -0500, Tom Lane wrote: > > Bruce Momjian writes: > > > On Thu, Jan 26, 2023 at 12:19:29PM +, PG Doc comments form wrote: > > >> From time to time some spelling f

Re: MERGE examples not clear

2023-09-27 Thread Bruce Momjian
e here...source_alias (...completely hides...the fact that a query was > issued).  What?  Probably it should read (not verified) that it is actually > required when the source is a query (maybe tweaking the syntax to match). The attached patch removes the second example, which does

Re: Mistake in statement example

2023-09-27 Thread Bruce Momjian
d a "second" transaciton, I changed the account number so I can talk about the second statement, because read committed changes the row visibility of the non-first statements, and I changed "transaction" to "statement". -- Bruce Momjian https://momjian.us

Re: Make SSPI documentation clearer

2023-09-27 Thread Bruce Momjian
n authenticate to a server which > is using either SSPI or GSSAPI, and a GSSAPI client can authenticate to > a server which is using either SSPI or GSSAPI. Generally speaking, > clients and servers on Windows are recommended to use SSPI while clients > and servers on Unix (non-Windows

Re: Seeming contradiction in 22.1

2023-09-27 Thread Bruce Momjian
way it avoids the passive tense which leaves some ambiguity as to who or > what and when is naming this superuser. I think the paragraph was trying to do too much so I simplified it, patch attached. -- Bruce Momjian https://momjian.us EDB

Re: Certificate authentication docs in multiple places

2023-09-27 Thread Bruce Momjian
to find it while thinking about > > authentication. > > > > Should we add a link from the former to the latter? > > Sure, some cross-linking between those two sections seems sensible. Attached is a patch which accomplishes this. -- Bruce Momjian https://momjian.us EDB

Re: Incorrect/confusing information about timetz

2023-09-26 Thread Bruce Momjian
On Thu, Sep 7, 2023 at 05:00:59PM -0400, Bruce Momjian wrote: > On Thu, Sep 7, 2023 at 04:41:48PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > Uh, yes to the storage part, no to the output part. ;-) Postgres does > > > store the timetz time zone offset, b

Re: group by can use alias from select list

2023-09-26 Thread Bruce Momjian
On Thu, Sep 7, 2023 at 10:11:00AM -0400, Bruce Momjian wrote: > We do farther down the docs in the GROUP BY section: > > https://www.postgresql.org/docs/devel/sql-select.html > > GROUP BY will condense into a single row all selected rows that share >

Re: pg_upgrade doc uses inconsistent versions within the doc.

2023-09-26 Thread Bruce Momjian
On Tue, Sep 26, 2023 at 10:56:27AM -0700, David G. Johnston wrote: > On Tue, Sep 26, 2023 at 10:35 AM Bruce Momjian wrote: > > On Mon, Sep 18, 2023 at 08:14:04PM +, PG Doc comments form wrote: > > The following documentation comment has been logged

Re: correct documentation in set role

2023-09-26 Thread Bruce Momjian
On Tue, Sep 26, 2023 at 11:44:42AM -0400, Bruce Momjian wrote: > On Mon, Sep 25, 2023 at 07:46:18AM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/16/sql-set-role

Re: pg_upgrade doc uses inconsistent versions within the doc.

2023-09-26 Thread Bruce Momjian
d since the catalog version is not accessible from SGML, it will usually not match the major version's catalog number. I would apply this only to Postgres 17 since it isn't really a fix. -- Bruce Momjian https://momjian.us EDB https://enterprisedb

Re: correct documentation in set role

2023-09-26 Thread Bruce Momjian
e_name must be a role that the current session user is a > member of "and has SET True option on it." > The second part missed in documentation for set role command. Good point. How is the attached patch? -- Bruce Momjian https://momjian.us EDB

Re: Remove obsolete mention of backslashes as escapes

2023-09-08 Thread Bruce Momjian
for specifying string constants is usually > convenient, it can be difficult to understand when the desired string > - contains many single quotes or backslashes, since each of those must > + contains many single quotes, since each of those must > be doubled. To allow mor

  1   2   3   4   5   6   7   >