Re: readability changes to postgres.sgml

2023-11-08 Thread Joshua Drake
Blink... thanks! and also for the tips. On Wed, Nov 8, 2023 at 1:48 PM Bruce Momjian wrote: > On Mon, Aug 19, 2019 at 04:00:13PM -0700, Joshua D. Drake wrote: > > Team, > > > > New version attached with spelling errors fixed. > > After four years, patch applied to master. I know reviews had

Re: readability changes to postgres.sgml

2023-11-08 Thread Bruce Momjian
On Mon, Aug 19, 2019 at 04:00:13PM -0700, Joshua D. Drake wrote: > Team, > > New version attached with spelling errors fixed. After four years, patch applied to master. I know reviews had trouble reviewing this, and I found git diff --word-diff=color to be very helpful for this patch. --

Re: readability changes to postgres.sgml

2019-08-20 Thread Joshua D. Drake
On 8/19/19 10:36 PM, Erik Rijkers wrote: On 2019-08-20 07:05, Michael Paquier wrote: On Mon, Aug 19, 2019 at 04:00:13PM -0700, Joshua D. Drake wrote: New version attached with spelling errors fixed. I have gone through this patch, and I have a hard time understanding why these are

Re: readability changes to postgres.sgml

2019-08-19 Thread Erik Rijkers
On 2019-08-20 07:05, Michael Paquier wrote: On Mon, Aug 19, 2019 at 04:00:13PM -0700, Joshua D. Drake wrote: New version attached with spelling errors fixed. I have gone through this patch, and I have a hard time understanding why these are improvements over the existing wording. In what

Re: readability changes to postgres.sgml

2019-08-19 Thread Michael Paquier
On Mon, Aug 19, 2019 at 04:00:13PM -0700, Joshua D. Drake wrote: > New version attached with spelling errors fixed. I have gone through this patch, and I have a hard time understanding why these are improvements over the existing wording. In what does this make things better? -- Michael

Re: readability changes to postgres.sgml

2019-08-19 Thread Joshua D. Drake
Team, New version attached with spelling errors fixed. -- Command Prompt, Inc. || http://the.postgres.company/ || @cmdpromptinc Postgres centered full stack support, consulting and development. Advocate: @amplifypostgres || Get help: https://commandprompt.com/ * Unless otherwise stated,

Re: readability changes to postgres.sgml

2019-08-19 Thread Joshua D. Drake
On 8/15/19 5:26 PM, Stephen Frost wrote: Specifically- Welcome to the PostgreSQL Tutorial. The -following few chapters are intended to give a simple introduction +tutorial is intended to give an introduction to PostgreSQL, relational database I disagree with removing

Re: readability changes to postgres.sgml

2019-08-19 Thread Joshua D. Drake
On 8/16/19 10:41 AM, Liudmila Mantrova wrote: For what it's worth, I think the proposed changes are all solid improvements. The text reads better with them, and that's what this is about -- not whether the removed little text-pieces were 'true' or not. If we want to make

Re: readability changes to postgres.sgml

2019-08-19 Thread Joshua D. Drake
On 8/15/19 10:22 PM, Erik Rijkers wrote: On 2019-08-16 02:26, Stephen Frost wrote: Greetings, * Joshua D. Drake (j...@commandprompt.com) wrote: attached they seem to be simply removing words and removing content that is For what it's worth, I think the proposed changes are all solid

Re: readability changes to postgres.sgml

2019-08-16 Thread Erik Rijkers
On 2019-08-16 07:22, Erik Rijkers wrote: On 2019-08-16 02:26, Stephen Frost wrote: Greetings, * Joshua D. Drake (j...@commandprompt.com) wrote: attached they seem to be simply removing words and removing content that is For what it's worth, I think the proposed changes are all solid

Re: readability changes to postgres.sgml

2019-08-16 Thread Liudmila Mantrova
> > For what it's worth, I think the proposed changes are all solid > improvements. The text reads better with them, and that's what this is > about -- not whether the removed little text-pieces were 'true' or not. > > I'm afraid I can't agree that all changes are good enough (e.g. "start with

Re: readability changes to postgres.sgml

2019-08-15 Thread Erik Rijkers
On 2019-08-16 02:26, Stephen Frost wrote: Greetings, * Joshua D. Drake (j...@commandprompt.com) wrote: attached they seem to be simply removing words and removing content that is For what it's worth, I think the proposed changes are all solid improvements. The text reads better with

Re: readability changes to postgres.sgml

2019-08-15 Thread Stephen Frost
Greetings, * Joshua D. Drake (j...@commandprompt.com) wrote: > attached While I'm all for working on improving the documentation and, in particular, our tutorials, the above description of what the suggested change is seems to be rather.. lacking, and the changes themselves don't come across as

readability changes to postgres.sgml

2019-08-15 Thread Joshua D. Drake
attached Thanks, JD -- Command Prompt, Inc. || http://the.postgres.company/ || @cmdpromptinc Postgres centered full stack support, consulting and development. Advocate: @amplifypostgres || Get help: https://commandprompt.com/ * Unless otherwise stated, opinions are my own. *