[DOCS] Fix some typos

Hello, Please consider committing the attached patches for docs. (One of them is affecting a comment in src/.) Also I found some inconsistent spellings of the names, but I'm not sure whether it should be fixed: 1. "Hans-Jurgen Schonig" and "Hans-Juergen Schoenig". Maybe it's better to spell

Re: [DOCS] with

Hello Alvaro, These duplicate entries caused by the zone attribute. If you'll remove it, you'll get only single entry (in secondary line). It seems that the following DocBook bugfix introduced the bug you encountered: https://github.com/docbook/xslt10-stylesheets/commit/f555842b I see the fol

Re: [DOCS] PDF building with FOP

Hello Peter, 11.03.2017 05:25, Peter Eisentraut wrote: The questions for those who are building PDFs are - Can you make the build work? - Does the output look OK? Yes, we use FOP build to generate all the PDF's for current versions (starting with 9.5). Output looks ok, though we need to use e

Re: [DOCS] PDF building with FOP

Hello Alvaro, 11.03.2017 06:19, Alvaro Herrera wrote: - Does the output look OK? It looks generally sane in a very quick skim, modulo the problems we've always had with PDFs, such as tables 9-44 and 9-45 being completely unusable. We at postgrespro added custom XSL (see pg-customize-fo.xsl in p

Re: [DOCS] Docbook 5.x

Hello Peter, 16.11.2016 14:30, Alexander Law wrote: So It seems, now we can continue the move to XML. I'd suggest to move in several steps. Please see the attached scripts. The main script is 7_check_conversion.sh. It performs all the conversion and checks whether the html output is the

Re: [DOCS] [HACKERS] switching documentation build to XSLT

Hello, It seems that there is some post-processing after `make html` that adds class = "c1" or class = "c2" to html. (It makes or ) And docs.css on the website contains the rule: .emphasis, .c2 { font-weight: bold; } So I think, the issue is related to publishing on the website. Best regards

Re: [DOCS] [HACKERS] switching documentation build to XSLT

Hello, The attached patch fixes this. Best regards, Alexander 22.11.2016 21:47, Tom Lane пишет: I wrote: I notice that whereas used to generate text like Section 4.1.2.7 now you get Section 4.1.2.7, “Constants of Other Types” I also find that for some reason, the results are

Re: [DOCS] [HACKERS] switching documentation build to XSLT

Hello, Attached patches fix the issues. I wrote about these differences before -- see issues 12 and 20 in http://oc.postgrespro.ru/index.php/s/Gj2PGZ9IHUbDC5t/download (See https://www.postgresql.org/message-id/4ffd72d6-8ab6-37c6-d7d5-dfed8967c0fc%40gmail.com) If you find that some other differ

[DOCS] Performance optimization for make postgres.epub

Hello, Please look at the attached patch to speedup (~5x) `make postgres.epub`. The optimization is similar to the previous one designed for xhtml. Additional script attached to prove that the result of modified XSL transformations is the same. Best regards, Alexander 7_check_epub-speedup-p

Re: [DOCS] Docbook 5.x

Hello Peter, I saw that you committed the patch to switch the html build to XSLT by default. So It seems, now we can continue the move to XML. I'd suggest to move in several steps. Please see the attached scripts. The main script is 7_check_conversion.sh. It performs all the conversion and che

Re: [DOCS] Docbook 5.x

Hello Peter, I think it's time to switch to XSLT. We at Postgres Pro already build (converted to XML) and publish the docs (for version 9.6, in English and Russian) and we've got only one bug report related to the header/navigation differences. (See https://postgrespro.com/docs/postgresql/9.6/

Re: [DOCS] Docbook 5.x

Hello, I've modified XSL's to eliminate most undesired differences between `make html` and `make xslthtml` outputs. The patch attached. See http://oc.postgrespro.ru/index.php/s/Gj2PGZ9IHUbDC5t/download (eliminated differences marked cyan). What should we do next to finish with the "Port all DSS

[DOCS] Several fixes for parallel.sgml

Hello, Please consider committing a couple of corrections for parallel.sgml. Best regards, Alexander diff --git a/doc/src/sgml/parallel.sgml b/doc/src/sgml/parallel.sgml index c80d42d..b8f33b3 100644 --- a/doc/src/sgml/parallel.sgml +++ b/doc/src/sgml/parallel.sgml @@ -148,7 +148,7 @@ EXPLAIN SE

Re: [DOCS] Docbook 5.x

14.09.2016 19:41, Alvaro Herrera wrote: Alexander Law wrote: 14.09.2016 18:30, Alvaro Herrera wrote: What's up with 30? ecpg.sgml contains "The scope of the allocated descriptor is WHAT?.", which is printed with XSLT but ignored with DSSSL. Maybe we can just remove such re

Re: [DOCS] Docbook 5.x

Hello Alvaro, 14.09.2016 18:30, Alvaro Herrera wrote: What's up with 30? ecpg.sgml contains "The scope of the allocated descriptor is WHAT?.", which is printed with XSLT but ignored with DSSSL. Maybe we can just remove such remarks. I found only two of them, other one in dml.sgml: Data

Re: [DOCS] Docbook 5.x

Hello Jürgen, 14.09.2016 16:05, Jürgen Purtz wrote: For me the following topics are ok: 18, 19, 22, 37. The problem with 37 is that such flat numbering present only in refentry. Other sections (sect1, sect2) have independent numbering. So you can't find "Table 236", but you can find "Table 27.2.

Re: [DOCS] Docbook 5.x

Hello, Peter. Should we now compare DSSSL outputs with XSLT? I had some success with it before. See my letter: https://www.postgresql.org/message-id/57712848.7060306%40gmail.com Those xslt's (see xhtml-like-dsssl.patch) can help us to see all the differences and to decide which customizations to

[DOCS] Incorrect case in functions-textsearch

Hello, Please consider fixing the case that is out of line with the other descriptions in functions-textsearch.sgml. Patch attached. Best regards, Alexander diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index 5148095..47fcb30 100644 --- a/doc/src/sgml/func.sgml +++ b/doc/src/s

[DOCS] A typo in the docs

Hello, Please consider fixing a typo in pgtrm.sgml. Patch attached. Best regards, Alexander diff --git a/doc/src/sgml/pgtrgm.sgml b/doc/src/sgml/pgtrgm.sgml index d362b03..775a7b8 100644 --- a/doc/src/sgml/pgtrgm.sgml +++ b/doc/src/sgml/pgtrgm.sgml @@ -104,7 +104,7 @@ the second string a

[DOCS] Invalid field name in RLS description

Hello, It seems, that the RLS description supposes that the users table contains the field "user", but it's a reserved keyword. Patch attached. (The replacement "user_name" selected as corresponding to the following examples). Best regards, Alexander diff --git a/doc/src/sgml/ddl.sgml b/doc/

Re: [DOCS] Incorrect 'literal' tags

Hello, I believe that the 'replaceable' tag should be used for keywords that intended to be replaced with some values, but 'literal' is for literal usage. But there are some places in the docs where 'literal' is used for replaceable values. Patch attached. Patch applied and backpatched to 9.6.

Re: [DOCS] UTF-8 docs

24.08.2016 09:58, Tatsuo Ishii пишет: Please look at the attached .pot for one of the doc files. You can use any translation software (which supports .po (e.g. poedit, Lokalize, ...)) to translate it to any language. And you can look at all the docs converted to .po for translation: http://oc.po

Re: [DOCS] UTF-8 docs

Hello, 24.08.2016 02:19, Tatsuo Ishii пишет: We at Postgres Pro using the gettext technologies for this. And we have complete working toolchain (including modified Makefile) for translation the docs. Sounds great but I am not sure if the technique can be applied to any language including Japanes

Re: [DOCS] UTF-8 docs

Hello, If I understand you right, your goal to change the docs encoding is to allow for the docs translation. But I don't think that the translation should be done that way (with replacing sgml/xml/whatever). Just as we don't translate server messages by copying all the source files and replaci

Re: [DOCS] Docbook 5.x

Hello, The next items in our plan were: An immediate problem is that the patched stuff no longer works with older stylesheets (1.76.1?). I'm glad to leave older stuff behind for a 400% speedup, but we need to analyze the exact effect and possibly document it or work around it. Please consider c

[DOCS] UTF-8 docs

Hello, I've just seen a discussion about docs endoding in pgsql-hackers. https://www.postgresql.org/message-id/20160822.141645.655870136709055853.t-ishii%40sraoss.co.jp Can we continue the discussion in this mailing list? We (at Postgres Pro) have developed the whole build chain (with support fo

Re: [DOCS] Docbook 5.x

8:28 AM, Peter Eisentraut wrote: On 6/4/16 10:28 AM, Alexander Law wrote: It caused by . Leaving aside the question whether the links "home", "up" and "copyright" are needed, maybe it's better to split the commit to two? First to speed up the conversion while

[DOCS] Incorrect 'literal' tags

Hello, While translating docs I encountered an inconsistency with the literal/replaceable Docbook tags. I believe that the 'replaceable' tag should be used for keywords that intended to be replaced with some values, but 'literal' is for literal usage. But there are some places in the docs wh

[DOCS] Several repeated words

Hello, There are some occurrences of repeated words in the docs. Patches attached. Also, please consider fixing 'and and' and 'the the' in the source code and regression test comments. Best regards, Alexander diff --git a/doc/src/sgml/runtime.sgml b/doc/src/sgml/runtime.sgml index 66fbe44..6

[DOCS] Outdated sentence in the pg_am description

Hello, It seems, that the pg_am description contains a sentence that is not valid anymore. Patch attached. Best regards, Alexander diff --git a/doc/src/sgml/indexam.sgml b/doc/src/sgml/indexam.sgml index b59cd03..0704926 100644 --- a/doc/src/sgml/indexam.sgml +++ b/doc/src/sgml/indexam.sgml @

[DOCS] Probably wrong word in information_schema.sgml

Hello, It seems that the udt_privileges view' description contains an incorrect copy-pasted word. Fix attached. Best regards, Alexander diff --git a/doc/src/sgml/information_schema.sgml b/doc/src/sgml/information_schema.sgml index ca1f20b..85db4d3 100644 --- a/doc/src/sgml/information_schema.sg

[DOCS] 'Do not not' in pg_receivexlog.sgml and pg_recvlogical.sgml

Hello, There are typos in --create-slot option description. Patch attached. Best regards, Alexander diff --git a/doc/src/sgml/ref/pg_receivexlog.sgml b/doc/src/sgml/ref/pg_receivexlog.sgml index 5ac1f4d..bfa055b 100644 --- a/doc/src/sgml/ref/pg_receivexlog.sgml +++ b/doc/src/sgml/ref/pg_receivex

Re: [DOCS] Some minor error fixes

ld rerun all the benchmarks and update all the numbers (see commit d6464fdc). Best wishes, Alexander 15.07.2016 05:36, Peter Eisentraut пишет: On 5/14/16 2:23 AM, Alexander Law wrote: Please look at the following errors/fixes. I've applied 2, 3, 4, 5. 1 was correct according to my ma

[DOCS] Incorrect 'last' adjective in pgbench.sgml

Hello, Log format description in pgbench.sgml describes min_latency and max_latency as last two fields, but they are not last nowadays. Patch attached. Best regards, Alexander diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgbench.sgml index f3afedb..323f2c7 100644 --- a/doc/sr

[DOCS] Invalid reference to ForkNumber enum

Hello, There is an invalid reference to ForkNumber definition (from commit f71939cd). It was defined in relfilenode.h at time of the commit (https://github.com/postgres/postgres/blob/f71939cd/src/include/storage/relfilenode.h), but now it's defined in relpath.h (https://github.com/postgres/po

[DOCS] A hyphen missing in runtime.sgml

Hello, I've found a hyphen missing in runtime.sgml. Patch attached. Best regards, Alexander diff --git a/doc/src/sgml/runtime.sgml b/doc/src/sgml/runtime.sgml index 6d39ce7..90def00 100644 --- a/doc/src/sgml/runtime.sgml +++ b/doc/src/sgml/runtime.sgml @@ -184,7 +184,7 @@ postgres$ initdb -D /usr

[DOCS] A typo in fdwhandler.sgml

Hello, There is a typo in fdwhandler.sgml. Patch attached. Best regards, Alexander diff --git a/doc/src/sgml/fdwhandler.sgml b/doc/src/sgml/fdwhandler.sgml index 4cd79f3..9137a96 100644 --- a/doc/src/sgml/fdwhandler.sgml +++ b/doc/src/sgml/fdwhandler.sgml @@ -854,7 +854,7 @@ void EndDirectMod

[DOCS] A mess with the BRIN's inclusion strategies

Hello, As I can see from stratnum.h and brin_inclusion.c, two operator strategies for BRIN inclusion opclass are messed in docs. Patch attached. Best regards, Alexander diff --git a/doc/src/sgml/brin.sgml b/doc/src/sgml/brin.sgml index 245ec5d..31384b4 100644 --- a/doc/src/sgml/brin.sgml +++ b

[DOCS] Invalid statement in ref/insert.sgml

Hello, It seems, that the statement "INSERT ... ON CONFLICT DO UPDATE tab SET table_name.col = 1" is invalid in two ways. Patch attached. Maybe it's worth to replace "UPDATE tab SET tab.col = 1" with "UPDATE table_name SET table_name.col = 1" in ref/update.sgml (for consistency) too. Best reg

[DOCS] A typo in install-windows.sgml

Hello, There is a typo in install-windows,sgml. Patch attached. Best regards, Alexander diff --git a/doc/src/sgml/install-windows.sgml b/doc/src/sgml/install-windows.sgml index 4e92cc9..8cd189c 100644 --- a/doc/src/sgml/install-windows.sgml +++ b/doc/src/sgml/install-windows.sgml @@ -84,7 +84,7

[DOCS] Missing parenthesis in backup.sgml

Hello, Closing parenthesis missing in backup.sgml. Patch attached. Best regards. Alexander diff --git a/doc/src/sgml/backup.sgml b/doc/src/sgml/backup.sgml index 96fc9a0..0f09d82 100644 --- a/doc/src/sgml/backup.sgml +++ b/doc/src/sgml/backup.sgml @@ -830,7 +830,7 @@ test ! -f /mnt/server/archiv

Re: [DOCS] Docbook 5.x

Hello, I have some progress with the "Port all DSSSL customizations to XSLT" step. I still think that we should avoid manual comparison of old and new outputs when we can align them and have all differences observable, countable and manageable. I had developed XSLT's that allows us to do it. P

Re: [DOCS] Docbook 5.x

ne, we can ensure that output is the same by automatic means. (See my letter: https://www.postgresql.org/message-id/56337365.2080104%40postgrespro.ru) Best regards, Alexander 06.06.2016 15:28, Peter Eisentraut пишет: On 6/4/16 10:28 AM, Alexander Law wrote: It caused by . Leaving aside the questi

Re: [DOCS] Docbook 5.x

ome", "up" and "copyright" are needed, maybe it's better to split the commit to two? First to speed up the conversion while making sure that the output is the same, and the second to change the html.head output format. Best regards, Alexander 03.06.2016

Re: [DOCS] Docbook 5.x

Hello Jürgen, We started to work on the conversion: http://www.postgresql.org/message-id/56337365.2080...@postgrespro.ru And now we (at PostgresPro) are going to continue this work. I think we should do it together to avoid redundant work. Best regards, Alexander 13.05.2016 21:01, Peter Eisentr

Re: [DOCS] Some minor error fixes

-TABLE [3] https://github.com/postgres/postgres/commit/d6464fdc0a591662e5e5ee1b0303932e89cb027c [4] http://www.postgresql.org/docs/9.1/static/pgcrypto.html#PGCRYPTO-HASH-SPEED-TABLE Best regards, Alexander 14.05.2016 04:41, Peter Eisentraut пишет: On 5/4/16 3:04 PM, Alexander Law wrote: Than

Re: [DOCS] Some minor error fixes

-TABLE [3] https://github.com/postgres/postgres/commit/d6464fdc0a591662e5e5ee1b0303932e89cb027c [4] http://www.postgresql.org/docs/9.1/static/pgcrypto.html#PGCRYPTO-HASH-SPEED-TABLE Best regards, Alexander 14.05.2016 04:41, Peter Eisentraut пишет: On 5/4/16 3:04 PM, Alexander Law wrote: Than

Re: [DOCS] Docbook 5.x

Hello Peter, I fully support your plan and going to move this way. Best regards, Alexander 05.05.2016 04:09, Peter Eisentraut пишет: On 5/4/16 11:08 AM, Alexander Law wrote: As was stated in the aforementioned thread, solution 2 can be much (8x) faster with some xslt optimizations, but I

Re: [DOCS] Docbook 5.x

Done (previous patch cleaned). This patch optimizes XSL transformations contained in docbook-xsl (1.78.1). Tested with 9.5.2 time make html real1m21.989s user1m21.392s sys 0m0.484s 1) time make xslthtml (before the patch) real29m19.904s user29m18.804s sys 0m0.888s 2) tim

Re: [DOCS] Some minor error fixes

5/4/16 10:40 AM, Alexander Law wrote: Please have a look at the some more errors. Regarding second patch, I think, that inconsistency should be fixed by omitting '_name', as this parameter could also include a password. fixed diff --git a/doc/src/sgml/gin.sgml b/doc/src/sgml/gi

Re: [DOCS] Docbook 5.x

04.05.2016 19:52, Jürgen Purtz пишет: On 04.05.2016 17:08, Alexander Law wrote: As was stated in the aforementioned thread, solution 2 can be much (8x) faster with some xslt optimizations, but I think now we should outline some roadmap before we start to prepare patches and so. Maybe we

Re: [DOCS] Docbook 5.x

Hello Alvaro, 04.05.2016 18:21, Alvaro Herrera wrote: Alexander Law wrote: Hello Jürgen, As was stated in the aforementioned thread, solution 2 can be much (8x) faster with some xslt optimizations, but I think now we should outline some roadmap before we start to prepare patches and so. Can

Re: [DOCS] Docbook 5.x

Hello Jürgen, As was stated in the aforementioned thread, solution 2 can be much (8x) faster with some xslt optimizations, but I think now we should outline some roadmap before we start to prepare patches and so. Maybe we should convert to XML with DocBook4 at first step? Then, once we get eve

Re: [DOCS] Some minor error fixes

16 1:30 AM, Alexander Law wrote: Please consider fixing some more minor errors. Patches attached. fixed diff --git a/doc/src/sgml/ecpg.sgml b/doc/src/sgml/ecpg.sgml index 1e285d9..8c0934a 100644 --- a/doc/src/sgml/ecpg.sgml +++ b/doc/src/sgml/ecpg.sgml @@ -6190,7 +6190,7 @@ cc -c test_mod.c -o

Re: [DOCS] Docbook 5.x

Hello Jürgen, Please look at the discussion that we had some time ago: http://www.postgresql.org/message-id/56337365.2080...@postgrespro.ru And we (postgrespro) still have plans to migrate to XML as soon as we get documentation translated. We had no issues with SGML->XML conversion, "make postg

[DOCS] Some minor error fixes

Hello, Please consider fixing some more minor errors. Patches attached. Best regards, Alexander - Alexander Lakhin Postgres Professional: http://www.postgrespro.com The Russian Postgres Company diff --git a/doc/src/sgml/ecpg.sgml b/doc/src/sgml/ecpg.sgml index 8748b9f..fdd9707 100644 --- a

[DOCS] Missing braces in ecpg.sgml

Hello, Please consider fixing braces in: http://www.postgresql.org/docs/current/static/ecpg-informix-compat.html Patch attached. Best regards, Alexander - Alexander Lakhin Postgres Professional: http://www.postgrespro.com The Russian Postgres Company diff --git a/doc/src/sgml/ecpg.sgml b/d

Re: [DOCS] Graphic to visualize data flow between processes, buffers and files

Hello, I think, that SVG should be preferred format too, as it (beside other forementioned advantages): 1) Supported by DocBook (http://www.docbook.org/tdg/en/html/svg-svg.html) and you can just embed an image in the docbook.xml (http://www.docbook.org/tdg5/publishers/5.1b3/en/html/_any.svg.ht

Re: [DOCS] Russian translation publication

06.03.2013 02:13, Peter Eisentraut пишет: On 3/5/13 10:08 AM, Alvaro Herrera wrote: Alexander Law escribió: Hello, I have translated into Russian first two parts of the PostgreSQL documentation and want to publish my work. Can I create app for Google Play Market as an e-book that will

[DOCS] Russian translation publication

Hello, I have translated into Russian first two parts of the PostgreSQL documentation and want to publish my work. Can I create app for Google Play Market as an e-book that will contain my translation? Can I make it paid? Should I add some special notices to the doc? If you're interested in i