Re: [DOCS] Behavior of recovery_target_inclusive.

2017-10-23 Thread Michael Paquier
On Tue, Oct 24, 2017 at 9:43 AM, Tomonari Katsumata wrote: > Does it need to fix the next sentence? Right. -- Michael -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

Re: [DOCS] Behavior of recovery_target_inclusive.

2017-10-23 Thread Michael Paquier
On Mon, Oct 23, 2017 at 10:27 PM, wrote: > At "recovery_target_inclusive (boolean)", nothing is mentioned about > "recovery_target_lsn". > It should be fixed, since "recovery_target_lsn" is affected by the > value of > "recovery_target_inclusive". > > Could you check this? Apologies. You are ri

Re: [DOCS] version 10 release note mistype in release-10.sgml

2017-10-11 Thread Michael Paquier
On Thu, Oct 12, 2017 at 2:17 PM, Ioseph Kim wrote: > Add function txid_current_ifassigned() to return > > -> > > Add function txid_current_if_assigned() to return Indeed, the release notes are getting that wrong because the commit message of 86f31695f is wrong. -- Michael -- Sent via pgsql-do

Re: [DOCS] adduser is missing --system

2017-09-27 Thread Michael Paquier
On Thu, Sep 28, 2017 at 6:33 AM, wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.6/static/install-short.html > Description: > > Hi, > > regarding > https://www.postgresql.org/docs/9.6/static/install-short.html > > adduser po

Re: [DOCS] CREATE GROUP: REPLICATION, NOREPLICATION, BYPASSRLS, NOBYPASSRLS, CONNECTION LIMIT connlimit

2017-09-20 Thread Michael Paquier
On Sat, Sep 16, 2017 at 9:31 PM, wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.5/static/sql-creategroup.html > Description: > > Options from subject are still available according to CREATE ROLE > definition > > Please upda

Re: [DOCS] password_encryption in postgresql.conf (10)

2017-09-06 Thread Michael Paquier
On Wed, Sep 6, 2017 at 5:31 PM, Oleg Bartunov wrote: > I may be mistaken, but postgresql.conf for version 10 still mentions > plain comment > > #password_encryption = md5 # md5, scram-sha-256, or plain You are right, this should be removed. -- Michael -- Sent via pgsql-docs mail

Re: [DOCS] Default names for CRL and CA files in the backend

2017-08-18 Thread Michael Paquier
On Fri, Aug 18, 2017 at 10:37 PM, Daniel Gustafsson wrote: >> On 18 Aug 2017, at 09:28, Michael Paquier wrote: >> - the server, i.e. signed by a certificate in the server's >> - root.crt file. >> + the server, i.e. signed by a certificate in the server&#

Re: [DOCS] Default names for CRL and CA files in the backend

2017-08-18 Thread Michael Paquier
On Thu, Aug 17, 2017 at 4:37 PM, Daniel Gustafsson wrote: >> On 17 Aug 2017, at 03:26, Michael Paquier wrote: > Since all supported versions have this as a parameter, this seems to mainly > serve as a help for anyone upgrading from 9.1 (or earlier) so mentioning when > the change

Re: [DOCS] CREATE SEQUENCE minvalue for descending sequence

2017-08-16 Thread Michael Paquier
On Wed, Aug 16, 2017 at 10:00 PM, Klemens Eisenstecken wrote: > Hello, > > while reading your documentation about create sequence I found that you > mention the minvalue for a descending sequence is -2^63-1. > > But as far as I know the minvalue of long is -2^63+1. > > The mentioned documentation

Re: [DOCS] Default names for CRL and CA files in the backend

2017-08-16 Thread Michael Paquier
On Thu, Aug 17, 2017 at 7:31 AM, Daniel Gustafsson wrote: > Commit a445cb92ef5b3a31313ebce30e18cc1d6e0bdecb removed the default names for > serverside CRL and CA files, but the defaults were left in the "SSL Server > File > Usage” table with a small note. I completely missed the note, even after

Re: [DOCS] ALTER SYSTEM is equal to editing postgresql.auto.conf, not postgres.conf

2017-07-13 Thread Michael Paquier
On Thu, Jul 13, 2017 at 12:53 PM, wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.6/static/config-setting.html > Description: > > > The already-mentioned ALTER SYSTEM command provides a SQL-accessible > means > of changing

Re: [DOCS] Documentation still mentioning SSLv2 and SSLv3

2017-07-03 Thread Michael Paquier
On Tue, Jul 4, 2017 at 12:17 AM, Magnus Hagander wrote: > On Mon, Jun 19, 2017 at 6:24 AM, Michael Paquier > wrote: >> The documentation of libpq and sslinfo are still mentioning SSLv2 and >> SSLv3, though such settings cannot be reach as they are not supported >> anymore

Re: [DOCS] Password encryption

2017-06-29 Thread Michael Paquier
Hi, On Thu, Jun 29, 2017 at 9:23 PM, wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.1/static/libpq-pgpass.html > Description: > > Can we keep encrypted password in .pgpass file or is there any way to > provide encrypted pa

Re: [DOCS] gen_random_uuid security not explicit in documentation

2017-06-22 Thread Michael Paquier
On Fri, Jun 23, 2017 at 3:02 AM, Heikki Linnakangas wrote: > I'm inclined to change gen_random_uuid() to throw an error if the server is > built with --disable-strong-random, like gen_random_bytes() does. That way, > they would behave the same. No objections to do that. I guess you don't need a p

Re: [DOCS] nothing ever works

2017-06-21 Thread Michael Paquier
On Thu, Jun 22, 2017 at 1:00 AM, Pavel Stehule wrote: > 2017-06-21 10:39 GMT+02:00 : >> >> The following documentation comment has been logged on the website: >> >> Page: https://www.postgresql.org/docs/9.6/static/plpgsql-statements.html >> Description: >> >> Your documentation although it seems s

[DOCS] Documentation still mentioning SSLv2 and SSLv3

2017-06-18 Thread Michael Paquier
Hi all, The documentation of libpq and sslinfo are still mentioning SSLv2 and SSLv3, though such settings cannot be reach as they are not supported anymore. Wouldn't it make sense to replace those mentions by TLSv1.*? Please find attached a patch. Thanks, -- Michael docs-sslv2.patch Descriptio

Re: [DOCS] SCRAM RFC

2017-05-27 Thread Michael Paquier
On Sat, May 27, 2017 at 10:33 PM, Peter Eisentraut wrote: > https://www.postgresql.org/docs/devel/static/sasl-authentication.html > contains that SCRAM is described in RFC 7677 and RFC 5741, but the > latter appears to be a mistake. Perhaps RFC 5802 was meant? Indeed, it should be s/5741/5802/.

Re: [DOCS] postgres index rebuild

2017-05-26 Thread Michael Paquier
On Fri, May 26, 2017 at 3:24 PM, Euler Taveira wrote: > CIC can't be executed inside a transaction block or a user-defined function > because it involves some phases that are not easily rollback-able. Instead > create a small script with those commands. If you are interested in the reasons why mu

Re: [DOCS] No doc pg_ctl runservice verb

2017-01-27 Thread Michael Paquier
On Sat, Jan 28, 2017 at 5:52 AM, wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.6/static/app-pg-ctl.html > Description: > > docs/9.6/static/app-pg-ctl.html does not mention the 'runservice' > verb. > While this verb is pre

Re: [DOCS] effective_io_concurrency option in ALTER TABLESPACE

2017-01-26 Thread Michael Paquier
On Thu, Jan 26, 2017 at 12:49 AM, wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.6/static/sql-altertablespace.html > Description: > > This page: > https://www.postgresql.org/docs/9.6/static/runtime-config-resource.html > >

Re: [DOCS] pg_xlogdump -p option correction

2017-01-09 Thread Michael Paquier
On Tue, Jan 10, 2017 at 4:32 AM, Bruce Momjian wrote: > On Sun, Jan 8, 2017 at 03:27:59PM +0900, Michael Paquier wrote: >> >> +subdirectory of both the current directory and the >> >> +PGDATA directory. >> >> This could say "of both

Re: [DOCS] pg_xlogdump -p option correction

2017-01-07 Thread Michael Paquier
On Sun, Jan 8, 2017 at 1:20 AM, Bruce Momjian wrote: > On Sat, Jan 7, 2017 at 09:50:32PM +0900, Michael Paquier wrote: >> >> 2) The documentation does not mention that if a directory is defined >> >> pg_xlogdump will try to look as well at defined_dir/pg_wal. >>

Re: [DOCS] pg_xlogdump -p option correction

2017-01-07 Thread Michael Paquier
On Sat, Jan 7, 2017 at 10:02 AM, Bruce Momjian wrote: >> 1) pg_xlogdump --help should mention PGDATA as well for the default >> behavior, and should make clear the default and when -p is defined: >> -p, --path=PATHdirectory in which to find log segment files >> (

Re: [DOCS] gen_random_uuid security not explicit in documentation

2017-01-03 Thread Michael Paquier
(Adding Heikki in CC who committed this code) On Mon, Jan 2, 2017 at 8:20 AM, wrote: > The C source code of gen_random_uuid reads: > > /* > * Generate random bits. pg_backend_random() will do here, we don't > * promis UUIDs to be cryptographically random, when built with > * --di

Re: [DOCS] Error when trying to start server

2016-12-27 Thread Michael Paquier
On Sun, Dec 25, 2016 at 11:42 PM, wrote: > I just installed version 9.6.1 on RHEL 6.5 x64. I used the installed from > your documentation page. > I tried to start the database and got: > > postgres -D /opt/PostgreSQL/9.6/data > FATAL: unrecognized configuration parameter > "dynamic_shared_memor

Re: [DOCS] pg_xlogdump -p option correction

2016-12-26 Thread Michael Paquier
On Tue, Dec 27, 2016 at 6:56 AM, Bruce Momjian wrote: > I have found that pg_xlogdump looks for WAL files in the in the current > directory and the pg_wal subdirectory of both the current directory and > the PGDATA directory. Doc patch attached. The whole behavior is listed in pg_xlogdump.c her

Re: [DOCS] Documentation does not SSL parameters are postmaster-only

2016-11-27 Thread Michael Paquier
On Sun, Nov 27, 2016 at 05:12:34PM +0100, Magnus Hagander wrote: > Applied, thanks. Thanks. -- Michael signature.asc Description: PGP signature

[DOCS] Documentation does not SSL parameters are postmaster-only

2016-11-23 Thread Michael Paquier
Hi all, While looking at the patch to support reload of SSL parameters, I have noticed that the following SSL parameters are not mentioned as parameters that can only be set at server start: - ssl_ciphers - ssl_ecdh_curve - ssl_prefer_server_ciphers Attached is a patch to correct the documentation

Re: [DOCS] Missing tablespace_option | effective_io_concurrency

2016-11-01 Thread Michael Paquier
On Mon, Oct 31, 2016 at 6:41 PM, wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.6/static/sql-altertablespace.html > Description: > > https://www.postgresql.org/docs/9.6/static/sql-altertablespace.html > Missing tablespace_o

Re: [DOCS] Foreign Table docs are way to brief.

2016-09-06 Thread Michael Paquier
On Mon, Sep 5, 2016 at 11:22 AM, wrote: > Too few words given over to helping me understand what FOREIGN brings to the > table in all these commands. Patches for improvements are welcome if you think that's worth it. Now there is this bit in the documentation that explains the concept of foreign

Re: [DOCS] How to backup

2016-09-03 Thread Michael Paquier
On Wed, Aug 31, 2016 at 4:52 PM, wrote: > Could you please explain 24.3.3.3 (version 9.5) further? This is not a bug. Such questions are better if directed to the mailing lists pgsql-novice or pgsql-general. -- Michael -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make c

Re: [DOCS] pg_rewind confusion

2016-07-21 Thread Michael Paquier
On Fri, Jul 22, 2016 at 2:15 AM, Bruce Momjian wrote: > On Thu, Jul 21, 2016 at 10:11:00PM +0900, Michael Paquier wrote: >> + Copy all other files such as clog and >> clog is not a term used a lot in the docs. It may be better to refer >> to pg_clog, or transaction st

Re: [DOCS] pg_rewind confusion

2016-07-21 Thread Michael Paquier
On Thu, Jul 21, 2016 at 3:07 AM, Bruce Momjian wrote: > I was confused by pg_rewind's ability to use a remote source server, and > another core team member was confused as well, so I figured I should > update the pg_rewind docs to be clearer. > > Attached is a patch to do that. This is a clean se

Re: [DOCS] DROP EXTENSION

2016-06-20 Thread Michael Paquier
On Tue, Jun 21, 2016 at 1:00 AM, wrote: > Page: https://www.postgresql.org/docs/9.5/static/sql-dropextension.html > Description: > I dropped an extension in my database with a function dependency. The > function was dropped (without messages of dependencies) and leaving the > function intact. >

Re: [DOCS] pg_rewind option clarification

2016-06-17 Thread Michael Paquier
On Sat, Jun 18, 2016 at 7:03 AM, Bruce Momjian wrote: > On Sat, Jun 18, 2016 at 06:36:45AM +0900, Michael Paquier wrote: >> On Sat, Jun 18, 2016 at 12:51 AM, Bruce Momjian wrote: >> > This patch clarifies the documentation for when --source-pgdata and >> >

Re: [DOCS] pg_rewind option clarification

2016-06-17 Thread Michael Paquier
On Sat, Jun 18, 2016 at 12:51 AM, Bruce Momjian wrote: > This patch clarifies the documentation for when --source-pgdata and > --source-server can be used. > > I would like to apply this to 9.6. What's the difference between "up and running" and "running"? I thought that the current documentation

Re: [DOCS] gamke error -postgres9.4.5

2016-06-14 Thread Michael Paquier
On Tue, Jun 14, 2016 at 9:12 PM, wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/8.3/static/libpq-build.html 8.3 is out of support by community. And why are you pointing to this page? This is libpq, and what is failing to com

Re: [DOCS] Typo

2016-06-06 Thread Michael Paquier
On Sat, Jun 4, 2016 at 4:28 PM, wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.5/static/backup-dump.html > Description: > > Before restoring an SQL dump, > > Should be > > Before restoring a SQL dump, The source code has a

Re: [DOCS] Math function description issue

2016-06-06 Thread Michael Paquier
On Mon, Jun 6, 2016 at 2:40 PM, wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.5/static/functions-math.html > Description: > > https://www.postgresql.org/docs/9.5/static/functions-math.html > > Same issue for other versions

Re: [DOCS] pg_extension_config_dump() function and sequences

2016-04-17 Thread Michael Paquier
On Mon, Apr 18, 2016 at 12:17 PM, Peter Eisentraut wrote: > On 01/19/2016 03:14 PM, Philippe BEAUDOIN wrote: >> Le 18/01/2016 07:10, Michael Paquier a écrit : >>> On Wed, Jan 6, 2016 at 5:29 AM, Philippe BEAUDOIN >>> wrote: > >>>> The pg_extensio

[DOCS] Incorrect markup for command "vceregress bincheck" in Windows docs

2016-02-16 Thread Michael Paquier
Hi all, I just bumped into the following thing while browsing the windows docs: diff --git a/doc/src/sgml/install-windows.sgml b/doc/src/sgml/install-windows.sgml index ba60a6b..d0bdb55 100644 --- a/doc/src/sgml/install-windows.sgml +++ b/doc/src/sgml/install-windows.sgml @@ -454,8 +454,9 @@ $ENV{

Re: [DOCS] pg_extension_config_dump() function and sequences

2016-01-17 Thread Michael Paquier
On Wed, Jan 6, 2016 at 5:29 AM, Philippe BEAUDOIN wrote: > The page "Packaging Related Objects into an Extension" has a third chapter > dealing with "Extension Configuration Tables". A final paragraph would be > useful to explain that: > > The pg_extension_config_dump() function can also register

Re: [DOCS] pg_rewind source-server connection

2015-11-18 Thread Michael Paquier
On Wed, Nov 18, 2015 at 7:03 PM, Pavel Luzanov wrote: > May be it's time to document that source-server connection in pg_rewind must > be non-replication and with superuser access. > Consider this small patch for documentation. +1. -- Michael -- Sent via pgsql-docs mailing list (pgsql-docs@po

Re: [DOCS] Documentation on Streaming Replication interface for Logical Decoding

2015-11-09 Thread Michael Paquier
On Tue, Nov 10, 2015 at 7:40 AM, Daniel Gustafsson wrote: > In section 46.3 (Streaming Replication Protocol Interface) the create command > for logical slots, CREATE_REPLICATION_SLOT, is defined as taking “options” > after the LOGICAL keyword when it in fact requires the plugin name. The start >

Re: [DOCS] Numeric Type Serial Range

2015-11-03 Thread Michael Paquier
On Tue, Nov 3, 2015 at 12:28 PM, Lewis Christie wrote: > I believe the range listed in Table 8-2. Numeric Types > http://www.postgresql.org/docs/9.3/static/datatype-numeric.html is > incorrect for the serial types. > > E.g. > serial4 bytesautoincrementing integer1 to 2147483647This describes the

Re: [DOCS] storage.sgml mentioning htup.h when referring to HeapTupleHeaderData

2015-10-01 Thread Michael Paquier
On Thu, Oct 1, 2015 at 11:14 PM, Fujii Masao wrote: > Applied. Thanks! > Thanks! -- Michael

Re: [DOCS] Updated docs on base backups

2015-09-27 Thread Michael Paquier
On Sun, Sep 27, 2015 at 11:27 AM, Amir Rohan wrote: > Further editing. See attached V3. I think that you should consider adding this patch to the next commit fest so as we do not lose track of it: https://commitfest.postgresql.org/7/ -- Michael -- Sent via pgsql-docs mailing list (pgsql-docs@p

[DOCS] storage.sgml mentioning htup.h when referring to HeapTupleHeaderData

2015-09-26 Thread Michael Paquier
Hi all, I found the following mistake in the docs while looking at another patch: diff --git a/doc/src/sgml/storage.sgml b/doc/src/sgml/storage.sgml index 0153b08..164d08c 100644 --- a/doc/src/sgml/storage.sgml +++ b/doc/src/sgml/storage.sgml @@ -990,7 +990,7 @@ data. Empty in ordinary tables.

Re: [DOCS] Possible mistake in Section 63.6 - 9.6devel Documentation

2015-09-09 Thread Michael Paquier
On Thu, Sep 10, 2015 at 12:42 AM, Fujii Masao wrote: > On Tue, Jul 21, 2015 at 9:59 AM, Michael Paquier > wrote: >> On Tue, Jul 21, 2015 at 6:54 AM, Vignesh Raghunathan >> wrote: >>> Hello, >>> >>> It has been mentioned in Section 63.6 that the fir

Re: [DOCS] Possible mistake in Section 63.6 - 9.6devel Documentation

2015-07-20 Thread Michael Paquier
On Tue, Jul 21, 2015 at 6:54 AM, Vignesh Raghunathan wrote: > Hello, > > It has been mentioned in Section 63.6 that the first two fields in > PageHeaderData track the most recent WAL entry related to the page. However, > I am not sure how pd_checksum is related to WAL. Could it be possible that >

Re: [DOCS] [BUGS] BUG #11661: CASE ELSE is evaluated although condition is true

2014-11-11 Thread Michael Paquier
On Tue, Nov 11, 2014 at 5:26 PM, Marti Raudsepp wrote: > Perhaps should be: > SELECT and HAVING clauses are evaluated. > > Other than that, looks good to me. Let's do so then and mark that as ready for committer. Thanks, -- Michael diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml inde

Re: [DOCS] [BUGS] BUG #11661: CASE ELSE is evaluated although condition is true

2014-11-10 Thread Michael Paquier
On Tue, Nov 11, 2014 at 4:37 PM, Marti Raudsepp wrote: > Why? This page explains in what order the expressions in a SELECT > query are processed. Aggregates can only be found in SELECT queries > and their semantics are non-trivial, so it seems like a big omission > to me that their relation to oth

Re: [DOCS] [BUGS] BUG #11661: CASE ELSE is evaluated although condition is true

2014-11-10 Thread Michael Paquier
On Tue, Oct 14, 2014 at 7:54 AM, Marti Raudsepp wrote: > Our documentation should be clearer about the fact that all aggregates > are evaluated strictly before their surrounding SELECT expressions, > the attached documentation patch adds a note about this to the > "general processing of SELECT" ex

Re: [DOCS] obsolete pg_receivexlog note?

2014-11-07 Thread Michael Paquier
On Sat, Nov 8, 2014 at 10:30 AM, Peter Eisentraut wrote: > On 11/5/14 7:36 PM, Peter Eisentraut wrote: >> On 11/5/14 6:54 PM, Michael Paquier wrote: >>> In this paragraph, is it worth mentioning as well that the tradeoff >>> when using replication slots is to monit

Re: [DOCS] obsolete pg_receivexlog note?

2014-11-05 Thread Michael Paquier
On Thu, Nov 6, 2014 at 6:42 AM, Peter Eisentraut wrote: > > On 10/20/14 2:07 PM, Peter Eisentraut wrote: > > The reference page for pg_receivexlog > > (http://www.postgresql.org/docs/9.4/static/app-pgreceivexlog.html) has > > this note: > > > > """ > > When using pg_receivexlog instead of archive_

Re: [DOCS] Missing docs: setting up replication slots for standbys

2014-09-04 Thread Michael Paquier
On Thu, Sep 4, 2014 at 3:06 PM, Josh Berkus wrote: > On 09/03/2014 11:03 PM, Andres Freund wrote: >> and I'm pretty sure primary_slot_name and such is configured at the >> appropriate place too. > > Huh. I can't seem to find any way to navigate to that page. What is it > supposed to be under? Ca

Re: [DOCS] [HACKERS] [doc] EXPLAIN CREATE MATERIALIZED VIEW AS?

2014-04-15 Thread Michael Paquier
On Wed, Apr 16, 2014 at 12:35 PM, Amit Langote wrote: > Hi, > > Attached adds CREATE MATERIALIZED VIEW AS to the list of statements > that can be EXPLAINed. Now that you mention that, REFRESH MATERIALIZED VIEW can be EXPLAIN'ed as well, except that it returns that and does not error out: =# explai