Re: [DOCS] Pg_upgrade and collation

2016-07-09 Thread Peter Geoghegan
On Sat, Jul 9, 2016 at 7:02 AM, Peter Eisentraut wrote: > On 6/28/16 5:58 PM, Peter Geoghegan wrote: >> >> I have long advocated adopting ICU as our defacto standard "collation >> provider", primarily so that we can directly control collations and >> collation versioning. I think that doing this w

Re: [DOCS] Pg_upgrade and collation

2016-07-09 Thread Peter Eisentraut
On 6/28/16 5:58 PM, Peter Geoghegan wrote: I have long advocated adopting ICU as our defacto standard "collation provider", primarily so that we can directly control collations and collation versioning. I think that doing this would solve many problems. I plan to submit a patch for ICU support

Re: [DOCS] Pg_upgrade and collation

2016-07-02 Thread Bruce Momjian
On Tue, Jun 28, 2016 at 05:21:51PM -0400, Bruce Momjian wrote: > On Mon, Jun 20, 2016 at 11:16:36AM -0400, Bruce Momjian wrote: > > In looking at the docs, it seems it would go in the Backup section > > somewhere: > > > > https://www.postgresql.org/docs/9.6/static/backup.html > > > > Seems it

Re: [DOCS] Pg_upgrade and collation

2016-06-28 Thread Peter Geoghegan
On Tue, Jun 28, 2016 at 3:50 PM, Alvaro Herrera wrote: > Uhmm. Until now I saw all this ICU thing as having fringe benefit on > strange platforms only, but it is seeming more and more like we need to > take it seriously. I'm not prepared to spend effort on it myself, > though. Let me put it thi

Re: [DOCS] Pg_upgrade and collation

2016-06-28 Thread Alvaro Herrera
Peter Geoghegan wrote: > The best argument for ICU is the evidently lax attitude that the glibc > people have towards the correctness and consistency of their > collations: > > https://bugzilla.redhat.com/show_bug.cgi?id=1320356#c3 > > Here, Carlos O'Donnell, a glic committer, says "Regarding (b

Re: [DOCS] Pg_upgrade and collation

2016-06-28 Thread Peter Geoghegan
On Tue, Jun 28, 2016 at 3:20 PM, Bruce Momjian wrote: >> I have long advocated adopting ICU as our defacto standard "collation >> provider", primarily so that we can directly control collations and >> collation versioning. I think that doing this would solve many >> problems. Besides, even SQLite

Re: [DOCS] Pg_upgrade and collation

2016-06-28 Thread Bruce Momjian
On Tue, Jun 28, 2016 at 02:58:58PM -0700, Peter Geoghegan wrote: > On Fri, Jun 17, 2016 at 2:51 PM, Alvaro Herrera > wrote: > > I think this is way too thin to be helpful: > > > >> --- 61,68 > >> checking for compatible compile-time settings, including 32/64-bit > >> binaries. It is

Re: [DOCS] Pg_upgrade and collation

2016-06-28 Thread Peter Geoghegan
On Fri, Jun 17, 2016 at 2:51 PM, Alvaro Herrera wrote: > I think this is way too thin to be helpful: > >> --- 61,68 >> checking for compatible compile-time settings, including 32/64-bit >> binaries. It is important that >> any external modules are also binary compatible, though t

Re: [DOCS] Pg_upgrade and collation

2016-06-28 Thread Bruce Momjian
On Mon, Jun 20, 2016 at 11:16:36AM -0400, Bruce Momjian wrote: > In looking at the docs, it seems it would go in the Backup section > somewhere: > > https://www.postgresql.org/docs/9.6/static/backup.html > > Seems it would apply to both of these backup sections: > > 24.2. File System

Re: [DOCS] Pg_upgrade and collation

2016-06-20 Thread Bruce Momjian
On Fri, Jun 17, 2016 at 06:11:58PM -0400, Alvaro Herrera wrote: > > Frankly, pg_upgrade is, by definition, upgrading on the same server, so > > I don't even see how they could have mismatched collation library > > versions, but it seemed good to document it. > > By this argument, the proposed patc

Re: [DOCS] Pg_upgrade and collation

2016-06-17 Thread Alvaro Herrera
Bruce Momjian wrote: > On Fri, Jun 17, 2016 at 06:01:59PM -0400, Bruce Momjian wrote: > > On Fri, Jun 17, 2016 at 05:51:54PM -0400, Alvaro Herrera wrote: > > > Bruce Momjian wrote: > > > > The attached patch documents that pg_upgrade requires old/new servers to > > > > use compatibile collation lib

Re: [DOCS] Pg_upgrade and collation

2016-06-17 Thread Bruce Momjian
On Fri, Jun 17, 2016 at 06:01:59PM -0400, Bruce Momjian wrote: > On Fri, Jun 17, 2016 at 05:51:54PM -0400, Alvaro Herrera wrote: > > Bruce Momjian wrote: > > > The attached patch documents that pg_upgrade requires old/new servers to > > > use compatibile collation library versions as well. > > > >

Re: [DOCS] Pg_upgrade and collation

2016-06-17 Thread Bruce Momjian
On Fri, Jun 17, 2016 at 05:51:54PM -0400, Alvaro Herrera wrote: > Bruce Momjian wrote: > > The attached patch documents that pg_upgrade requires old/new servers to > > use compatibile collation library versions as well. > > I think this is way too thin to be helpful: Well, this is a much larger i

Re: [DOCS] Pg_upgrade and collation

2016-06-17 Thread Alvaro Herrera
Bruce Momjian wrote: > The attached patch documents that pg_upgrade requires old/new servers to > use compatibile collation library versions as well. I think this is way too thin to be helpful: > --- 61,68 > checking for compatible compile-time settings, including 32/64-bit > binarie

[DOCS] Pg_upgrade and collation

2016-06-17 Thread Bruce Momjian
The attached patch documents that pg_upgrade requires old/new servers to use compatibile collation library versions as well. I would like to apply this to all PG branches. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you a