Re: [DOCS] Window function docs

2017-04-11 Thread Bruce Momjian
On Mon, Apr 10, 2017 at 03:15:58PM -0400, Bruce Momjian wrote: > On Fri, Apr 7, 2017 at 01:06:53PM -0400, Tom Lane wrote: > > I actually think "regular" might be a better choice than "normal" for this > > purpose, mainly because somebody looking for statistical aggregates might > > think that

Re: [DOCS] Window function docs

2017-04-10 Thread Bruce Momjian
On Fri, Apr 7, 2017 at 01:06:53PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > This change is not on my patch yes but what do you think about changing > > "regular" and "normal" aggregate designations to "generic"? That seems > > clearer because the aggregates work in

Re: [DOCS] Window function docs

2017-04-07 Thread Tom Lane
Bruce Momjian writes: > On Thu, Apr 6, 2017 at 06:13:44PM -0400, Tom Lane wrote: >> Not really convinced by the s/regular/normal/g changes. That doesn't seem >> to clarify much either. Maybe it would help to define "normal" near here. >> There's a definition in func.sgml

Re: [DOCS] Window function docs

2017-04-07 Thread Bruce Momjian
On Thu, Apr 6, 2017 at 06:13:44PM -0400, Tom Lane wrote: > avg() is going to be evaluated across the current frame, not the whole > partition. I don't mind trying to be more precise than "appropriate set", > but it doesn't help to be apparently precise but wrong. > > Not really convinced by the

Re: [DOCS] Window function docs

2017-04-06 Thread Bruce Momjian
On Thu, Apr 6, 2017 at 06:43:38PM -0700, David G. Johnston wrote: > On Thu, Apr 6, 2017 at 6:14 PM, Bruce Momjian wrote: > > On Thu, Apr  6, 2017 at 03:53:24PM -0700, David G. Johnston wrote: > > > hypothetical-set aggregates as being distinct from ordered-set >

Re: [DOCS] Window function docs

2017-04-06 Thread David G. Johnston
On Thu, Apr 6, 2017 at 6:14 PM, Bruce Momjian wrote: > On Thu, Apr 6, 2017 at 03:53:24PM -0700, David G. Johnston wrote: > > > hypothetical-set aggregates as being distinct from ordered-set > aggregates yet > > the tables and the docs here do. > > Do you have any suggested

Re: [DOCS] Window function docs

2017-04-06 Thread Bruce Momjian
On Thu, Apr 6, 2017 at 03:53:24PM -0700, David G. Johnston wrote: > On Thu, Apr 6, 2017 at 2:49 PM, Bruce Momjian wrote: > > As part of writing a talk about window functions, I have done some > cleanups of the window function docs, attached, that I would like to >

Re: [DOCS] Window function docs

2017-04-06 Thread Bruce Momjian
On Thu, Apr 6, 2017 at 06:13:44PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > As part of writing a talk about window functions, I have done some > > cleanups of the window function docs, attached, that I would like to > > apply to head. > > I think this change is just

Re: [DOCS] Window function docs

2017-04-06 Thread David G. Johnston
On Thu, Apr 6, 2017 at 2:49 PM, Bruce Momjian wrote: > As part of writing a talk about window functions, I have done some > cleanups of the window function docs, attached, that I would like to > apply to head. +1 Overall. Some minor technical items noted below. The only

Re: [DOCS] Window function docs

2017-04-06 Thread Tom Lane
Bruce Momjian writes: > As part of writing a talk about window functions, I have done some > cleanups of the window function docs, attached, that I would like to > apply to head. I think this change is just wrong: aggregate function, but the OVER clause causes it to be -

[DOCS] Window function docs

2017-04-06 Thread Bruce Momjian
As part of writing a talk about window functions, I have done some cleanups of the window function docs, attached, that I would like to apply to head. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + As you are,