Re: Restore relhaspkey in PostgreSQL Version 11 Beta

2018-07-31 Thread Peter Geoghegan
On Tue, Jul 31, 2018 at 7:47 AM, Melvin Davidson wrote: > I was hoping that at least one other person would see my point of view, but > by the > harsh replies I've been getting, I feel more like a whistle blower that > insiders > think I also should be made to "go away". You were bellicose from

Re: Restore relhaspkey in PostgreSQL Version 11 Beta

2018-07-31 Thread Adrian Klaver
On 07/31/2018 07:47 AM, Melvin Davidson wrote: [2] https://www.postgresql.org/message-id/flat/20140317185255.20724.49675%40wrigleys.postgresql.org --  David Rowley

Re: Restore relhaspkey in PostgreSQL Version 11 Beta

2018-07-31 Thread Melvin Davidson
> [2] https://www.postgresql.org/message-id/flat/20140317185255.20724.49675% > 40wrigleys.postgresql.org > > -- > David Rowley http://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Training & Services > >

Re: Restore relhaspkey in PostgreSQL Version 11 Beta

2018-07-30 Thread David Rowley
On 31 July 2018 at 11:11, Melvin Davidson wrote: >> If you want stability use information_schema which we'll try very hard to >> not ever break. > Of course. Would you be so kind as to point out where in the > information_schema it > indicates if a table has a primary key or not. Oh wait, now I

Re: Restore relhaspkey in PostgreSQL Version 11 Beta

2018-07-30 Thread David G. Johnston
On Mon, Jul 30, 2018 at 4:11 PM, Melvin Davidson wrote: > *Random atavistic things? I hardly think relhaspkey is random. It's been > there since version 7.2.* > *Exactly how does keeping it around slow you/us down?* > My recap of the discussion thread: That this has been around for a long time

Re: Restore relhaspkey in PostgreSQL Version 11 Beta

2018-07-30 Thread Andres Freund
Hi, On 2018-07-30 19:11:34 -0400, Melvin Davidson wrote: > *Of course. Would you be so kind as to point out where in the > information_schema it * > *indicates if a table has a primary key or not. Oh wait, now I > remember...no place.* As Adrian pointed out, that's wrong. It's in

Re: Restore relhaspkey in PostgreSQL Version 11 Beta

2018-07-30 Thread Adrian Klaver
On 07/30/2018 04:11 PM, Melvin Davidson wrote: On Mon, Jul 30, 2018 at 6:21 PM, Andres Freund > wrote: Hi, On 2018-07-30 17:21:25 -0400, Melvin Davidson wrote: > * >it has never been the case that relhaspkey meant that the table > *currently* has

Re: Restore relhaspkey in PostgreSQL Version 11 Beta

2018-07-30 Thread Melvin Davidson
On Mon, Jul 30, 2018 at 6:21 PM, Andres Freund wrote: > Hi, > > On 2018-07-30 17:21:25 -0400, Melvin Davidson wrote: > > * >it has never been the case that relhaspkey meant that the table > > *currently* has a primary key. * > > > *Hmmm, I guess it's a lot harder to fix "squishy semantics"from >

Re: Restore relhaspkey in PostgreSQL Version 11 Beta

2018-07-30 Thread Andres Freund
Hi, On 2018-07-30 17:21:25 -0400, Melvin Davidson wrote: > * >it has never been the case that relhaspkey meant that the table > *currently* has a primary key. * > *Hmmm, I guess it's a lot harder to fix "squishy semantics"from "True > if the table has (or once had) a primary key" to

Re: Restore relhaspkey in PostgreSQL Version 11 Beta

2018-07-30 Thread Melvin Davidson
* >it has never been the case that relhaspkey meant that the table *currently* has a primary key. * *Hmmm, I guess it's a lot harder to fix "squishy semantics"from "True if the table has (or once had) a primary key" to"True if the table has a primary key after vacuum"rather than

Re: Restore relhaspkey in PostgreSQL Version 11 Beta

2018-07-30 Thread Adrian Klaver
On 07/30/2018 07:42 AM, Melvin Davidson wrote: On Mon, Jul 30, 2018 at 10:31 AM, Tom Lane > wrote: Melvin Davidson mailto:melvin6...@gmail.com>> writes: > In the release notes for Version 11 Beta, under changes, I see these scary > remarks: >

Re: Restore relhaspkey in PostgreSQL Version 11 Beta

2018-07-30 Thread Melvin Davidson
On Mon, Jul 30, 2018 at 10:31 AM, Tom Lane wrote: > Melvin Davidson writes: > > In the release notes for Version 11 Beta, under changes, I see these > scary > > remarks: > > Remove relhaspkey column from system table pg_class (Peter Eisentraut) > > Applications needing to check for a primary

Re: Restore relhaspkey in PostgreSQL Version 11 Beta

2018-07-30 Thread Tom Lane
Melvin Davidson writes: > In the release notes for Version 11 Beta, under changes, I see these scary > remarks: > Remove relhaspkey column from system table pg_class (Peter Eisentraut) > Applications needing to check for a primary key should consult pg_index. > > That absolutely breaks my code

Restore relhaspkey in PostgreSQL Version 11 Beta

2018-07-30 Thread Melvin Davidson
In the release notes for Version 11 Beta, under changes, I see these scary remarks: Remove relhaspkey column from system table pg_class (Peter Eisentraut) Applications needing to check for a primary key should consult pg_index. That absolutely breaks my code (and I'm guessing others), as I have