Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

On Tue, Dec 5, 2017 at 11:04 AM, Rajkumar Raghuwanshi wrote: > On Mon, Dec 4, 2017 at 7:34 AM, Ashutosh Bapat > wrote: >> I agree, the patch looks longer than expected. I think, it's important >> to have some testcases to

Re: Mention ordered datums in PartitionBoundInfoData comment

On Tue, Dec 5, 2017 at 11:20 AM, Julien Rouhaud wrote: > + * PartitionBoundInfoData structures for two partitioned table with > exactly same > > should be "tables". Sorry. Thanks for pointing it out. fixed in the attached patch. -- Best Wishes, Ashutosh Bapat EnterpriseDB

BUGFIX: standby disconnect can corrupt serialized reorder buffers

Hi all TL;DR: we should delete pg_replslot/$SLOTNAME/* at the start of each decoding session or we can accidentally re-use stale reorder buffer contents from prior runs and $BADNESS happens. StartupReorderBuffer() is not sufficient. Details: Petr and I have found a bug in logical decoding

Re: explain analyze output with parallel workers - question about meaning of information for explain.depesz.com

On Mon, Dec 4, 2017 at 11:17 PM, Robert Haas wrote: > On Sat, Dec 2, 2017 at 8:04 AM, Amit Kapila wrote: >> Attached patch contains regression test as well. Note that I have >> carefully disabled all variable stats by using (analyze, timing off,

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

On Mon, Dec 4, 2017 at 7:34 AM, Ashutosh Bapat wrote: > I agree, the patch looks longer than expected. I think, it's important > to have some testcases to test partition-wise join with default > partitions. I think we need at least one test for range default >

Re: Is it OK to ignore directory open failure in ResetUnloggedRelations?

On Mon, Dec 04, 2017 at 03:15:08PM -0500, Tom Lane wrote: > While working through Michael Paquier's patch to clean up inconsistent > usage of AllocateDir(), I noticed that ResetUnloggedRelations and its > subroutines are not consistent about whether a directory open failure > results in erroring

Re: Is it OK to ignore directory open failure in ResetUnloggedRelations?

Hi Tom, On 12/4/17 3:15 PM, Tom Lane wrote: > While working through Michael Paquier's patch to clean up inconsistent > usage of AllocateDir(), I noticed that ResetUnloggedRelations and its > subroutines are not consistent about whether a directory open failure > results in erroring out or just

Re: [HACKERS] Walsender timeouts and large transactions

On 29 November 2017 at 23:59, Petr Jelinek wrote: > Hi, > > On 17/11/17 08:35, Kyotaro HORIGUCHI wrote: > > > > Moving around the code allow us to place ps_is_send_pending() in > > the while condition, which seems to be more proper place to do > > that. I haven't

Re: [HACKERS] logical decoding of two-phase transactions

On 4 December 2017 at 23:15, Nikhil Sontakke wrote: > PFA, latest patch for this functionality. > This patch contains the following changes as compared to the earlier patch: > > - Fixed a bunch of typos and comments > > - Modified HeapTupleSatisfiesVacuum to return

Re: [HACKERS] pow support for pgbench

On Tue, Dec 5, 2017 at 11:32 AM, Tom Lane wrote: > ISTM one key issue here is whether pgbench's expression language is > meant to model SQL (where we have function overloading) or C (where > there is no overloading). I don't think we've really settled on a > fixed policy on

Usage of epoch in txid_current

Hi, Currently, txid_current and friends export a 64-bit format of transaction id that is extended with an “epoch” counter so that it will not wrap around during the life of an installation. The epoch value it uses is based on the epoch that is maintained by checkpoint (aka only checkpoint

Re: REPLICA IDENTITY FULL

On Fri, Jun 23, 2017 at 03:45:48PM -0400, Peter Eisentraut wrote: > On 6/23/17 13:14, Alvaro Herrera wrote: > > Andres Freund wrote: > >> On 2017-06-23 13:05:21 -0400, Alvaro Herrera wrote: > >>> Tom Lane wrote: > Peter Eisentraut writes: > > Any

Re: Error handling (or lack of it) in RemovePgTempFilesInDir

Michael Paquier writes: > On Tue, Dec 5, 2017 at 10:51 AM, Tom Lane wrote: >> Uh ... I'm confused? That particular change only concerns whether we emit >> a log message, not whether the action is attempted or succeeds. > From the commit mentioned

Re: Silly API for do_pg_start_backup()

On Tue, Dec 5, 2017 at 3:58 AM, Tom Lane wrote: > Barring objection I'll remove the tblspcdir parameter and have > do_pg_start_backup() open and close the directory immediately > around the loop where it's read, like every other case in the > backend. +1. Thanks for the

Re: [HACKERS] pow support for pgbench

On Tue, Dec 5, 2017 at 5:38 AM, Robert Haas wrote: > I'm willing to commit any of the following things: > > 1. A patch that adds an integer version of pow() but not a double version > 2. A patch that adds a double version of pow() but not an integer version > 3. A patch

Re: Add PGDLLIMPORT lines to some variables

. On Mon, Dec 4, 2017 at 5:41 PM, Noah Misch wrote: >> I don't think we quite have an established protocol for this. I >> personally, but I'm biased in this specific case, is that we should >> adopt a position that PGDLLIMPORTs should basically backpatched whenever >> a

Re: Errands around AllocateDir()

Michael Paquier writes: > Note I am +/-0 with exposing ReadDirExtended in back-branches, because > there is no use for it yet there. My thought is basically that we might end up back-patching some change that needs that. Nothing I've done today requires it, but it

Re: Error handling (or lack of it) in RemovePgTempFilesInDir

On Tue, Dec 5, 2017 at 8:40 AM, Thomas Munro wrote: > On Tue, Dec 5, 2017 at 4:44 AM, Tom Lane wrote: >> Anyway, I'm inclined to reverse that choice and emit LOG messages >> reporting failure of any of the lstat, rmdir, or unlink calls in >>

Re: Add PGDLLIMPORT lines to some variables

On Mon, Nov 20, 2017 at 12:02:30PM -0800, Andres Freund wrote: > On 2017-11-20 11:58:44 -0800, Brian Cloutier wrote: > > > please, append session_timezone to your list > > > > Here's a v2 patch which also includes session_timezone. > > > > Separately, is this the kind of thing which is eligible

Re: Errands around AllocateDir()

On Tue, Dec 5, 2017 at 4:11 AM, Alvaro Herrera wrote: > Tom Lane wrote: >> Yeah, agreed. The only thing I'm concerned about back-patching is >> the places where a wrong errno might be reported. > > If we're currently reporting "could not open dir: Success" then >

Re: Errands around AllocateDir()

On Tue, Dec 5, 2017 at 7:17 AM, Tom Lane wrote: > Michael Paquier writes: >> I had a close look at all the callers of AllocateDir() and noticed a >> couple of unwelcome things (Tom noticed some of those in the thread >> mentioned above, I found

Re: es_query_dsa is broken

On Thu, Nov 30, 2017 at 11:19 PM, Thomas Munro wrote: > On Thu, Nov 30, 2017 at 4:01 AM, Robert Haas wrote: >>> Better ideas? >> >> How about this: >> >> 1. Remove es_query_dsa altogether. >> 2. Add a dsa_area * to

Re: Signals in a BGW

On Tue, Dec 5, 2017 at 10:03 AM, Craig Ringer wrote: > pglogical sets up its own handler 'handle_sigterm'. However, it now does > much the same as src/backend/tcop/postgres.c's 'die' function, just without > the single-user mode checks. Documentation shows a simple example

Re: Signals in a BGW

On 5 December 2017 at 00:40, Chapman Flack wrote: > > Is there a known, default behavior that some signals will > have, if I simply BackgroundWorkerUnblockSignals() without customizing? > Will SIGINT and SIGTERM, for example, have default handlers that > interact with the

Re: [HACKERS] compress method for spgist - 2

On 30.11.2017 05:31, Michael Paquier wrote: I can see as well that the patches posted at the beginning of the thread got reviews but that those did not get answered. The set of patches also have conflicts with HEAD so they need a rebase. For those reasons I am marking this entry as returned

Re: [HACKERS] Proposal: Local indexes for partitioned table

On 2 December 2017 at 03:39, Robert Haas wrote: > On Thu, Nov 30, 2017 at 11:39 PM, David Rowley > wrote: >> I feel like we could do better here with little extra effort. The >> DETACH index feature does not really seem required for this

Re: [HACKERS] Proposal: Local indexes for partitioned table

On 2 December 2017 at 11:10, Alvaro Herrera wrote: > What you're saying is that I've written code for A+B, and you're > "interested in C (which is incompatible with B), so can we have A+C and > drop B". But in reality, there exists (unwritten) D that solves the >

Re: [HACKERS] postgres_fdw super user checks

On Tue, Dec 5, 2017 at 2:49 AM, Robert Haas wrote: > On Sun, Dec 3, 2017 at 3:42 PM, Stephen Frost wrote: >> I'm not a fan of having *only* warning in the back-branches. What I >> would think we'd do here is correct the back-branch documentation to be

Re: Errands around AllocateDir()

Michael Paquier writes: > I had a close look at all the callers of AllocateDir() and noticed a > couple of unwelcome things (Tom noticed some of those in the thread > mentioned above, I found others): Pushed with some minor additional fiddling. The most notable thing

Re: [HACKERS] pow support for pgbench

On Mon, Dec 4, 2017 at 10:47 AM, Fabien COELHO wrote: >> What's the name of the backend function whose behavior this matches? >> >> As Fabien has mentioned, it tries to behave as "numeric_power". Maybe we >> it'd better if we switch to "dpow" (which is pow with some error

Re: [HACKERS] Additional logging for VACUUM and ANALYZE

On 12/4/17, 2:27 PM, "Robert Haas" wrote: > Committed. Thanks! Nathan

Is it OK to ignore directory open failure in ResetUnloggedRelations?

While working through Michael Paquier's patch to clean up inconsistent usage of AllocateDir(), I noticed that ResetUnloggedRelations and its subroutines are not consistent about whether a directory open failure results in erroring out or just emitting a LOG message and continuing.

Re: Errands around AllocateDir()

Tom Lane wrote: > Yeah, agreed. The only thing I'm concerned about back-patching is > the places where a wrong errno might be reported. If we're currently reporting "could not open dir: Success" then backpatching such a fix is definitely an improvement. OTOH if currently we have opendir()

Silly API for do_pg_start_backup()

Why is it that do_pg_start_backup() expects its callers to pass in an open DIR pointer for the pg_tblspc directory, rather than doing the AllocateDir call for itself? This complicates the callers, provides no flexibility (since do_pg_start_backup() is hardwired to know that pg_tblspc is what it

Re: [HACKERS] postgres_fdw super user checks

On Sun, Dec 3, 2017 at 3:42 PM, Stephen Frost wrote: > I'm not a fan of having *only* warning in the back-branches. What I > would think we'd do here is correct the back-branch documentation to be > correct, and then add a warning that it changes in v11. > > You didn't

Re: explain analyze output with parallel workers - question about meaning of information for explain.depesz.com

On Sat, Dec 2, 2017 at 8:04 AM, Amit Kapila wrote: > Attached patch contains regression test as well. Note that I have > carefully disabled all variable stats by using (analyze, timing off, > summary off, costs off) and then selected parallel sequential scan on > the

Re: [HACKERS] Secondary index access optimizations

On Tue, Sep 5, 2017 at 9:10 AM, Konstantin Knizhnik < k.knizh...@postgrespro.ru> wrote: > > > On 05.09.2017 04:02, Amit Langote wrote: > > Like Thomas, I'm not so sure about the whole predtest.c patch. The core > logic in operator_predicate_proof() should be able to conclude that, say, > k < 21

Re: [HACKERS] WIP: Covering + unique indexes.

> 30 нояб. 2017 г., в 23:07, Andrey Borodin написал(а): > > Seems like it was not a big deal of patching, I've fixed those bits (see > attachment). > I've done only simple tests as for now, but I'm planning to do better testing > before next CF. > Thanks for mentioning

Re: [HACKERS] Secondary index access optimizations

On 04.12.2017 19:44, Alvaro Herrera wrote: Konstantin Knizhnik wrote: On 30.11.2017 05:16, Michael Paquier wrote: On Mon, Nov 6, 2017 at 10:13 PM, Konstantin Knizhnik wrote: Concerning broken partition_join test: it is "expected" failure: my patch removes from

Re: [HACKERS] PATCH: Keep one postmaster monitoring pipe per process

On Thu, Sep 15, 2016 at 04:40:00PM -0400, Tom Lane wrote: > Thomas Munro writes: > > Very interesting. Perhaps that is why NetBSD shows a speedup with the > > kqueue patch[1] but FreeBSD doesn't. I guess that if I could get the > > kqueue patch to perform better

Re: Errands around AllocateDir()

Michael Paquier writes: > I had a close look at all the callers of AllocateDir() and noticed a > couple of unwelcome things (Tom noticed some of those in the thread > mentioned above, I found others): The only part of this that seems likely to be controversial is the

Re: [HACKERS] Secondary index access optimizations

Konstantin Knizhnik wrote: > > > On 30.11.2017 05:16, Michael Paquier wrote: > > On Mon, Nov 6, 2017 at 10:13 PM, Konstantin Knizhnik > > wrote: > > > Concerning broken partition_join test: it is "expected" failure: my patch > > > removes from the plans redundant

Signals in a BGW

I'm curious about handling signals in a background worker. As I understand it, these are blocked when the BGW is born, until enabled with BackgroundWorkerUnblockSignals() after possible customization. Is there a known, default behavior that some signals will have, if I simply

Re: [HACKERS] PoC: full merge join on comparison clause

Here is the patch rebased to a852cfe9. -- Alexander Kuzmenkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company diff --git a/src/backend/executor/nodeMergejoin.c b/src/backend/executor/nodeMergejoin.c index ef9e1ee471..c842ed2968 100644 ---

Re: [HACKERS] [POC] Faster processing at Gather node

On Sun, Dec 3, 2017 at 10:30 PM, Amit Kapila wrote: > I thought there are some cases (though less) where we want to Shutdown > the nodes (ExecShutdownNode) earlier and release the resources sooner. > However, if you are not completely sure about this change, then we can >

Re: [HACKERS] pow support for pgbench

Please add the new function into the documentation table in alphabetical order. Fixed in the attached patch. Yep. Patch applies cleanly. Make check & pgbench check ok. make html ok. POW is in the right place in the table, sorry I did not check before. What's the name of the backend

Re: [HACKERS] Cached plans and statement generalization

On 30.11.2017 04:59, Michael Paquier wrote: On Wed, Sep 13, 2017 at 2:11 AM, Konstantin Knizhnik wrote: One more patch passing all regression tests with autoprepare_threshold=1. I still do not think that it should be switch on by default... This patch does not

Error handling (or lack of it) in RemovePgTempFilesInDir

The recent changes in commit dc6c4c9dc caused Coverity to start complaining that RemovePgTempFilesInDir calls rmdir() without checking its return value, as would be good practice. Now, this wasn't really a fault of that commit, because the code was already ignoring the result of unlink(), but it

Re: [HACKERS] proposal: psql command \graw

2017-12-04 9:29 GMT+01:00 Alexander Korotkov : > On Mon, Dec 4, 2017 at 11:21 AM, Alexander Korotkov < > a.korot...@postgrespro.ru> wrote: > >> The problem is that it's hard to read arbitrary formatted psql output >> from external program (not just gnuplot, but even

Re: [HACKERS] Surjective functional indexes

On 30.11.2017 05:02, Michael Paquier wrote: On Wed, Sep 27, 2017 at 4:07 PM, Simon Riggs wrote: On 15 September 2017 at 16:34, Konstantin Knizhnik wrote: Attached please find yet another version of the patch. Thanks. I'm reviewing it. Two

Re: [HACKERS] pgbench more operators & functions

I'm not sure why it wasn't failing before, but I have issues building the doc: +are built into pgbench Missing '/' to close the xref Indeed, missing xml-ization. The format was still SGML when the patch was developed. + 1 3 Expecting ';' as the previous use () Indeed, a typo.

Re: [HACKERS] logical decoding of two-phase transactions

PFA, latest patch for this functionality. This patch contains the following changes as compared to the earlier patch: - Fixed a bunch of typos and comments - Modified HeapTupleSatisfiesVacuum to return HEAPTUPLE_RECENTLY_DEAD if the transaction id is newer than OldestXmin. Doing this only for

Re: Re: User defined data types in Logical Replication

On Wed, Nov 22, 2017 at 12:25 AM, Huong Dangminh wrote: > Thanks for your response. > # And sorry again because I could not reply to your gmail > # address from my environment due to security restriction. It's okay. I can understand your environment :-) > Sorry for

Re: BUG #14941: Vacuum crashes

On Mon, Dec 4, 2017 at 8:59 AM, Lyes Ameddah wrote: > sorry guys, yes I'm talking about a FULL VACUUM and not about Auto-Vacuum. > Thank you very match for your feedback. OK, but that's not the confusion. What you said is that it CRASHES, but the behavior you described is

Re: Would a BGW need shmem_access or database_connection to enumerate databases?

On 1 December 2017 at 23:04, Chapman Flack wrote: > On 11/29/2017 05:48 PM, Chapman Flack wrote: > > I'm thinking of writing a background worker that will enumerate > > the databases present, and spin off, for each one, another BGW > > that will establish a connection and

Re: Would a BGW need shmem_access or database_connection to enumerate databases?

On 30 November 2017 at 06:48, Chapman Flack wrote: > I'm thinking of writing a background worker that will enumerate > the databases present, and spin off, for each one, another BGW > that will establish a connection and do stuff. > > For the "master" one, what

Add GROUPS option to the Window Functions

Adds the GROUPS option to the window framing clause. This further resolves TODO list item "Implement full support for window framing clauses" and implements SQL:2011 T620. No other mainstream db has this feature. Apply this on top of my previous patch available here:

Re: using index or check in ALTER TABLE SET NOT NULL

Hello I update patch and also rebase to current head. I hope now it is better aligned with project stylediff --git a/src/backend/catalog/partition.c b/src/backend/catalog/partition.c index dd4a8d3..36bcb3f 100644 --- a/src/backend/catalog/partition.c +++ b/src/backend/catalog/partition.c @@

Re: BUG #14941: Vacuum crashes

sorry guys, yes I'm talking about a FULL VACUUM and not about Auto-Vacuum. Thank you very match for your feedback. That's Waht I do : vacuum FULL VERBOSE ANALYZE; reindex database postgres; I would be happy if there is a patch to fix that ! 2017-12-01 22:16 GMT+01:00 Bossart, Nathan

Re: [HACKERS] pgbench more operators & functions

Hi, > Regenerated v15 that applies cleanly on head. No changes. I'm not sure why it wasn't failing before, but I have issues building the doc: +are built into pgbench Missing '/' to close the xref + 1 3 Expecting ';' as the previous use () On Fri, Dec 1, 2017 at 1:57 PM, Fabien

RE: Re: User defined data types in Logical Replication

Hi, > From: Huong Dangminh [mailto:huo-dangm...@ys.jp.nec.com] > I attached a patch based on Sawada-san's patch with a bit of messages > modified and remove the above check. > Could somebody check it for me or should I add it into CF? Sorry, I have added this thread to the next CF. --- Thanks

Re: Doc tweak for huge_pages?

On 12/01/2017 05:35 AM, Thomas Munro wrote: >> since it also >> supports "transparent" hugepages. > Hmm. Yeah, it does, but apparently it's not so transparent. +1. We saw performance drop with transparent_hugepage enabled on server with more than 256GB RAM. Access to the cache where slow down

Re: [HACKERS] proposal: psql command \graw

On Mon, Dec 4, 2017 at 11:21 AM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > The problem is that it's hard to read arbitrary formatted psql output from > external program (not just gnuplot, but even especially written script). I > made my scripts read few variations, but it doesn't

Re: [HACKERS] proposal: psql command \graw

On Fri, Dec 1, 2017 at 6:36 PM, Robert Haas wrote: > On Fri, Dec 1, 2017 at 12:16 AM, Michael Paquier > wrote: > > On Sat, Nov 11, 2017 at 12:57 AM, Pavel Stehule > wrote: > >> 2017-11-10 16:38 GMT+01:00 Fabien COELHO