Re: documentation fixes for partition pruning, round two

On Thu, May 24, 2018 at 11:30:40AM +0900, Amit Langote wrote: > Hi Justin. > > Thanks for writing the patch. I have a couple of comments. Thanks for your review, find attached updated patch. > +possible to show the difference between a plan whose partitions have been > +pruned and one

Re: PG11 jit failing on ppc64el

Thomas Munro writes: > BTW It is working on arm64 too, starting with LLVM 6. 5 crashed the > same way as it does on ppc. See build farm member eelpout which is > running Debian. For entertainment's sake, I tried building --with-llvm on FreeBSD 12 arm64 (hey,

Re: Simplify final sync in pg_rewind's target folder and add --no-sync

On Sun, Mar 25, 2018 at 09:26:07PM +0900, Michael Paquier wrote: > Both things are implemented as attached. I am of course not pushing for > integrating that patch in v11 even if it is straight-forward, so I'll > park it in the next future commit fest. Patch has roted per the feedback of Mr

Re: documentation fixes for partition pruning, round two

Hi Justin. Thanks for writing the patch. I have a couple of comments. On 2018/05/24 8:31, Justin Pryzby wrote: > On Thu, May 24, 2018 at 10:46:38AM +1200, David Rowley wrote: >> On 24 May 2018 at 09:35, Justin Pryzby wrote: >>> On Fri, May 18, 2018 at 08:56:53PM -0500,

Re: Postgres 11 release notes

On Tue, May 22, 2018 at 11:31:08PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Fri, May 18, 2018 at 10:28:12AM -0400, Tom Lane wrote: > >> While we're all griping about omissions from the release notes ... > >> I think you should have documented that we fixed plpgsql

Re: Possible bug in logical replication.

Hello. At Wed, 23 May 2018 15:56:22 +0900, Masahiko Sawada wrote in > > So directly set ctx->reader->EndRecPtr by startlsn fixes the > > problem, but I found another problem here. > > I confirmed that

RE: [HACKERS] Transactions involving multiple postgres foreign servers

From: Masahiko Sawada [mailto:sawada.m...@gmail.com] > > I'm for the latter. That is, COMMIT or PREPARE TRANSACTION statement > issued from an application reports an error. > > I'm not sure that we should end up with an error in such case, but if > we want then we can raise an error when the

RE: Update backend/lib/README

>Seems reasonable. Pushed, thanks! > >- Heikki > Thanks for the quick work! Ideriha, Takeshi

Re: SCRAM with channel binding downgrade attack

On Wed, May 23, 2018 at 06:41:16PM -0400, Bruce Momjian wrote: > I can imagine someone wanting both checks so merging them into a single > options seems unwise, as Magnus mentioned. FWIW, definitely agreed. -- Michael signature.asc Description: PGP signature

Re: -D option of pg_resetwal is only works with absolute path

On Wed, May 23, 2018 at 11:40:48AM -0400, David Steele wrote: > On 5/23/18 11:35 AM, Tom Lane wrote: >> I pushed a patch already, although certainly an additional pair of eyes >> on the issue would be good. > > Looks good to me. Thanks! The TAP tests cannot catch that as all paths are absolute

Re: [PATCH v14] GSSAPI encryption support

On Wed, May 23, 2018 at 04:03:12PM -0400, Stephen Frost wrote: >> Finally, I've submitted this as a single patch because it was requested >> previously. I'm happy to break it apart into many commits instead, if >> that's helpful. > > Please be sure to register this on the commitfest app. I'm

Re: [PATCH v14] GSSAPI encryption support

On Thu, May 24, 2018 at 8:00 AM, Robbie Harwood wrote: > Zombie patch is back from the dead. Hi Robbie, Robots[1] vs zombies: + $postgres->RemoveFile('src/backennd/libpq/be-gssapi-common.c'); Typo, breaks on Windows. runtime.sgml:2032: parser error : Opening and ending

Re: documentation fixes for partition pruning, round two

On Thu, May 24, 2018 at 10:46:38AM +1200, David Rowley wrote: > On 24 May 2018 at 09:35, Justin Pryzby wrote: > > On Fri, May 18, 2018 at 08:56:53PM -0500, Justin Pryzby wrote: > >> I reread this and have some more comments. > >>

Re: [PATCH] (Windows) psql echoes password when reading from pipe

Matthew Stickney writes: > The attached is a patch that uses the _fileno/_get_osfhandle approach. > This doesn't address the stdin fallback, or error handling if opening > termin fails; however, it should be no worse than what's there now, and > it fixes the immediate

Re: documentation fixes for partition pruning, round two

On 24 May 2018 at 09:35, Justin Pryzby wrote: > On Fri, May 18, 2018 at 08:56:53PM -0500, Justin Pryzby wrote: >> I reread this and have some more comments. >> https://www.postgresql.org/docs/devel/static/ddl-partitioning.html > >> Let me know if it's useful to provide a

Re: Subplan result caching

On 24 May 2018 at 04:25, Tom Lane wrote: > That's doable no doubt, but I wonder whether that leaves you in a place > that's any better than the plan-time-decorrelation approach you proposed > in the earlier thread. I liked that better TBH; this one seems like > a very ad-hoc

Re: SCRAM with channel binding downgrade attack

On Wed, May 23, 2018 at 11:15:28AM +0200, Magnus Hagander wrote: > On Wed, May 23, 2018 at 11:08 AM, Heikki Linnakangas wrote: > SCRAM, even without channel binding, does prove that you're talking to the > correct server. Or to be precise, it proves to the client, that

Re: printf format selection vs. reality

On Thu, May 24, 2018 at 8:28 AM, Tom Lane wrote: > The problem is to get a compiler that thinks that %z is a violation > of *any* archetype. gaur's compiler does think that, but it has no > archetype that does accept %z, so that's little help (I've had it > building with

Re: printf format selection vs. reality

Sigh, I'm an idiot. I forgot that USE_REPL_SNPRINTF doesn't just replace snprintf, it replaces the entire *printf family; see port.h lines 137ff. So actually we're OK as far as these %z and argument-reordering concerns go. Maybe the comments in configure could use a bit of work though. There's

documentation fixes for partition pruning, round two

On Fri, May 18, 2018 at 08:56:53PM -0500, Justin Pryzby wrote: > I reread this and have some more comments. > https://www.postgresql.org/docs/devel/static/ddl-partitioning.html > Let me know if it's useful to provide a patch. I propose this. There's two other, wider changes to consider: -

Re: PG11 jit failing on ppc64el

On Thu, May 24, 2018 at 9:00 AM, Christoph Berg wrote: > Re: Andres Freund 2018-05-23 > <20180523205521.mdzwldqabriup...@alap3.anarazel.de> >> What I meant was that I'd conditionally enable it for the other archs >> when the version is >= 7. > > Good idea, but unfortunately

Re: Time to put context diffs in the grave

On Wed, May 23, 2018 at 5:01 PM, Tom Lane wrote: > Andrew Dunstan writes: >> OK, that's done. Now I think we can get rid of git-external-diff. > > I for one rely on that. I won't tell anyone else what kind of diff > they have to read, but if

Re: plperl fails with perl 5.28

Christoph Berg writes: > Re: Tom Lane 2018-05-23 <23260.1527026...@sss.pgh.pa.us> >> but TBH I think someone oughta file a bug report first. > https://rt.perl.org/Public/Bug/Display.html?id=133220 Thanks. Looking at this again, it seems like the core of the problem is that

Re: Time to put context diffs in the grave

Andrew Dunstan writes: > OK, that's done. Now I think we can get rid of git-external-diff. I for one rely on that. I won't tell anyone else what kind of diff they have to read, but if you try to tell me what kind of diff I have to read, I'm going to complain. >

Re: PG11 jit failing on ppc64el

Re: Andres Freund 2018-05-23 <20180523205521.mdzwldqabriup...@alap3.anarazel.de> > What I meant was that I'd conditionally enable it for the other archs > when the version is >= 7. Good idea, but unfortunately there's a bunch of architectures on ports.debian.org that llvm hasn't been ported to

Re: PG11 jit failing on ppc64el

On 2018-05-23 22:45:26 +0200, Christoph Berg wrote: > Re: Andres Freund 2018-05-23 > <38f42310-62ac-48b1-8a83-639b97e5f...@anarazel.de> > > >I've disabled --with-llvm on all platforms except amd64 i386 now. Will > > >try talking to the llvm maintainers in Debian to see if we can get > > >this

Re: Time to put context diffs in the grave

On Mon, May 21, 2018 at 10:52 PM, Andres Freund wrote: > Hi, > > On 2018-05-21 21:51:11 -0400, Andrew Dunstan wrote: >> We haven't insisted on context diffs in years now, and one of my >> interlocutors has just turned handsprings trying to follow the advice at >>

Re: plperl fails with perl 5.28

Re: Tom Lane 2018-05-23 <23260.1527026...@sss.pgh.pa.us> > but TBH I think someone oughta file a bug report first. https://rt.perl.org/Public/Bug/Display.html?id=133220 Christoph

Re: PG11 jit failing on ppc64el

Re: Andres Freund 2018-05-23 <38f42310-62ac-48b1-8a83-639b97e5f...@anarazel.de> > >I've disabled --with-llvm on all platforms except amd64 i386 now. Will > >try talking to the llvm maintainers in Debian to see if we can get > >this fixed and have more coverage. > > How about making that dependant

Re: printf format selection vs. reality

Alvaro Herrera writes: > On 2018-May-23, Tom Lane wrote: >> The practical alternatives seem to be to avoid %z in frontend code, >> or to invent a macro SIZE_T_MODIFIER and use it like INT64_MODIFIER. >> Either one will be extremely error-prone, I'm afraid, unless we can

Re: printf format selection vs. reality

On 2018-May-23, Tom Lane wrote: > The practical alternatives seem to be to avoid %z in frontend code, > or to invent a macro SIZE_T_MODIFIER and use it like INT64_MODIFIER. > Either one will be extremely error-prone, I'm afraid, unless we can > find a way to get compiler warnings for violations.

Re: [PATCH v14] GSSAPI encryption support

Greetings Robbie! * Robbie Harwood (rharw...@redhat.com) wrote: > Zombie patch is back from the dead. It's been a bit more than two years > since v12 (the last major revision) and almost three since it was > originally submitted. (I do have enough pride to point out that it did > not actually

Re: [PATCH v14] GSSAPI encryption support

Hello -hackers, Zombie patch is back from the dead. It's been a bit more than two years since v12 (the last major revision) and almost three since it was originally submitted. (I do have enough pride to point out that it did not actually /take/ anywhere close to two years to update it.) CC'd

Re: Error on vacuum: xmin before relfrozenxid

2018-05-23 20:32 GMT+02:00 Andres Freund : > On 2018-05-22 16:39:58 -0700, Andres Freund wrote: > > Hi, > > > > On 2018-05-23 00:04:26 +0200, Paolo Crosato wrote: > > > I managed to recover the log of the first time we run into the issue, > the > > > error was the same but on

Re: [PATCH] (Windows) psql echoes password when reading from pipe

The attached is a patch that uses the _fileno/_get_osfhandle approach. This doesn't address the stdin fallback, or error handling if opening termin fails; however, it should be no worse than what's there now, and it fixes the immediate problem. I'm still thinking about the fallback in terms

Re: printf format selection vs. reality

I wrote: > I think we should abandon the pretense that we can work with libc > printfs that accept anything but "l"/"ll", and rip out the excess > complexity in configure, just setting INT64_MODIFIER to "l" or "ll" > depending on whether "int64" is "long" or "long long". I pushed that, but while

Re: Error on vacuum: xmin before relfrozenxid

On 2018-05-22 16:39:58 -0700, Andres Freund wrote: > Hi, > > On 2018-05-23 00:04:26 +0200, Paolo Crosato wrote: > > I managed to recover the log of the first time we run into the issue, the > > error was the same but on template1: > > > > May 8 11:26:46 xxx postgres[32543]: [1154-1]

Re: [PATCH] Clear up perlcritic 'missing return' warning

On Wed, May 23, 2018 at 1:45 PM, Alvaro Herrera wrote: > On 2018-May-23, Andrew Dunstan wrote: > >> And yes, the idea is that if we do this then we adopt a perlcritic >> policy that calls it out when we forget. > > If we can have a buildfarm animal that runs perlcritic

Re: Subplan result caching

On 2018-05-23 12:51:38 -0400, Tom Lane wrote: > Heikki Linnakangas writes: > > On 23/05/18 19:25, Tom Lane wrote: > >> To make this > >> patch safe, I think you'd need to grovel through the subquery and make > >> sure that the parameters are only used as inputs to operators that

Re: [PATCH] Clear up perlcritic 'missing return' warning

On 2018-May-23, Andrew Dunstan wrote: > And yes, the idea is that if we do this then we adopt a perlcritic > policy that calls it out when we forget. If we can have a buildfarm animal that runs perlcritic that starts green (and turns yellow with any new critique), with a config that's also part

Re: [PATCH] Clear up perlcritic 'missing return' warning

On Tue, May 22, 2018 at 4:35 PM, Mike Blackwell wrote: > On Tue, May 22, 2018 at 3:32 AM, Michael Paquier > wrote: >> >> >> And this >> maps with any C code. > > > The important differences here are: > *) Declaring a C function as void prevents

Re: Subplan result caching

Heikki Linnakangas writes: > On 23/05/18 19:25, Tom Lane wrote: >> To make this >> patch safe, I think you'd need to grovel through the subquery and make >> sure that the parameters are only used as inputs to operators that belong >> to the type's default btree or hash opfamily.

Re: Subplan result caching

On 23/05/18 19:25, Tom Lane wrote: Heikki Linnakangas writes: I've been working on a patch to add a little cache to SubPlans, to speed up queries with correlated subqueries, where the same subquery is currently executed multiple times with the same parameters. The idea is to

Re: PG11 jit failing on ppc64el

On May 23, 2018 4:59:00 AM PDT, Christoph Berg wrote: >Re: Andres Freund 2018-05-22 ><20180522151101.drsbh6p7ltxpm...@alap3.anarazel.de> >> Hi, >> >> On 2018-05-22 16:33:57 +0200, Christoph Berg wrote: >> > PG 11 beta1 is failing on ppc64el. All Debian/Ubuntu releases >except

Re: Subplan result caching

Heikki Linnakangas writes: > I've been working on a patch to add a little cache to SubPlans, to speed > up queries with correlated subqueries, where the same subquery is > currently executed multiple times with the same parameters. The idea is > to cache the result of the

Re: -D option of pg_resetwal is only works with absolute path

On 5/23/18 11:35 AM, Tom Lane wrote: David Steele writes: On 5/23/18 10:08 AM, Tom Lane wrote: Seems to be caused by careless placement of new umask-changing code. I wonder how many other places that patch broke similarly. I'll look into this today. I pushed a patch

Re: -D option of pg_resetwal is only works with absolute path

David Steele writes: > On 5/23/18 10:08 AM, Tom Lane wrote: >> Seems to be caused by careless placement of new umask-changing code. >> I wonder how many other places that patch broke similarly. > I'll look into this today. I pushed a patch already, although certainly an

Re: -D option of pg_resetwal is only works with absolute path

On 5/23/18 10:08 AM, Tom Lane wrote: tushar writes: In the  latest PG v11,  found that  -D option of pg_resetwal is only works with absolute path .. not with relative path Confirmed here. This did work in previous releases, so I'd say it's unquestionably a

Re: A Japanese-unfriendy error message contruction

Kyotaro HORIGUCHI writes: > At Tue, 22 May 2018 14:27:29 -0400, Tom Lane wrote in > <13575.1527013...@sss.pgh.pa.us> >> * Is it OK for the OCLASS_CLASS-with-subId case to assume that it can >> tack on "column COLNAME" after the description of

Re: -D option of pg_resetwal is only works with absolute path

tushar writes: > In the  latest PG v11,  found that  -D option of pg_resetwal is only > works with absolute path .. not with relative path Confirmed here. This did work in previous releases, so I'd say it's unquestionably a bug. [ diffs v10 against head... ]

Re: Subplan result caching

On 23 May 2018 at 21:31, Heikki Linnakangas wrote: > I've been working on a patch to add a little cache to SubPlans, to speed up > queries with correlated subqueries, where the same subquery is currently > executed multiple times with the same parameters. The idea is to cache the

Re: Add --include-table-data-where option to pg_dump, to export only a subset of table data

> > pg_dump.c:2323:2: warning: ISO C90 forbids mixed declarations and code > [-Wdeclaration-after-statement] > char *filter_clause = NULL; > ^ > > You need to declare this variable at the top of its scope. If you're > using GCC or Clang you might consider building with COPT=-Werror so > that

Re: Shared PostgreSQL libraries and symbol versioning

Thanks Stephen, On Wednesday, May 23, 2018 1:13:08 PM CEST Stephen Frost wrote: > Greetings, > > * Pavel Raiskup (prais...@redhat.com) wrote: > > On Thursday, May 10, 2018 12:41:40 PM CEST Pavel Raiskup wrote: > > > On Monday, April 9, 2018 11:04:33 PM CEST Tom Lane wrote: > > > > Stephen Frost

Re: Compiler warnings with --enable-dtrace

Re: Peter Geoghegan 2018-05-12

Re: PG11 jit failing on ppc64el

Re: Andres Freund 2018-05-22 <20180522151101.drsbh6p7ltxpm...@alap3.anarazel.de> > Hi, > > On 2018-05-22 16:33:57 +0200, Christoph Berg wrote: > > PG 11 beta1 is failing on ppc64el. All Debian/Ubuntu releases except > > Jessie are affected. My guess is on problems with llvm/jit, because of > >

Re: Subplan result caching

>I like the idea. +1 >Also, there probably should be a GUC for this, defaulting to "off". I think the feature could be on by default provided it can properly identify "volatile" functions/tables hidden behind views. Vladimir

Re: Subplan result caching

Heikki Linnakangas wrote: > I've been working on a patch to add a little cache to SubPlans, to speed > up queries with correlated subqueries, where the same subquery is > currently executed multiple times with the same parameters. The idea is > to cache the result of the subplan, with the

Subplan result caching

Hi, I've been working on a patch to add a little cache to SubPlans, to speed up queries with correlated subqueries, where the same subquery is currently executed multiple times with the same parameters. The idea is to cache the result of the subplan, with the correlation vars as the cache

Re: SCRAM with channel binding downgrade attack

On Wed, May 23, 2018 at 11:08 AM, Heikki Linnakangas wrote: > On 23/05/18 09:59, Magnus Hagander wrote: > >> With that, a connection would be allowed, if either the server's SSL >>> certificate is verified as with "sslmode=verify-full", *or* SCRAM >>> authentication with channel

Re: SCRAM with channel binding downgrade attack

On Wed, May 23, 2018 at 05:56:19PM +0900, Michael Paquier wrote: > OK, being able to introduce a new default if necessary is a good point. > Let's introduce a "require" mode then, which uses tls-unique > underground, while "tls-unique" and "tls-server-end-point" are > documented as

Re: SCRAM with channel binding downgrade attack

On 23/05/18 09:59, Magnus Hagander wrote: With that, a connection would be allowed, if either the server's SSL certificate is verified as with "sslmode=verify-full", *or* SCRAM authentication with channel binding was used. Or perhaps cram it into sslmode,

Re: Add --include-table-data-where option to pg_dump, to export only a subset of table data

On Wed, May 23, 2018 at 5:18 PM, Carter Thaxton wrote: > Ah yes, thanks. I did in fact have colors enabled. > I've attached a new patch generated by `git format-patch`. Hopefully that's > correct. pg_dump.c:2323:2: warning: ISO C90 forbids mixed declarations and code

Re: SCRAM with channel binding downgrade attack

On Wed, May 23, 2018 at 10:56 AM, Michael Paquier wrote: > On Wed, May 23, 2018 at 08:59:43AM +0200, Magnus Hagander wrote: > > On Wed, May 23, 2018 at 8:46 AM, Heikki Linnakangas > wrote: > >> "tls-unique" and "tls-server-end-point" are overly technical to

Re: SCRAM with channel binding downgrade attack

On Wed, May 23, 2018 at 08:59:43AM +0200, Magnus Hagander wrote: > On Wed, May 23, 2018 at 8:46 AM, Heikki Linnakangas wrote: >> "tls-unique" and "tls-server-end-point" are overly technical to users. >> They don't care which one is used, there's no difference in security. >>

Re: Shared PostgreSQL libraries and symbol versioning

On Thursday, May 10, 2018 12:41:40 PM CEST Pavel Raiskup wrote: > On Monday, April 9, 2018 11:04:33 PM CEST Tom Lane wrote: > > Stephen Frost writes: > > > * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > > >> On 4/5/18 02:04, Pavel Raiskup wrote: > > >>> As a

Re: pgAdmin4 Docker behind load balancer

On Tue, May 22, 2018 at 8:09 PM, Daniel Gustafsson wrote: > > On 22 May 2018, at 18:07, Lenain wrote: > > > > Hello hackers, > > > > We are currently using the dpage/pgadmin4 image to run a pgAdmin4 web > interface behind an AWS application load balancer. > >

Re: Error on vacuum: xmin before relfrozenxid

2018-05-23 1:39 GMT+02:00 Andres Freund : > Hi, > > On 2018-05-23 00:04:26 +0200, Paolo Crosato wrote: > > I managed to recover the log of the first time we run into the issue, the > > error was the same but on template1: > > > > May 8 11:26:46 xxx postgres[32543]: [1154-1]

Re: A Japanese-unfriendy error message contruction

Thank you for the suggestion. Is there anyone using another language who is having difficulties in translating some messages? At Tue, 22 May 2018 14:27:29 -0400, Tom Lane wrote in <13575.1527013...@sss.pgh.pa.us> > Kyotaro HORIGUCHI writes:

Re: Memory unit GUC range checks

On 17/05/18 00:56, Alexander Korotkov wrote: On Wed, May 16, 2018 at 10:41 PM, Andres Freund wrote: Generally ok, two minor points: diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 7cd2d2d80e..93402030f7 100644 {"TB", GUC_UNIT_BLOCKS,

Re: SCRAM with channel binding downgrade attack

On Wed, May 23, 2018 at 8:46 AM, Heikki Linnakangas wrote: > On 22/05/18 11:22, Michael Paquier wrote: > >> On Sat, May 19, 2018 at 09:35:57PM +0900, Michael Paquier wrote: >> >>> The previous patch has actually problems with servers using "trust", >>> "password" and any

Re: Possible bug in logical replication.

On Fri, May 18, 2018 at 2:37 PM, Kyotaro HORIGUCHI wrote: > At Thu, 17 May 2018 13:54:07 +0300, Arseny Sher wrote > in <87in7md034.fsf@ars-thinkpad> >> >> Konstantin Knizhnik writes: >> >> > I think that using

Re: [PATCH] Clear up perlcritic 'missing return' warning

On Tue, May 22, 2018 at 3:32 AM, Michael Paquier wrote: > > And this > maps with any C code. > The important differences here are: *) Declaring a C function as void prevents returning a value. The intent not to return a value is clear to any caller and is enforced by

Re: SCRAM with channel binding downgrade attack

On 22/05/18 11:22, Michael Paquier wrote: On Sat, May 19, 2018 at 09:35:57PM +0900, Michael Paquier wrote: The previous patch has actually problems with servers using "trust", "password" and any protocol which can send directly AUTH_REQ_OK as those could still enforce a downgrade to not use

Re: Add --include-table-data-where option to pg_dump, to export only a subset of table data

Ah yes, thanks. I did in fact have colors enabled. I've attached a new patch generated by `git format-patch`. Hopefully that's correct. On Mon, May 21, 2018 at 4:00 PM, Thomas Munro wrote: > On Tue, May 22, 2018 at 4:05 AM, Stephen Frost

Re: Add --include-table-data-where option to pg_dump, to export only a subset of table data

> How would you handle foreign keys? It seems easier to produce a dump > that won't restore. > This proposal will not attempt to be smart about foreign keys or anything like that. I don't believe that would even be expected. > We have the existing options: > > --include-table=table(and

-D option of pg_resetwal is only works with absolute path

Hi, In the  latest PG v11,  found that  -D option of pg_resetwal is only works with absolute path .. not with relative path e.g Not Working - [centos@localhost bin]$ ./pg_resetwal -D data pg_resetwal: could not read permissions of directory "data": No such file or directory Working -