Re: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-08-26 Thread Michael Paquier
Hi Shinoda-san, On Sun, Aug 26, 2018 at 02:21:55AM +, Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote: > Thank you very much for your comment. > I will try to modify it so that GUC can be added more generically. It seems to me that you would pass down just a string which gets allocated for

Re: Removing useless DISTINCT clauses

2018-08-26 Thread David Rowley
On 25 August 2018 at 04:05, Finnerty, Jim wrote: > I'll explore a proper way to test that it's in the single-relation case, and > will post a separate thread for the 'remove unnecessary DISTINCT' > optimization. See: has_multiple_baserels() in allpaths.c -- David Rowley

Re: simplehash.h comment

2018-08-26 Thread Thomas Munro
On Sun, Aug 26, 2018 at 2:41 PM Thomas Munro wrote: > Some more comments on simplehash.h: ... and a patch. Thoughts? -- Thomas Munro http://www.enterprisedb.com 0001-Code-review-for-simplehash.h.patch Description: Binary data

Re: patch to allow disable of WAL recycling

2018-08-26 Thread Thomas Munro
On Mon, Aug 27, 2018 at 10:14 AM Tomas Vondra wrote: > zfs (Linux) > --- > On scale 200, there's pretty much no difference. Speculation: It could be that the dnode and/or indirect blocks that point to data blocks are falling out of memory in my test setup[1] but not in yours. I don't

Re: Adding a note to protocol.sgml regarding CopyData

2018-08-26 Thread Tatsuo Ishii
> On 2018-08-25, Tatsuo Ishii wrote to the pgsql-docs mailing list ... >> Hi Bradley, >> Thank you for your follow up. Your patch looks good to me. >> Can you please re-send your message in pgsql-hackers attaching to this >> thread ... >> CommitFest app does not allow ... emails other than posted

Re: Improve behavior of concurrent ANALYZE/VACUUM

2018-08-26 Thread Michael Paquier
On Fri, Aug 24, 2018 at 05:30:01PM +, Bossart, Nathan wrote: > On 8/23/18, 9:16 PM, "Michael Paquier" wrote: >> Thanks, I have pushed the new test series, and reused it to check the >> new version of the main patch, which is attached. I have added a commit >> message and I have indented the

Re: patch to allow disable of WAL recycling

2018-08-26 Thread Tomas Vondra
On 08/25/2018 12:11 AM, Jerry Jelinek wrote: > Alvaro, > > I have previously posted ZFS numbers for SmartOS and FreeBSD to this > thread, although not with the exact same benchmark runs that Tomas did. > > I think the main purpose of running the benchmarks is to demonstrate > that there is no

Re: Small patch to remove some duplicate words in comments

2018-08-26 Thread David Rowley
On 27 August 2018 at 09:38, Thomas Munro wrote: > On Sun, Aug 26, 2018 at 11:42 PM David Rowley > wrote: >> I noticed one while looking at partprune.c and found the others with grep. > > Pushed. Thanks -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development,

Re: Small patch to remove some duplicate words in comments

2018-08-26 Thread Thomas Munro
On Sun, Aug 26, 2018 at 11:42 PM David Rowley wrote: > I noticed one while looking at partprune.c and found the others with grep. Pushed. -- Thomas Munro http://www.enterprisedb.com

Re[2]: Adding a note to protocol.sgml regarding CopyData

2018-08-26 Thread Bradley DeJong
On 2018-08-25, Tatsuo Ishii wrote to the pgsql-docs mailing list ... > Hi Bradley, > Thank you for your follow up. Your patch looks good to me. > Can you please re-send your message in pgsql-hackers attaching to this thread ... > CommitFest app does not allow ... emails other than posted to

Re: Something's busted in plpgsql composite-variable handling

2018-08-26 Thread Tom Lane
I wrote: > [ dropping and recreating a composite type confuses plpgsql ] > That's not very nice. What's worse is that it works cleanly in v10, > making this a regression, no doubt caused by the hacking I did on > plpgsql's handling of composite variables. After further poking, I've concluded

Something's busted in plpgsql composite-variable handling

2018-08-26 Thread Tom Lane
While answering someone's question I was motivated to try this: regression=# create type comp_type as (f1 int, f2 int); CREATE TYPE regression=# create function foo(int) returns int language plpgsql as ' declare z comp_type; begin z.f1 = $1; z.f2 = $1+1; return z.f1 + z.f2; end'; CREATE

Multiple reporting of syslogger errors

2018-08-26 Thread Tom Lane
I noticed while testing the fix for Alexander Kukushkin's complaint that if the syslogger process detects a problem (e.g., failure to open a new log file) while log_destination is set to "csvlog", the error report actually goes to THREE places. It gets spit out to csvlog, *and* to the stderr log

Postmaster doesn't send SIGTERM to bgworker during fast shutdown when pmState == PM_STARTUP

2018-08-26 Thread Alexander Kukushkin
Hello hackers, it is possible to start bgworker with bgw_start_time = BgWorkerStart_PostmasterStart, which will be started immediately after postmaster. But if you try to do a fast shutdown while postmaster still in the pmState == PM_STARTUP, bgworker will never get SIGTERM and postmaster will

Small patch to remove some duplicate words in comments

2018-08-26 Thread David Rowley
I noticed one while looking at partprune.c and found the others with grep. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services remove_duplicate_words_in_comments.patch Description: Binary data

Re: Postgres 11 release notes

2018-08-26 Thread Amit Kapila
On Sun, Aug 26, 2018 at 12:17 AM Bruce Momjian wrote: > > On Sat, Aug 25, 2018 at 11:42:35AM -0700, Andres Freund wrote: > > > > > > On August 25, 2018 11:41:11 AM PDT, Bruce Momjian wrote: > > >On Sun, Aug 12, 2018 at 11:21:26AM +0200, Adrien Nayrat wrote: > > >> Hello, > > >> > > >> It seems

Re: JIT compiling with LLVM v12

2018-08-26 Thread Tels
Moin, On Sat, August 25, 2018 9:34 pm, Robert Haas wrote: > On Wed, Aug 22, 2018 at 6:43 PM, Andres Freund wrote: >> Now you can say that'd be solved by bumping the cost up, sure. But >> obviously the row / cost model is pretty much out of whack here, I don't >> see how we can make reasonable

Re: JIT compiling with LLVM v12

2018-08-26 Thread Fabien COELHO
Now you can say that'd be solved by bumping the cost up, sure. But obviously the row / cost model is pretty much out of whack here, I don't see how we can make reasonable decisions in a trivial query that has a misestimation by five orders of magnitude. Before JIT, it didn't matter whether