Re: can commitfest application resend a mail?

2018-09-10 20:37 GMT+02:00 Alvaro Herrera : > On 2018-Sep-10, Pavel Stehule wrote: > > > 2018-09-10 20:13 GMT+02:00 Alvaro Herrera : > > > > > On 2018-Sep-10, Pavel Stehule wrote: > > > > > > > I use web gmail, so it is not a good news. I need it for review. I > don't > > > > archive mails in my

Re: Retrieve memory size allocated by libpq

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: not tested Spec compliant: not tested Documentation:tested, passed The implementation of PQresultMemsize is simple and correct. There

Re: [HACKERS] Secondary index access optimizations

On 9 July 2018 at 13:26, David Rowley wrote: > I started looking over this patch and have a few comments: Hi Konstantin, Wondering, are you going to be submitting an updated patch for this commitfest? If not then I think we can mark this as returned with feedback as it's been waiting on author

Re: Can I just reload the slave to change primary_conninfo?

On Mon, Sep 10, 2018 at 06:12:52PM +0300, Sergei Kornilov wrote: > There were already some discussions about move recovery.conf into GUC > infrastructure first. I continue work on one most recent patch here: > https://commitfest.postgresql.org/19/1711/ If this patch will be > committed - i plan

Re: CREATE ROUTINE MAPPING

On Mon, Sep 10, 2018 at 3:28 AM Hannu Krosing wrote: > Hi Corey > > Have you looked at pl/proxy ? > I have, a long while ago. > It does this and then some (sharding) > PL/proxy isn't a part of the SQL Standard. PL/proxy only connects to other libpq-speaking databases. The hope with routine

Re: speeding up planning with partitions

On 2018/09/11 10:11, Peter Geoghegan wrote: > On Wed, Aug 29, 2018 at 5:06 AM, Amit Langote > wrote: >> It is more or less well known that the planner doesn't perform well with >> more than a few hundred partitions even when only a handful of partitions >> are ultimately included in the plan.

Re: speeding up planning with partitions

On Wed, Aug 29, 2018 at 5:06 AM, Amit Langote wrote: > It is more or less well known that the planner doesn't perform well with > more than a few hundred partitions even when only a handful of partitions > are ultimately included in the plan. Situation has improved a bit in PG > 11 where we

Re: speeding up planning with partitions

On 30 August 2018 at 21:29, Amit Langote wrote: > Attached updated patches, with 0002 containing the changes mentioned above. Here's my first pass review on this: 0001: 1. I think the following paragraph should probably mention something about some performance difference between the two

Re: [HACKERS] PATCH: multivariate histograms and MCV lists

Hi, On 07/18/2018 09:32 AM, Konstantin Knizhnik wrote: > > > On 18.07.2018 02:58, Tomas Vondra wrote: >> On 07/18/2018 12:41 AM, Konstantin Knizhnik wrote: >>> ... >>> >>> Teodor Sigaev has proposed an alternative approach for calculating >>> selectivity of multicolumn join or compound index

Re: Index Skip Scan

> On Mon, 18 Jun 2018 at 17:26, Jesper Pedersen > wrote: > > I took Thomas Munro's previous patch [2] on the subject, added a GUC, a > test case, documentation hooks, minor code cleanups, and made the patch > pass an --enable-cassert make check-world run. So, the overall design is > the same.

Re: can commitfest application resend a mail?

On 2018-Sep-10, Pavel Stehule wrote: > 2018-09-10 20:13 GMT+02:00 Alvaro Herrera : > > > On 2018-Sep-10, Pavel Stehule wrote: > > > > > I use web gmail, so it is not a good news. I need it for review. I don't > > > archive mails in my mailbox, and I would not to start new thread. > > > > The

Re: pg_stat_statements query jumbling question

Yes, I Regards PAscal -- Sent from: http://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html

Re: StandbyAcquireAccessExclusiveLock doesn't necessarily

On Fri, Sep 7, 2018 at 6:37 PM, Tom Lane wrote: > So my inclination is to remove the reportMemoryError = false parameter, > and just let an error happen in the unlikely situation that we hit OOM > for the lock table. Wouldn't that take down the entire cluster with no restart? -- Robert Haas

Re: can commitfest application resend a mail?

2018-09-10 20:13 GMT+02:00 Alvaro Herrera : > On 2018-Sep-10, Pavel Stehule wrote: > > > I use web gmail, so it is not a good news. I need it for review. I don't > > archive mails in my mailbox, and I would not to start new thread. > > The other option is to paste your email contents in the

Re: can commitfest application resend a mail?

On 2018-Sep-10, Pavel Stehule wrote: > I use web gmail, so it is not a good news. I need it for review. I don't > archive mails in my mailbox, and I would not to start new thread. The other option is to paste your email contents in the commitfest app, which will send it as an email with the

Re: can commitfest application resend a mail?

2018-09-10 20:01 GMT+02:00 Magnus Hagander : > On Mon, Sep 10, 2018 at 10:53 AM, Pavel Stehule > wrote: > >> Hi >> >> I cannot to find a page, where I can resend a mail from mailing list >> archive. >> >> Can do it the commitfest application? It can much more comfortable, than >> searching it

Re: can commitfest application resend a mail?

On Mon, Sep 10, 2018 at 10:53 AM, Pavel Stehule wrote: > Hi > > I cannot to find a page, where I can resend a mail from mailing list > archive. > > Can do it the commitfest application? It can much more comfortable, than > searching it via majordomo. > > p.s. How I can do it with current version

Re: warnings from parser?

2018-09-10 19:39 GMT+02:00 Pavel Stehule : > > > 2018-09-10 19:38 GMT+02:00 Andrew Gierth : > >> > "Pavel" == Pavel Stehule writes: >> >> >> gram.y: In function ‘base_yyparse’: >> >> gram.y:4507:20: warning: assignment to ‘CollateClause *’ {aka ‘struct >> >> CollateClause *’} from

can commitfest application resend a mail?

Hi I cannot to find a page, where I can resend a mail from mailing list archive. Can do it the commitfest application? It can much more comfortable, than searching it via majordomo. p.s. How I can do it with current version of PostgreSQL mailing list archive? Regards Pavel

Re: warnings from parser?

2018-09-10 19:38 GMT+02:00 Andrew Gierth : > > "Pavel" == Pavel Stehule writes: > > >> gram.y: In function ‘base_yyparse’: > >> gram.y:4507:20: warning: assignment to ‘CollateClause *’ {aka ‘struct > >> CollateClause *’} from incompatible pointer type ‘Node *’ {aka ‘> > >> n-> collClause

Re: warnings from parser?

> "Pavel" == Pavel Stehule writes: >> gram.y: In function ‘base_yyparse’: >> gram.y:4507:20: warning: assignment to ‘CollateClause *’ {aka ‘struct >> CollateClause *’} from incompatible pointer type ‘Node *’ {aka ‘> >> n-> collClause = $7; >> ^ >> gram.y:4519:20: warning: assignment to

Re: warnings from parser?

2018-09-10 19:23 GMT+02:00 Pavel Stehule : > Hi > > I got new warnings > > gram.y: In function ‘base_yyparse’: > gram.y:4507:20: warning: assignment to ‘CollateClause *’ {aka ‘struct > CollateClause *’} from incompatible pointer type ‘Node *’ {aka ‘> > n->collClause = $7; >

warnings from parser?

Hi I got new warnings gram.y: In function ‘base_yyparse’: gram.y:4507:20: warning: assignment to ‘CollateClause *’ {aka ‘struct CollateClause *’} from incompatible pointer type ‘Node *’ {aka ‘> n->collClause = $7; ^ gram.y:4519:20: warning: assignment to ‘CollateClause

Re: master, static inline and #ifndef FRONTEND

Hi, On 2018-09-10 12:39:16 -0400, Tom Lane wrote: > Andres Freund writes: > > In a recent commit [1] I added a static inline which castoroides > > dislikes: ... > > It's obviously trivial to fix this case with by adding an #ifndef > > FRONTEND. But as castoroides appears to be the only animal

Re: master, static inline and #ifndef FRONTEND

Andres Freund writes: > In a recent commit [1] I added a static inline which castoroides > dislikes: ... > It's obviously trivial to fix this case with by adding an #ifndef > FRONTEND. But as castoroides appears to be the only animal showing the > problem - after subtracting the animals dead due

Re: Query is over 2x slower with jit=on

Hi, On 2018-09-10 15:42:55 +0530, Amit Khandekar wrote: > Attached is a patch that accumulates the per-worker jit counters into > the leader process. Thanks! > I think we better show per-worker jit info also. The current patch > does not show that. I think it would be easy to continue on the

Re: Pluggable Storage - Andres's take

On Mon, Sep 10, 2018 at 7:33 PM, Amit Kapila wrote: > On Mon, Sep 10, 2018 at 1:12 PM Haribabu Kommi > wrote: >> >> On Wed, Sep 5, 2018 at 2:04 PM Haribabu Kommi >> wrote: >>> >> pg_stat_get_tuples_hot_updated and others: >> /* >> * Counter tuples_hot_updated stores number of hot updates for

Re: Can I just reload the slave to change primary_conninfo?

Hello > Is there any reason this cannot be changed via a signal?  Is it a general > lack of infrastructure or is it there significant problem we want to ensure > never happens? Just make possible reload recovery.conf is not what the pgsql-hackers community want. My patch with exactly this

Re: Can I just reload the slave to change primary_conninfo?

On Mon, Sep 10, 2018 at 1:36 PM Michael Paquier wrote: > On Mon, Sep 10, 2018 at 12:08:07PM +0300, Sergei Kornilov wrote: > >> This parameter is defined in postgresql.conf > > Huh, i believe it be in future. > > Currently it is recovery.conf parameter, and yes - it can be set (or > > changed)

Re: Loaded footgun open_datasync on Windows

Noah Misch wrote: > On Wed, Jun 27, 2018 at 12:09:24PM +0200, Laurenz Albe wrote: > > Michael Paquier wrote: > > > > I have added it to the July commitfest. > > > > > > Have you looked at the possibility of removing the log file constraints > > > in pg_upgrade with the change you are doing here

Re: cache lookup failed for constraint when alter table referred by partition table

On 2018-Sep-10, Alvaro Herrera wrote: > On 2018-Sep-10, Justin Pryzby wrote: > > > Adding Alvaro > > > > On Fri, Sep 07, 2018 at 04:02:13PM +0530, Rajkumar Raghuwanshi wrote: > > > postgres=# CREATE TABLE non_part (a INT,PRIMARY KEY(a)); > > > postgres=# CREATE TABLE part (a INT REFERENCES

Re: patch to allow disable of WAL recycling

Tomas, Thank you again for running all of these tests on your various hardware configurations. I was not aware of the convention that the commented example in the config file is expected to match the default value, so I was actually trying to show what to use if you didn't want the default, but I

Re: Pluggable Storage - Andres's take

On Mon, Sep 10, 2018 at 1:12 PM Haribabu Kommi wrote: > > On Wed, Sep 5, 2018 at 2:04 PM Haribabu Kommi > wrote: >> > pg_stat_get_tuples_hot_updated and others: > /* > * Counter tuples_hot_updated stores number of hot updates for heap table > * and the number of inplace updates for zheap table.

Re: Latest HEAD fails to build

Rafia Sabih writes: >>> I tried maintaner-clean and distclean but it didn't work. FWIW, my invariable habit is to do "make distclean" *before* git pull, not after. That avoids synchronization problems like this one, where the updated makefiles don't know about some build product that used to

Re: SerializeParamList vs machines with strict alignment

Amit Kapila writes: > On Mon, Sep 10, 2018 at 8:58 AM Tom Lane wrote: >> In particular, SerializeParamList does this: >> >> /* Write flags. */ >> memcpy(*start_address, >pflags, sizeof(uint16)); >> *start_address += sizeof(uint16); >> >> immediately followed by this: >> >>

Re: Standby reads fail when autovacuum take AEL during truncation

On 9/7/18 7:36 PM, Alexander Korotkov wrote: Please, take a look at following threads: 1.https://www.postgresql.org/message-id/c9374921e50a5e8fb1ecf04eb8c6ebc3%40postgrespro.ru 2.https://www.postgresql.org/message-id/CAHGQGwE5UqFqSq1%3DkV3QtTUtXphTdyHA-8rAj4A%3DY%2Be4kyp3BQ%40mail.gmail.com

Re: cache lookup failed for constraint when alter table referred by partition table

On 2018-Sep-10, Justin Pryzby wrote: > Adding Alvaro > > On Fri, Sep 07, 2018 at 04:02:13PM +0530, Rajkumar Raghuwanshi wrote: > > postgres=# CREATE TABLE non_part (a INT,PRIMARY KEY(a)); > > postgres=# CREATE TABLE part (a INT REFERENCES non_part(a)) PARTITION BY > > RANGE(a); > > postgres=#

Re: How to find local logical replication origin?

Hi, On 10/09/18 05:30, Jinhua Luo wrote: > Because I found in the source codes that if not explicitly set (e.g. > via pg_replication_origin_session_setup), the > replorigin_session_origin included in the wal is InvalidRepOriginId, > correct? This is correct, unless explicitly set, it will be

Re: Can I just reload the slave to change primary_conninfo?

On Mon, Sep 10, 2018 at 12:08:07PM +0300, Sergei Kornilov wrote: >> This parameter is defined in postgresql.conf > Huh, i believe it be in future. > Currently it is recovery.conf parameter, and yes - it can be set (or > changed) only at database start. Thanks Sergei for the correction. Indeed

Re: [PATCH][PROPOSAL] Add enum releation option type

Hi Nikolay, I did a quick look at yout patch and have some questions/points to discuss. I like the idea of the patch and think that enum reloptions can be useful. Especially for some frequently checked values, as it was mentioned before. There are few typos in comments, like 'validateing'. I

Re: [HACKERS] Restricting maximum keep segments by repslots

Hello. At Thu, 6 Sep 2018 22:32:21 +0200, Peter Eisentraut wrote in <29bbd79d-696b-509e-578a-0fc38a3b9...@2ndquadrant.com> > This documentation > > + > +Specify the maximum size of WAL files > +that replication > +slots are allowed to retain in the > pg_wal > +

Re: Latest HEAD fails to build

On Mon, Sep 10, 2018 at 4:10 PM, Christoph Berg wrote: > Re: Rafia Sabih 2018-09-10 8hfpxsrr6mxab54ebju...@mail.gmail.com> > > Thanks for the interest and help you offered. But I didn't quite get it, > I > > tried maintaner-clean and distclean but it didn't work. > > git clean -xdf > Thanks

Re: Latest HEAD fails to build

Re: Rafia Sabih 2018-09-10 > Thanks for the interest and help you offered. But I didn't quite get it, I > tried maintaner-clean and distclean but it didn't work. git clean -xdf Christoph

Re: Adding a note to protocol.sgml regarding CopyData

>> Hello Bradley & Tatsuo-san, >> ... references to the protocol version lacks homogeneity. ... I'd suggest to keep "the vX.0 protocol" for a short version, and "the version X.0 protocol" for long ... >>> >>> I agree. Change made. >> >> Patch applies cleanly. Doc build ok. >> >>

Re: [HACKERS] Restricting maximum keep segments by repslots

Hello. At Thu, 6 Sep 2018 19:55:39 +0900, Masahiko Sawada wrote in > On Thu, Sep 6, 2018 at 4:10 PM, Kyotaro HORIGUCHI > wrote: > > Thank you for the comment. > > > > At Wed, 5 Sep 2018 14:31:10 +0900, Masahiko Sawada > > wrote in > > > >> On Tue, Sep 4, 2018 at 7:52 PM, Kyotaro HORIGUCHI

Re: Query is over 2x slower with jit=on

On 22 August 2018 at 22:21, Andres Freund wrote: > On 2018-08-22 18:39:18 +0200, Andreas Joseph Krogh wrote: >> Just to be clear; The query really runs slower (wall-clock time), it's not >> just the timing. > > I bet it's not actually running slower, it "just" takes longer to start > up due to

Re: Avoid extra Sort nodes between WindowAggs when sorting can be reused

The last version looked OK, so I'm marking this patch as ready for committer in the commitfest app. -- Alexander Kuzmenkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Bug report: Dramatic increase in conflict with recovery after upgrading 10.2->10.5

I haven't done significant debugging on this yet but if anyone else has seen this problem and can point me at anything this would be good. Otherwise I believe we will expect to debug and try to fix this problem soon. After upgrading to PostgreSQL 10.5 from 10.2, we went from one type of query

Re: Latest HEAD fails to build

> On 10 Sep 2018, at 11:35, Rafia Sabih wrote: > On Mon, Sep 10, 2018 at 2:56 PM, Daniel Gustafsson > wrote: > > On 10 Sep 2018, at 11:22, Rafia Sabih > > wrote: > > > > Hi all, > > > > After pulling the the latest commit -- > >

Re: Latest HEAD fails to build

On Mon, Sep 10, 2018 at 2:56 PM, Daniel Gustafsson wrote: > > On 10 Sep 2018, at 11:22, Rafia Sabih > wrote: > > > > Hi all, > > > > After pulling the the latest commit -- > > e3d77ea6b4e425093db23be492f236896dd7b501, > I am getting following error on compiling, > > cp: cannot stat

Re: cache lookup failed for constraint when alter table referred by partition table

Adding Alvaro On Fri, Sep 07, 2018 at 04:02:13PM +0530, Rajkumar Raghuwanshi wrote: > postgres=# CREATE TABLE non_part (a INT,PRIMARY KEY(a)); > postgres=# CREATE TABLE part (a INT REFERENCES non_part(a)) PARTITION BY > RANGE(a); > postgres=# CREATE TABLE part_p1 PARTITION OF part FOR VALUES

Re: Latest HEAD fails to build

> On 10 Sep 2018, at 11:22, Rafia Sabih wrote: > > Hi all, > > After pulling the the latest commit -- > e3d77ea6b4e425093db23be492f236896dd7b501, I am getting following error on > compiling, > cp: cannot stat ‘./dynloader.h’: No such file or directory > > Things were working fine till

Latest HEAD fails to build

Hi all, After pulling the the latest commit -- e3d77ea6b4e425093db23be492f236896dd7b501, I am getting following error on compiling, cp: cannot stat ‘./dynloader.h’: No such file or directory Things were working fine till ac27c74def5d8544530b13d5901308a342f072ac atleast. Anybody having a clue

Re: Can I just reload the slave to change primary_conninfo?

Hi > This parameter is defined in postgresql.conf Huh, i believe it be in future. Currently it is recovery.conf parameter, and yes - it can be set (or changed) only at database start. regards, Sergei

Re: Can I just reload the slave to change primary_conninfo?

On Mon, Sep 10, 2018 at 04:32:39PM +0800, Jinhua Luo wrote: > If I need to change the master address from which the slave > replicates, must I restart the postgresql? Or just reload is ok? This parameter is defined in postgresql.conf, you need to restart the instance. -- Michael signature.asc

Can I just reload the slave to change primary_conninfo?

Hi All, If I need to change the master address from which the slave replicates, must I restart the postgresql? Or just reload is ok?

Re: Pluggable Storage - Andres's take

On Wed, Sep 5, 2018 at 2:04 PM Haribabu Kommi wrote: > > On Tue, Sep 4, 2018 at 10:33 AM Andres Freund wrote: > >> Hi, >> >> Thanks for the patches! >> >> On 2018-09-03 19:06:27 +1000, Haribabu Kommi wrote: >> > I found couple of places where the zheap is using some extra logic in >> >

Re: CREATE ROUTINE MAPPING

Hi Corey Have you looked at pl/proxy ? It does this and then some (sharding) It actually started out as a set of pl/pythonu functions, but then got formalized into a full extension language for defining remote (potentially sharded) function calls Best Regards Hannu Krosng On Fri, 12 Jan

Re: CREATE ROUTINE MAPPING

Hello. At Tue, 4 Sep 2018 09:34:21 +0900, Masahiko Sawada wrote in > On Tue, Sep 4, 2018 at 5:48 AM, David Fetter wrote: > > On Fri, Aug 31, 2018 at 05:18:26PM +0900, Masahiko Sawada wrote: > >> On Thu, Jan 25, 2018 at 2:13 PM, David Fetter wrote: > >> > On Thu, Jan 18, 2018 at 04:09:13PM

Re: SerializeParamList vs machines with strict alignment

On Mon, Sep 10, 2018 at 8:58 AM Tom Lane wrote: > > I wondered why buildfarm member chipmunk has been failing hard > for the last little while. Fortunately, it's supplying us with > a handy backtrace: > > Program terminated with signal 7, Bus error. > #0 EA_flatten_into (allocated_size=,

Re: stat() on Windows might cause error if target file is larger than 4GB

On Mon, Sep 10, 2018 at 02:01:53AM +, Higuchi, Daisuke wrote: > This mail is about following bug report post: > https://www.postgresql.org/message-id/flat/153442391458.1505.9181095584291689853%40wrigleys.postgresql.org Thanks for following up on this thread. I marked that as one of my TODOs

Re: How to find local logical replication origin?

On Sat, Sep 08, 2018 at 05:41:06PM +0800, Jinhua Luo wrote: > What's the local logical replication origin, which could be used to > filter local changes in the replication slot? You are looking for that perhaps? https://www.postgresql.org/docs/devel/static/replication-origins.html After that

Re: Problem while setting the fpw with SIGHUP

On Tue, Aug 28, 2018 at 4:05 PM Kyotaro HORIGUCHI wrote: > > Hello. > > At Sat, 25 Aug 2018 14:50:53 +0530, Amit Kapila > wrote in > > On Wed, Aug 1, 2018 at 12:56 PM Kyotaro HORIGUCHI > > wrote: > > > > > > Thank you, Amit, Michael. > > > > > > > Can you verify the first patch that I have

Re: Add extension options to control TAP and isolation tests

On Wed, Sep 05, 2018 at 06:48:49PM -0700, Michael Paquier wrote: > On a recent thread of pgsql-committers has been discussed the fact that > we lacked a bit of infrastructure to allow extensions to control > isolation and TAP tests: >