On Sat, Oct 20, 2018 at 02:03:32AM -0400, Stephen Frost wrote:
> On Sat, Oct 20, 2018 at 01:11 Andres Freund wrote:
>> or the new checksum validation logic complaining about them, and such
>>> when doing backups and I wonder if that is because people simply don’t
>>> use the two together much, mak
Greetings,
On Sat, Oct 20, 2018 at 01:11 Andres Freund wrote:
> Hi,
>
> On 2018-10-20 01:07:43 -0400, Stephen Frost wrote:
> > I have to say that I can’t recall hearing much in the way of complaints
> > about pg_basebackup copying all the random cstore files
>
> Why would somebody complain about
Greetings,
On Sat, Oct 20, 2018 at 01:16 Andres Freund wrote:
> Hi,
>
> On 2018-10-20 00:25:19 -0400, Stephen Frost wrote:
> > If we are going to decide that we only deal with files in our directories
> > matching these whitelisted patterns, then shouldn’t we apply similar
> logic
> > in things
(Returns from leave and beyond the reaches of the internet)
On 18 October 2018 at 07:45, Peter Eisentraut
wrote:
> On 16/10/2018 06:33, Ashutosh Sharma wrote:
>> I think, the root cause of this problem is that CopyFrom() is using
>> the stale value of *has_before_insert_row_trig* to determine if
Hi,
On 2018-10-20 00:25:19 -0400, Stephen Frost wrote:
> If we are going to decide that we only deal with files in our directories
> matching these whitelisted patterns, then shouldn’t we apply similar logic
> in things like DROP DATABASE and any other cases where we perform actions
> in a recursi
Hi,
On 2018-10-20 01:07:43 -0400, Stephen Frost wrote:
> I have to say that I can’t recall hearing much in the way of complaints
> about pg_basebackup copying all the random cstore files
Why would somebody complain about that? It's usually desirable.
> or the new checksum validation logic compl
Greetings,
On Sat, Oct 20, 2018 at 00:58 Michael Paquier wrote:
> On Sat, Oct 20, 2018 at 12:41:04AM -0400, Stephen Frost wrote:
> > I’d also like to give David Steele a chance to comment on the specific
> API,
> > and any other backup tools authors, which I don’t think we should be
> > rushing
On Sat, Oct 20, 2018 at 12:41:04AM -0400, Stephen Frost wrote:
> I’d also like to give David Steele a chance to comment on the specific API,
> and any other backup tools authors, which I don’t think we should be
> rushing into anyway and I would think we’d only put into master..
By the way, we nee
Greetings,
On Sat, Oct 20, 2018 at 00:43 Michael Paquier wrote:
> On Sat, Oct 20, 2018 at 12:25:19AM -0400, Stephen Frost wrote:
> > On Fri, Oct 19, 2018 at 23:40 Michael Paquier
> wrote:
> >> - I agree with not doing a simple revert to not turn the buildfarm red
> >> again. This is annoying f
On Sat, Oct 20, 2018 at 12:41:04AM -0400, Stephen Frost wrote:
> I’d also like to give David Steele a chance to comment on the specific API,
> and any other backup tools authors, which I don’t think we should be
> rushing into anyway and I would think we’d only put into master..
Getting David inpu
On Thu, Oct 18, 2018 at 1:44 PM Andres Freund wrote:
> I wonder if it'd make sense to hack up a patch that logs when evicting a
> buffer while already holding another lwlock. That shouldn't be too hard.
I tried this. It looks like we're calling FlushBuffer() with more than
a single LWLock held (n
On Sat, Oct 20, 2018 at 06:24:28AM +0200, Laurenz Albe wrote:
> Here is another version, with a fix in pg_proc.dat, an improved comment
> and "wait_seconds" exercised in the regression test.
Thanks for the new version. This looks pretty good to me. I'll see if
I can review it once and then commi
On Sat, Oct 20, 2018 at 12:25:19AM -0400, Stephen Frost wrote:
> On Fri, Oct 19, 2018 at 23:40 Michael Paquier wrote:
>> - I agree with not doing a simple revert to not turn the buildfarm red
>> again. This is annoying for animal maintainers. Andrew has done a very
>> nice work in disabling manu
Greetings,
On Sat, Oct 20, 2018 at 00:31 Michael Paquier wrote:
> On Fri, Oct 19, 2018 at 08:50:04PM -0700, Andres Freund wrote:
> > On 2018-10-20 12:39:55 +0900, Michael Paquier wrote:
> >> So what I think we ought to do is the following:
> >> - Start a new thread, this one about TAP tests is n
Hi,
On 2018-10-20 13:30:46 +0900, Michael Paquier wrote:
> On Fri, Oct 19, 2018 at 08:50:04PM -0700, Andres Freund wrote:
> > On 2018-10-20 12:39:55 +0900, Michael Paquier wrote:
> >> So what I think we ought to do is the following:
> >> - Start a new thread, this one about TAP tests is not adapte
On Fri, Oct 19, 2018 at 08:50:04PM -0700, Andres Freund wrote:
> On 2018-10-20 12:39:55 +0900, Michael Paquier wrote:
>> So what I think we ought to do is the following:
>> - Start a new thread, this one about TAP tests is not adapted.
>> - Add in src/common/relpath.c the API from d55241af called
>
Greetings,
On Fri, Oct 19, 2018 at 23:40 Michael Paquier wrote:
> On Fri, Oct 19, 2018 at 06:43:18PM -0400, Tom Lane wrote:
> > Andrew Dunstan writes:
> >> I don't think just reverting it is really acceptable.
> >
> > +several. I do not mind somebody writing and installing a better fix.
> > I
I wrote:
> Fixed.
Here is another version, with a fix in pg_proc.dat, an improved comment
and "wait_seconds" exercised in the regression test.
Yours,
Laurenz Albe
From a2a7f9fd1b23ad102d11992b22158dab8b5451d5 Mon Sep 17 00:00:00 2001
From: Laurenz Albe
Date: Sat, 20 Oct 2018 06:21:00 +0200
Subje
Hi,
On 2018-10-20 12:39:55 +0900, Michael Paquier wrote:
> - I agree with Stephen's point that we should decide if a file has
> checksums or not in a single place, and that we should use the same
> logic for base backups and pg_verify_checksums.
To be clear, I wholeheartedly agree on that. We pr
On Fri, Oct 19, 2018 at 06:43:18PM -0400, Tom Lane wrote:
> Andrew Dunstan writes:
>> I don't think just reverting it is really acceptable.
>
> +several. I do not mind somebody writing and installing a better fix.
> I do object to turning the buildfarm red again.
I did not expect this thread to
Hi,
buildfarm member lorikeet had an interesting buildfarm failure in the
logical decoding test. The failure looks unrelated to logical decoding,
but might be more widely relevant:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lorikeet&dt=2018-10-19%2011%3A22%3A34
VACUUM FULL pg_class
On Fri, Oct 19, 2018 at 10:00 AM Adelino Silva <
adelino.j.si...@googlemail.com> wrote:
> Hi,
>
> What is the advantage to use archive_mode = always in a slave server
> compared to archive_mode = on (shared WAL archive) ?
> I only see duplication of Wal files, what is the purpose of this feature ?
Hi,
I am using postgresql at work, and I would like to contribute.
>From the todo list, I chose:
Allow log_min_messages to be specified on a per-module basis
Is this feature always wanted ? That would be my first contribution to
postgresql, is it an easy one ?
Thanks,
Saïd
Andrew Dunstan writes:
> I don't think just reverting it is really acceptable.
+several. I do not mind somebody writing and installing a better fix.
I do object to turning the buildfarm red again.
regards, tom lane
Greetings,
* Andres Freund (and...@anarazel.de) wrote:
> On 2018-10-19 17:32:58 -0400, Stephen Frost wrote:
> > As you pointed out previously, the current code *doesn't* work, before
> > or after this change, and we clearly need to rework this to move things
> > into libpgcommon and also fix pg_ba
On 10/19/2018 05:32 PM, Stephen Frost wrote:
As you pointed out previously, the current code *doesn't* work, before
or after this change, and we clearly need to rework this to move things
into libpgcommon and also fix pg_basebackup. Reverting this would at
least get us back to having similar
Hi,
On 2018-10-19 17:32:58 -0400, Stephen Frost wrote:
> As you pointed out previously, the current code *doesn't* work, before
> or after this change, and we clearly need to rework this to move things
> into libpgcommon and also fix pg_basebackup. Reverting this would at
> least get us back to h
Greetings,
* Andres Freund (and...@anarazel.de) wrote:
> On 2018-10-19 16:35:46 -0400, Stephen Frost wrote:
> > The only justification for *not* doing this is that some extension
> > author might have dumped files into our tablespace directory, something
> > we've never claimed to support nor gene
Hi,
On 2018-10-19 16:35:46 -0400, Stephen Frost wrote:
> The only justification for *not* doing this is that some extension
> author might have dumped files into our tablespace directory, something
> we've never claimed to support nor generally worried about in all the
> time that I can recall bef
Greetings,
* Andres Freund (and...@anarazel.de) wrote:
> On 2018-10-19 15:57:28 -0400, Stephen Frost wrote:
> > Perhaps it doesn't today but surely one goal of pg_verify_checksum is to
> > be able to run it on a running cluster eventually.
>
> I was saying *precisely* that above. I give up.
I'm
On 2018-10-19 15:57:28 -0400, Stephen Frost wrote:
> > > > > Of course- the same is true with a crash/restart case, so I'm not sure
> > > > > what you're getting at here.
> > > >
> > > > pg_verify_checksum doesn't support running on a crashed cluster, and I'm
> > > > not sure it'd make sense to te
Greetings,
* Andres Freund (and...@anarazel.de) wrote:
> On 2018-10-19 14:47:51 -0400, Stephen Frost wrote:
> > * Andres Freund (and...@anarazel.de) wrote:
> > > Oh, for crying out loud. Yes, obviously you can create conflicts, nobody
> > > ever doubted that. How on earth is that a useful point fo
Hi,
On 2018-10-19 14:47:51 -0400, Stephen Frost wrote:
> * Andres Freund (and...@anarazel.de) wrote:
> > On 2018-10-19 14:11:03 -0400, Stephen Frost wrote:
> > > * Andres Freund (and...@anarazel.de) wrote:
> > > > cstore e.g. does this, and it's already out there. So yes, we should
> > > > provide
Hello Sir/ Madam,
I participated last year in the Google Code-in Competition and I kept track
of the participating organizations. I feel that your organization fits my
interests and skill sets perfectly and is the best addition to the
participating organizations. I wish to mentor in the GCI this y
Greetings,
* Andres Freund (and...@anarazel.de) wrote:
> On 2018-10-19 14:11:03 -0400, Stephen Frost wrote:
> > * Andres Freund (and...@anarazel.de) wrote:
> > > cstore e.g. does this, and it's already out there. So yes, we should
> > > provide better infrastructure. But for now, we gotta deal wit
Hi,
Thank you for the review.
I fixed a typo and some comments. Please find new version attached.
---
Best regards,
Parfenov Aleksandr
On Fri, 19 Oct 2018 at 16:40, Anthony Bykov wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: teste
On 2018-10-19 14:11:03 -0400, Stephen Frost wrote:
> Greetings,
>
> * Andres Freund (and...@anarazel.de) wrote:
> > On 2018-10-19 13:52:28 -0400, Stephen Frost wrote:
> > > > > I also categorically disagree with the notion that it's ok for
> > > > > extensions to dump files into our tablespace dir
On 2018-10-19 14:08:19 -0400, J Chapman Flack wrote:
> On 10/19/2018 01:17 PM, Andres Freund wrote:
> > On 2018-10-19 10:36:59 -0400, Stephen Frost wrote:
> >
> >> I also categorically disagree with the notion that it's ok for
> >> extensions to dump files into our tablespace diretories
> >
>
On 10/19/2018 01:17 PM, Andres Freund wrote:
> On 2018-10-19 10:36:59 -0400, Stephen Frost wrote:
>
>> I also categorically disagree with the notion that it's ok for
>> extensions to dump files into our tablespace diretories
>
> I'm unconvinced. There already are extensions doing so, and it's
Greetings,
* Andres Freund (and...@anarazel.de) wrote:
> On 2018-10-19 13:52:28 -0400, Stephen Frost wrote:
> > > > I also categorically disagree with the notion that it's ok for
> > > > extensions to dump files into our tablespace diretories or that we
> > > > should try to work around random cod
Hi,
On 2018-10-19 13:52:28 -0400, Stephen Frost wrote:
> > > I also categorically disagree with the notion that it's ok for
> > > extensions to dump files into our tablespace diretories or that we
> > > should try to work around random code dumping extra files in the
> > > directories which we mai
Greetings,
* Andres Freund (and...@anarazel.de) wrote:
> On 2018-10-19 10:36:59 -0400, Stephen Frost wrote:
> > * Michael Paquier (mich...@paquier.xyz) wrote:
> > > On Wed, Oct 17, 2018 at 05:30:05PM -0400, Andrew Dunstan wrote:
> > > > Fine by me.
> > >
> > > Thanks. This is now committed after
Hi hackers,
Currently Postgres has options for continuous WAL files archiving, which
is quite often used along with master-replica setup. OK, then the worst
is happened and it's time to get your old master back and synchronize it
with new master (ex-replica) with pg_rewind. However, required W
Hi,
On 2018-10-19 10:36:59 -0400, Stephen Frost wrote:
> * Michael Paquier (mich...@paquier.xyz) wrote:
> > On Wed, Oct 17, 2018 at 05:30:05PM -0400, Andrew Dunstan wrote:
> > > Fine by me.
> >
> > Thanks. This is now committed after some tweaks to the comments, a bit
> > earlier than I thought
Greetings,
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> Stephen Frost writes:
> > * Tom Lane (t...@sss.pgh.pa.us) wrote:
> >> Seems like a job for a new(?) module in src/common/.
>
> > Yeah, that would be nice... Even nicer would be a way for non-core PG
> > tools to be able to use it (we have basi
Stephen Frost writes:
> * Tom Lane (t...@sss.pgh.pa.us) wrote:
>> Seems like a job for a new(?) module in src/common/.
> Yeah, that would be nice... Even nicer would be a way for non-core PG
> tools to be able to use it (we have basically the same thing in
> pgbackrest, unsurprisingly), though I
Greetings,
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> Michael Banck writes:
> > Am Freitag, den 19.10.2018, 10:36 -0400 schrieb Stephen Frost:
> >> I just saw this committed and I'm trying to figure out why we are
> >> creating yet-another-list when it comes to deciding what should be
> >> checksum
Michael Banck writes:
> Am Freitag, den 19.10.2018, 10:36 -0400 schrieb Stephen Frost:
>> I just saw this committed and I'm trying to figure out why we are
>> creating yet-another-list when it comes to deciding what should be
>> checksum'd and what shouldn't be.
> To be fair, the list in src/back
Hi,
Am Freitag, den 19.10.2018, 10:36 -0400 schrieb Stephen Frost:
> Greetings,
>
> * Michael Paquier (mich...@paquier.xyz) wrote:
> > On Wed, Oct 17, 2018 at 05:30:05PM -0400, Andrew Dunstan wrote:
> > > Fine by me.
> >
> > Thanks. This is now committed after some tweaks to the comments, a bit
Greetings,
* Michael Paquier (mich...@paquier.xyz) wrote:
> On Wed, Oct 17, 2018 at 05:30:05PM -0400, Andrew Dunstan wrote:
> > Fine by me.
>
> Thanks. This is now committed after some tweaks to the comments, a bit
> earlier than I thought first.
I just saw this committed and I'm trying to figu
On 10/19/18 2:03 AM, Mehman Jafarov wrote:
Hi everyone,
I have a problem with partitioned table in PostgreSql.
Actually I use the version 10. I created the partitioned table in test
environment but face some problems with partitioned table constraint.
I google all about it last week and from th
John Naylor writes:
> I changed the signature of a freespace.c function that the BRIN code
> calls, and this change by itself doesn't cause a crash. With the full
> FSM patch, causing BRIN errors in manual queries in psql doesn't cause
> a crash. However, during the BRIN regression tests, the quer
On Fri, Oct 19, 2018 at 03:00:15PM +0100, Adelino Silva wrote:
> What is the advantage to use archive_mode = always in a slave server
> compared to archive_mode = on (shared WAL archive) ?
> I only see duplication of Wal files, what is the purpose of this
> feature?
Some users like having redundan
On Thu, Oct 18, 2018 at 09:57:00PM +0200, Peter Eisentraut wrote:
> I noticed that get_attidentity() isn't really necessary because the
> information can be obtained from an existing tuple descriptor in each
> case.
This one is also recent, so it looks fine to remove it.
> Also, get_atttypmod() h
On 10/18/2018 08:25 PM, Thomas Munro wrote:
On Fri, Oct 19, 2018 at 1:13 PM Michael Paquier wrote:
On Thu, Oct 18, 2018 at 08:31:11AM -0400, Andrew Dunstan wrote:
The attached ridiculously tiny patch solves the problem whereby while we can
run Postgres on Windows safely from an Administrator
Hi,
What is the advantage to use archive_mode = always in a slave server
compared to archive_mode = on (shared WAL archive) ?
I only see duplication of Wal files, what is the purpose of this feature ?
Many thanks in advance,
Adelino.
On Wed, Oct 17, 2018 at 05:30:05PM -0400, Andrew Dunstan wrote:
> Fine by me.
Thanks. This is now committed after some tweaks to the comments, a bit
earlier than I thought first.
--
Michael
signature.asc
Description: PGP signature
Hi all,
I ran into a surprising behavior while hacking on the FSM delay patch.
I changed the signature of a freespace.c function that the BRIN code
calls, and this change by itself doesn't cause a crash. With the full
FSM patch, causing BRIN errors in manual queries in psql doesn't cause
a crash.
Attached is a patch to speed up text_position_setup/next(), in some
common cases with multibyte encodings.
text_position_next() uses the Boyer-Moore-Horspool search algorithm,
with a skip table. Currently, with a multi-byte encoding, we first
convert both input strings to arrays of wchars, and
Michael Paquier wrote:
> + /* wait for up to a minute for promotion */
> + for (i = 0; i < WAITS_PER_SECOND * WAIT_SECONDS; ++i)
> + {
> + if (!RecoveryInProgress())
> + PG_RETURN_BOOL(true);
> +
> + pg_usleep(100L / WAITS_PER_
On 2018/10/19 16:47, Michael Paquier wrote:
> On Fri, Oct 19, 2018 at 01:05:52PM +0900, Amit Langote wrote:
>> As I said above, the price of removing relhassubclass might be a bit
>> steep. So, the other alternative I mentioned before is to set
>> relhassubclass correctly even for indexes if only
Thanks for commenting.
On 2018/10/19 15:17, Michael Paquier wrote:
> On Fri, Oct 19, 2018 at 01:45:03AM -0400, Tom Lane wrote:
>> Amit Langote writes:
>>> Should relhassubclass be set/reset for partitioned indexes?
>>
>> Seems like a reasonable idea to me, at least the "set" end of it.
>> We don'
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Hello,
I was trying to review your patch, but I couldn't install it:
pr
Hi everyone,
I have a problem with partitioned table in PostgreSql.
Actually I use the version 10. I created the partitioned table in test
environment but face some problems with partitioned table constraint.
I google all about it last week and from the official site I get that
version 11 will be
Hello. Thank you for the comment.
At Thu, 4 Oct 2018 04:27:04 +, "Ideriha, Takeshi"
wrote in
<4E72940DA2BF16479384A86D54D0988A6F1BCB6F@G01JPEXMBKW04>
> >As a *PoC*, in the attached patch (which applies to current master), size of
> >CTups are
> >counted as the catcache size.
> >
> >It also
On Fri, Oct 19, 2018 at 01:05:52PM +0900, Amit Langote wrote:
> As I said above, the price of removing relhassubclass might be a bit
> steep. So, the other alternative I mentioned before is to set
> relhassubclass correctly even for indexes if only for pg_partition_tree to
> be able to use find_in
66 matches
Mail list logo
