Re: Optimizing nested ConvertRowtypeExpr execution

2018-11-06 Thread Andrew Gierth
> "Kyotaro" == Kyotaro HORIGUCHI writes: Kyotaro> My last comment was the while() loop does nothing. Ashutosh Kyotaro> said that it is on the model of RelabelType. Kyotaro> I examined the code for T_RelabelType again and it is Kyotaro> intending that the ece_mutator can convert something

Re: [Bug Fix]ECPG: cancellation of significant digits on ECPG

2018-11-06 Thread Dmitry Dolgov
> On Tue, 6 Nov 2018 at 10:19, Higuchi, Daisuke > wrote: > > Thank you for checking! > I rebased patches on the current master, so I attach them. After adding 'EXEC SQL ALLOCATE DESCRIPTOR sqlda' I've managed to reproduce the problem you're talking about, and indeed it looks strange: =# table t

Re: csv format for psql

2018-11-06 Thread Daniel Verite
Michael Paquier wrote: > Ordering them in alphabetical order is a good idea due to the high > number of options available, and more would pile up even if this > separates a bit "aligned" and "unaligned", so I have have separated > those diffs from the core patch and committed it, leaving t

Re: [HACKERS] generated columns

2018-11-06 Thread Simon Riggs
On Tue, 6 Nov 2018 at 04:31, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 31/10/2018 08:58, Erikjan Rijkers wrote: > > I have also noticed that logical replication isn't possible on tables > > with a generated column. That's a shame but I suppsoe that is as > > expected. > > T

Re: ON COMMIT actions and inheritance

2018-11-06 Thread Alvaro Herrera
While you're there -- I think the CCI after the heap_truncate is not needed. Could as well get rid of it ... -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: plruby: rb_iterate symbol clash with libruby.so

2018-11-06 Thread Pavel Raiskup
On Monday, November 5, 2018 9:06:41 PM CET Robert Haas wrote: > On Sat, Nov 3, 2018 at 2:20 PM Tom Lane wrote: > > > Is it realistic we could rename red-black tree methods from 'rb_*' to e.g. > > > 'rbt_*' to avoid this clash? > > > > That's not terribly appetizing, because it essentially means we

Re: [HACKERS] generated columns

2018-11-06 Thread Peter Eisentraut
On 31/10/2018 08:58, Erikjan Rijkers wrote: > I have also noticed that logical replication isn't possible on tables > with a generated column. That's a shame but I suppsoe that is as > expected. This is an issue we need to discuss. How should this work? The simplest solution would be to exclu

Re: [HACKERS] generated columns

2018-11-06 Thread Peter Eisentraut
On 30/10/2018 16:14, Sergei Kornilov wrote: > Hi > > I applied this patch on top 2fe42baf7c1ad96b5f9eb898161e258315298351 commit > and found a bug while adding STORED column: > > postgres=# create table test(i int); > CREATE TABLE > postgres=# insert into test values (1),(2); > INSERT 0 2 > post

Re: Connection slots reserved for replication

2018-11-06 Thread Kyotaro HORIGUCHI
Hello. Thank you for the new version. At Thu, 1 Nov 2018 11:58:52 +0100, Alexander Kukushkin wrote in > Hi, > > Attached rebased version patch to the current HEAD and created commit fest > entry > On Fri, 21 Sep 2018 at 13:43, Alexander Kukushkin wrote: > > > > Hi, > > > > On 20 September 20

Re: BUG #15449: file_fdw using program cause exit code error when using LIMIT

2018-11-06 Thread Etsuro Fujita
(2018/11/06 12:53), Kyotaro HORIGUCHI wrote: At Fri, 02 Nov 2018 22:05:36 +0900, Etsuro Fujita wrote in<5bdc4ba0.7050...@lab.ntt.co.jp> (2018/10/29 15:58), Kyotaro HORIGUCHI wrote: At Tue, 23 Oct 2018 13:21:31 +0100, Tom Lane wrote in<18397.1540297...@sss.pgh.pa.us> It's just a POC because

Re: PostgreSQL Limits and lack of documentation about them.

2018-11-06 Thread John Naylor
On 11/1/18, David Rowley wrote: > I've attached an updated patch, again it's just intended as an aid for > discussions at this stage. Also included the rendered html. Looks good so far. Based on experimentation with toasted columns, it seems the largest row size is 452GB, but I haven't tried tha

Re: BUG #15449: file_fdw using program cause exit code error when using LIMIT

2018-11-06 Thread Thomas Munro
On Wed, Oct 24, 2018 at 1:21 AM Tom Lane wrote: > I wrote: > > =?utf-8?q?PG_Bug_reporting_form?= writes: > >> SELECT * FROM test_file_fdw_program_limit LIMIT 0; > >> /* > >> [38000] ERROR: program "echo "test"" failed Detail: child process exited > >> with exit code 1 > >> */ > > > Yeah, I can re

Re: PostgreSQL Limits and lack of documentation about them.

2018-11-06 Thread John Naylor
On 11/1/18, Andrew Gierth wrote: > So (with 8k blocks) the limit on the number of non-null external-toasted > columns is about 450, while you can have the full 1600 columns if they > are integers or smaller, or just over 1015 bigints. But you can have > 1600 text columns if they average 4 bytes or

Re: ON COMMIT actions and inheritance

2018-11-06 Thread Amit Langote
Hi, On 2018/11/06 12:03, Michael Paquier wrote: > On Mon, Nov 05, 2018 at 02:37:05PM +0900, Amit Langote wrote: >> Michael pointed out a problem with specifying different ON COMMIT actions >> on a temporary inheritance parent and its children: >> >> https://www.postgresql.org/message-id/2018110205

Performance improvements of INSERTs to a partitioned table

2018-11-06 Thread Kato, Sho
Hi, I want to discuss performance improvements of INSERTs to a partitioned table. When an application inserts records into a table partitioned into thousands, find_all_inheritors() locks all of the partitions. Updating partition key locks in the same way. So, Execution time becomes longer as th

RE: [Bug Fix]ECPG: cancellation of significant digits on ECPG

2018-11-06 Thread Higuchi, Daisuke
From: Dmitry Dolgov [mailto:9erthali...@gmail.com] > Thanks for the patches. Unfortunately, judging from the cfbot.cputube.org they > can't be applied anymore to the current master, could you please rebase them? Thank you for checking! I rebased patches on the current master, so I attach them.

Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation

2018-11-06 Thread Amit Langote
Hi, Thank you for looking at this. On 2018/11/06 7:25, Alvaro Herrera wrote: > On 2018-Aug-07, Amit Langote wrote: > >>> But in >>> case of partitioning there is only one parent and hence >>> coldef->constraints is NULL and hence just overwriting it works. I >>> think we need comments mentioning

Re: Support custom socket directory in pg_upgrade

2018-11-06 Thread Thomas Munro
On Wed, Oct 10, 2018 at 9:27 AM Daniel Gustafsson wrote: > > On 9 Oct 2018, at 16:22, Tom Lane wrote: > > Daniel Gustafsson writes: > >> Having hit the maximum socketdir length error a number of times in > >> pg_upgrade, > >> especially when running tests in a deep directory hierarchy, I figure

Re: Optimizing nested ConvertRowtypeExpr execution

2018-11-06 Thread Kyotaro HORIGUCHI
Sorry for the absense. At Sun, 4 Nov 2018 16:26:12 +0100, Dmitry Dolgov <9erthali...@gmail.com> wrote in > > On Sun, 4 Nov 2018 at 15:48, Andrew Gierth > > wrote: > > > > > "Dmitry" == Dmitry Dolgov <9erthali...@gmail.com> writes: > > > > Dmitry> This patch went through the last tree comm

<    1   2