Re: BUG #15623: Inconsistent use of default for updatable view

2019-02-27 Thread Dean Rasheed
On Tue, 12 Feb 2019 at 10:33, Dean Rasheed wrote: > Here's an updated patch ... So I pushed that. However, ... Playing around with it some more, I realised that whilst this appeared to fix the reported problem, it exposes another issue which is down to the interaction between rewriteTargetListIU

Re: Segfault when restoring -Fd dump on current HEAD

2019-02-27 Thread Dmitry Dolgov
> On Tue, Feb 26, 2019 at 11:53 PM Alvaro Herrera > wrote: > > On 2019-Feb-26, Dmitry Dolgov wrote: > > > Yes, it should be rather simple, we can e.g. return to the old less > > consistent > > NULL handling approach something (like in the attached patch), or replace a > > NULL > > value with an

Re: get_controlfile() can leak fds in the backend

2019-02-27 Thread Andres Freund
Hi, On 2019-02-27 10:23:45 +0100, Fabien COELHO wrote: > However, while at it, there is also the question of whether the control file > should be locked when updated, eg with flock(2) to avoid race conditions > between concurrent commands. ISTM that there is currently not such thing in > the code,

Re: get_controlfile() can leak fds in the backend

2019-02-27 Thread Fabien COELHO
Bonjour Michaël, Thoughts? None. However, while at it, there is also the question of whether the control file should be locked when updated, eg with flock(2) to avoid race conditions between concurrent commands. ISTM that there is currently not such thing in the code, but that it would be

Re: BUG #15589: Due to missing wal, restore ends prematurely and opens database for read/write

2019-02-27 Thread leif
"Michael Paquier" skrev 26. februar 2019 kl. 09:13: > On Thu, Jan 31, 2019 at 09:26:48PM +0900, Kyotaro HORIGUCHI wrote: > >> I don't think no one expected that server follows >> recovery_target_action without setting a target, so we can change >> the behavior when any kind of target is specifie

RE: Protect syscache from bloating with negative cache entries

2019-02-27 Thread Ideriha, Takeshi
>From: Robert Haas [mailto:robertmh...@gmail.com] > >On Mon, Feb 25, 2019 at 3:50 AM Tsunakawa, Takayuki > wrote: >> How can I make sure that this context won't exceed, say, 10 MB to avoid OOM? > >As Tom has said before and will probably say again, I don't think you actually >want that. >We know t

Re: psql show URL with help

2019-02-27 Thread Peter Eisentraut
On 2019-02-25 12:05, Peter Eisentraut wrote: > On 2019-02-21 18:28, Peter Eisentraut wrote: >> => \h analyze > >> URL: https://www.postgresql.org/docs/12/sql-analyze.html >> > > Here is a patch. > > It doesn't deal with the "devel" paths yet. Discussion there is still > ongoing a bit. A n

<    1   2