On 2019-May-30, Michael Paquier wrote:
> On Thu, May 30, 2019 at 01:52:20PM -0400, Alvaro Herrera wrote:
> > If there are other obvious improvements to be had, please let me know.
> > (We have PG_TEST_EXTRA="ssl ldap" currently, do we have any more extra
> > tests now?)
>
> You can add kerberos
Actually I'd like to add something to this. I think I've found a bug in the
current implementation. Would someone be able to check?
Given a table definition of (market text, feedcode text, updated_at
timestamptz, value float8) and an index on (market, feedcode, updated_at desc)
(note that this
After some talks with Jesper at PGCon about the Index Skip Scan, I started
testing this patch, because it seems to have great potential in speeding up
many of our queries (great conference by the way, really enjoyed my first time
being there!). I haven't looked in depth to the code itself, but
Speaking with Robert today at pgcon, I happily discovered that REFRESH
MATERIALIZED VIEW CONCURRENTLY actually only updates rows that have changed
since the last refresh, rather than rewriting every row. In my curiosity,
I went to the docs, and found that this detail is not mentioned anywhere.
I wrote:
> There are various other minor issues, but they generally look
> fixable with little consequence.
I've now pushed your patch and additional minor fixes, and
we've expanded cpluspluscheck's coverage so we don't miss
such issues in future.
regards, tom lane
Hi,
On 2019-05-31 09:56:45 -0400, Tom Lane wrote:
> Andres Freund writes:
> > Attached is a small patch allowing cpluspluscheck to run from different
> > directories. I needs the src and build directories for that,
> > unsurprisingly.
>
> No objection to changing this, but you could reduce the
On 2018-Oct-24, Chapman Flack wrote:
> Inspired by the wiki page on PostgreSQL vs SQL Standard in general,
> I have made another wiki page specifically about $subject. I hope
> this was not presumptuous, and invite review / comment. I have not
> linked to it from any other page yet.
In the SQL
I've rebased the patch on master and confirmed make check world passes.
incremental-sort-27.patch
Description: Binary data
On 2019-May-30, Alvaro Herrera wrote:
> One thing I noticed while writing it, though, is that worker_spi uses
> the postgres database, instead of the contrib_regression database that
> was created for it. And we create a schema and a table there. This is
> going to get some eyebrows raised, I
On Fri, 3 May 2019 at 19:06, David Rowley wrote:
> FWIW, I'm in favour of changing ATTACH PARTITION's INFO messages to
> DEBUG1 for PG12 to align it to what bbb96c3704c did.
>
> Anyone else?
Does anyone think we shouldn't change the INFO message in ATTACH
PARTITION to a DEBUG1 in PG12?
I think
Isaac Morland writes:
> Given that other built-in types have built-in range types, I think that the
> time and timetz types should also have built-in range types.
There's only a very small number of built-in range types:
postgres=# select typname from pg_type where typtype = 'r' order by 1;
timetzrange is also missing. In my database I have:
CREATE TYPE timerange AS RANGE (SUBTYPE = time);
COMMENT ON TYPE timerange IS 'range of times without time zone';
GRANT USAGE ON TYPE timerange TO PUBLIC;
CREATE TYPE timetzrange AS RANGE (SUBTYPE = timetz);
COMMENT ON TYPE timetzrange IS
On Fri, 31 May 2019 at 05:02, Antonin Houska wrote:
> Please see the diff attached.
Pushed. Thanks.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Alvaro Herrera writes:
> I forgot to mention that this patch produces a new warning:
> /pgsql/source/master/src/backend/tcop/postgres.c: In function 'quickdie':
> /pgsql/source/master/src/backend/tcop/postgres.c:2737:2: warning: implicit
> declaration of function '__gcov_flush'; did you mean
On 2019-May-31, Alvaro Herrera wrote:
> On 2019-May-30, Michael Paquier wrote:
>
> > On Wed, May 29, 2019 at 12:09:08PM -0400, Alvaro Herrera wrote:
> > > Are there objections to doing that now on the master branch?
> >
> > Adding the flush call just on HEAD is fine for me. Not sure that
> >
On 2019-May-30, Michael Paquier wrote:
> On Wed, May 29, 2019 at 12:09:08PM -0400, Alvaro Herrera wrote:
> > Are there objections to doing that now on the master branch?
>
> Adding the flush call just on HEAD is fine for me. Not sure that
> there is an actual reason to back-patch that.
Okay
Donald Shtjefni schrieb am 31.05.2019 um 13:35:
> I was wondering why there is not a type Range of time without time zone, I
> think it may be useful for someone, Is good if i do PR.
you can easily create one:
create type timerange as range (subtype = time);
Thomas
On 2018-06-01 14:22:26, Alexander Korotkov wrote:
> I'd like to note, that I'm going to provide revised version of this patch
> to the next commitfest.
> After some conversations at PGCon regarding this patch, I got more
> confident that providing separate paths for incremental sorts is right.
>
On Fri, May 31, 2019 at 08:35:31AM +0200, Donald Shtjefni wrote:
Hi,
I was wondering why there is not a type Range of time without time zone, I
think it may be useful for someone, Is good if i do PR.
Sorry if I've worte in the wrong place
Doesn't tsrange already do that? That's a timestamp
Hi,
I was wondering why there is not a type Range of time without time zone, I
think it may be useful for someone, Is good if i do PR.
Sorry if I've worte in the wrong place
Andres Freund writes:
> Attached is a small patch allowing cpluspluscheck to run from different
> directories. I needs the src and build directories for that,
> unsurprisingly.
No objection to changing this, but you could reduce the surprise
factor for existing workflows with a couple of
Andres Freund writes:
> On 2019-05-30 14:01:00 -0400, Tom Lane wrote:
>> Kinda looks like you can't get away with using "struct" on a forward
>> declaration of something that is not actually a struct type.
> Ugh. Odd that only C++ compilers complain. I just removed the typedef,
> it's not needed
On Fri, 31 May 2019 at 03:18, Kato, Sho wrote:
> Is it possible to improve a subquery quals to pull up into outer query?
Sure, it's possible, but it would require writing code. When it can
and cannot/should not be done would need to be determined.
--
David Rowley
On Thu, 30 May 2019 at 11:39, Magnus Hagander wrote:
> Congratulations to David, may the buildfarm be gentle to him, and his first
> revert far away!
Thank you, all. I will do my best not to anger the build gods and
turn the farm red ;-)
--
David Rowley
On 5/30/19 11:39 AM, Magnus Hagander wrote:
Congratulations to David, may the buildfarm be gentle to him, and his first
revert far away!
Congrats !
Best regards,
Jesper
On Fri, 31 May 2019 at 11:08, Amit Khandekar wrote:
>
> On Thu, 30 May 2019 at 20:13, Andres Freund wrote:
> >
> > Hi,
> >
> > On 2019-05-30 19:46:26 +0530, Amit Khandekar wrote:
> > > @@ -1042,7 +1042,8 @@ ReplicationSlotReserveWal(void)
> > > if (!RecoveryInProgress() && SlotIsLogical(slot))
Please see the diff attached.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
diff --git a/src/include/access/tableam.h b/src/include/access/tableam.h
index bf3a472018..e3619b8e7e 100644
--- a/src/include/access/tableam.h
+++ b/src/include/access/tableam.h
@@ -1331,7 +1331,7 @@
Monday, May 27, 2019 7:56 PM Tom Lane wrote:
> No, what is happening there is that the subquery gets inlined into the
> outer query. That can't happen in your previous example because of the
> aggregation/GROUP BY --- but subqueries that are just scan/join queries
> generally get merged into the
Robert Haas wrote:
> On Tue, May 28, 2019 at 11:27 AM Antonin Houska wrote:
> > We thought that it's more convenient for administrator to enter password. To
> > achieve that, we can instead tell the admin how to use the key derivation
> > tool
> > (pg_keysetup) and send its output to postgres.
Meskes-san
> This looks good to me. It passes all my tests, too.
>
> There were two minor issues, the regression test did not run and gcc
> complained about the indentation in ECPGprepare(). Both I easily fixed.
Thank you so much !
> > (2)
> > I found some bugs (two types). I didn't fix them
30 matches
Mail list logo
