Re: Why is infinite_recurse test suddenly failing?

On Tue, May 21, 2019 at 9:22 AM Mark Wong wrote: > Andrew let me know I need to get on v10. I've upgraded demoiselle, and > am trying to work through the rest now... Here's another crash like that. https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=cavefish=2019-07-13%2003%3A49%3A38

Re: pg_stat_statements vs. SELECT FOR UPDATE

On Thu, Jul 11, 2019 at 9:08 PM Sergei Kornilov wrote: > Patch is still applied cleanly on HEAD and passes check-world. I think > ignoring FOR UPDATE clause is incorrect behavior. With my reviewer hat: I agree. With my CFM hat: It seems like this patch is ready to land so I have set it to

Re: Tab completion for CREATE TYPE

On Tue, May 14, 2019 at 11:13 PM Kyotaro HORIGUCHI wrote: > At Tue, 14 May 2019 18:58:14 +1200, Thomas Munro > wrote in > > On Tue, May 14, 2019 at 6:18 PM Kyotaro HORIGUCHI > > wrote: > > > I played with this a bit and found that "... (attr=[tab]" (no > > > space between "r" and "=")

Re: Introduce timeout capability for ConditionVariableSleep

On Fri, Jul 12, 2019 at 6:08 PM Shawn Debnath wrote: > On Tue, Jul 09, 2019 at 11:03:18PM +1200, Thomas Munro wrote: > > On Sun, Jul 7, 2019 at 3:09 PM Thomas Munro wrote: > > > + /* Timed out */ > > > + if (rc == 0) > > > + return true; > > > >

Re: Check-out mutable functions in check constraints

On Fri, Jul 12, 2019 at 07:59:13PM -0400, Tom Lane wrote: Tomas Vondra writes: On Fri, Jul 12, 2019 at 02:00:25PM +0200, Pavel Stehule wrote: Mutable function are allowed in check constraint expressions but it is not right. The attached is a proposed fix for it including regression test.

Re: warning to publication created and wal_level is not set to logical

On Sat, Jul 13, 2019 at 3:21 AM Lucas Viecelli wrote: >> Agreed, fixed. Also run through pgindent > > Thank you for the adjustments. > All right, for me. If wal_level can not interfere with the testes result, it > seems to a better approach Pushed. Thanks for the patch! -- Thomas Munro

Some thoughts on heaps and freezing

Hello hackers, Here's a set of ideas that I think could get rid of wraparound freezes from the traditional heap, using undo logs technology. They're inspired by things that Heikki has said over various threads, adapted to our proposed undo infrastructure. 1. Don't freeze committed xids by

Re: [sqlsmith] Crash in mcv_get_match_bitmap

On Thu, Jul 11, 2019 at 05:08:22PM +0200, Tomas Vondra wrote: On Wed, Jul 10, 2019 at 06:48:16PM -0400, Tom Lane wrote: Oh ... while we're piling on here, it just sunk into me that mcv_get_match_bitmap is deciding what the semantics of an operator are by seeing what it's using for a selectivity

Re: Check-out mutable functions in check constraints

Tomas Vondra writes: > On Fri, Jul 12, 2019 at 02:00:25PM +0200, Pavel Stehule wrote: >>> Mutable function are allowed in check constraint expressions but >>> it is not right. The attached is a proposed fix for it including >>> regression test. > Yes, and the question is whether this is the

Re: Check-out mutable functions in check constraints

On Fri, Jul 12, 2019 at 02:00:25PM +0200, Pavel Stehule wrote: pá 12. 7. 2019 v 13:11 odesílatel Tomas Vondra napsal: On Fri, Jul 12, 2019 at 08:55:20AM +0200, Pavel Stehule wrote: >Hi > >pá 12. 7. 2019 v 8:45 odesílatel Kyotaro Horiguchi < horikyota@gmail.com> >napsal: > >> Hello. >> >>

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

On Fri, Jul 12, 2019 at 12:41:19PM -0600, Ryan Lambert wrote: > >> I vote for AES 256 rather than 128. > > > > Why?  This page seems to think 128 is sufficient: > > > >         https://crypto.stackexchange.com/questions/20/ >

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

>> I vote for AES 256 rather than 128. > > Why? This page seems to think 128 is sufficient: > > https://crypto.stackexchange.com/questions/20/what-are-the-practical-differences-between-256-bit-192-bit-and-128-bit-aes-enc > > For practical purposes, 128-bit keys are sufficient to ensure

Re: [RFC] [PATCH] Flexible "partition pruning" hook

On Fri, Jul 12, 2019 at 4:25 AM Amit Langote wrote: > > Sorry for jumping into this thread pretty late. I have read the > messages on this thread a couple of times and... > > On Fri, Jul 12, 2019 at 3:05 PM Kyotaro Horiguchi > wrote: > > I'm on Peter's side. Unlike other similar hooks, this

Re: [PATCH] kNN for btree

Attached 13th version of the patches. On 08.07.2019 21:09, Alexander Korotkov wrote: I have more thoughts about planner/executor infrastructure. It appears that supporting "ORDER BY col1, col2 <-> val" is too complex for initial version of patch. Handling of "ORDER BY col" and "ORDER BY col

Re: idea: log_statement_sample_rate - bottom limit for sampling

Hi pá 12. 7. 2019 v 13:07 odesílatel Adrien Nayrat napsal: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation:

Re: proposal - patch: psql - sort_by_size

pá 12. 7. 2019 v 15:10 odesílatel Fabien COELHO napsal: > > Hello Pavel, > > > rebased patch attached > > I prefer patches with a number rather than a date, if possible. For one > thing, there may be several updates in one day. > > About this version (20180708, probably v3): applies cleanly,

Re: warning to publication created and wal_level is not set to logical

Thomas Munro writes: > On Wed, Jul 10, 2019 at 12:47 PM Tom Lane wrote: >> 3. AFAICS, the proposed test case changes will cause the core regression >> tests to fail if wal_level is not replica. This is not true today --- >> they pass regardless of wal_level --- and I object in the strongest

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

On Fri, Jul 12, 2019 at 02:15:02PM +0900, Masahiko Sawada wrote: > > We will use CBC AES128 mode for tables/indexes, and CTR AES128 for WAL. > > 8k pages will use the LSN as a nonce, which will be encrypted to > > generate the initialization vector (IV). We will not encrypt the first > > 16 bytes

Re: Brazil disables DST - 2019b update

Tomas Vondra writes: > On Fri, Jul 12, 2019 at 02:52:53PM +1000, Robins Tharakan wrote: >> An August release does give a little more comfort. (I was expecting that >> the August >> date would get pushed out since 11.4 was an emergency release at the end of >> June). > I think the plan is still

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

On Fri, Jul 12, 2019 at 07:26:21AM -0400, Sehrope Sarkuni wrote: > On Thu, Jul 11, 2019 at 9:05 PM Bruce Momjian wrote: > > > > On Thu, Jul 11, 2019 at 08:41:52PM -0400, Joe Conway wrote: > > > I vote for AES 256 rather than 128. > > > > Why? This page seems to think 128 is sufficient: > > > >

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

On Fri, Jul 12, 2019 at 03:20:37PM +0900, Masahiko Sawada wrote: > Thank you for summarizing the discussion, it's really helpful. I'll > update the wiki page based on the summary. > > On Fri, Jul 12, 2019 at 10:05 AM Bruce Momjian wrote: > > > The keys themselves should be in an file which is

Re: warning to publication created and wal_level is not set to logical

> Agreed, fixed. Also run through pgindent > Thank you for the adjustments. > I agree that it's not really worth having tests for this, and I take > your point about the dependency on wal_level that we don't currently > have. The problem is that the core tests include publications > already,

Re: Brazil disables DST - 2019b update

On Fri, Jul 12, 2019 at 02:52:53PM +1000, Robins Tharakan wrote: On Fri, 12 Jul 2019 at 14:04, Michael Paquier wrote: On Fri, Jul 12, 2019 at 01:42:59PM +1000, Robins Tharakan wrote: So 2019b has been released on the 1st of July. Usually tzdata updates happen just before a minor release, so

Re: Brazil disables DST - 2019b update

Magnus Hagander writes: > On Fri, Jul 12, 2019 at 4:14 PM Tom Lane wrote: >> The usual recommendation on well-maintained production systems is to >> configure PG with --with-system-tzdata, then rely on your platform >> vendor for timely updates of that data. > It should be noted that this is

Re: Brazil disables DST - 2019b update

On Fri, Jul 12, 2019 at 4:14 PM Tom Lane wrote: > Robins Tharakan writes: > > The 2019b DST update [1] disables DST for Brazil. This would take effect > > starting November 2019. The last DST update in Postgres was 2019a in > v11.3 > > (since this update came in after the recent-most Postgres

Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead

В письме от четверг, 4 июля 2019 г. 19:44:42 MSK пользователь Dent John написал: > Hi Nikolay, > > I have had a crack at re-basing the current patch against 12b2, but I didn’t > trivially succeed. > > It’s probably more my bodged fixing of the rejections than a fundamental > problem. But I now

Re: Brazil disables DST - 2019b update

Robins Tharakan writes: > The 2019b DST update [1] disables DST for Brazil. This would take effect > starting November 2019. The last DST update in Postgres was 2019a in v11.3 > (since this update came in after the recent-most Postgres release). Yeah. I intend to install 2019b (or later?)

Re: Option to dump foreign data in pg_dump

> > On 28 Jun 2019, at 19:55, Luis Carril wrote: > > What about providing a list of FDW servers instead of an all or nothing > > option? In that way the user really has to do a conscious decision to dump > > the content of the foreign tables for > > a specific server, this would > > allow

Re: Patch to document base64 encoding

Hello Karl, doc_base64_part1_v9.patch Only moves, eliminates duplicates, and adjusts indentation. doc_base64_part2_v9.patch Cleanup wording after moving functions between sections. doc_base64_part3_v9.patch Documents base64, hex, and escape encode() and decode() formats. I

Re: POC: Cleaning up orphaned files using undo logs

On Fri, Jul 12, 2019 at 5:40 AM Amit Kapila wrote: > I am not sure but don't we need to retain the color of z as well? I believe that would be very wrong. If you recolor an internal node, you'll break the constant-black-height invariant. > Apart from this, the duplicate key (ex. for size queues

Re: proposal - patch: psql - sort_by_size

Hello Pavel, rebased patch attached I prefer patches with a number rather than a date, if possible. For one thing, there may be several updates in one day. About this version (20180708, probably v3): applies cleanly, compiles, make check ok, doc build ok. No tests. It works for me on

Re: Allow table AM's to cache stuff in relcache

On Fri, Jun 14, 2019 at 5:40 PM Tom Lane wrote: > > Heikki Linnakangas writes: > > Index AM's can cache stuff in RelationData->rd_amcache. In the zedstore > > table AM we've been hacking on, I'd like to also use rd_amcache to cache > > some information, but that's not currently possible, because

Re: pg_stat_database update stats_reset only by pg_stat_reset

On Fri, Jul 12, 2019 at 01:51:50PM +0900, Michael Paquier wrote: On Thu, Jul 11, 2019 at 04:34:20PM +0200, Daniel Verite wrote: I can understand why you'd want that resetting the stats for a single object would not reset the per-database timestamp, but this would revert a 8+ years old decision

Re: Detailed questions about pg_xact_commit_timestamp

Adrien, thanks very much for answering my question. Just a couple of follow-up points, if you don't mind. In our answer, you offer an example of pg_xact_commit_timestamp showing out-of-sequence commit times: Session xid pg_xact_commit_timestamp A 34386826 2019-07-11

Re: Request for improvement: Allow to push (t.o).id via GROUP BY ocd.o

And, probably, next query belongs to same issue: SELECT --next_ots.group_cost AS next_cost, (SELECT next_ots FROM order_total_suma( next_range ) next_ots WHERE next_ots.order_id = ots.order_id AND next_ots.consumed_period @> (ots.o).billed_to ) AS next_suma, -- << this takes 111ms only ots.*

Add FOREIGN to ALTER TABLE in pg_dump

Hello, pg_dump creates plain ALTER TABLE statements even if the table is a foreign table, which for someone reading the dump is confusing. This also made a difference when applying the dump if there is any plugin installed that hooks on ProcessUtility, because the plugin could react

Re: Check-out mutable functions in check constraints

pá 12. 7. 2019 v 13:11 odesílatel Tomas Vondra napsal: > On Fri, Jul 12, 2019 at 08:55:20AM +0200, Pavel Stehule wrote: > >Hi > > > >pá 12. 7. 2019 v 8:45 odesílatel Kyotaro Horiguchi < > horikyota@gmail.com> > >napsal: > > > >> Hello. > >> > >> As mentioned in the following message: > >> >

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

On Thu, Jul 11, 2019 at 9:05 PM Bruce Momjian wrote: > > On Thu, Jul 11, 2019 at 08:41:52PM -0400, Joe Conway wrote: > > I vote for AES 256 rather than 128. > > Why? This page seems to think 128 is sufficient: > > >

Re: Check-out mutable functions in check constraints

On Fri, Jul 12, 2019 at 03:44:58PM +0900, Kyotaro Horiguchi wrote: Hello. As mentioned in the following message: https://www.postgresql.org/message-id/20190712.150527.145133646.horikyota.ntt%40gmail.com Mutable function are allowed in check constraint expressions but it is not right. The

Re: Check-out mutable functions in check constraints

On Fri, Jul 12, 2019 at 08:55:20AM +0200, Pavel Stehule wrote: Hi pá 12. 7. 2019 v 8:45 odesílatel Kyotaro Horiguchi napsal: Hello. As mentioned in the following message: https://www.postgresql.org/message-id/20190712.150527.145133646.horikyota.ntt%40gmail.com Mutable function are

Re: idea: log_statement_sample_rate - bottom limit for sampling

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed Sorry, I forgot to tick "passed" boxes.

Re: idea: log_statement_sample_rate - bottom limit for sampling

The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, failed Spec compliant: tested, failed Documentation:tested, failed I test the latest patch attached to this thread

Re: Request for improvement: Allow to push (t.o).id via GROUP BY ocd.o

Hello to my mind I may be done, because `id` is primary key of `o` table Friday, July 12, 2019, 1:04:27 PM, you wrote: > Hello PostgreSQL-development, > something's stopping the planner from being able to deduce that > (t.o).id is safe to push through a GROUP BY ocd.o > SELECT * FROM

Request for improvement: Allow to push (t.o).id via GROUP BY ocd.o

Hello PostgreSQL-development, something's stopping the planner from being able to deduce that (t.o).id is safe to push through a GROUP BY ocd.o SELECT * FROM ( SELECT sum( t.group_suma ) OVER( PARTITION BY t.id ) AS total_suma, --

Re: Add parallelism and glibc dependent only options to reindexdb

On Fri, Jul 12, 2019 at 7:57 AM Michael Paquier wrote: > > On Fri, Jul 12, 2019 at 07:49:13AM +0200, Julien Rouhaud wrote: > > It shouldn't be a problem, I reused the same infrastructure as for > > vacuumdb. so run_reindex_command has a new "async" parameter, so when > > there's no parallelism

RE: Copy data to DSA area

Hi, thank you for the previous two emails. Thomas Munro wrote: >What do you think about the following? Even though I know you want to start >with >much simpler kinds of cache, I'm looking ahead to the lofty end-goal of having >a shared >plan cache. No doubt, that involves solving many other

Re: POC: Cleaning up orphaned files using undo logs

On Thu, Jul 11, 2019 at 1:29 AM Robert Haas wrote: > > After some off-list discussion with Andres ... > > Another possible approach here, which I think I like better, is to > switch from using a binary heap to using an rbtree. That wouldn't > work well in DSM because of the way it uses pointers,

Re: Minimal logical decoding on standbys

On 07/10/2019 05:12 PM, Amit Khandekar wrote: All right. Will do that in the next patch set. For now, I have quickly done the below changes in a single patch again (attached), in order to get early comments if any. Thanks Amit for your patch. i am able to see 1 issues  on Standby server -

Re: [HACKERS] WAL logging problem in 9.4.3?

At Fri, 12 Jul 2019 17:30:41 +0900 (Tokyo Standard Time), Kyotaro Horiguchi wrote in <20190712.173041.236938840.horikyota@gmail.com> > The v16 seems no longer works so I'll send further rebased version. It's just by renaming of TestLib::real_dir to perl2host. This is rebased version v17.

Re: [HACKERS] WAL logging problem in 9.4.3?

Many message seem lost during moving to new environmet.. I'm digging the archive but coudn't find the message for v15.. At Thu, 11 Jul 2019 18:03:35 -0700, Noah Misch wrote in <20190712010335.gb1610...@rfd.leadboat.com> > On Wed, Jul 10, 2019 at 01:19:14PM +0900, Kyotaro Horiguchi wrote: > >

Re: [RFC] [PATCH] Flexible "partition pruning" hook

Sorry for jumping into this thread pretty late. I have read the messages on this thread a couple of times and... On Fri, Jul 12, 2019 at 3:05 PM Kyotaro Horiguchi wrote: > I'm on Peter's side. Unlike other similar hooks, this hook is > provided just to introduce arbitrary inconsistency in

Re: Comment fix of config_default.pl

On Fri, Jul 12, 2019 at 03:34:11PM +0900, Kyotaro Horiguchi wrote: > At Fri, 12 Jul 2019 13:01:13 +0900, Michael Paquier > wrote in <20190712040113.gd2...@paquier.xyz> >> --with-ossp-uuid is an obsolete spelling. Wouldn't it be better to >> replace it with --with-uuid=? That would be a bit

Re: benchmarking Flex practices

On Wed, Jul 10, 2019 at 3:15 AM Tom Lane wrote: > > John Naylor writes: > > [ v4 patches for trimming lexer table size ] > > I reviewed this and it looks pretty solid. One gripe I have is > that I think it's best to limit backup-prevention tokens such as > quotecontinuefail so that they match

Re: Remove page-read callback from XLogReaderState.

At Tue, 28 May 2019 04:45:24 -0700, Andres Freund wrote in <20190528114524.dvj6ymap2virl...@alap3.anarazel.de> > Hi, > > On 2019-04-18 21:02:57 +0900, Kyotaro HORIGUCHI wrote: > > Hello. As mentioned before [1], read_page callback in > > XLogReaderState is a cause of headaches. Adding another >

Re: Memory-Bounded Hash Aggregation

On Thu, Jul 11, 2019 at 06:06:33PM -0700, Jeff Davis wrote: On Thu, 2019-07-11 at 17:55 +0200, Tomas Vondra wrote: Makes sense. I haven't thought about how the hybrid approach would be implemented very much, so I can't quite judge how complicated would it be to extend "approach 1" later. But if

Re: Check-out mutable functions in check constraints

Hi pá 12. 7. 2019 v 8:45 odesílatel Kyotaro Horiguchi napsal: > Hello. > > As mentioned in the following message: > > > https://www.postgresql.org/message-id/20190712.150527.145133646.horikyota.ntt%40gmail.com > > Mutable function are allowed in check constraint expressions but > it is not

Check-out mutable functions in check constraints

Hello. As mentioned in the following message: https://www.postgresql.org/message-id/20190712.150527.145133646.horikyota.ntt%40gmail.com Mutable function are allowed in check constraint expressions but it is not right. The attached is a proposed fix for it including regression test. Other

Re: Comment fix of config_default.pl

Thanks. At Fri, 12 Jul 2019 13:01:13 +0900, Michael Paquier wrote in <20190712040113.gd2...@paquier.xyz> > On Fri, Jul 12, 2019 at 12:15:29PM +0900, Kyotaro Horiguchi wrote: > > In src/tools/msvc/config_default.pl, parameter "perl" requires a > > path string, not a bool differently from that of

Re: Unknown type name bool

On Thu, Jul 11, 2019 at 11:14 PM Michael Paquier wrote: > On Thu, Jul 11, 2019 at 10:54:53PM -0700, Igal Sapir wrote: > > Thank you, Michael, but my goal is not to just build from source, but to > > run Postgres in an IDE. I tried CLion because it's modern and cross > > platform, but I am open

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

Thank you for summarizing the discussion, it's really helpful. I'll update the wiki page based on the summary. On Fri, Jul 12, 2019 at 10:05 AM Bruce Momjian wrote: > > The keys themselves should be in an file which is encrypted by a master > > key. Obtaining the master key should be pattern it

Re: Unknown type name bool

On Thu, Jul 11, 2019 at 10:54:53PM -0700, Igal Sapir wrote: > Thank you, Michael, but my goal is not to just build from source, but to > run Postgres in an IDE. I tried CLion because it's modern and cross > platform, but I am open to other IDEs. > > What IDEs do Postgres hackers use (other than

Re: Unknown type name bool

On 12/07/2019 17:54, Igal Sapir wrote: On Thu, Jul 11, 2019 at 10:27 PM Michael Paquier > wrote: On Thu, Jul 11, 2019 at 10:21:06PM -0700, Igal Sapir wrote: > Any thoughts?  (disclaimer: I have much more experience with Java than C) We don't support

Re: [RFC] [PATCH] Flexible "partition pruning" hook

Hello. I'm on Peter's side. Unlike other similar hooks, this hook is provided just to introduce arbitrary inconsistency in partition pruning. # By the way, InvokePartitionPruningHook seems useless if the # reason for it is to avoid duplicate if()'s . Adding check constraint on children works