Re: pgbench - allow to create partitioned tables

2019-09-21 Thread Amit Kapila
On Sat, Sep 21, 2019 at 1:18 PM Fabien COELHO wrote: > > Yes, this code is correct. I am not sure if you understood the point, > > so let me try again. I am bothered about below code in the patch: > > + /* only print partitioning information if some partitioning was detected > > */ > > + if

Re: Avoiding possible future conformance headaches in JSON work

2019-09-21 Thread Tom Lane
Peter Eisentraut writes: > On 2019-09-20 01:14, Tom Lane wrote: >> Sure. But we also modeled those features on the same language that the >> committee is looking at (or at least I sure hope we did). So it's >> reasonable to assume that they would come out at the same spot without >> any

Re: Nondeterministic collations vs. text_pattern_ops

2019-09-21 Thread Peter Eisentraut
On 2019-09-21 22:30, Tom Lane wrote: > I wrote: >> Peter Eisentraut writes: Here is a draft patch. > >> Where are we on pushing that? I'm starting to get antsy about the >> amount of time remaining before rc1. It's a low-risk fix, but still, >> it'd be best to have a complete buildfarm

Re: some PostgreSQL 12 release notes comments

2019-09-21 Thread Tom Lane
I've pushed some release note adjustments responding to your points about the GSSAPI and name-collation entries. I see the LDAP text is fixed already. regards, tom lane

Re: dropdb --force

2019-09-21 Thread Pavel Stehule
pá 20. 9. 2019 v 5:10 odesílatel Thomas Munro napsal: > On Thu, Sep 19, 2019 at 6:44 AM Pavel Stehule > wrote: > > I am sending updated version > > +appendPQExpBuffer(, "DROP DATABASE %s%s%s;", > + (force ? " (FORCE) " : ""), > > An extra space before (FORCE) caused the

Re: dropdb --force

2019-09-21 Thread Pavel Stehule
pá 20. 9. 2019 v 7:58 odesílatel Dilip Kumar napsal: > On Thu, Sep 19, 2019 at 12:14 AM Pavel Stehule > wrote: > > > > Hi > > > > I am sending updated version - the changes against last patch are two. I > use pg_terminate_backed for killing other terminates like Tom proposed. I > am not sure if

PATCH: standby crashed when replay block which truncated in standby but failed to truncate in master node

2019-09-21 Thread Thunder
The step to reproduce this issue. 1. Create a table create table gist_point_tbl(id int4, p point); create index gist_pointidx on gist_point_tbl using gist(p); 2. Insert data insert into gist_point_tbl (id, p) select g,point(g*10, g*10) from generate_series(1, 100) g; 3.

Re: Fwd: Extending range type operators to cope with elements

2019-09-21 Thread Esteban Zimanyi
On Tue, Sep 17, 2019 at 5:18 AM David Fetter wrote: > It's not done by pull request at this time. Instead, it is done by sending > patches to this mailing list. Dear all You will find enclosed the patch that extends the range type operators so they cope with elements. Any comments most

Re: WIP: Generic functions for Node types using generated metadata

2019-09-21 Thread David Fetter
On Fri, Sep 20, 2019 at 03:43:54PM -0700, Andres Freund wrote: > Hi, > > On 2019-09-19 22:18:57 -0700, Andres Freund wrote: > > While working on this I evolved the node string format a bit: > > > > 1) Node types start with the their "normal" name, rather than > >uppercase. There seems little

Re: pgbench - allow to create partitioned tables

2019-09-21 Thread Fabien COELHO
Hello Amit, Yes, this code is correct. I am not sure if you understood the point, so let me try again. I am bothered about below code in the patch: + /* only print partitioning information if some partitioning was detected */ + if (partition_method != PART_NONE) This is the only place now

Re: Efficient output for integer types

2019-09-21 Thread Andrew Gierth
> "David" == David Fetter writes: David> +static inline uint32 David> +decimalLength64(const uint64_t v) Should be uint64, not uint64_t. Also return an int, not a uint32. For int vs. int32, my own inclination is to use "int" where the value is just a (smallish) number, especially one

Re: A problem about partitionwise join

2019-09-21 Thread Dilip Kumar
On Fri, Sep 20, 2019 at 2:33 PM Richard Guo wrote: > > Hi Dilip, > > Thank you for reviewing this patch. > > On Fri, Sep 20, 2019 at 12:48 PM Dilip Kumar wrote: >> >> On Thu, Aug 29, 2019 at 3:15 PM Richard Guo wrote: >> > >> > >> > Attached is a patch as an attempt to address this issue. The

Re: Efficient output for integer types

2019-09-21 Thread David Fetter
On Sat, Sep 21, 2019 at 03:36:21AM +0100, Andrew Gierth wrote: > > "David" == David Fetter writes: > > David> + /* Compute the result string. */ > David> + if (value >= 1) > David> + { > David> + const uint32 value2 = value % 1; > David> + >