Re: Fix a typo in slot.c

2020-05-17 Thread Amit Kapila
On Fri, May 15, 2020 at 10:08 AM Masahiko Sawada wrote: > > On Fri, 15 May 2020 at 13:26, Amit Kapila wrote: > > > > > > /* > > - * Allocate and initialize walsender-related shared memory. > > + * Allocate and initialize replication slots' shared memory. > > */ > > > > How about changing it

Re: Parallel copy

2020-05-17 Thread Amit Kapila
On Fri, May 15, 2020 at 6:49 PM Robert Haas wrote: > > On Fri, May 15, 2020 at 12:19 AM Amit Kapila wrote: > > > My sense is that it would be a lot more sensible to do it at the > > > *beginning* of the parallel operation. Once we do it once, we > > > shouldn't ever do it again; that's how it

[PATCH] Add support to psql for edit-and-execute-command

2020-05-17 Thread Joe Wildish
Hi hackers, Attached is a small patch for adding "edit-and-execute-command" readline support to psql. Bash has this concept and I miss it when using psql. It allows you to amend the current line in an editor by pressing "v" (when in vi mode) or "C-x C-e" (when in emacs mode). Those are the

Re: [PATCH] fix GIN index search sometimes losing results

2020-05-17 Thread Pavel Borisov
Hi, all! Below is my variant how to patch Gin-Gist weights issue: 1. First of all I propose to shift from previously Gin's own TS_execute variant and leave only two: TS_execute with bool result and bool type callback and ternary TS_execute_recurse with ternary callback. I suppose all legacy

Re: Add A Glossary

2020-05-17 Thread Alvaro Herrera
On 2020-May-17, Erik Rijkers wrote: > On 2020-05-17 08:51, Alvaro Herrera wrote: > > I don't think that's the general understanding of those terms. For all > > I know, they *are* synonyms, and there's no specific term for "the > > fluctuating objects" as you call them. The instance is either

Re: Postgres default FILLFACTOR value

2020-05-17 Thread Virender Singla
In Postgres, Index FILLFACTOR only works for monotonically increasing column values and for random values it will do 50:50 block split. However it's really less likely that monotonically increasing columns gets updated then why we need to waste that 10% space and also making Index range scan on

Re: pgbench: option delaying queries till connections establishment?

2020-05-17 Thread Fabien COELHO
Hello, I've merged all time-related stuff (time_t, instr_time, int64) to use a unique type (pg_time_usec_t) and set of functions/macros, which simplifies the code somehow. Hm. I'm not convinced it's a good idea for pgbench to do its own thing here. I really think that the refactoring part

Re: pgsql: Show opclass and opfamily related information in psql

2020-05-17 Thread Alexander Korotkov
On Thu, May 14, 2020 at 1:34 PM Alexander Korotkov wrote: > On Thu, May 14, 2020 at 1:30 PM Nikita Glukhov > wrote: > > I agree that this patch is an improvement. > > OK, I'm going to push this patch if no objections. > (Sergey doesn't seem to continue involvement in PostgreSQL > development,

Re: Add A Glossary

2020-05-17 Thread Erik Rijkers
On 2020-05-17 08:51, Alvaro Herrera wrote: On 2020-May-17, Jürgen Purtz wrote: On 15.05.20 02:00, Alvaro Herrera wrote: > Thanks everybody. I have compiled together all the suggestions and the > > * I changed "instance", and made "cluster" be mostly a synonym of that. In my understanding,

Re: Add A Glossary

2020-05-17 Thread Jürgen Purtz
On 17.05.20 08:51, Alvaro Herrera wrote: On 15.05.20 02:00, Alvaro Herrera wrote: Thanks everybody. I have compiled together all the suggestions and the result is in the attached patch. Some of it is of my own devising. * I changed "instance", and made "cluster" be mostly a synonym of that.

Re: Add A Glossary

2020-05-17 Thread Jürgen Purtz
On 17.05.20 08:51, Alvaro Herrera wrote: Any object that exists in a database is local, regardless of whether it exists in a schema or not. This implies that the term "local" is unnecessary, just call them "SQL object". "Extensions" is one type of object that does not belong in a schema.

Re: [HACKERS] Restricting maximum keep segments by repslots

2020-05-17 Thread Alvaro Herrera
On 2020-May-16, Andres Freund wrote: > Hi, > > On 2020-05-16 22:51:50 -0400, Alvaro Herrera wrote: > > On 2020-May-16, Andres Freund wrote: > > > > > I, independent of this patch, added a few additional paths in which > > > checkpointer's latch is reset, and I found a few shutdowns in

Re: Add A Glossary

2020-05-17 Thread Alvaro Herrera
On 2020-May-17, Jürgen Purtz wrote: > On 15.05.20 02:00, Alvaro Herrera wrote: > > Thanks everybody. I have compiled together all the suggestions and the > > result is in the attached patch. Some of it is of my own devising. > > > > * I changed "instance", and made "cluster" be mostly a

Re: Add A Glossary

2020-05-17 Thread Jürgen Purtz
On 15.05.20 02:00, Alvaro Herrera wrote: Thanks everybody. I have compiled together all the suggestions and the result is in the attached patch. Some of it is of my own devising. * I changed "instance", and made "cluster" be mostly a synonym of that. In my understanding, "instance" and