Re: Remove unused variable from SharedSort

2020-11-14 Thread Bharath Rupireddy
On Thu, Nov 12, 2020 at 5:29 PM Dilip Kumar wrote: > > While going through the code I noticed that the nTapes member in > SharedSort is unused. This is just initialized with nworkers but > never used. The attached patch removes this variable. > We could have used that variable for an assert

Re: Supporting = operator in gin/gist_trgm_ops

2020-11-14 Thread Julien Rouhaud
On Sun, Nov 15, 2020 at 1:55 PM Alexander Korotkov wrote: > > On Sat, Nov 14, 2020 at 8:26 PM Julien Rouhaud wrote: > > On Sat, Nov 14, 2020 at 7:58 PM Erik Rijkers wrote: > > > > > > On 2020-11-14 12:53, Julien Rouhaud wrote: > > > > On Sat, Nov 14, 2020 at 6:07 PM Alexander Korotkov > > > >

Re: Refactor pg_rewind code and make it work against a standby

2020-11-14 Thread Tom Lane
I wrote: > Not sure if you noticed, but piculet has twice failed the > 007_standby_source.pl test that was added by 9c4f5192f: > ... > Now, I'm not sure what to make of that, but I can't help noticing that > piculet uses --disable-atomics while francolin uses --disable-spinlocks. > That leads the

Re: Refactor pg_rewind code and make it work against a standby

2020-11-14 Thread Tom Lane
Not sure if you noticed, but piculet has twice failed the 007_standby_source.pl test that was added by 9c4f5192f: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=piculet=2020-11-15%2006%3A00%3A11 https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=piculet=2020-11-13%2011%3A20%3A10

Re: logical streaming of xacts via test_decoding is broken

2020-11-14 Thread Dilip Kumar
On Fri, Nov 13, 2020 at 3:18 PM Amit Kapila wrote: > > On Thu, Nov 12, 2020 at 3:10 PM Dilip Kumar wrote: > > > > On Tue, Nov 10, 2020 at 7:20 PM Amit Kapila wrote: > > > > > > On Tue, Nov 10, 2020 at 2:25 PM Dilip Kumar wrote: > > > > > 3. Can you please prepare a separate patch for test case

Re: Supporting = operator in gin/gist_trgm_ops

2020-11-14 Thread Alexander Korotkov
On Sat, Nov 14, 2020 at 8:26 PM Julien Rouhaud wrote: > On Sat, Nov 14, 2020 at 7:58 PM Erik Rijkers wrote: > > > > On 2020-11-14 12:53, Julien Rouhaud wrote: > > > On Sat, Nov 14, 2020 at 6:07 PM Alexander Korotkov > > > > > > > > >Note that those indexes may not be as afficient as regulat

Re: POC: Cleaning up orphaned files using undo logs

2020-11-14 Thread Amit Kapila
On Sun, Nov 15, 2020 at 11:24 AM Amit Kapila wrote: > > On Fri, Nov 13, 2020 at 6:02 PM Antonin Houska wrote: > > > > Amit Kapila wrote: > > > > > On Thu, Nov 12, 2020 at 2:45 PM Antonin Houska wrote: > > > > > > > > > > > > No background undo > > > > -- > > > > > > > > Reduced

Re: POC: Cleaning up orphaned files using undo logs

2020-11-14 Thread Amit Kapila
On Fri, Nov 13, 2020 at 6:02 PM Antonin Houska wrote: > > Amit Kapila wrote: > > > On Thu, Nov 12, 2020 at 2:45 PM Antonin Houska wrote: > > > > > > > > > No background undo > > > -- > > > > > > Reduced complexity of the patch seems to be the priority at the moment. > > > Amit

Re: Add docs stub for recovery.conf

2020-11-14 Thread David G. Johnston
On Fri, Nov 13, 2020 at 10:42 AM Bruce Momjian wrote: > I think the big problem, and I have seen this repeatedly, is showing up > with a patch without discussing whether people actually want the > feature. I know it is a doc issue, but our TODO list has the order as: > > Desirability ->

Re: More time spending with "delete pending"

2020-11-14 Thread Alexander Lakhin
15.11.2020 04:11, Justin Pryzby wrote: > On Sat, Nov 14, 2020 at 01:00:00PM +0300, Alexander Lakhin wrote: >> As noted in [1], a sensible solution would be putting the same "retry on >> ERROR_ACCESS_DENIED" action in a wrapper for stat(). >> And bed90759f brought in master the _pgstat64()

Re: More time spending with "delete pending"

2020-11-14 Thread Justin Pryzby
On Sat, Nov 14, 2020 at 01:00:00PM +0300, Alexander Lakhin wrote: > As noted in [1], a sensible solution would be putting the same "retry on > ERROR_ACCESS_DENIED" action in a wrapper for stat(). > And bed90759f brought in master the _pgstat64() function, where such > error handling should be

Re: extension patch of CREATE OR REPLACE TRIGGER

2020-11-14 Thread Tom Lane
"osumi.takami...@fujitsu.com" writes: > [ CREATE_OR_REPLACE_TRIGGER_v18.patch ] Pushed with some mostly-minor cleanup. (I know this has been a very long slog. Congratulations for seeing it through.) regards, tom lane

Re: Supporting = operator in gin/gist_trgm_ops

2020-11-14 Thread Julien Rouhaud
On Sat, Nov 14, 2020 at 7:58 PM Erik Rijkers wrote: > > On 2020-11-14 12:53, Julien Rouhaud wrote: > > On Sat, Nov 14, 2020 at 6:07 PM Alexander Korotkov > > > > > >Note that those indexes may not be as afficient as regulat B-tree > > indexes > >for equality operator. > > > 'afficient as

Re: pgbench: option delaying queries till connections establishment?

2020-11-14 Thread Alexander Korotkov
Hi! On Thu, Feb 27, 2020 at 9:01 PM Andres Freund wrote: > I am trying to run a few benchmarks measuring the effects of patch to > make GetSnapshotData() faster in the face of larger numbers of > established connections. > > Before the patch connection establishment often is very slow due to >

Re: pgbench: option delaying queries till connections establishment?

2020-11-14 Thread Fabien COELHO
Hello Marina, 1) It looks like pgbench will no longer support Windows XP due to the function DeleteSynchronizationBarrier. From https://docs.microsoft.com/en-us/windows/win32/api/synchapi/nf-synchapi-deletesynchronizationbarrier Minimum supported client: Windows 8 [desktop apps only] Minimum

Re: PATCH: Batch/pipelining support for libpq

2020-11-14 Thread Daniel Verite
Alvaro Herrera wrote: > I adapted the test code to our code style. I also removed the "timings" > stuff; I think that's something better left to pgbench. > > (I haven't looked at Daniel's pgbench stuff yet, but I will do that > next.) The patch I posted in [1] was pretty simple, but at

Re: pgbench: option delaying queries till connections establishment?

2020-11-14 Thread Marina Polyakova
Hello! On 2020-11-13 08:44, kuroda.hay...@fujitsu.com wrote: Dear Fabien, and this will wait till its time comes. In the mean time, I think that you should put the patch status as you see fit, independently of the other patch: it seems unlikely that they would be committed together, and

Re: Supporting = operator in gin/gist_trgm_ops

2020-11-14 Thread Erik Rijkers
On 2020-11-14 12:53, Julien Rouhaud wrote: On Sat, Nov 14, 2020 at 6:07 PM Alexander Korotkov > Note that those indexes may not be as afficient as regulat B-tree indexes for equality operator. 'afficient as regulat' should be 'efficient as regular' Sorry to be nitpicking - it's

Re: Supporting = operator in gin/gist_trgm_ops

2020-11-14 Thread Julien Rouhaud
On Sat, Nov 14, 2020 at 6:07 PM Alexander Korotkov wrote: > > Hi, Erik! > > On Sat, Nov 14, 2020 at 11:37 AM Erik Rijkers wrote: > > On 2020-11-14 06:30, Alexander Korotkov wrote: > > > > > [v4-0001-Handle-equality...in-contrib-pg_trgm.patch (~] > > > > > > I'm going to push this if no

Re: Supporting = operator in gin/gist_trgm_ops

2020-11-14 Thread Alexander Korotkov
Hi, Erik! On Sat, Nov 14, 2020 at 11:37 AM Erik Rijkers wrote: > On 2020-11-14 06:30, Alexander Korotkov wrote: > > > [v4-0001-Handle-equality...in-contrib-pg_trgm.patch (~] > > > > I'm going to push this if no objections. > > > > About the sgml, in doc/src/sgml/pgtrgm.sgml : > > > Beginning in

More time spending with "delete pending"

2020-11-14 Thread Alexander Lakhin
Hello hackers, After fixing bug #16161 (pg_ctl inability to open just deleted postmaster.pid) there are still some errors related to the same Windows-only issue. Namely, pg_upgradeCheck failures seen on https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=fairywren=REL_13_STABLE Here

Re: Allow an alias to be attached directly to a JOIN ... USING

2020-11-14 Thread Peter Eisentraut
On 2020-08-03 19:44, Wolfgang Walther wrote: So given this: SELECT x.id FROM a LEFT JOIN b USING (id) AS x will this return NULL or a.id for rows that don't match in b? This should definitely be mentioned in the docs and I guess a test wouldn't be too bad as well? This issue is independent

Re: Allow an alias to be attached directly to a JOIN ... USING

2020-11-14 Thread Peter Eisentraut
On 2020-11-10 16:15, Georgios Kokolatos wrote: I noticed that this patch fails on the cfbot. For this, I changed the status to: 'Waiting on Author'. Cheers, //Georgios The new status of this patch is: Waiting on Author Here is a rebased and lightly retouched patch. -- Peter Eisentraut

Re: Supporting = operator in gin/gist_trgm_ops

2020-11-14 Thread Erik Rijkers
On 2020-11-14 06:30, Alexander Korotkov wrote: [v4-0001-Handle-equality...in-contrib-pg_trgm.patch (~] I'm going to push this if no objections. About the sgml, in doc/src/sgml/pgtrgm.sgml : Beginning in PostgreSQL 14, these indexes also support equality operator (simple comparison