Re: PG 14 release notes, first draft

2021-05-11 Thread Amit Langote
On Wed, May 12, 2021 at 6:47 AM Alvaro Herrera wrote: > On 2021-May-11, Bruce Momjian wrote: > > > > 86dc90056d Rework planning and execution of UPDATE and DELETE. > > > a1115fa078 Postpone some more stuff out of ExecInitModifyTable. > > > c5b7ba4e67 Postpone some stuff out of ExecInitModifyTable.

Re: compute_query_id and pg_stat_statements

2021-05-11 Thread Pavel Stehule
st 12. 5. 2021 v 8:10 odesílatel Julien Rouhaud napsal: > On Wed, May 12, 2021 at 07:49:13AM +0200, Pavel Stehule wrote: > > > > > Ah, I missed that case. And we are wanting to use pg_stat_statements > > > with (almost) zero-config? How about the following behavior? > > > > > > > > Until now, t

Re: PG 14 release notes, first draft

2021-05-11 Thread Amit Langote
On Wed, May 12, 2021 at 6:23 AM Bruce Momjian wrote: > On Tue, May 11, 2021 at 11:57:10AM +0900, Amit Langote wrote: > > On Mon, May 10, 2021 at 11:40 PM Justin Pryzby wrote: > > > Same as the last couple years, I checked for missing items in the release > > > notes, running something like this.

Re: proposal: possibility to read dumped table's name from file

2021-05-11 Thread Pavel Stehule
Hi ne 11. 4. 2021 v 9:48 odesílatel Pavel Stehule napsal: > Hi > > út 16. 2. 2021 v 20:32 odesílatel Pavel Stehule > napsal: > >> >> Hi >> >> rebase >> > > rebase > fresh rebase > > Regards > > Pavel > > >> Regards >> >> Pavel >> > diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/re

Re: compute_query_id and pg_stat_statements

2021-05-11 Thread Julien Rouhaud
On Wed, May 12, 2021 at 07:49:13AM +0200, Pavel Stehule wrote: > > > Ah, I missed that case. And we are wanting to use pg_stat_statements > > with (almost) zero-config? How about the following behavior? > > > > > Until now, the pg_stat_statements was zero-config. So the change is not > user frie

Re: compute_query_id and pg_stat_statements

2021-05-11 Thread Julien Rouhaud
On Wed, May 12, 2021 at 02:33:35PM +0900, Kyotaro Horiguchi wrote: > At Wed, 12 May 2021 10:42:01 +0800, Julien Rouhaud wrote > in > > > > I don't think that this approach would cope well for people who want a > > queryid > > without pg_stat_statements or such. Since the queryid can now be fo

Re: compute_query_id and pg_stat_statements

2021-05-11 Thread Pavel Stehule
Hi > Ah, I missed that case. And we are wanting to use pg_stat_statements > with (almost) zero-config? How about the following behavior? > > Until now, the pg_stat_statements was zero-config. So the change is not user friendly. The idea so pg_stat_statements requires enabled computed_query_id

Re: compute_query_id and pg_stat_statements

2021-05-11 Thread Kyotaro Horiguchi
At Wed, 12 May 2021 14:33:35 +0900 (JST), Kyotaro Horiguchi wrote in > Ok, if we want to support alternative providers from the first, we > need to actually write the loader code for query-id providers. It > would not be so hard?, but it might not be suitable to this stage so I > proposed that

Re: parallel vacuum - few questions on docs, comments and code

2021-05-11 Thread Amit Kapila
On Tue, May 11, 2021 at 5:38 PM Bharath Rupireddy wrote: > > I was going through the parallel vacuum docs and code. I found below > things, please someone clarify: > > 1) I see that a term "parallel degree" is used in the docs, code > comments, error messages "parallel vacuum degree must be a > n

Re: [Patch] ALTER SYSTEM READ ONLY

2021-05-11 Thread Dilip Kumar
On Tue, May 11, 2021 at 11:54 PM Robert Haas wrote: > > On Tue, May 11, 2021 at 11:17 AM Amul Sul wrote: > > I think I have much easier solution than this, will post that with update > > version patch set tomorrow. > > I don't know what you have in mind, but based on this discussion, it > seems

Re: Schema variables - new implementation for Postgres 15

2021-05-11 Thread Pavel Stehule
st 12. 5. 2021 v 6:17 odesílatel Pavel Stehule napsal: > Hi > > only rebase > second try - rebase after serial_scheduler remove Regards Pavel > Regards > > Pavel > schema-variables-2021-05-12-2.patch.gz Description: application/gzip

Re: compute_query_id and pg_stat_statements

2021-05-11 Thread Kyotaro Horiguchi
At Wed, 12 May 2021 10:42:01 +0800, Julien Rouhaud wrote in > Hello Horiguchi-san, > > On Wed, May 12, 2021 at 11:08:36AM +0900, Kyotaro Horiguchi wrote: > > > > If we look it in pg_settings, it shows the current value and the value > > at boot-time. So I'm fine with that behavior. > > > > H

Re: parallel vacuum - few questions on docs, comments and code

2021-05-11 Thread Dilip Kumar
On Tue, May 11, 2021 at 5:38 PM Bharath Rupireddy wrote: > > Hi, > > I was going through the parallel vacuum docs and code. I found below > things, please someone clarify: > > 1) I see that a term "parallel degree" is used in the docs, code > comments, error messages "parallel vacuum degree must

Re: Asynchronous Append on postgres_fdw nodes.

2021-05-11 Thread Etsuro Fujita
On Tue, May 11, 2021 at 6:55 PM Etsuro Fujita wrote: > On Tue, May 11, 2021 at 6:27 PM Andrey Lepikhov > wrote: > > On 11/5/21 12:24, Etsuro Fujita wrote: > > > >> -> Append (actual rows=3000 loops=1) > > >>-> Async Foreign Scan on f1 (actual rows=0 loops=1) > > >>-

Re: Performance Evaluation of Result Cache by using TPC-DS

2021-05-11 Thread Yuya Watari
Hello David, Thank you for your reply. > That's certainly one side of it. On the other side, it's pretty > important to also note that in 4 of 23 queries the result cache plan > executed faster but the planner costed it as more expensive. > > I'm not saying the costing is perfect, but what I am

Re: Replication slot stats misgivings

2021-05-11 Thread Tom Lane
vignesh C writes: > On Wed, May 12, 2021 at 9:59 AM Tom Lane wrote: >> Is there any value in converting the test case into a TAP test that >> could be more flexible about the expected output? I'm mainly wondering >> whether there are any code paths that this test forces the server through, >> wh

Re: Replication slot stats misgivings

2021-05-11 Thread vignesh C
On Wed, May 12, 2021 at 9:59 AM Tom Lane wrote: > > vignesh C writes: > > I agree with your analysis to remove that test. Attached patch has the > > changes for the same. > > Is there any value in converting the test case into a TAP test that > could be more flexible about the expected output? I

Re: Replication slot stats misgivings

2021-05-11 Thread Tom Lane
vignesh C writes: > I agree with your analysis to remove that test. Attached patch has the > changes for the same. Is there any value in converting the test case into a TAP test that could be more flexible about the expected output? I'm mainly wondering whether there are any code paths that this

Re: Replication slot stats misgivings

2021-05-11 Thread vignesh C
On Wed, May 12, 2021 at 9:08 AM Amit Kapila wrote: > > On Wed, May 12, 2021 at 7:53 AM Amit Kapila wrote: > > > > On Wed, May 12, 2021 at 4:00 AM Masahiko Sawada > > wrote: > > > > > > Ugh, since by commit 592f00f8de we send slot stats every after > > > spil/stream it’s possible that we report

Re: parallel vacuum - few questions on docs, comments and code

2021-05-11 Thread Amit Kapila
On Tue, May 11, 2021 at 6:31 PM Justin Pryzby wrote: > > On Tue, May 11, 2021 at 05:37:50PM +0530, Bharath Rupireddy wrote: > > 3) Should the Assert(nindexes > 0); in begin_parallel_vacuum just be > > Assert(nindexes > 1); as this function is entered only when indexes > > are > 1? > > I think you'

Re: Schema variables - new implementation for Postgres 15

2021-05-11 Thread Pavel Stehule
Hi only rebase Regards Pavel schema-variables-2021-05-12.patch.gz Description: application/gzip

Re: PG 14 release notes, first draft

2021-05-11 Thread Amit Kapila
On Wed, May 12, 2021 at 2:36 AM Bruce Momjian wrote: > > > OK, I added this: > > > > > > Allow logical decoding to more efficently process cache invalidation > messages > > > > This allows Logical decoding to work efficiently in presenc

Re: PG 14 release notes, first draft

2021-05-11 Thread Amit Kapila
On Tue, May 11, 2021 at 6:43 PM Jonathan S. Katz wrote: > > First Bruce, thank you for compiling the release notes draft. Comments > inline: > > On 5/10/21 11:56 PM, Amit Kapila wrote: > > On Mon, May 10, 2021 at 7:30 PM Justin Pryzby wrote: > >> > >> Can these be merged: > >> Allow logical repl

Re: Replication slot stats misgivings

2021-05-11 Thread Amit Kapila
On Wed, May 12, 2021 at 7:53 AM Amit Kapila wrote: > > On Wed, May 12, 2021 at 4:00 AM Masahiko Sawada wrote: > > > > Ugh, since by commit 592f00f8de we send slot stats every after > > spil/stream it’s possible that we report slot stats that have non-zero > > counters for spill_bytes/txns and zer

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Tue, May 11, 2021 at 05:13:21PM -0500, Justin Pryzby wrote: > On Tue, May 11, 2021 at 10:35:23AM -0400, Bruce Momjian wrote: > > > | Allow more than the common name (CN) to be matched for client > > > certificate authentication (Andrew Dunstan) > > > Your description makes it sound like arbitr

Re: compute_query_id and pg_stat_statements

2021-05-11 Thread Julien Rouhaud
Hello Horiguchi-san, On Wed, May 12, 2021 at 11:08:36AM +0900, Kyotaro Horiguchi wrote: > > If we look it in pg_settings, it shows the current value and the value > at boot-time. So I'm fine with that behavior. > > However, IMHO, I doubt the necessity of "on". Assuming that we require > any mod

Re: Some other CLOBBER_CACHE_ALWAYS culprits

2021-05-11 Thread Andres Freund
Hi, On 2021-05-11 19:02:00 -0700, Andres Freund wrote: > Why would rebuilding non-accessed relcache entries over and over help > with that? I am not proposing that we do not mark all cache entries are > invalid, or that we do not rebuild tables that aren't accessed. A slightly more concrete propo

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Wed, May 12, 2021 at 12:19:37AM +0300, Alexander Korotkov wrote: > This relates not just to quotes. Original problem relates to quotes > in websearch_to_tsquery() and phrase operator in to_tsquery(). But > the solution changes output for all query operands containing > discarded tokens. > > C

Re: Replication slot stats misgivings

2021-05-11 Thread Amit Kapila
On Wed, May 12, 2021 at 4:00 AM Masahiko Sawada wrote: > > On Wed, May 12, 2021 at 6:32 AM Tom Lane wrote: > > > > Amit Kapila writes: > > > I have closed this open item. > > > > That seems a little premature, considering that the > > contrib/test_decoding/sql/stats.sql test case is still failin

Re: compute_query_id and pg_stat_statements

2021-05-11 Thread Kyotaro Horiguchi
At Tue, 11 May 2021 18:52:49 +0800, Julien Rouhaud wrote in > On Tue, May 11, 2021 at 05:41:06PM +0800, Julien Rouhaud wrote: > > On Tue, May 11, 2021 at 10:59:51AM +0200, Magnus Hagander wrote: > > > > > > That doesn't fundamentally make it impossible, you just have to add it > > > to the list

Re: Some other CLOBBER_CACHE_ALWAYS culprits

2021-05-11 Thread Andres Freund
Hi, On 2021-05-11 19:30:48 -0400, Tom Lane wrote: > > IMO the problem largely stems from eagerly rebuilding *all* relcache entries > > during invalidation processing. > > Uh, we don't do that; only for relations that are pinned, which we > know are being used. Sorry, all surviving relcache entrie

Re: Some other CLOBBER_CACHE_ALWAYS culprits

2021-05-11 Thread Tom Lane
Andres Freund writes: > On 2021-05-11 12:03:33 -0400, Tom Lane wrote: >> In some recent threads I complained about how CLOBBER_CACHE_ALWAYS >> test runs have gotten markedly slower over the past couple of release >> cycles [1][2][3]. > I wonder if the best way to attack this in a more fundamental

Re: Some other CLOBBER_CACHE_ALWAYS culprits

2021-05-11 Thread Andres Freund
Hi, On 2021-05-11 12:03:33 -0400, Tom Lane wrote: > In some recent threads I complained about how CLOBBER_CACHE_ALWAYS > test runs have gotten markedly slower over the past couple of release > cycles [1][2][3]. I wonder if the best way to attack this in a more fundamental manner would be to handl

Re: Replication slot stats misgivings

2021-05-11 Thread Masahiko Sawada
On Wed, May 12, 2021 at 6:32 AM Tom Lane wrote: > > Amit Kapila writes: > > I have closed this open item. > > That seems a little premature, considering that the > contrib/test_decoding/sql/stats.sql test case is still failing regularly. Thank you for reporting. Ugh, since by commit 592f00f8de

Re: PG 14 release notes, first draft

2021-05-11 Thread Justin Pryzby
On Tue, May 11, 2021 at 10:35:23AM -0400, Bruce Momjian wrote: > > | Allow more than the common name (CN) to be matched for client certificate > > authentication (Andrew Dunstan) > > Your description makes it sound like arbitrary attributes can be compared. > > But > > the option just allows co

Re: Corrected documentation of data type for the logical replication message formats.

2021-05-11 Thread Peter Smith
On Wed, May 12, 2021 at 1:02 AM vignesh C wrote: > > Thanks for the comments, Attached v3 patch has the changes as suggested. This v3 mostly looks good to me now except for some minor comments about the flags. ~~~ 1. Commit flags @@ -6534,11 +6536,11 @@ Commit -Int8 +Uint

Re: pgsql: autovacuum: handle analyze for partitioned tables

2021-05-11 Thread Alvaro Herrera
On 2021-Apr-23, Justin Pryzby wrote: > On Thu, Apr 22, 2021 at 12:43:46PM -0500, Justin Pryzby wrote: > > > > I think that should probably have been written down somewhere other than for > > the manual ANALYZE command, but in any case it seems to be outdated now. > > Starting with this Agreed,

Re: Why do we have perl and sed versions of Gen_dummy_probes?

2021-05-11 Thread Andrew Dunstan
On 5/11/21 5:43 PM, Andrew Dunstan wrote: > On 5/11/21 4:01 PM, Tom Lane wrote: >> Andres Freund writes: >>> On 2021-05-11 14:30:10 -0400, Andrew Dunstan wrote: I'm not aware of any other case where we generate an in-tree file from a vpath, which is why it feels strange. >>> Yea, it is

Re: PG 14 release notes, first draft

2021-05-11 Thread Alvaro Herrera
On 2021-May-11, Bruce Momjian wrote: > > 86dc90056d Rework planning and execution of UPDATE and DELETE. > > a1115fa078 Postpone some more stuff out of ExecInitModifyTable. > > c5b7ba4e67 Postpone some stuff out of ExecInitModifyTable. Are these the set that means UPDATE/DELETE can now do partitio

Re: Why do we have perl and sed versions of Gen_dummy_probes?

2021-05-11 Thread Andrew Dunstan
On 5/11/21 4:01 PM, Tom Lane wrote: > Andres Freund writes: >> On 2021-05-11 14:30:10 -0400, Andrew Dunstan wrote: >>> I'm not aware of any other case where we generate an in-tree file from a >>> vpath, which is why it feels strange. >> Yea, it is a bit odd, agreed. We don't have many generated

Re: Replication slot stats misgivings

2021-05-11 Thread Tom Lane
Amit Kapila writes: > I have closed this open item. That seems a little premature, considering that the contrib/test_decoding/sql/stats.sql test case is still failing regularly. https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=locust&dt=2021-05-11%2019%3A14%3A53 https://buildfarm.postgre

Re: Python 3.10 breaks regression tests with traceback changes

2021-05-11 Thread Honza Horak
I missed Tom already started the thread, so just passing the other mail with a patch proposal here: https://www.postgresql.org/message-id/CA%2BHKMWPk0bMUvwV7x4pYxbtNMCVvpBVi%3Do%3DS96MFYTr_WKZ7UA%40mail.gmail.com Honza On 5/11/21 6:13 PM, Tom Lane wrote: $SUBJECT was discovered in Fedora 35 p

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Mon, May 10, 2021 at 07:53:08AM -0700, Peter Geoghegan wrote: > On Sun, May 9, 2021 at 11:03 PM Bruce Momjian wrote: > > I have committed the first draft of the PG 14 release notes. > > This definitely isn't necessary, since the commit in question was a > totally mechanical thing that cleaned

plpython subtransaction test failure with Python 3.10

2021-05-11 Thread Honza Horak
Originally reported as https://bugzilla.redhat.com/show_bug.cgi?id=1959080 during early integration testing of Python 3.10 done in Fedora. The test failed because Python 3.10 reports the traceback a bit differently: cat postgresql-13.2/src/pl/plpython/regression.diffs diff -U3 postgresql-13.2/src

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Tue, May 11, 2021 at 11:57:10AM +0900, Amit Langote wrote: > On Mon, May 10, 2021 at 11:40 PM Justin Pryzby wrote: > > Same as the last couple years, I checked for missing items in the release > > notes, running something like this. > > > > git log --cherry-pick --oneline origin/REL_13_STABLE..

Re: PG 14 release notes, first draft

2021-05-11 Thread Alexander Korotkov
.On Tue, May 11, 2021 at 11:31 PM Bruce Momjian wrote: > On Tue, May 11, 2021 at 01:16:38PM +0300, Alexander Korotkov wrote: > > > OK, what symbols trigger this change? Underscore? What else? > > > > Any symbol, which is recognized as a separator by full-text parser, > > but not tsquery parser.

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
Thanks you for the review. I did skip these items based on the criteria I normally use, but it is good for people to review this list to see if my analysis or criteria is wrong. --- On Mon, May 10, 2021 at 09:40:45AM -0500

Re: PG 14 release notes, first draft

2021-05-11 Thread Jonathan S. Katz
On 5/11/21 5:12 PM, Bruce Momjian wrote: > On Tue, May 11, 2021 at 09:13:31AM -0400, Jonathan Katz wrote: >> First Bruce, thank you for compiling the release notes draft. Comments >> inline: >> >> On 5/10/21 11:56 PM, Amit Kapila wrote: >>> and say something like: >>> Allow logical replication to

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Tue, May 11, 2021 at 08:24:22AM -0500, Justin Pryzby wrote: > I think these should be merged: > > | Remove factorial operators ! and !! (Mark Dilger) > | Add documentation for the factorial() function (Peter Eisentraut) > > | This can be disabled by turning client options "sslsni" off. > > o

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Tue, May 11, 2021 at 09:13:31AM -0400, Jonathan Katz wrote: > First Bruce, thank you for compiling the release notes draft. Comments > inline: > > On 5/10/21 11:56 PM, Amit Kapila wrote: > > On Mon, May 10, 2021 at 7:30 PM Justin Pryzby wrote: > >> > >> Can these be merged: > >> Allow logical

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Mon, May 10, 2021 at 08:08:01AM -0700, Peter Geoghegan wrote: > On Mon, May 10, 2021 at 7:00 AM Justin Pryzby wrote: > > | Allow VACUUM VERBOSE to report page deletion counts for each scan of an > > index (Peter Geoghegan) > > > > I think "Allow" is wrong - should just say that VACUUM VERBOSE

Re: seawasp failing, maybe in glibc allocator

2021-05-11 Thread Fabien COELHO
Hello Andres,p Unless perhaps the hard rlimit for -C is set? ulimit -c -H should show that. Possibly I have just added "ulimit -c unlimited" in the script, we should see the effect on next round. If it's the hard limit that won't help, because the hard limit can only be increased by a priv

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Tue, May 11, 2021 at 09:26:36AM +0530, Amit Kapila wrote: > On Mon, May 10, 2021 at 7:30 PM Justin Pryzby wrote: > > > > Can these be merged: > > Allow logical replication to stream long transactions to standbys (Dilip > > Kumar, Tomas Vondra, Amit Kapila, Nikhil Sontakke) > > Improve the lo

Re: Printing backtrace of postgres processes

2021-05-11 Thread Robert Haas
On Thu, May 6, 2021 at 3:31 PM Tom Lane wrote: > Andres Freund writes: > > On 2021-05-06 14:56:09 -0400, Tom Lane wrote: > >> If we think it's worth having a predefined role for, OK. However, > >> I don't like the future I see us heading towards where there are > >> hundreds of random predefined

Re: PG 14 release notes, first draft

2021-05-11 Thread Peter Geoghegan
On Tue, May 11, 2021 at 1:41 PM Bruce Momjian wrote: > > "Allow VACUUM to eagerly place newly deleted B-Tree pages in the Free > > Space Map. Previously VACUUM could only place preexisting deleted > > pages in the Free Space Map for recycling." > > So, previously it could only place pages that wer

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Mon, May 10, 2021 at 08:08:01AM -0700, Peter Geoghegan wrote: > On Mon, May 10, 2021 at 7:00 AM Justin Pryzby wrote: > > | Allow VACUUM VERBOSE to report page deletion counts for each scan of an > > index (Peter Geoghegan) > > > > I think "Allow" is wrong - should just say that VACUUM VERBOSE

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Tue, May 11, 2021 at 01:16:38PM +0300, Alexander Korotkov wrote: > > OK, what symbols trigger this change? Underscore? What else? > > Any symbol, which is recognized as a separator by full-text parser, > but not tsquery parser. Fulltext search is extensible and allowing > pluggable parsers.

Re: pg_receivewal makes a bad daemon

2021-05-11 Thread Andres Freund
Hi, On 2021-05-07 12:03:36 +0200, Magnus Hagander wrote: > It might be interesting for us as developers, but not to the vast > majority of our users. Most of those get their startup scripts from > our packagers -- so maybe we should encourage packagers to provide it, > like they do for PostgreSQL

Re: pg_receivewal makes a bad daemon

2021-05-11 Thread Andres Freund
Hi, On 2021-05-05 18:34:36 +0200, Magnus Hagander wrote: > Is this really a problem we should fix ourselves? Most daemon-managers > today will happily be configured to automatically restart a daemon on > failure with a single setting since a long time now. E.g. in systemd > (which most linuxen use

Re: Why do we have perl and sed versions of Gen_dummy_probes?

2021-05-11 Thread Tom Lane
Andres Freund writes: > On 2021-05-11 14:30:10 -0400, Andrew Dunstan wrote: >> I'm not aware of any other case where we generate an in-tree file from a >> vpath, which is why it feels strange. > Yea, it is a bit odd, agreed. We don't have many generated sources > inside the git repo (vs in the ta

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Tue, May 11, 2021 at 03:51:39PM -0400, Tom Lane wrote: > Joe Conway writes: > > On 5/11/21 1:30 PM, Bruce Momjian wrote: > >> It just feels like this change makes the function's behavior less > >> consistent. > > > See Tom's commit message here: > > https://git.postgresql.org/gitweb/?p=postgre

Re: Let's get rid of serial_schedule

2021-05-11 Thread Pavel Borisov
вт, 11 мая 2021 г. в 23:47, Daniel Gustafsson : > > On 11 May 2021, at 21:44, Tom Lane wrote: > > > > Daniel Gustafsson writes: > >> On 11 May 2021, at 20:58, Tom Lane wrote: > >>> + # for backwards compatibility, interpret "serial" as parallel tests > > > >> This comment may seem odd without

Re: Why do we have perl and sed versions of Gen_dummy_probes?

2021-05-11 Thread Alvaro Herrera
On 2021-May-11, Andrew Dunstan wrote: > Yeah, but this will create the perl file in the vpath directory where it > won't ever be used anyway. You really want this back in the source > directory where you can check it in etc. Hmm ... no, it doesn't. As far as I can see it works as intended. The

Re: PG 14 release notes, first draft

2021-05-11 Thread Tom Lane
Joe Conway writes: > On 5/11/21 1:30 PM, Bruce Momjian wrote: >> It just feels like this change makes the function's behavior less >> consistent. > See Tom's commit message here: > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=3d0f68dd30612 > In particular: >"The variants o

Re: Why do we have perl and sed versions of Gen_dummy_probes?

2021-05-11 Thread Andres Freund
Hi, On 2021-05-11 14:30:10 -0400, Andrew Dunstan wrote: > On 5/11/21 1:21 PM, Andres Freund wrote: > > It doesn't work in a VPATH build right now, FWIW. $@, $< will point to a > > local file in the build directory, right now. And the path to perltidyrc > > doesn't work either. It seems to work aft

Re: Let's get rid of serial_schedule

2021-05-11 Thread Daniel Gustafsson
> On 11 May 2021, at 21:44, Tom Lane wrote: > > Daniel Gustafsson writes: >> On 11 May 2021, at 20:58, Tom Lane wrote: >>> + # for backwards compatibility, interpret "serial" as parallel tests > >> This comment may seem odd without reading the commit message. Perhaps it can >> be reworded t

Re: Why do we have perl and sed versions of Gen_dummy_probes?

2021-05-11 Thread Andrew Dunstan
On 5/11/21 2:30 PM, Andrew Dunstan wrote: > On 5/11/21 1:21 PM, Andres Freund wrote: >> Hi, >> >> On 2021-05-11 10:52:22 -0400, Tom Lane wrote: >>> Works for me. One other thought --- do we care whether this works >>> in a VPATH build, and if so does it? The $< and $@ references should >>> be O

Re: Let's get rid of serial_schedule

2021-05-11 Thread Tom Lane
Daniel Gustafsson writes: > On 11 May 2021, at 20:58, Tom Lane wrote: >> +# for backwards compatibility, interpret "serial" as parallel tests > This comment may seem odd without reading the commit message. Perhaps it can > be reworded to "..as parallel tests running with a single worker" or

Re: Let's get rid of serial_schedule

2021-05-11 Thread Tom Lane
Heikki Linnakangas writes: > On 11/05/2021 21:58, Tom Lane wrote: >> +# for backwards compatibility, interpret "serial" as parallel tests > This comment isn't great, IMHO. How about: > # for backwards comopatibility, "serial" runs the tests in > # parallel_schedule one by one. Yeah, and on

Re: PG 14 release notes, first draft

2021-05-11 Thread Joe Conway
On 5/11/21 1:30 PM, Bruce Momjian wrote: On Tue, May 11, 2021 at 12:31:01PM -0400, Joe Conway wrote: On 5/11/21 11:37 AM, Bruce Momjian wrote: > On Tue, May 11, 2021 at 11:26:48AM -0400, Joe Conway wrote: > > On 5/11/21 11:11 AM, Bruce Momjian wrote: > > > > Previously existence of such columns

Re: Let's get rid of serial_schedule

2021-05-11 Thread Heikki Linnakangas
On 11/05/2021 21:58, Tom Lane wrote: We've several times discussed doing $SUBJECT by replacing the makefile's use of serial_schedule with calling parallel_schedule with --max-connections=1. This'd remove the need to maintain two lists of regression test scripts. I got annoyed again just now abo

Re: Let's get rid of serial_schedule

2021-05-11 Thread Daniel Gustafsson
> On 11 May 2021, at 20:58, Tom Lane wrote: > We've several times discussed doing $SUBJECT by replacing the > makefile's use of serial_schedule with calling parallel_schedule > with --max-connections=1. This'd remove the need to maintain > two lists of regression test scripts. > > I got annoyed

Let's get rid of serial_schedule

2021-05-11 Thread Tom Lane
We've several times discussed doing $SUBJECT by replacing the makefile's use of serial_schedule with calling parallel_schedule with --max-connections=1. This'd remove the need to maintain two lists of regression test scripts. I got annoyed again just now about how people seem unable to keep the t

Re: Performance degradation of REFRESH MATERIALIZED VIEW

2021-05-11 Thread Andrew Dunstan
On 5/11/21 2:23 PM, Alvaro Herrera wrote: > On 2021-May-11, Michael Paquier wrote: > >> Hmm. Is that really something we should do after feature freeze? A >> 25% degradation for matview refresh may be a problem for a lot of >> users and could be an upgrade stopper. Another thing we could do is

Re: Reducing opr_sanity test's runtime under CLOBBER_CACHE_ALWAYS

2021-05-11 Thread Tom Lane
Andrew Dunstan writes: > +1 for doing it now. Pushed. > You could possibly just move "inet macaddr macaddr8 " to the following > group and so have room for create_function_0. I just tried that and it > seemed happy. I decided that the minimum change would be to push tstypes to the following gro

Re: Why do we have perl and sed versions of Gen_dummy_probes?

2021-05-11 Thread Andrew Dunstan
On 5/11/21 1:21 PM, Andres Freund wrote: > Hi, > > On 2021-05-11 10:52:22 -0400, Tom Lane wrote: >> Works for me. One other thought --- do we care whether this works >> in a VPATH build, and if so does it? The $< and $@ references should >> be OK, but I'm betting you need $(srcdir)/Gen_dummy_pr

Re: [Patch] ALTER SYSTEM READ ONLY

2021-05-11 Thread Robert Haas
On Tue, May 11, 2021 at 11:17 AM Amul Sul wrote: > I think I have much easier solution than this, will post that with update > version patch set tomorrow. I don't know what you have in mind, but based on this discussion, it seems to me that we should just have 5 states instead of 4: 1. WAL is p

Re: Performance degradation of REFRESH MATERIALIZED VIEW

2021-05-11 Thread Alvaro Herrera
On 2021-May-11, Michael Paquier wrote: > Hmm. Is that really something we should do after feature freeze? A > 25% degradation for matview refresh may be a problem for a lot of > users and could be an upgrade stopper. Another thing we could do is > also to revert 7db0cd2 and 39b66a9 from the v14

Re: [PATCH] Identify LWLocks in tracepoints

2021-05-11 Thread Andres Freund
Hi, On 2021-05-10 09:46:02 -0700, Andres Freund wrote: > No worries - I knew that I'd have to do this at some point, even though > I hadn't planned to do that today... I should have all of them green > before end of today. > > I found that I actually can build LLVM 3.9 directly, as clang-6 can >

Re: Performance degradation of REFRESH MATERIALIZED VIEW

2021-05-11 Thread Tomas Vondra
On 5/11/21 7:25 PM, Andres Freund wrote: Hi, On 2021-05-11 16:07:44 +0200, Tomas Vondra wrote: On 5/11/21 11:04 AM, Masahiko Sawada wrote: I think the changes for heap_multi_insert() are fine so we can revert only heap_insert() part if we revert something from the v14 tree, although we will

Re: Performance degradation of REFRESH MATERIALIZED VIEW

2021-05-11 Thread Tomas Vondra
On 5/11/21 5:56 PM, Masahiko Sawada wrote: On Tue, May 11, 2021 at 11:07 PM Tomas Vondra wrote: On 5/11/21 11:04 AM, Masahiko Sawada wrote: On Tue, May 11, 2021 at 4:37 PM Michael Paquier wrote: On Wed, May 05, 2021 at 03:04:53PM +0200, Tomas Vondra wrote: Thanks, that looks promising.

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Tue, May 11, 2021 at 12:31:01PM -0400, Joe Conway wrote: > On 5/11/21 11:37 AM, Bruce Momjian wrote: > > On Tue, May 11, 2021 at 11:26:48AM -0400, Joe Conway wrote: > > > On 5/11/21 11:11 AM, Bruce Momjian wrote: > > > > > Previously existence of such columns were ignored when caller had > > >

Re: Performance degradation of REFRESH MATERIALIZED VIEW

2021-05-11 Thread Andres Freund
Hi, On 2021-05-11 16:07:44 +0200, Tomas Vondra wrote: > On 5/11/21 11:04 AM, Masahiko Sawada wrote: > > I think the changes for heap_multi_insert() are fine so we can revert > > only heap_insert() part if we revert something from the v14 tree, > > although we will end up not inserting frozen tuple

Re: Why do we have perl and sed versions of Gen_dummy_probes?

2021-05-11 Thread Andres Freund
Hi, On 2021-05-11 11:44:22 -0400, Andrew Dunstan wrote: > Why would we? It's only used in Windows builds, and there's no VPATH > there (sadly). Is that really relevant? We'll need to update the file on any platform when modifying the .sed, not just in windows. Greetings, Andres Freund

Re: Why do we have perl and sed versions of Gen_dummy_probes?

2021-05-11 Thread Andres Freund
Hi, On 2021-05-11 10:52:22 -0400, Tom Lane wrote: > Works for me. One other thought --- do we care whether this works > in a VPATH build, and if so does it? The $< and $@ references should > be OK, but I'm betting you need $(srcdir)/Gen_dummy_probes.pl.prolog > or the like. It doesn't work in a

Re: seawasp failing, maybe in glibc allocator

2021-05-11 Thread Andres Freund
On 2021-05-11 10:22:02 +0200, Fabien COELHO wrote: > > > On 2021-05-11 12:16:44 +1200, Thomas Munro wrote: > > > OK we got the SIGABRT this time, but still no backtrace. If the > > > kernel's core_pattern is "core", gdb is installed, then considering > > > that the buildfarm core_file_glob is "co

Re: PG 14 release notes, first draft

2021-05-11 Thread Joe Conway
On 5/11/21 11:37 AM, Bruce Momjian wrote: On Tue, May 11, 2021 at 11:26:48AM -0400, Joe Conway wrote: On 5/11/21 11:11 AM, Bruce Momjian wrote: > > Previously existence of such columns were ignored when caller had table > > level privileges. > > I can't reproduce the NULL using column name text

Re: Parallel INSERT SELECT take 2

2021-05-11 Thread Bharath Rupireddy
On Tue, May 11, 2021 at 6:11 PM houzj.f...@fujitsu.com wrote: > > > > > So, users need to check count(*) for this to determine > > > > parallel-safety? How about if we provide a wrapper function on top > > > > of this function or a separate function that returns char to > > > > indicate whether it

Python 3.10 breaks regression tests with traceback changes

2021-05-11 Thread Tom Lane
$SUBJECT was discovered in Fedora 35 prerelease testing of Python 3.10: https://bugzilla.redhat.com/show_bug.cgi?id=1959080 We have time to think about what to do about this, but some fix will be needed before long. regards, tom lane

Re: Enhanced error message to include hint messages for redundant options error

2021-05-11 Thread Bharath Rupireddy
On Tue, May 11, 2021 at 6:54 PM vignesh C wrote: > > On Tue, May 11, 2021 at 2:47 AM Alvaro Herrera > wrote: > > > > On 2021-May-10, vignesh C wrote: > > > > > That sounds fine to me, Attached v6 patch which has the changes for the > > > same. > > > > What about defining a function (maybe a sta

Some other CLOBBER_CACHE_ALWAYS culprits

2021-05-11 Thread Tom Lane
In some recent threads I complained about how CLOBBER_CACHE_ALWAYS test runs have gotten markedly slower over the past couple of release cycles [1][2][3]. It'd be impossibly time-consuming to investigate the causes by repeating the whole test corpus, but I've had some success in bisecting while me

Re: Performance degradation of REFRESH MATERIALIZED VIEW

2021-05-11 Thread Masahiko Sawada
On Tue, May 11, 2021 at 11:07 PM Tomas Vondra wrote: > > On 5/11/21 11:04 AM, Masahiko Sawada wrote: > > On Tue, May 11, 2021 at 4:37 PM Michael Paquier wrote: > >> > >> On Wed, May 05, 2021 at 03:04:53PM +0200, Tomas Vondra wrote: > >>> Thanks, that looks promising. I repeated the tests I did on

Re: Why do we have perl and sed versions of Gen_dummy_probes?

2021-05-11 Thread Andrew Dunstan
On 5/11/21 10:52 AM, Tom Lane wrote: > Andrew Dunstan writes: >> On 5/10/21 12:07 PM, Tom Lane wrote: >>> I don't think this is good practice; it implies that any >>> accidental corruption of the commentary would be carried >>> forward. I think we should be extracting the commentary >>> from Ge

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Tue, May 11, 2021 at 11:26:48AM -0400, Joe Conway wrote: > On 5/11/21 11:11 AM, Bruce Momjian wrote: > > > Previously existence of such columns were ignored when caller had table > > > level privileges. > > > > I can't reproduce the NULL using column name text: > > > test=> SELECT has_colu

Re: PG 14 release notes, first draft

2021-05-11 Thread Joe Conway
On 5/11/21 11:11 AM, Bruce Momjian wrote: On Tue, May 11, 2021 at 06:57:19AM -0400, Joe Conway wrote: On 5/10/21 9:56 PM, Bruce Momjian wrote: > On Mon, May 10, 2021 at 07:50:14AM -0400, Joe Conway wrote: > > On 5/10/21 2:03 AM, Bruce Momjian wrote: > > > I have committed the first draft of the

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Mon, May 10, 2021 at 02:03:08AM -0400, Bruce Momjian wrote: > I have committed the first draft of the PG 14 release notes. You can > see the most current build of them here: > > https://momjian.us/pgsql_docs/release-14.html > > I need clarification on many items, and the document still

Re: [Patch] ALTER SYSTEM READ ONLY

2021-05-11 Thread Amul Sul
On Tue, 11 May 2021 at 7:50 PM, Dilip Kumar wrote: > On Tue, May 11, 2021 at 6:56 PM Amul Sul wrote: > > > > On Tue, May 11, 2021 at 6:48 PM Dilip Kumar > wrote: > > > > > > On Tue, May 11, 2021 at 4:50 PM Amul Sul wrote: > > > > > > > > On Tue, May 11, 2021 at 4:13 PM Dilip Kumar > wrote: >

Re: PG 14 release notes, first draft

2021-05-11 Thread Bruce Momjian
On Tue, May 11, 2021 at 06:57:19AM -0400, Joe Conway wrote: > On 5/10/21 9:56 PM, Bruce Momjian wrote: > > On Mon, May 10, 2021 at 07:50:14AM -0400, Joe Conway wrote: > > > On 5/10/21 2:03 AM, Bruce Momjian wrote: > > > > I have committed the first draft of the PG 14 release notes. You can > > > >

Re: Corrected documentation of data type for the logical replication message formats.

2021-05-11 Thread vignesh C
On Tue, May 11, 2021 at 9:09 AM Euler Taveira wrote: > > On Mon, May 10, 2021, at 10:45 AM, vignesh C wrote: > > I agree to specifying the actual dataypes like XLogRecPtr for lsn, > TimestampTz for timestamp, TransactionId for xid and Oid for the > object id. Attached v2 patch which is changed on

Re: Corrected documentation of data type for the logical replication message formats.

2021-05-11 Thread vignesh C
On Tue, May 11, 2021 at 8:06 AM Peter Smith wrote: > > On Mon, May 10, 2021 at 11:46 PM vignesh C wrote: > > > > On Sun, May 9, 2021 at 6:54 PM Euler Taveira wrote: > > > > > > On Sun, May 9, 2021, at 9:37 AM, vignesh C wrote: > > > > > > For some of the logical replication messages the data typ

  1   2   >