Re: ECPG bug fix: DECALRE STATEMENT and DEALLOCATE, DESCRIBE

2021-08-14 Thread Tom Lane
Michael Meskes writes: > I will commit the patch(es). Thanks. This commit appears to be responsible for new noise on stderr during check-world: $ make -s check-world >/dev/null declare.pgc:123: WARNING: connection "con2" is overwritten to "con1". declare.pgc:124: WARNING: connection "con2" is

Re: What are exactly bootstrap processes, auxiliary processes, standalone backends, normal backends(user sessions)?

2021-08-14 Thread Justin Pryzby
On Sat, Jul 17, 2021 at 10:45:52AM -0400, Alvaro Herrera wrote: > On 2021-Jul-17, Bharath Rupireddy wrote: > > On Thu, Jul 15, 2021 at 8:17 PM Justin Pryzby wrote: > > > It sounds like something that should be in the glossary, which currently > > > refers > > > to but doesn't define "auxiliary

Re: when the startup process doesn't (logging startup delays)

2021-08-14 Thread Justin Pryzby
Should this feature distinguish between crash recovery and archive recovery on a hot standby ? Otherwise the standby will display this all the time. 2021-08-14 16:13:33.139 CDT startup[11741] LOG: redo in progress, elapsed time: 124.42 s, current LSN: 0/EEE2100 If so, I think maybe you'd

Re: Added schema level support for publication.

2021-08-14 Thread Tom Lane
Peter Eisentraut writes: > I think the strict separation between publication-for-tables vs. > publication-for-schemas is a mistake. Why can't I have a publication > that publishes tables t1, t2, t3, *and* schemas s1, s2, s3. Also note > that we have a pending patch to add sequences support

Re: Added schema level support for publication.

2021-08-14 Thread vignesh C
On Fri, Aug 6, 2021 at 4:02 PM Amit Kapila wrote: > > On Fri, Aug 6, 2021 at 2:16 PM vignesh C wrote: > > > > On Thu, Aug 5, 2021 at 3:54 PM Amit Kapila wrote: > > > > > > > > > Few more comments: > > > === > > > 1. Do we need the previous column 'puballtables' after adding

Re: Added schema level support for publication.

2021-08-14 Thread vignesh C
On Mon, Aug 9, 2021 at 10:23 AM Amit Kapila wrote: > > On Sun, Aug 8, 2021 at 2:52 PM vignesh C wrote: > > > > On Fri, Aug 6, 2021 at 4:39 PM Amit Kapila wrote: > > > > > > On Fri, Aug 6, 2021 at 2:02 PM vignesh C wrote: > > > > > > > > On Wed, Aug 4, 2021 at 4:10 PM Amit Kapila wrote: > > >

Re: Added schema level support for publication.

2021-08-14 Thread vignesh C
On Thu, Aug 12, 2021 at 5:54 PM Masahiko Sawada wrote: > > On Fri, Aug 6, 2021 at 5:33 PM vignesh C wrote: > > > > Thanks for the comments, the attached v19 patch has the fixes for the comments. > > Thank you for updating the patch! > > Here are some comments on v19 patch: > > +

Re: Added schema level support for publication.

2021-08-14 Thread vignesh C
On Tue, Aug 10, 2021 at 1:40 PM Greg Nancarrow wrote: > > On Fri, Aug 6, 2021 at 6:32 PM vignesh C wrote: > > > > Thanks for the comments, the attached v19 patch has the fixes for the comments. > > > > Some more review comments, this time for the v19 patch: > > > (1) In patch v19-0002, there's

Re: Added schema level support for publication.

2021-08-14 Thread vignesh C
On Mon, Aug 9, 2021 at 9:50 PM Mark Dilger wrote: > > > > > On Aug 6, 2021, at 1:32 AM, vignesh C wrote: > > > > the attached v19 patch > > With v19 applied, a schema owner can publish the contents of a table regardless of ownership or permissions on that table: > > +CREATE ROLE user1; > +GRANT

Re: Added schema level support for publication.

2021-08-14 Thread Amit Kapila
On Sat, Aug 14, 2021 at 3:02 PM Peter Eisentraut wrote: > > On 13.08.21 04:59, Amit Kapila wrote: > >> Even if we drop all tables added to the publication from it, 'pubkind' > >> doesn't go back to 'empty'. Is that intentional behavior? If we do > >> that, we can save the lookup of

Re: Default to TIMESTAMP WITH TIME ZONE?

2021-08-14 Thread Simon Riggs
On Sat, 14 Aug 2021 at 09:03, Peter Eisentraut wrote: > > On 13.08.21 19:07, Tom Lane wrote: > > "David G. Johnston" writes: > >> On Fri, Aug 13, 2021 at 9:28 AM Simon Riggs > >> wrote: > >>> The only hope is to eventually change the default, so probably > >>> the best thing is to apply

Re: Added schema level support for publication.

2021-08-14 Thread Peter Eisentraut
On 13.08.21 04:59, Amit Kapila wrote: Even if we drop all tables added to the publication from it, 'pubkind' doesn't go back to 'empty'. Is that intentional behavior? If we do that, we can save the lookup of pg_publication_rel and pg_publication_schema in some cases, and we can switch the

Re: Default to TIMESTAMP WITH TIME ZONE?

2021-08-14 Thread Peter Eisentraut
On 13.08.21 19:07, Tom Lane wrote: "David G. Johnston" writes: On Fri, Aug 13, 2021 at 9:28 AM Simon Riggs wrote: The only hope is to eventually change the default, so probably the best thing is to apply pressure via the SQL Std process. Then there is no hope because this makes the