Confusing messages about index row size

Hi everyone, I tried an old test that at some point crashed the database... that is already fixed. So now it gives a good ERROR message: """ postgres=# create table t1 (col1 text, col2 text); CREATE TABLE postgres=# create unique index on t1 ((col1 || col2)); CREATE INDEX postgres=# insert into

Re: Schema variables - new implementation for Postgres 15

On Fri, Sep 10, 2021 at 10:06:04AM +0200, Pavel Stehule wrote: > Hi > > čt 9. 9. 2021 v 12:21 odesílatel Erik Rijkers napsal: > > > > [schema-variables-20210909.patch] > > > > Hi Pavel, > > > > The patch applies and compiles fine but 'make check' for the > > assert-enabled fails on 131 out of

Re: pg_upgrade test for binary compatibility of core data types

On Fri, Jul 16, 2021 at 06:02:18PM +, Jacob Champion wrote: > On Fri, 2021-04-30 at 13:33 -0500, Justin Pryzby wrote: > > On Sat, Mar 06, 2021 at 03:01:43PM -0500, Tom Lane wrote: > > > v4-0001 mostly teaches test.sh about specific changes that have to be > > > made to historic versions of the

Re: BUG #15293: Stored Procedure Triggered by Logical Replication is Unable to use Notification Events

Artur Zakirov writes: > On Mon, Sep 6, 2021 at 9:27 PM Tom Lane wrote: >> Hm. So that forecloses back-patching this to earlier than v13. >> On the other hand, given that we've been ignoring the bug for awhile, >> maybe a fix that only works in v13+ is good enough. (Or maybe by now >> it'd be

Re: 2021-09 Commitfest

Hi Jaime, > Needs review: 171. > Waiting on Author: 79. > Ready for Committer: 15. > > How could we advance on the "needs review" queue? It's just too long! For the record, some patches marked as "Needs review" are in fact rotted and need to be rebased http://cfbot.cputube.org/ I notified

Re: BUG #15293: Stored Procedure Triggered by Logical Replication is Unable to use Notification Events

Thank you Tom for your review. On Mon, Sep 6, 2021 at 9:27 PM Tom Lane wrote: > > Artur Zakirov writes: > > I attached the patch which fixes it in a different way. It calls > > SignalBackends() in AtCommit_Notify(). It is possible to call > > SignalBackends() > > outside of

Re: new regexp_*(text, text, int) functions crash

Jaime Casanova writes: > BTW, this only happens when the third parameter is large. Here is an > example that consistently crash here: > select regexp_count('jaime.casanova', 'valid', 102481); Hah ... pg_regexec has never had a check that the search start position is sane. Will fix.

Re: Added missing invalidations for all tables publication

Amit Kapila writes: > On Wed, Sep 8, 2021 at 7:57 AM houzj.f...@fujitsu.com > wrote: >> I found that the patch cannot be applied to back-branches(v10-v14) cleanly, >> so, I generate the patches for back-branches. Attached, all the patches have >> passed regression test. > Pushed! Shouldn't the

Re: pg_upgrade test for binary compatibility of core data types

Jacob Champion writes: > On Fri, 2021-04-30 at 13:33 -0500, Justin Pryzby wrote: >> I started this. I don't know if it's compatible with the buildfarm client, >> but >> I think any issues maybe can be avoided by using "IF EXISTS". > Here are the differences I see on a first pass (without

new regexp_*(text, text, int) functions crash

Hi, BTW, this only happens when the third parameter is large. Here is an example that consistently crash here: select regexp_count('jaime.casanova', 'valid', 102481); -- Jaime Casanova Director de Servicios Profesionales SystemGuards - Consultores de PostgreSQL

Re: Increase value of OUTER_VAR

Andrey Lepikhov writes: > But why the Index type still uses for indexing of range table entries? > For example: > - we give int resultRelation value to create_modifytable_path() as Index > nominalRelation value. > - exec_rt_fetch(Index) calls list_nth(int). > - generate_subquery_vars() accepts

Re: Increase value of OUTER_VAR

Aleksander Alekseev writes: > +1. The proposed changes will be beneficial in the long term. They > will affect existing extensions. However, the scale of the problem > seems to be exaggerated. Yeah, after thinking more about this I agree we should just do it. I do not say that David's concerns

Re: missing warning in pg_import_system_collations

Anton Voloshin writes: > On 10/09/2021 01:37, Tom Lane wrote: >> It's sure not very clear to me why one case deserves a message and the >> other not. Perhaps they both do, which would lead to adding another >> DEBUG1 message here. > I'm not an expert in locales, but I think it makes some sense

Compressing temporary files

Hi hackers! There's a lot of compression discussions nowadays. And that's cool! Recently Naresh Chainani in private discussion shared with me the idea to compress temporary files on disk. And I was thrilled to find no evidence of implementation of this interesting idea. I've prototyped Random

Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c

Hi, We have two static check_permissions functions (one in slotfuncs.c another in logicalfuncs.c) with the same name and same code for checking the privileges for using replication slots. Why can't we have a single function CheckReplicationSlotPermissions in slot.c? This way, we can get rid of

Re: Polyphase merge is obsolete

On Fri, Sep 10, 2021 at 11:35 PM Jaime Casanova < jcasa...@systemguards.com.ec> wrote: > On Wed, Jul 14, 2021 at 06:04:14PM +0300, Heikki Linnakangas wrote: > > On 14/07/2021 15:12, vignesh C wrote: > > > On Sat, Jan 23, 2021 at 3:49 AM Heikki Linnakangas > wrote: > > > > Here's an updated

Re: Polyphase merge is obsolete

On Wed, Jul 14, 2021 at 06:04:14PM +0300, Heikki Linnakangas wrote: > On 14/07/2021 15:12, vignesh C wrote: > > On Sat, Jan 23, 2021 at 3:49 AM Heikki Linnakangas wrote: > > > Here's an updated version that fixes one bug: > > > > > > The CFBot was reporting a failure on the FreeBSD system [1].